ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on pull request #140: #64854 Add preserveduplicates option to ResourceList
Date Sun, 06 Dec 2020 20:31:21 GMT

bodewig commented on pull request #140:
URL: https://github.com/apache/ant/pull/140#issuecomment-739559178


   You removed the `volatile` attribute `cached´ from `ResourceList`. Th way code is structured
now there is a race-condition where one thread my be using a cache that hasn't been initialized
completely. I'm afraid you need to bring back `cached` redundant as it may seem.
   
   Apart from that I've only got a few nits:
   
   * I'm not sure about the name `WriteableResourceCollection` - `AppendableResourceCollection`
maybe?
   * please add since markers with 1.10.10 to new classes/methods and to the manual
   * more importantly, add yourself to CONTRIBUTORS (plain text) and contributors.xml. The
files are supposed to be ordered lexicographically by first name.
   
   Many thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message