ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on pull request #141: #64855 Add filterbeforeconcat option to Concat
Date Sun, 06 Dec 2020 10:38:05 GMT

bodewig commented on pull request #141:
URL: https://github.com/apache/ant/pull/141#issuecomment-739484127


   I like the approach of moving the logic for fixing the lat lines to a separate filter.
Kudos for adding tests ;-)
   
   A different approach could be to allow an alternative set of filters to be applied before
concatenating, i.e. allowing users to define two sets of filters one to apply on each input
stream individually and one to be applied to the merged stream. Naming could become an issue
(and I've got a long track of picking bad names myself).
   
   I'm not asking you to change your PR, I'd rather like to discuss the different approaches
to see which would be best. So what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message