ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on pull request #134: [WIP] Add the possibility to specify a custom filename mapper when creating an INDEX.LIST
Date Mon, 10 Aug 2020 13:51:42 GMT

bodewig commented on pull request #134:
URL: https://github.com/apache/ant/pull/134#issuecomment-671366647


   Many thanks @maartenc I believe your second alternative sounds like what I meant. It feels
as if the impact of the change would be smaller overall - so please give it a try if you've
got the time to do so.
   
   Your current patch would be binary incompatible (code compiled against an older version
of Ant that called `addConfiguredIndexJars` with a `Path` would now no longer find the method
it was expecting and had to be recompiled). It would even be source incompatible for a hypothetic
subclass of `Jar` that overrode `addConfiguredIndexJars` but I doubt such a thing exists.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message