ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on pull request #134: [WIP] Add the possibility to specify a custom filename mapper when creating an INDEX.LIST
Date Sun, 09 Aug 2020 12:11:32 GMT

bodewig commented on pull request #134:
URL: https://github.com/apache/ant/pull/134#issuecomment-671044385


   I overlooked you've been doing more than "just" mapping the file name, sorry. Actually
I'm still not sure I fully understand what you want to achieve and could probably use a description
of the problem rather than a proposed solution :-)
   
   I'm trying to wrap my head around jar indexing and what the task actually does right now.
   
   FWIU you've got a `Path` of jars that will be available in certain locations when the jar
you are creating is loaded and you want to create a jar-index for the jars of this `Path`
and use the "certain locations" rather than the current behaviour of using the base name for
each Path-element. Right?
   
   Would it be enough to add a `FileNameMapper` that is used in https://github.com/apache/ant/blob/6022806ecd6a47c8034713303db97a3c1a2b7f0c/src/main/org/apache/tools/ant/taskdefs/Jar.java#L1030
with `FlattenMapper` as default?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message