ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant-ivy] arcticgeek commented on issue #91: IVY-1615: implement retrieval of ivysettings from url in standalone
Date Wed, 13 Nov 2019 06:35:42 GMT
arcticgeek commented on issue #91: IVY-1615: implement retrieval of ivysettings from url in
standalone
URL: https://github.com/apache/ant-ivy/pull/91#issuecomment-553261485
 
 
   I appreciate your input.
   
   Supplying settings to ivy is a foundational task.
   As the top option in the standalone help output, it seemed to me that making that one option
which performs this important task location-transparent would be the most straightforward
for the user. The user does not have to look up or remember to specify an different variant
option which does the same fundamental thing. They simply supply a URL to the option they
already understand. This location-transparent approach also means there is no concern for
what happens when both option variants are supplied together on the same invocation in terms
of function or error reporting.
   
   Also, the semantics are "load settings from a location". Please look a bit closer: This
patch is basing its decision on URI scheme, not exception handling, and then calling the appropriate
Ivy.configure() method which is already present in the source code but not exposed to the
standalone CLI interface. As such a small patch where all changes are very local to the code
being modified, I cannot see why the location-transparent approach I chose creates a maintainability
problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message