ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <>
Subject Re: ant git commit: Unbreak tests
Date Wed, 04 Jul 2018 19:27:09 GMT

> -      passfile="testpassfile.tmp"%/>
> +      passfile="testpassfile.tmp"/>

the commit that introduced the issue was labeled "Trailing whitespace"
and I trusted to contain exactly that and didn't bother reviewing
it. Obviously it did not.

A single commit that spans a dozen mail messages is something you really
cannot review properly.

Glitches happen, this is not a problem. But if they hide inside a patch
that contains more than 4500 changes lines it becomes impossible to deal
with them.

Given we were planning to cut new releases I now feel very uncomfortable
and compelled to wade through all those 4500 lines as well as the 4500
lines of the other commit with the same message and the merge of the 1.9
branch (and doing the same to the equally big commits on the 1.9.x
branch). This is going to delay the releases by several days, at least.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message