ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gintautas Grigelionis <>
Subject Re: PR-33: problems
Date Mon, 29 May 2017 09:00:21 GMT
If it's acceptable I'll complement the PR addressing all the points.


Den 29 maj 2017 10:13 skrev "Jan Matèrne" <>:

I did a review of  <>

Here are the points I have problems with, so I want to discuss them here.

Basically it's about breaking BC. So how to deal with that?


Fixing the spell error in DelegateHandler$ChildElementHandler
(s/childHanlded/childHandled/) means breaking beakward compatiblity.

We could introduce a delegetate for that:

  /** for BC */


  public void childHanlded(DH child) throws SAXParseException {

    childHandled(DH child);


While refactoring you have renamed all occurences in the Ivy codebase.

On the other hand I don't know the impact (maybe outside of Ivy). I'll bring
that to the dev-list.

src/java/org/apache/ivy/osgi/repo/ renaming the
public constant DEFAULT_BUNLDE_FILTER also means breaking BC.

src/java/org/apache/ivy/osgi/util/ the constructor removes the
(IMO unneccessary) ParseException. But because it is a checked Exception we
break BC.

renaming EncrytedProperties to EncryptedProperties means breaking BC. If
required we could introduce a delegating class or a subclass.

ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
required we could introduce a delegating method.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message