ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janmaterne <...@git.apache.org>
Subject [GitHub] ant-ivy issue #33: More code cleanup
Date Mon, 29 May 2017 08:10:50 GMT
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/33
  
    build.xml
    - Nice idea with the copyright statement in Javadoc ( (c)${years} ; years=tstamp("2007-yyyy")
).
    
    You found a lot of spell errors ;)
    
    MatcherLookup.java#get(Map<String,String>): new Javadoc is:
      '@return a list of matchers that can apply to module withs specified attributes'
    I am not sure about 'withs' or 'with' ...
    
    Nice rewrites of 
      "myBoolean == null : false = myBoolean.booleanValue()" (and opposite) to
      "myBoolean != null && myBoolean"
    
    
    
    For Discussion:
    ---------------
    ModuleInSort.java, class javadoc, "is sorted": I think the 'iff' has a 'f' too much.
    
    
    
    Problems:
    ---------
    Fixing the spell error in DelegateHandler$ChildElementHandler (s/childHanlded/childHandled/)
means breaking beakward compatiblity. 
    We could introduce a delegetate for that:
      /** for BC */
      @Deprecated
      public void childHanlded(DH child) throws SAXParseException {
        childHandled(DH child);
      }
    While refactoring you have renamed all occurences in the Ivy codebase. 
    On the other hand I don't know the impact (maybe outside of Ivy). I'll bring that to the
dev-list.
    
    src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the public constant
DEFAULT_BUNLDE_FILTER also means breaking BC.
    
    src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the (IMO unneccessary)
ParseException. But because it is a checked Exception we break BC.
    
    renaming EncrytedProperties to EncryptedProperties means breaking BC. If required we could
introduce a delegating class or a subclass.
    
    ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If required we could
introduce a delegating method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message