ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janmaterne <...@git.apache.org>
Subject [GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code
Date Thu, 25 May 2017 18:47:24 GMT
Github user janmaterne commented on the issue:

    https://github.com/apache/ant-ivy/pull/31
  
    That was a lot of work (or writing/using a transformator ;)
    Basically it
    - removes the "extends TestCase" and
    - uses JUnit annotations
    - change string.indexOf()!=-1 to string.contains()
    - use foreach instead of for-i
    - small improvements
    - spell check
    
    test/java/org/apache/ivy/ant/IvyCacheFilesetTest.java
    In testFailure() you use @Test(expect=BuildException.class). Therefor the last fail()
statement is obsolete.
    
    This pattern occurs several more times. 
    Could you change that?
    
    Nice use of @Rule ExpectedException in IvyCleanCacheTest.
    Could you use that in IvyConfigureTest#testOverrideNotAllowed() and Co?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message