ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <>
Subject AW: svn commit: r579266 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ssh:
Date Wed, 26 Sep 2007 12:36:45 GMT
>> What about pulling the HUNDRED_KILOBYTES constant to 
>AbstractSshMessage and make it protected?
>Or public.
>> Or using a utility class holding these constants?
>This has some history, It is my fourth time trying to remove the
>magic numbers. Each of the other times, I used a magic numbers class,
>or classes, but had a problem in that I found it too easy to make
>and the code was not easy to read. This time, I decided to do a file at
>at time, use //CheckStyle:*** OFF at places where I could not figure
>a good name (for example 3, 4, 0x3f, etc) and only do a small number
for each commit
>so that other people could see if the changes were correct.


>Any silliness can be refactored later.



To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message