ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Reilly" <peter.kitt.rei...@gmail.com>
Subject Re: Location in non-Task tasks
Date Sat, 09 Sep 2006 21:17:06 GMT
I think that Location handling should be at the project
component level, being there could make better
reporting of nested elements. So +1 for handling
of Location in ProjectComponent.

However, it is a pity that AssetTask has to extend
ConditionBase ... oh well.

Peter




On 9/9/06, Stefan Bodewig <bodewig@apache.org> wrote:
>
> Hi,
>
> I just added the feature to print the line number an error occured on
> in AntUnit's plainlistener.
>
> I must admit that my error messages are sometimes not chosen well
> enough so having the line number to know which assertion in a longer
> testcase failed helps me a lot in J/NUnit.  I wanted to provide the
> same functionality to AntUnit.
>
> Unfortunately AssertTask extends ConditionBase and thus gets wrapped
> in a TaskAdapter.  This means it doesn't know where it is (inside of
> the build file) and cannnot add the information to the exception it
> throws.
>
> I'd like to do the following:
>
> (1) push the Location handling from Task down to ProjectComponent
>
> (2) Modify TaskAdapter to reflect Location into the wrapped task much
> like it reflects the Project instance into it right now.
>
> Does anybody object here?  An alternative to (1) would be to copy the
> logic from Task to ConditionBase.
>
> (3) I'd like to take advantage of these changes in AssertTask.
>
> The later would either mean
>
> * AntUnit 1.0beta1 had to wait until after Ant 1.7.0beta2 (or RC1 or
>   whatever) was released
>
> or
>
> * we'd release AntUnit 1.0beta1 without my change (3) and modify
>   AssertTask once a matching Ant release was out.
>
> What do you think?
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message