ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: Ant log statements being created even when not used
Date Mon, 25 Sep 2006 14:38:51 GMT
It was a design decision for Ant's logging system to
work in such a way that only the logger instances
themselves know their log level.  This was probably
intended to specifically _prevent_ tasks having to
know too much about such things; also it means that
different attached loggers can log at different
levels.

-Matt

--- Scott Stirling <scottstirling@gmail.com> wrote:

> Ah, that adds some helpful context.
> 
> How come the runtime doesn't know the current log
> level?
> 
> Scott Stirling
> Framingham, MA
> 
> On 9/25/06, Jan.Materne@rzf.fin-nrw.de
> <Jan.Materne@rzf.fin-nrw.de> wrote:
> > Because the runtime does not know the current
> loglevel.
> > The RT forwards the (build) message to the
> registered Listeners.
> >
> > Jan
> >
> > >-----Urspr√ľngliche Nachricht-----
> > >Von: Scott Stirling
> [mailto:scottstirling@gmail.com]
> > >Gesendet: Montag, 25. September 2006 15:29
> > >An: Ant Developers List
> > >Betreff: Re: Ant log statements being created
> even when not used
> > >
> > >What's wrong with a guard statement that doesn't
> construct the
> > >log message unless the log level at which the
> message is used
> > >is enabled?
> > >
> > >i.e.:
> > >
> > >if (LOG.isDebugEnabled()) {
> > >    StringBuilder msg = new StringBuilder();
> > >    msg.append(etc....);
> > >    [...]
> > >    LOG.debug(msg.toString());
> > >}
> > >
> > >That's simple, don't you think? In my experience,
> the problem
> > >of polluting "client" code with logging is a red
> herring and
> > >not such a problem. More common are the problems
> of not enough
> > >useful logging or too much logging, e.g., when
> every component
> > >in an application stack is coded to log the same
> damn thing so
> > >you wind up with massive stack traces logged
> multiple times by
> > >well-meaning components that should often just be
> throwing
> > >their exceptions up to a higher layer for logging
> and other handling.
> > >
> > >
> > >Scott Stirling
> > >Framingham, MA
> > >
> > >On 9/25/06, Kevin Jackson <foamdino@gmail.com>
> wrote:
> > >> Hi,
> > >> Remember early this year I had a problem with a
> build that basically
> > >> ran out of memory and if I commented out
> logging code I could get it
> > >> to run?
> > >>
> > >>
> http://www.digitalmars.com/d/lazy-evaluation.html
> > >>
> > >> This explains exactly the problem (and a
> solution for D), I
> > >wonder if
> > >> some solution exists for Java such that log
> statements are not as
> > >> wasteful of resources as they currently are
> > >>
> > >> Kev
> > >>
> > >>
>
---------------------------------------------------------------------
> > >> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org For
> > >additional
> > >> commands, e-mail: dev-help@ant.apache.org
> > >>
> > >>
> > >
> >
>
>---------------------------------------------------------------------
> > >To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org For
> > >additional commands, e-mail:
> dev-help@ant.apache.org
> > >
> > >
> >
> >
>
---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> > For additional commands, e-mail:
> dev-help@ant.apache.org
> >
> >
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message