ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional Cab.java
Date Mon, 14 Mar 2005 10:42:35 GMT
bodewig     2005/03/14 02:42:35

  Modified:    .        CONTRIBUTORS WHATSNEW
               src/main/org/apache/tools/ant/taskdefs/optional Cab.java
  Log:
  <cab> should now deal with file names containing spaces.
  
  PR: 17182
  Submitted by:	Jay Peck <jpeck at afsimage dot com>
  
  Revision  Changes    Path
  1.45      +1 -0      ant/CONTRIBUTORS
  
  Index: CONTRIBUTORS
  ===================================================================
  RCS file: /home/cvs/ant/CONTRIBUTORS,v
  retrieving revision 1.44
  retrieving revision 1.45
  diff -u -r1.44 -r1.45
  --- CONTRIBUTORS	14 Mar 2005 09:13:41 -0000	1.44
  +++ CONTRIBUTORS	14 Mar 2005 10:42:35 -0000	1.45
  @@ -89,6 +89,7 @@
   Jason Salter
   Jason Yip
   Jay Dickon Glanville
  +Jay Peck
   Jay van der Meer
   JC Mann
   J D Glanville
  
  
  
  1.775     +3 -0      ant/WHATSNEW
  
  Index: WHATSNEW
  ===================================================================
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.774
  retrieving revision 1.775
  diff -u -r1.774 -r1.775
  --- WHATSNEW	14 Mar 2005 09:33:30 -0000	1.774
  +++ WHATSNEW	14 Mar 2005 10:42:35 -0000	1.775
  @@ -385,6 +385,9 @@
   * The framed JUnit report now handles multiple reports for the same
     testcase properly.  Bugzilla Report 32745.
   
  +* <cab> didn't work for files with spaces in their names on Windows.
  +  Bugzilla Report 17182.
  +
   Changes from Ant 1.6.1 to Ant 1.6.2
   ===================================
   
  
  
  
  1.37      +6 -2      ant/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java
  
  Index: Cab.java
  ===================================================================
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java,v
  retrieving revision 1.36
  retrieving revision 1.37
  diff -u -r1.36 -r1.37
  --- Cab.java	18 Feb 2005 23:27:59 -0000	1.36
  +++ Cab.java	14 Mar 2005 10:42:35 -0000	1.37
  @@ -145,6 +145,9 @@
       /**
        * Creates a list file.  This temporary file contains a list of all files
        * to be included in the cab, one file per line.
  +     *
  +     * <p>This method expects to only be called on Windows and thus
  +     * quotes the file names.</p>
        */
       protected File createListFile(Vector files)
           throws IOException {
  @@ -153,8 +156,9 @@
   
           PrintWriter writer = new PrintWriter(new FileOutputStream(listFile));
   
  -        for (int i = 0; i < files.size(); i++) {
  -            writer.println(files.elementAt(i).toString());
  +        int size = files.size();
  +        for (int i = 0; i < size; i++) {
  +            writer.println('\"' + files.elementAt(i).toString() + '\"');
           }
           writer.close();
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message