ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 27007] - subant task fails even if failonerror="false"
Date Wed, 18 Feb 2004 10:50:18 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27007>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=27007

subant task fails even if failonerror="false"





------- Additional Comments From j_a_fernandez@yahoo.com  2004-02-18 10:50 -------
I think we are getting into a backward compatibility redhearing here.
I see no reason why people would be even thinking such code should be
supported. So to me this is a bug fix, nothing else.

It make no sense to me to create a new safeExecute() method since ALL
tasks all over will override execute() which means obtaining the "correct"
behaviour will have an extremely high cost of conversion, which eventually
will defeat the whole purpose of the fix.

In any case, the fix should probably be not in Task.execute(), but in 
Task.perform() to be exact on the catch block for RuntimeException. 
If you look at the code in there it throws the original exception as is,
instead, I think, it should catch Throwable (I am being bold here),
and convert it into a BuildException before doing what is doing now.

Task.perform() is what the ANT engine calls, and if someone wants to
see the raw result, it can always call Task.execute() directly.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message