ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peterrei...@apache.org
Subject cvs commit: ant/src/main/org/apache/tools/ant Project.java
Date Thu, 11 Dec 2003 12:11:36 GMT
peterreilly    2003/12/11 04:11:36

  Modified:    src/main/org/apache/tools/ant Project.java
  Log:
  In addReference, remove calling tostring on the references being added.
  The tostring can be a very expensive operation, and causes
  massive slowdown when used in conjuction with antcall.
  
  Revision  Changes    Path
  1.155     +2 -12     ant/src/main/org/apache/tools/ant/Project.java
  
  Index: Project.java
  ===================================================================
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/Project.java,v
  retrieving revision 1.154
  retrieving revision 1.155
  diff -u -r1.154 -r1.155
  --- Project.java	12 Sep 2003 20:56:45 -0000	1.154
  +++ Project.java	11 Dec 2003 12:11:36 -0000	1.155
  @@ -1747,17 +1747,7 @@
                   log("Overriding previous definition of reference to " + name,
                       MSG_WARN);
               }
  -
  -            String valueAsString = "";
  -            try {
  -                valueAsString = value.toString();
  -            } catch (Throwable t) {
  -                log("Caught exception (" + t.getClass().getName() + ")"
  -                    + " while expanding " + name + ": " + t.getMessage(),
  -                    MSG_WARN);
  -            }
  -            log("Adding reference: " + name + " -> " + valueAsString,
  -                MSG_DEBUG);
  +            log("Adding reference: " + name, MSG_DEBUG);
               references.put(name, value);
           }
       }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message