ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <peter.rei...@corvil.com>
Subject Re: Advice required on committing
Date Wed, 28 May 2003 11:43:34 GMT
Ok,
This sounds sensible.

Peter

On Wednesday 28 May 2003 12:35, Magesh Umasankar wrote:
> Though we haven't been following the practise of
> always creating a bug report before fixing it,
> I think it would be a good approach to include it
> in Bugzilla.  The reason is some user may come across
> this issue before the release and may logically
> search Bugzilla to see if the error has already
> been reported/addressed before creating a report.
> Expecting the user to search through mailing lists
> or the README in CVS Head would not be fair.
>
> Cheers,
> Magesh
>
> ----- Original Message -----
> From: "peter reilly" <peter.reilly@corvil.com>
> To: <dev@ant.apache.org>
> Sent: Wednesday, May 28, 2003 6:57 AM
> Subject: Advice required on committing
>
>
> Hi, I have just been made a ant committer.
>
> I have found a bug in ant's regular expession
> handling for replacing matched groups.
>
> Ant uses \n  to identify the matched group,
> jdk14 and jakarta-oro uses $n to identify the
> group. The code in ant correctly replaces the \
> with $. However, it does not escape any $ on
> the input.
>
> The following
>    <replaceregex pattern="@([^@]+)@" replace="${\1}"/>
> fails on jdk14 as Matcher#appendReplacement gets passed
> "${$1}" rather than "\${$1}".
>
> My question is:
>    should I make a bugzilla entry or just
>    commit the changes, with unit test and
>    appropriate comment ?
>
> Peter
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message