ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominique Devienne <DDevie...@lgc.com>
Subject RE: [PATCH] add regular expressions to ContainsSelector.java
Date Thu, 10 Apr 2003 22:23:08 GMT
I'll try to answer for Stefan, since he won't read your message until
tomorrow because of his timezone...

Yes, 'make ContainsRegexpSelector under /ant/types/selectors ...'. I believe
Stefan was merely pointing out that there are separate classes for filtering
on string literals and regular expressions, and thus there should be
separate selectors selecting on string literals and regular expressions, to
remain consistent.

Does that help? --DD

-----Original Message-----
From: Jay [mailto:jvandermeer2@comcast.net] 
Sent: Thursday, April 10, 2003 5:19 PM
To: Ant Developers List
Subject: Re: [PATCH] add regular expressions to ContainsSelector.java

I'm still new to how ant is organized, let me make sure I understand the 
preferred way to do this.  I had started to do the patch as a filter under 
/ant/filters but I was thinking that the filters were more geared to
changing 
text, not just identifiying a file has a specific content.  So would it be
ok 
to make ContainsRegexpSelector under /ant/types/selectors that is basically 
the same as ContainsSelector but just accepts a single parm and does the
regular expression search only?  If that's not what you were asking for
could
you point me in the right direction?

Thanks for your time on this.

Jay van der Meer

On Thursday 10 April 2003 01:13, Stefan Bodewig wrote:
> On Wed, 09 Apr 2003, Jay <jvandermeer2@comcast.net> wrote:
> > Attached is a update to ContainsSelector.java (based on 1.5.3) that
> > allows the users to specify the text attribute is to be used as a
> > regular expression.
>
> I'd prefer a separate ContainsRegexpSelector for this.  This would
> mirror the replace tasks or the linecontains filter readers.
>
> Stefan

Mime
View raw message