ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fathman, Abraham" <Abraham.Fath...@53.com>
Subject Patch: WebsphereDeployTool
Date Thu, 27 Mar 2003 17:48:33 GMT
I have found two bugs in WebsphereDeployTool

1) I mentioned in a previous email regarding spaces in the classpath
2) On a windows machine the JarEntry.getName() has /'s in them instead of
File.separator and WebsphereDeployTool uses File.separator

see http://forum.java.sun.com/thread.jsp?forum=22&thread=302053

Here is the diff to fix both problems:


---
..\apache-ant-1.5.2_unmodified\apache-ant-1.5.2\src\main\org\apache\tools\an
t\taskdefs\optional\ejb\WebsphereDeploymentTool.java	2003-02-28
10:06:42.000000000 -0500
+++
src\main\org\apache\tools\ant\taskdefs\optional\ejb\WebsphereDeploymentTool.
java	2003-03-27 12:39:51.000000000 -0500
@@ -580,7 +580,7 @@
                     " " + getOptions();
 
                 if (getCombinedClasspath() != null &&
getCombinedClasspath().toString().length() > 0) {
-                    args += " -cp " + getCombinedClasspath();
+                    args += " -cp \"" + getCombinedClasspath() + "\"";
                 }
 
                 // Why do my ""'s get stripped away???
@@ -757,7 +757,7 @@
 
                             if (genericEntry.getName().endsWith(".class"))
{
                                 //File are different see if its an object
or an interface
-                                String classname =
genericEntry.getName().replace(File.separatorChar, '.');
+                                String classname =
genericEntry.getName().replace('/', '.');
 
                                 classname = classname.substring(0,
classname.lastIndexOf(".class"));
 




Abraham Fathman
eBusiness Architecture
513-534-4607




Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message