ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <>
Subject Re: Selector examples
Date Wed, 01 May 2002 19:38:21 GMT
----- Original Message -----
From: "Bruce Atherton" <>

> >Also, I was just briefly looking at the code to get a feel for it.  I see
> >ContainsSelector.isSelected that it returns true without closing the
> >I'm assuming that it should, right?
> It should always be closed by the finally block. The question for me in
> that code is whether catching an exception on close should throw an
> exception. If the close fails because the creation of the stream threw an
> exception, this throw may hide the real problem. OTOH, empty catch blocks
> are generally considered bad karma.
> What does the combined wisdom of the Ant Dev mailing list think about this
> situation?

Ummm, but:

    return true;

won't drop into the finally, right?!  :))


To unsubscribe, e-mail:   <>
For additional commands, e-mail: <>

View raw message