ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: cvs commit: jakarta-ant/src/testcases/org/apache/tools/ant/types DirSetTest.java
Date Fri, 05 Apr 2002 13:35:38 GMT
On Fri, 05 Apr 2002, Conor MacNeill <conor@cortexebusiness.com.au>
wrote:

>  From your reasoning, I would say that a DirSet should probably not
>  be a subclass of FileSet

Yes.  I've already been thinking about pushing almost everything from
FileSet into a different class and make both FileSet and DirSet use
this, probably a common base class.

> I think the best thing may be to have DirSet provide a
> DirectoryScanner subclass where getIncludedFiles returns nothing

Not making it a subclass of FileSet would be better IMHO, so tasks
have to support it explicitly.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message