ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PROPOSAL] simple input framework
Date Thu, 28 Feb 2002 08:20:15 GMT
On Wed, 27 Feb 2002, Magesh Umasankar <umagesh@apache.org> wrote:

> This is cool.

Thanks.

> Just one comment:
> 
> In DefaultInputHandler, instead of doing 
> 
> if (request instanceof MultipleChoiceInputRequest) {
>   compose prompt
> }
> 
> please consider moving that logic to
> MultipleChoiceInputRequest.getPrompt() which would override
> InputRequest's getPrompt() method.

I've thought about this before, but then I'd get the modified prompt
in the SwingInputHandler as well, which is not what you want (as the
choices are obvious by the combo box).  So I felt it was the
responsibility of the handler.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message