ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Jar.java
Date Mon, 04 Feb 2002 15:08:02 GMT
> conor       02/02/03 20:31:42
>
>   Modified:    src/main/org/apache/tools/ant/taskdefs Jar.java
>   Log:
>   Change Jar so empty jars are not rebuilt
>
>   PR: 6069
>   Submitted by: jesse.glick@netbeans.com (Jesse Glick)
>
>   Revision  Changes    Path
>   1.34      +1 -1
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Jar.java
>
>   Index: Jar.java
>   ===================================================================
>   RCS file:
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Jar.java,v
>   retrieving revision 1.33
>   retrieving revision 1.34
>   diff -u -w -u -r1.33 -r1.34
>   --- Jar.java 20 Jan 2002 20:45:56 -0000 1.33
>   +++ Jar.java 4 Feb 2002 04:31:42 -0000 1.34
>   @@ -370,7 +370,7 @@
>
>        protected boolean createEmptyZip(File zipFile) {
>            // Jar files always contain a manifest and can never be empty
>   -        return false;
>   +        return true;
>        }
>
>        /**

I am not sure I like this patch.  Consider the
situation where a non-empty Jar exists already.
createEmptyZip, which is called by isUptoDate
will return true, ultimately leaving the Jar
untouched where it should actually have overwritten
it as an empty jar.  Or is this handled in some
way that I quite don't see?

Cheers,
Magesh

***********************************************
*  Yawn: The only time some married men ever  *
*  get to open their mouth.                   *
***********************************************



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message