ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Vernum <Tim.Ver...@macquarie.com.au>
Subject RE: [PATCH] Add "includefile" element to patternset/fileset
Date Wed, 14 Feb 2001 03:35:40 GMT
I feel a bit strange replying to my own reply to myself, but...

This was sent a week ago, and I haven't heard anything.
Should I raise something in bugzilla, or do I just need to wait for everyone to get 1.3 out
the door.

> -----Original Message-----
> From: Tim Vernum [mailto:Tim.Vernum@macquarie.com.au]
> Sent: Wednesday, 7 February 2001 8:59 PM
> To: 'ANT-dev'
> Subject: RE: [PATCH] Add "includefile" element to patternset/fileset
> 
> 
> *sigh*
> Always the way.
> Walking to the kitchen, about to head home, and I realise 
> there's a slight bug.
> The fixed version is attached.
> 
> So I was wondering, should I be providing a patch to the test 
> cases also?
> 
> > -----Original Message-----
> > From: Tim Vernum [mailto:Tim.Vernum@macquarie.com.au]
> > Sent: Wednesday, 7 February 2001 12:05 PM
> > To: 'ANT-dev'
> > Subject: [PATCH] Add "includefile" element to patternset/fileset
> > 
> > 
> > Patch
> > ====
> > This patch allows patternset/fileset to accepts a 
> > "<includefile>" sub-element. (and also excludefile)
> > 
> > The <includefile> works much like <include> except it uses 
> > the logic from includesfile=....
> > In order to support this I had to make a few changes to the 
> > way patternset works, and I think that it ends up being quite 
> > a bit cleaner.
> > 
> > The includefile element supports 4 attributes.
> > file = <path>
> > if = <condition>
> > unless = <condition>
> > commentchar = <char>
> > 
> > The commentchar allows you to specify a character that marks 
> > a comment in the patternfile.
> > The default is to have no comments.
> > 
> > I was tempted to make it a commentstring, but I thought that 
> > my be overkill.
> > 
> > This is my first patch to ant, so I'd appreciate comments/reviews.
> > 
> > Reason for patch
> > ============
> > I'm writing a fairly generic build file for a number of 
> > projects in development.
> > Most of the build process is run by properties.
> > I want to allow developers to includes a list of jar files, 
> > for inclusion in a WAR.
> > This list will be in a file and will specified as a property.
> > The <includefile> should only be processed in that property is set.
> > ie, I need the "if" support that is only available in a 
> > sub-element, and not as a direct attribute on patternset.
> > Also I want developers to be able to comment these include 
> > files, as they will form part of the build process that will 
> > be versioned (etc).
> > 
> > All of that is for my personal projects, but I imagine that 
> > others will have similar needs.
> > I certainly think that being able to comment includefiles is 
> > an important change.
> > 
> > 
> > 
> > 
> > 
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: ant-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: ant-dev-help@jakarta.apache.org
> > 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ant-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: ant-dev-help@jakarta.apache.org
> 

Mime
View raw message