xml-axkit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sergeant <m...@sergeant.org>
Subject Re: Two patches that may break things...
Date Thu, 20 May 2004 12:48:04 GMT
On Tue, 18 May 2004, Matt Sergeant wrote:

> So I added the following to deliver_to_browser (it made for cleaner
> code to add it there):
>
> diff -u -r1.53 AxKit.pm
> --- lib/AxKit.pm        18 Sep 2003 22:12:33 -0000      1.53
> +++ lib/AxKit.pm        18 May 2004 18:45:20 -0000
> @@ -917,6 +917,9 @@
>
>       AxKit::Debug(4, "delivering to browser");
>
> +    return $result_code if $result_code == DECLINED;
> +    return OK if $result_code == DONE;
> +
>       if (length($r->pnotes('xml_string'))) {
>           # ok, data is in xml_string
>           AxKit::Debug(4, "Delivering xml_string");
>
> Now I'm slightly worried that this will break something. However only
> slightly as it all made sense to me.

I've removed the DONE line above from my patch as it turns out that the
cache change works out slower once you manually send the right headers.

Though this still leaves me asking whether this will cause problems.

The potential problem comes if the developer returns DECLINED from a
transformation (XSP or XPathScript only I guess), but expects his output
to actually go to the browser. Can anyone think of when or why that might
happen?

> That was patch #1. Can I get votes on applying this please?

I'm not going to wait for feedback or votes any more. So if nobody talks
I'm just going to apply.

Matt.

Mime
View raw message