xml-axkit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sergeant <m...@sergeant.org>
Subject Re: cvs commit: xml-axkit/lib/Apache/AxKit/Language XSP.pm
Date Tue, 05 Mar 2002 08:07:14 GMT
On 4 Mar 2002, jwalt@apache.org wrote:

> jwalt       02/03/04 15:32:10
>
>   Modified:    lib/Apache/AxKit/Language XSP.pm
>   Log:
>   fixed line numbering for error log output (line numbers in error messages)
>
>   Revision  Changes    Path
>   1.6       +3 -2      xml-axkit/lib/Apache/AxKit/Language/XSP.pm
>
>   Index: XSP.pm
>   ===================================================================
>   RCS file: /home/cvs/xml-axkit/lib/Apache/AxKit/Language/XSP.pm,v
>   retrieving revision 1.5
>   retrieving revision 1.6
>   diff -u -r1.5 -r1.6
>   --- XSP.pm	3 Mar 2002 19:22:51 -0000	1.5
>   +++ XSP.pm	4 Mar 2002 23:32:10 -0000	1.6
>   @@ -1,4 +1,4 @@
>   -# $Id: XSP.pm,v 1.5 2002/03/03 19:22:51 darobin Exp $
>   +# $Id: XSP.pm,v 1.6 2002/03/04 23:32:10 jwalt Exp $
>
>    package Apache::AxKit::Language::XSP;
>
>   @@ -294,7 +294,8 @@
>
>        $e->{XSP_Script} = join("\n",
>                    "package $e->{XSP_Package}; \@$e->{XSP_Package}::ISA = ('Apache::AxKit::Language::XSP::Page');",
>   -                "#line 2 ".$e->{XSP_Line}."\n",
>   +                # "#line 2 ".$e->{XSP_Line}."\n", # This is wrong. Currently, line
numbers are unrelated to the source file's lines.
>   +                                                  # Better leave it out, it makes
debug output confusing.
>                    "use Apache;",
>                    "use Apache::Constants qw(:common);",
>                    "use XML::LibXML;",

I'd like to see this fixed - once we move to SAX2 we should be able to use
the DocumentLocator interface to put in accurate line numbers.

-- 
<!-- Matt -->
<:->Get a smart net</:->


Mime
View raw message