sqoop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hshreedha...@apache.org
Subject git commit: SQOOP-1226. --password-file option triggers FileSystemClosed exception at end of Oozie action
Date Thu, 16 Jan 2014 20:19:17 GMT
Updated Branches:
  refs/heads/trunk 49c0bf9b2 -> a1e45de8e


SQOOP-1226. --password-file option triggers FileSystemClosed exception at end of Oozie action

(Jarek Jarcec Cecho via Hari Shreedharan)


Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/a1e45de8
Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/a1e45de8
Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/a1e45de8

Branch: refs/heads/trunk
Commit: a1e45de8e9c85f0911c5c6c7c3bb7acfa76190e0
Parents: 49c0bf9
Author: Hari Shreedharan <hshreedharan@cloudera.com>
Authored: Thu Jan 16 12:18:05 2014 -0800
Committer: Hari Shreedharan <hshreedharan@cloudera.com>
Committed: Thu Jan 16 12:18:05 2014 -0800

----------------------------------------------------------------------
 .../org/apache/sqoop/util/password/FilePasswordLoader.java  | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/sqoop/blob/a1e45de8/src/java/org/apache/sqoop/util/password/FilePasswordLoader.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/sqoop/util/password/FilePasswordLoader.java b/src/java/org/apache/sqoop/util/password/FilePasswordLoader.java
index 86b71ec..4a288bf 100644
--- a/src/java/org/apache/sqoop/util/password/FilePasswordLoader.java
+++ b/src/java/org/apache/sqoop/util/password/FilePasswordLoader.java
@@ -79,11 +79,8 @@ public class FilePasswordLoader extends PasswordLoader {
     Path path = new Path(p);
     FileSystem fs = path.getFileSystem(configuration);
 
-    try {
-      verifyPath(fs, path);
-      return new String(readBytes(fs, path));
-    } finally {
-      fs.close();
-    }
+    // Not closing FileSystem object because of SQOOP-1226
+    verifyPath(fs, path);
+    return new String(readBytes(fs, path));
   }
 }


Mime
View raw message