sqoop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jar...@apache.org
Subject git commit: SQOOP-1161: Generated Delimiter Set Field Should be Static
Date Thu, 15 Aug 2013 15:32:26 GMT
Updated Branches:
  refs/heads/trunk a9089430e -> db89861c0


SQOOP-1161: Generated Delimiter Set Field Should be Static

(Nick White via Jarek Jarcec Cecho)


Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/db89861c
Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/db89861c
Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/db89861c

Branch: refs/heads/trunk
Commit: db89861c0ca9646a1719037690bc63fead13f6fa
Parents: a908943
Author: Jarek Jarcec Cecho <jarcec@apache.org>
Authored: Thu Aug 15 08:31:38 2013 -0700
Committer: Jarek Jarcec Cecho <jarcec@apache.org>
Committed: Thu Aug 15 08:31:38 2013 -0700

----------------------------------------------------------------------
 src/java/org/apache/sqoop/orm/ClassWriter.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/sqoop/blob/db89861c/src/java/org/apache/sqoop/orm/ClassWriter.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/sqoop/orm/ClassWriter.java b/src/java/org/apache/sqoop/orm/ClassWriter.java
index 1bd2a41..4cb4b78 100644
--- a/src/java/org/apache/sqoop/orm/ClassWriter.java
+++ b/src/java/org/apache/sqoop/orm/ClassWriter.java
@@ -808,7 +808,7 @@ public class ClassWriter {
       String [] colNames, StringBuilder sb) {
 
     // Save the delimiters to the class.
-    sb.append("  private final DelimiterSet __outputDelimiters = ");
+    sb.append("  private static final DelimiterSet __outputDelimiters = ");
     sb.append(options.getOutputDelimiters().formatConstructor() + ";\n");
 
     // The default toString() method itself follows. This just calls
@@ -972,7 +972,7 @@ public class ClassWriter {
       sb.append("      String[] strByteVal = __cur_str.trim().split(\" \");\n");
       sb.append("      byte [] byteVal = new byte[strByteVal.length];\n");
       sb.append("      for (int i = 0; i < byteVal.length; ++i) {\n");
-      sb.append("          byteVal[i] = (byte)Integer.parseInt(strByteVal[i], 16);\n"); 
+      sb.append("          byteVal[i] = (byte)Integer.parseInt(strByteVal[i], 16);\n");
       sb.append("      }\n");
       sb.append("      this." + colName + " = new BytesWritable(byteVal);\n");
     } else {
@@ -995,7 +995,7 @@ public class ClassWriter {
     // records.  Note that these can differ from the delims to use as output
     // via toString(), if the user wants to use this class to convert one
     // format to another.
-    sb.append("  private final DelimiterSet __inputDelimiters = ");
+    sb.append("  private static final DelimiterSet __inputDelimiters = ");
     sb.append(options.getInputDelimiters().formatConstructor() + ";\n");
 
     // The parser object which will do the heavy lifting for field splitting.


Mime
View raw message