sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject [sis] 03/04: Avoid to declare <scope>provided</scode> on netCDF in <dependencyManagement> section, because it causes difficulties to control the scope in transitive dependencies. Instead all uses of netCDF in sub-modules must declare the desired scope explicitly.
Date Wed, 12 Aug 2020 17:32:58 GMT
This is an automated email from the ASF dual-hosted git repository.

desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git

commit b6f8ed7e8bc8c40e2f55f374a84190275430ce56
Author: Martin Desruisseaux <martin.desruisseaux@geomatys.com>
AuthorDate: Wed Aug 12 18:53:50 2020 +0200

    Avoid to declare <scope>provided</scode> on netCDF in <dependencyManagement>
section,
    because it causes difficulties to control the scope in transitive dependencies.
    Instead all uses of netCDF in sub-modules must declare the desired scope explicitly.
---
 pom.xml                            | 2 --
 profiles/sis-japan-profile/pom.xml | 6 ++++++
 storage/sis-netcdf/pom.xml         | 3 ++-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index ca9cd5d..8d49462 100644
--- a/pom.xml
+++ b/pom.xml
@@ -522,13 +522,11 @@
         <groupId>edu.ucar</groupId>
         <artifactId>cdm</artifactId>
         <version>${netcdf.version}</version>
-        <scope>provided</scope>
       </dependency>
       <dependency>
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-jdk14</artifactId>
         <version>1.7.22</version>               <!-- Must matches the version
used by netCDF. -->
-        <scope>test</scope>                     <!-- Should never be needed
at compile time.  -->
       </dependency>
     </dependencies>
   </dependencyManagement>
diff --git a/profiles/sis-japan-profile/pom.xml b/profiles/sis-japan-profile/pom.xml
index 65a7145..3fd6009 100644
--- a/profiles/sis-japan-profile/pom.xml
+++ b/profiles/sis-japan-profile/pom.xml
@@ -99,6 +99,12 @@
       <groupId>edu.ucar</groupId>
       <artifactId>cdm</artifactId>
       <scope>compile</scope>
+      <optional>false</optional>
+    </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>          <!-- For UCAR library. -->
+      <artifactId>slf4j-jdk14</artifactId>
+      <scope>runtime</scope>
     </dependency>
   </dependencies>
 
diff --git a/storage/sis-netcdf/pom.xml b/storage/sis-netcdf/pom.xml
index 2e9e7b8..4fde6a6 100644
--- a/storage/sis-netcdf/pom.xml
+++ b/storage/sis-netcdf/pom.xml
@@ -117,6 +117,7 @@
     <dependency>
       <groupId>edu.ucar</groupId>
       <artifactId>cdm</artifactId>
+      <scope>provided</scope>
       <optional>true</optional>
     </dependency>
 
@@ -136,7 +137,7 @@
       <scope>test</scope>
     </dependency>
     <dependency>
-      <groupId>org.slf4j</groupId>
+      <groupId>org.slf4j</groupId>          <!-- For UCAR library. -->
       <artifactId>slf4j-jdk14</artifactId>
       <scope>test</scope>
     </dependency>


Mime
View raw message