Author: desruisseaux Date: Thu May 9 15:28:00 2019 New Revision: 1859019 URL: http://svn.apache.org/viewvc?rev=1859019&view=rev Log: Add IP review for GeodeticCalculatorTest. Added: sis/ip-review/GeodeticCalculatorTest.xhtml sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml Added: sis/ip-review/GeodeticCalculatorTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto ============================================================================== --- sis/ip-review/GeodeticCalculatorTest.xhtml (added) +++ sis/ip-review/GeodeticCalculatorTest.xhtml Thu May 9 15:28:00 2019 @@ -0,0 +1,73 @@ + + + + + GeodeticCalculatorTest history + + + +
+

GeodeticCalculatorTest history

+

Click on the commit message for inspecting the diff and how the code has been rewritten. + In addition of author information provided by commits, comments in the code suggests that the following + test cases were provided by external users:

+ +

For the implementation in SIS, we plan to replace or complete some tests be the + GeographicLib to be used as a reference implementation + (SIS-386).

+ +

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
307602008-06-18desruisseauxUpgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.
306412008-06-12acusterCopyright headers: lib/referencing, this time with feeling (and the el in Toolkit)
306392008-06-12acusterCopyright headers: cleanup library/referencing
305212008-06-05acusterCopyright: Update referencing headers
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
297682008-04-02desruisseauxUpgrated the metadata and referencing tests to JUnit 4.
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
287792008-01-16desruisseauxIn referencing module, changed the DirectPosition2D.hashCode() and equals(Object) implementation in order to comply with DirectPosition contract, which fix an AssertionError. It has the unfortunate side-effect of violating the Point2D.hashCode() contract. Unfortunatly it is not possible to comply to both in same time. I added a note in javadoc trying to make that clear.In the coverage module, applied the ImageWorker changes mentioned on the mailing list. Also provided a first draft of an ImageWorkerTest. Note that the build still fail in the shapefile-renderer module for a reason that I believe unrelated to those changes. The same changes have already been applied to the 2.4 branch, which build fine.
287512008-01-14desruisseauxAttempt to make the GeodeticCalculator slightly more resistant to antipodal case (at least for orthodromic distance).
285402007-12-29acusterHide buttons which are not yet used
249252007-03-27jgarnettchange to org.opengis.geometry
245762007-02-24desruisseauxRenamed 'StereographicFoo' classes as 'FooStereographic' for consistency with EPSG and OGC naming. Note that 'ObliqueStereographic' is NOT the new name for 'StereographicOblique'; it is rather the new name for 'StereographicDouble'. The old name was confusing since 'StereographicOblique' was not for the EPSG 'Oblique_Stereographic' projection. The new naming scheme should match more closely the common usage. In addition, also renamed some JUnit test classes in an attempt to make clearer what they are testing.
223272006-10-23desruisseauxGEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.
223172006-10-22desruisseauxReorganisation of directory tree structure (GEOT-982) phase 3: moved 'test' to 'src/test/java'.
217802006-10-03desruisseauxRemoved methods from the referencing module that were deprecated in Geotools 2.3. This imply the replacement of 'CRS.transform' by 'CRS.findMathTransform' in the whole Geotools code base.
208742006-08-07jgarnettip review
176722006-01-19desruisseauxAdded @source tag.
176602006-01-18desruisseauxFixed SVN attributes, including the addition of URL attribute.
153502005-08-16desruisseauxMerged the 'split-main' branch to trunk (GEOT-662)
152562005-08-09desruisseauxExtraction of referencing module from main
152552005-08-09desruisseauxPrepare branch for splitting main
149592005-07-28desruisseauxAdded orthodromic distance computation to OpenOffice formulas
149112005-07-26desruisseauxFixed GEOT-627, 630, 631, 632 and 634
138362005-05-26desruisseauxAdded 'Default' suffix to some CRS implementations: partial work
111372005-02-05desruisseauxTune CRS tests (e.g. allow different tolerance level for assertions in different projections)
107962005-01-28dzwiersimports cleaned
101772005-01-03desruisseauxTuned JUnit tests for WKT parsing
62752004-05-31jgarnettfixed format test problem
62552004-05-31desruisseauxBug fix for horizontal and vertical line colinear with an axis
59082004-05-23jgarnettcts-coordtrans moved to main
58512004-05-23jgarnettTest is assumed to be the junit directory
57742004-05-23jgarnettgeotools-src serves as the start of our new module directory (the data access modules will escape off to plugin directory soon)
57692004-05-23jgarnettProject renamed to gt
56192004-05-13(no author)Move repository under gt.
51302004-03-08desruisseauxAdded a geodetic calculator
+
+ + Added: sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto ============================================================================== --- sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml (added) +++ sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml Thu May 9 15:28:00 2019 @@ -0,0 +1,21 @@ + + + + + GeodeticCalculatorTest changes for revisions 5618:5908 + + + +
+

GeodeticCalculatorTest changes for revisions 5618:5908

+

Commits cancel each other.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r5618:5908 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java
+ + +
Revision 5618Revision 5908
+
+ + Added: sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto ============================================================================== --- sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml (added) +++ sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml Thu May 9 15:28:00 2019 @@ -0,0 +1,36 @@ + + + + + GeodeticCalculatorTest changes for revisions 6274:6275 + + + +
+

GeodeticCalculatorTest changes for revisions 6274:6275

+

Does not apply to SIS since we do not use the SVN $Id$ property.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r6274:6275 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java
+ + + + +
Revision 6274Revision 6275
/**
+ * Test the geodetic calculator.
+ *
+ * @version $Id: GeodeticCalculatorTest.java,v 1.1 2004/03/08 17:48:27 desruisseaux Exp $
+ */
+public class GeodeticCalculatorTest extends TestCase {
+    /**
/**
+ * Test the geodetic calculator.
+ *
+ * @version $Id$
+ */
+public class GeodeticCalculatorTest extends TestCase {
+    /**
+
+ + Added: sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto ============================================================================== --- sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml (added) +++ sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml Thu May 9 15:28:00 2019 @@ -0,0 +1,49 @@ + + + + + GeodeticCalculatorTest changes for revisions 10795:10796 + + + +
+

GeodeticCalculatorTest changes for revisions 10795:10796

+

Changes in this commit seem to be the result of some "auto reformat" tool execution. +The Java - GeoAPI - GeoTools import ordering is altered, +imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken. +This commit has been reverted, except for the removal of really unused imports which are keep removed.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java
+ + + + +
Revision 10795Revision 10796
// J2SE dependencies and extensions
+import java.awt.Shape;
+import java.awt.geom.PathIterator;
+import java.awt.geom.IllegalPathStateException;
+import javax.units.SI;
+
+// JUnit dependencies
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+// Geotools dependencies
+import org.geotools.referencing.datum.Ellipsoid;
// J2SE dependencies and extensions
+import java.awt.Shape;
+import java.awt.geom.IllegalPathStateException;
+import java.awt.geom.PathIterator;
+
+import javax.units.SI;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+import org.geotools.referencing.datum.Ellipsoid;
+
+ + Added: sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto ============================================================================== --- sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml (added) +++ sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml Thu May 9 15:28:00 2019 @@ -0,0 +1,50 @@ + + + + + GeodeticCalculatorTest changes for revisions 20873:20874 + + + +
+

GeodeticCalculatorTest changes for revisions 20873:20874

+

Changes in GeoTools header only. The removal of the "or (at your option) any later version" clause +must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing. +This header does not apply to Apache SIS, since the above-cited contributions are omitted.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java
+ + + + + + +
Revision 20873Revision 20874
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Management Committee (PMC)
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
/*
+ *    GeoTools - OpenSource mapping toolkit
+ *    http://geotools.org
+ *    (C) 2004-2006, Geotools Project Managment Committee (PMC)
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
 *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+ *    You should have received a copy of the GNU Lesser General Public
+ *    License along with this library; if not, write to the Free Software
+ *    Foundation, Inc.. 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+package org.geotools.referencing;
 *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing;
+
+ + Added: sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto ============================================================================== --- sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml (added) +++ sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml Thu May 9 15:28:00 2019 @@ -0,0 +1,37 @@ + + + + + GeodeticCalculatorTest changes for revisions 24924:24925 + + + +
+

GeodeticCalculatorTest changes for revisions 24924:24925

+

This commit propagates the package names change which was done in GeoAPI. +There is no way such change could be done differently, +since not renaming the packages cause a compilation error.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java
+ + + + +
Revision 24924Revision 24925
import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.crs.GeographicCRS;
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.spatialschema.geometry.DirectPosition;
+
+// Geotools dependencies
+import org.geotools.geometry.DirectPosition2D;
import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.crs.GeographicCRS;
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.geometry.DirectPosition;
+
+// Geotools dependencies
+import org.geotools.geometry.DirectPosition2D;
+
+ +