sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1859019 - in /sis/ip-review: ./ rev/05908/ rev/06275/ rev/10796/ rev/20874/ rev/24925/
Date Thu, 09 May 2019 15:28:00 GMT
Author: desruisseaux
Date: Thu May  9 15:28:00 2019
New Revision: 1859019

URL: http://svn.apache.org/viewvc?rev=1859019&view=rev
Log:
Add IP review for GeodeticCalculatorTest.

Added:
    sis/ip-review/GeodeticCalculatorTest.xhtml
    sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml
    sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml
    sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml
    sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml
    sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml

Added: sis/ip-review/GeodeticCalculatorTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto
==============================================================================
--- sis/ip-review/GeodeticCalculatorTest.xhtml (added)
+++ sis/ip-review/GeodeticCalculatorTest.xhtml Thu May  9 15:28:00 2019
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeodeticCalculatorTest history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeodeticCalculatorTest history</h1>
+      <p>Click on the commit message for inspecting the <code>diff</code>
and how the code has been rewritten.
+        In addition of author information provided by commits, comments in the code suggests
that the following
+        test cases were provided by external users:</p>
+      <ul>
+        <li><code>testGEOT1535()</code> (from GEOT-1535 bug report)</li>
+        <li><code>testGeodeticCurveOnEquator()</code> (from GEOT-103 bug
report)</li>
+        <li><code>testPointsOnGeodeticCurve()</code> (from GEOT-2716 bug
report)</li>
+      </ul>
+      <p>For the implementation in SIS, we plan to replace or complete some tests be
the
+        <a href="https://geographiclib.sourceforge.io/">GeographicLib</a> to
be used as a reference implementation
+        (<a href="https://issues.apache.org/jira/browse/SIS-386">SIS-386</a>).</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated
from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations
in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30639</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: cleanup library/referencing</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29768</td><td>2008-04-02</td><td>desruisseaux</td><td>Upgrated
the metadata and referencing tests to JUnit 4.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28779</td><td>2008-01-16</td><td>desruisseaux</td><td>In
referencing module, changed the DirectPosition2D.hashCode() and equals(Object) implementation
in order to comply with DirectPosition contract, which fix an AssertionError. It has the unfortunate
side-effect of violating the Point2D.hashCode() contract. Unfortunatly it is not possible
to comply to both in same time. I added a note in javadoc trying to make that clear.In the
coverage module, applied the ImageWorker changes mentioned on the mailing list. Also provided
a first draft of an ImageWorkerTest. Note that the build still fail in the shapefile-renderer
module for a reason that I believe unrelated to those changes. The same changes have already
been applied to the 2.4 branch, which build fine.</td></tr>
+<tr><td class="rev">28751</td><td>2008-01-14</td><td>desruisseaux</td><td>Attempt
to make the GeodeticCalculator slightly more resistant to antipodal case (at least for orthodromic
distance).</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/24925/GeodeticCalculatorTest.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">24576</td><td>2007-02-24</td><td>desruisseaux</td><td>Renamed
'StereographicFoo' classes as 'FooStereographic' for consistency with EPSG and OGC naming.
Note that 'ObliqueStereographic' is NOT the new name for 'StereographicOblique'; it is rather
the new name for 'StereographicDouble'. The old name was confusing since 'StereographicOblique'
was not for the EPSG 'Oblique_Stereographic' projection. The new naming scheme should match
more closely the common usage. In addition, also renamed some JUnit test classes in an attempt
to make clearer what they are testing.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22317</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 3: moved 'test' to 'src/test/java'.</td></tr>
+<tr><td class="rev">21780</td><td>2006-10-03</td><td>desruisseaux</td><td>Removed
methods from the referencing module that were deprecated in Geotools 2.3. This imply the replacement
of 'CRS.transform' by 'CRS.findMathTransform' in the whole Geotools code base.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/GeodeticCalculatorTest.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction
of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td class="rev">14959</td><td>2005-07-28</td><td>desruisseaux</td><td>Added
orthodromic distance computation to OpenOffice formulas</td></tr>
+<tr><td class="rev">14911</td><td>2005-07-26</td><td>desruisseaux</td><td>Fixed
GEOT-627, 630, 631, 632 and 634</td></tr>
+<tr><td class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added
'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td class="rev">11137</td><td>2005-02-05</td><td>desruisseaux</td><td>Tune
CRS tests (e.g. allow different tolerance level for assertions in different projections)</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a
href="rev/10796/GeodeticCalculatorTest.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">10177</td><td>2005-01-03</td><td>desruisseaux</td><td>Tuned
JUnit tests for WKT parsing</td></tr>
+<tr><td class="rev">6275</td><td>2004-05-31</td><td class="unav">jgarnett</td><td><a
href="rev/06275/GeodeticCalculatorTest.xhtml">fixed format test problem</a></td></tr>
+<tr><td class="rev">6255</td><td>2004-05-31</td><td>desruisseaux</td><td>Bug
fix for horizontal and vertical line colinear with an axis</td></tr>
+<tr><td class="rev">5908</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a
href="rev/05908/GeodeticCalculatorTest.xhtml">cts-coordtrans moved to main</a></td></tr>
+<tr><td class="rev">5851</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a
href="rev/05908/GeodeticCalculatorTest.xhtml">Test is assumed to be the junit directory</a></td></tr>
+<tr><td class="rev">5774</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a
href="rev/05908/GeodeticCalculatorTest.xhtml">geotools-src serves as the start of our new
module directory (the data access modules will escape off to plugin directory soon)</a></td></tr>
+<tr><td class="rev">5769</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a
href="rev/05908/GeodeticCalculatorTest.xhtml">Project renamed to gt</a></td></tr>
+<tr><td class="rev">5619</td><td>2004-05-13</td><td class="unav">(no
author)</td><td><a href="rev/05908/GeodeticCalculatorTest.xhtml">Move repository
under gt.</a></td></tr>
+<tr><td class="rev">5130</td><td>2004-03-08</td><td>desruisseaux</td><td>Added
a geodetic calculator</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto
==============================================================================
--- sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml (added)
+++ sis/ip-review/rev/05908/GeodeticCalculatorTest.xhtml Thu May  9 15:28:00 2019
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeodeticCalculatorTest changes for revisions 5618:5908</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeodeticCalculatorTest changes for revisions 5618:5908</h1>
+<p>Commits cancel each other.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r5618:5908 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 5618</th><th>Revision 5908</th></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto
==============================================================================
--- sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml (added)
+++ sis/ip-review/rev/06275/GeodeticCalculatorTest.xhtml Thu May  9 15:28:00 2019
@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeodeticCalculatorTest changes for revisions 6274:6275</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeodeticCalculatorTest changes for revisions 6274:6275</h1>
+      <p>Does not apply to SIS since we do not use the SVN <code>$Id$</code>
property.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r6274:6275 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 6274</th><th>Revision 6275</th></tr>
+<tr><td><pre>/**
+ * Test the geodetic calculator.
+ *
+<span class="del"> * @version $Id: GeodeticCalculatorTest.java,v 1.1 2004/03/08 17:48:27
desruisseaux Exp $</span>
+ */
+public class GeodeticCalculatorTest extends TestCase {
+    /**</pre></td>
+<td><pre>/**
+ * Test the geodetic calculator.
+ *
+<span class="add"> * @version $Id$</span>
+ */
+public class GeodeticCalculatorTest extends TestCase {
+    /**</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto
==============================================================================
--- sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml (added)
+++ sis/ip-review/rev/10796/GeodeticCalculatorTest.xhtml Thu May  9 15:28:00 2019
@@ -0,0 +1,49 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeodeticCalculatorTest changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeodeticCalculatorTest changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite>
tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite>
import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are
keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>// J2SE dependencies and extensions
+import java.awt.Shape;
+import java.awt.geom.PathIterator;
+<span class="del">import java.awt.geom.IllegalPathStateException;</span>
+import javax.units.SI;
+
+<span class="del">// JUnit dependencies</span>
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+<span class="del">// Geotools dependencies</span>
+import org.geotools.referencing.datum.Ellipsoid;</pre></td>
+<td><pre>// J2SE dependencies and extensions
+import java.awt.Shape;
+<span class="add">import java.awt.geom.IllegalPathStateException;</span>
+import java.awt.geom.PathIterator;
+<span class="add"></span>
+import javax.units.SI;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+import org.geotools.referencing.datum.Ellipsoid;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto
==============================================================================
--- sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml (added)
+++ sis/ip-review/rev/20874/GeodeticCalculatorTest.xhtml Thu May  9 15:28:00 2019
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeodeticCalculatorTest changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeodeticCalculatorTest changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the <cite>"or (at your option)
any later version"</cite> clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Management Committee (PMC)</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, Geotools Project Managment Committee (PMC)</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty
of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc.. 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.referencing;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml?rev=1859019&view=auto
==============================================================================
--- sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml (added)
+++ sis/ip-review/rev/24925/GeodeticCalculatorTest.xhtml Thu May  9 15:28:00 2019
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeodeticCalculatorTest changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeodeticCalculatorTest changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/GeodeticCalculatorTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.crs.GeographicCRS;
+import org.opengis.referencing.operation.TransformException;
+<span class="del">import org.opengis.spatialschema.geometry.DirectPosition;</span>
+
+// Geotools dependencies
+import org.geotools.geometry.DirectPosition2D;</pre></td>
+<td><pre>import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.crs.GeographicCRS;
+import org.opengis.referencing.operation.TransformException;
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+
+// Geotools dependencies
+import org.geotools.geometry.DirectPosition2D;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>



Mime
View raw message