sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1848556 - in /sis/ip-review: ./ rev/05900/ rev/10796/ rev/10894/ rev/20970/ rev/24476/
Date Mon, 10 Dec 2018 08:50:52 GMT
Author: desruisseaux
Date: Mon Dec 10 08:50:52 2018
New Revision: 1848556

URL: http://svn.apache.org/viewvc?rev=1848556&view=rev
Log:
IP review on ScaledColorSpace and ColorModelFactory.

Added:
    sis/ip-review/ColorModelFactory.xhtml
    sis/ip-review/ScaledColorSpace.xhtml
    sis/ip-review/ScaledColorSpaceTest.xhtml
    sis/ip-review/rev/05900/ScaledColorSpaceTest.xhtml
    sis/ip-review/rev/10796/ColorModelFactory.xhtml
    sis/ip-review/rev/10796/ScaledColorSpace.xhtml
    sis/ip-review/rev/10894/ScaledColorSpaceTest.xhtml
    sis/ip-review/rev/20970/ColorModelFactory.xhtml
    sis/ip-review/rev/20970/ScaledColorSpace.xhtml
    sis/ip-review/rev/20970/ScaledColorSpaceTest.xhtml
    sis/ip-review/rev/24476/
    sis/ip-review/rev/24476/ColorModelFactory.xhtml
    sis/ip-review/rev/24476/HEADER.html

Added: sis/ip-review/ColorModelFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ColorModelFactory.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/ColorModelFactory.xhtml (added)
+++ sis/ip-review/ColorModelFactory.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,56 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ColorModelFactory history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ColorModelFactory history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/ColorModelFactory.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30836</td><td>2008-07-01</td><td>desruisseaux</td><td>Best effort in an attempt to bring a little bit of order in the coverage test bazar. A lonely test file moved to the sample-data module. Operation tests moved to the processing package. A few utility methods consolidated in base classes ending in "TestBase.java". Removed redundancy introduced by copy-and-paste. Merged the two occurences of ImageWorkerTest. Examples of coverages provided in a more "Java collection" way. Comparaison of values performed with "assertEquals(a,b)" rather than "assertTrue(a==b)" so we know what was the expected value in case of failure. Tests upgrated to JUnit 4 framework.</td></tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29093</td><td>2008-02-05</td><td>desruisseaux</td><td>First draft of a test suite for ViewsManager in an attempt to understand why our "Piecewise" operation produces different results than what we would expect. Some bug fixes.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25421</td><td>2007-05-05</td><td>desruisseaux</td><td>Reviewing current state of core coverage module, prior to image and coverage I/O work.</td></tr>
+<tr><td class="rev">24476</td><td>2007-02-16</td><td class="unav">simboss</td><td><a href="rev/24476/ColorModelFactory.xhtml">-first bunch of changes for the alignment of trunk with 2.3.x</a></td></tr>
+<tr><td class="rev">23211</td><td>2006-12-05</td><td>desruisseaux</td><td>Replaced Citation.OGC by Citation.GEOTOOLS for non-OGC operations. Code reformating and javadoc.</td></tr>
+<tr><td class="rev">23120</td><td>2006-11-29</td><td>desruisseaux</td><td>Coverage branch review. Reformatted code (including javadoc work), modification of AbstractCoverage.show and AbstractCoverage.evaluate(DirectPosition,Set).</td></tr>
+<tr><td class="rev">22817</td><td>2006-11-17</td><td>desruisseaux</td><td>Fixed SVN properties for all Java files.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/ColorModelFactory.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">20741</td><td>2006-07-28</td><td class="unav">simboss</td><td><a href="rev/20970/ColorModelFactory.xhtml">-cleaning up a bit and improving coverages code</a></td></tr>
+<tr><td class="rev">20600</td><td>2006-07-18</td><td class="unav">simboss</td><td><a href="rev/20741/ColorModelFactory.xhtml">-committing first bunch of changes from the coverage branch. Modules involved are*api *referencing *coverage *main *renderer *shaperenderer</a></td></tr>
+<tr><td class="rev">18017</td><td>2006-02-14</td><td>desruisseaux</td><td>Added support for GraphicStyleListeners.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/ColorModelFactory.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added more implementations for Coverage support</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/ScaledColorSpace.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ScaledColorSpace.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/ScaledColorSpace.xhtml (added)
+++ sis/ip-review/ScaledColorSpace.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ScaledColorSpace history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ScaledColorSpace history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/ScaledColorSpace.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">22817</td><td>2006-11-17</td><td>desruisseaux</td><td>Fixed SVN properties for all Java files.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/ScaledColorSpace.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">15803</td><td>2005-09-22</td><td>desruisseaux</td><td>Bux fix in automatic axis swapping during GridCoverage(..., Envelope, ...) construction.</td></tr>
+<tr><td class="rev">13928</td><td>2005-05-30</td><td>desruisseaux</td><td>Fixed GEOT-482; added a convenience method for loading a matrix from a file</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13016</td><td>2005-04-07</td><td>desruisseaux</td><td>Moved 'org.geotools.io.image' to 'org.geotools.image.io' / Continue work on CoverageStack</td></tr>
+<tr><td class="rev">11572</td><td>2005-02-23</td><td>desruisseaux</td><td>Initial port of sub-transform, required for some grid coverages</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/ScaledColorSpace.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added more implementations for Coverage support</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/ScaledColorSpaceTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/ScaledColorSpaceTest.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/ScaledColorSpaceTest.xhtml (added)
+++ sis/ip-review/ScaledColorSpaceTest.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ScaledColorSpaceTest history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ScaledColorSpaceTest history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/ScaledColorSpaceTest.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30836</td><td>2008-07-01</td><td>desruisseaux</td><td>Best effort in an attempt to bring a little bit of order in the coverage test bazar. A lonely test file moved to the sample-data module. Operation tests moved to the processing package. A few utility methods consolidated in base classes ending in "TestBase.java". Removed redundancy introduced by copy-and-paste. Merged the two occurences of ImageWorkerTest. Examples of coverages provided in a more "Java collection" way. Comparaison of values performed with "assertEquals(a,b)" rather than "assertTrue(a==b)" so we know what was the expected value in case of failure. Tests upgrated to JUnit 4 framework.</td></tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29826</td><td>2008-04-07</td><td>desruisseaux</td><td>More support for PixelOrientation in GridGeometry construction and queries. A side effect of this work is the refactoring of GridGeometry2D translation method into a separated PixelTranslation class.</td></tr>
+<tr><td class="rev">29052</td><td>2008-02-01</td><td>desruisseaux</td><td>More information in GridCoverage2D.toString(). Attempt to enable "Piecewise" JAI operation when converting from packed to geophysics (not finished). Bug fix in Resampler2D when the only work to do is a Crop.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28500</td><td>2007-12-24</td><td>desruisseaux</td><td>Added a new GridGeometry implementation (ImageGeometry) has a lightweight placeholder for 'gridRange' as a Rectangle and 'gridToCRS' as an AffineTransform. Used by TileBuilder.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22317</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 3: moved 'test' to 'src/test/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/ScaledColorSpaceTest.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">11910</td><td>2005-03-09</td><td>desruisseaux</td><td>Moved GridCoverage tests from legacy to main module</td></tr>
+<tr><td class="rev">11004</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in legacy/test</td></tr>
+<tr><td class="rev">10894</td><td>2005-01-31</td><td class="unav">dzwiers</td><td><a href="rev/10894/ScaledColorSpaceTest.xhtml">moved legacy</a></td></tr>
+<tr><td class="rev">10822</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10894/ScaledColorSpaceTest.xhtml">moving tests</a></td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10894/ScaledColorSpaceTest.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">6275</td><td>2004-05-31</td><td class="unav">jgarnett</td><td><a href="rev/10894/ScaledColorSpaceTest.xhtml">fixed format test problem</a></td></tr>
+<tr><td class="rev">6255</td><td>2004-05-31</td><td>desruisseaux</td><td>Bug fix for horizontal and vertical line colinear with an axis</td></tr>
+<tr><td class="rev">5900</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a href="rev/05900/ScaledColorSpaceTest.xhtml">gcs-coverage moved to main</a></td></tr>
+<tr><td class="rev">5843</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a href="rev/05900/ScaledColorSpaceTest.xhtml">Test directory now assumed to be junit</a></td></tr>
+<tr><td class="rev">5774</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a href="rev/05900/ScaledColorSpaceTest.xhtml">geotools-src serves as the start of our new module directory (the data access modules will escape off to plugin directory soon)</a></td></tr>
+<tr><td class="rev">5769</td><td>2004-05-23</td><td class="unav">jgarnett</td><td><a href="rev/05900/ScaledColorSpaceTest.xhtml">Project renamed to gt</a></td></tr>
+<tr><td class="rev">5619</td><td>2004-05-13</td><td class="unav">(no author)</td><td><a href="rev/05900/ScaledColorSpaceTest.xhtml">Move repository under gt.</a></td></tr>
+<tr><td class="rev">2858</td><td>2003-05-13</td><td>desruisseaux</td><td>Added PMC owner to copyright notice</td></tr>
+<tr><td class="rev">1399</td><td>2002-08-09</td><td>desruisseaux</td><td>Added test for ScaledColorSpace</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/05900/ScaledColorSpaceTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05900/ScaledColorSpaceTest.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/05900/ScaledColorSpaceTest.xhtml (added)
+++ sis/ip-review/rev/05900/ScaledColorSpaceTest.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ScaledColorSpaceTest changes for revisions 5618:5900</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ScaledColorSpaceTest changes for revisions 5618:5900</h1>
+<p>No contribution relevant to SIS here.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r5618:5900 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/ScaledColorSpaceTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 5618</th><th>Revision 5900</th></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10796/ColorModelFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/ColorModelFactory.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/10796/ColorModelFactory.xhtml (added)
+++ sis/ip-review/rev/10796/ColorModelFactory.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,130 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ColorModelFactory changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ColorModelFactory changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite> tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/ColorModelFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.coverage;
+
+// J2SE dependencies
+<span class="del">import java.util.Map;</span>
+<span class="del">import java.util.Arrays;</span>
+<span class="del"></span>
+<span class="del">// Images and colors</span>
+import java.awt.Transparency;
+import java.awt.color.ColorSpace;
+import java.awt.image.ColorModel;
+import java.awt.image.DataBuffer;
+<span class="del">import java.awt.image.RenderedImage;   // For Javadoc</span>
+<span class="del">import java.awt.image.ComponentColorModel;</span>
+
+<span class="del">// JAI dependencies</span>
+import javax.media.jai.RasterFactory;
+<span class="del">import javax.media.jai.FloatDoubleColorModel;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.util.WeakValueHashMap;</span>
+import org.geotools.resources.gcs.Resources;
+<span class="del">import org.geotools.resources.gcs.ResourceKeys;</span>
+import org.geotools.resources.image.ColorUtilities;
+import org.geotools.resources.image.ComponentColorModelJAI;
+
+
+/**</pre></td>
+<td><pre>package org.geotools.coverage;
+
+// J2SE dependencies
+import java.awt.Transparency;
+import java.awt.color.ColorSpace;
+import java.awt.image.ColorModel;
+<span class="add">import java.awt.image.ComponentColorModel;</span>
+import java.awt.image.DataBuffer;
+<span class="add">import java.awt.image.RenderedImage;</span>
+<span class="add">import java.util.Arrays;</span>
+<span class="add">import java.util.Map;</span>
+
+<span class="add">import javax.media.jai.FloatDoubleColorModel;</span>
+import javax.media.jai.RasterFactory;
+
+<span class="add">import org.geotools.resources.gcs.ResourceKeys;</span>
+import org.geotools.resources.gcs.Resources;
+import org.geotools.resources.image.ColorUtilities;
+import org.geotools.resources.image.ComponentColorModelJAI;
+<span class="add">import org.geotools.util.WeakValueHashMap;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre> */
+final class ColorModelFactory {
+    /**
+<span class="del">     * Modèles de couleurs suggérés pour l'affichage des catégories. Ces modèles de couleurs</span>
+<span class="del">     * peuvent être construits à partir des couleurs qui ont été définies dans les différentes</span>
+<span class="del">     * catégories du tableau {@link #categories}.</span>
+     */
+    private static final Map colors = new WeakValueHashMap();</pre></td>
+<td><pre> */
+final class ColorModelFactory {
+    /**
+<span class="add">     * Mod�les de couleurs sugg�r�s pour l'affichage des cat�gories. Ces mod�les de couleurs</span>
+<span class="add">     * peuvent �tre construits � partir des couleurs qui ont �t� d�finies dans les diff�rentes</span>
+<span class="add">     * cat�gories du tableau {@link #categories}.</span>
+     */
+    private static final Map colors = new WeakValueHashMap();</pre></td></tr>
+<tr><td><pre>}
+/*
+ * Calcule le nombre de couleurs de la palette
+<span class="del"> * en cherchant l'index le plus élevé des thèmes.</span>
+ */
+final int mapSize = (int)Math.round(categories[categories.length-1].maximum)+1;
+final int[]  ARGB = new int[mapSize];
+/*
+ * Interpole les codes de couleurs dans la palette. Les couleurs
+<span class="del"> * correspondantes aux plages non-définies par un thème seront transparentes.</span>
+ */
+for (int i=0; i&lt;categories.length; i++) {
+    final Category category = categories[i];</pre></td>
+<td><pre>}
+/*
+ * Calcule le nombre de couleurs de la palette
+<span class="add"> * en cherchant l'index le plus �lev� des th�mes.</span>
+ */
+final int mapSize = (int)Math.round(categories[categories.length-1].maximum)+1;
+final int[]  ARGB = new int[mapSize];
+/*
+ * Interpole les codes de couleurs dans la palette. Les couleurs
+<span class="add"> * correspondantes aux plages non-d�finies par un th�me seront transparentes.</span>
+ */
+for (int i=0; i&lt;categories.length; i++) {
+    final Category category = categories[i];</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10796/ScaledColorSpace.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/ScaledColorSpace.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/10796/ScaledColorSpace.xhtml (added)
+++ sis/ip-review/rev/10796/ScaledColorSpace.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,155 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ScaledColorSpace changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ScaledColorSpace changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite> tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/ScaledColorSpace.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>// J2SE dependencies
+import java.awt.color.ColorSpace;
+
+<span class="del">// Geotools dependencies</span>
+import org.geotools.resources.Utilities;
+
+
+/**
+ * Espace de couleurs pour les images dont les valeurs
+<span class="del"> * de pixels se situent entre deux nombre réels.</span>
+ *
+ * NOTE: Actual implementation is a copy of org.geotools.io.image.ScaledColorSpace.
+ *       Future implementation will be differents (interpolate in a color table</pre></td>
+<td><pre>// J2SE dependencies
+import java.awt.color.ColorSpace;
+
+import org.geotools.resources.Utilities;
+
+
+/**
+ * Espace de couleurs pour les images dont les valeurs
+<span class="add"> * de pixels se situent entre deux nombre r�els.</span>
+ *
+ * NOTE: Actual implementation is a copy of org.geotools.io.image.ScaledColorSpace.
+ *       Future implementation will be differents (interpolate in a color table</pre></td></tr>
+<tr><td><pre>private final float scale;
+
+/**
+<span class="del"> * Nombre à aditionner aux pixels après</span>
+ * les avoir multiplier par {@link #scale}.
+ */
+private final float offset;
+
+/**
+<span class="del"> * Construit un modèle de couleurs.</span>
+ *
+<span class="del"> * @param band La bande à rendre visible (habituellement 0).</span>
+<span class="del"> * @param numComponents Nombre de composante (seule la première sera prise en compte).</span>
+<span class="del"> * @param minimum La valeur géophysique minimale.</span>
+<span class="del"> * @param maximum La valeur géophysique maximale.</span>
+ */
+public ScaledColorSpace(final int band, final int numComponents,
+                        final double minimum, final double maximum)</pre></td>
+<td><pre>private final float scale;
+
+/**
+<span class="add"> * Nombre � aditionner aux pixels apr�s</span>
+ * les avoir multiplier par {@link #scale}.
+ */
+private final float offset;
+
+/**
+<span class="add"> * Construit un mod�le de couleurs.</span>
+ *
+<span class="add"> * @param band La bande � rendre visible (habituellement 0).</span>
+<span class="add"> * @param numComponents Nombre de composante (seule la premi�re sera prise en compte).</span>
+<span class="add"> * @param minimum La valeur g�ophysique minimale.</span>
+<span class="add"> * @param maximum La valeur g�ophysique maximale.</span>
+ */
+public ScaledColorSpace(final int band, final int numComponents,
+                        final double minimum, final double maximum)</pre></td></tr>
+<tr><td><pre>/**
+ * Retourne une couleur RGB en tons de
+<span class="del"> * gris pour le nombre réel spécifié.</span>
+ */
+public float[] toRGB(final float[] values) {
+    float value = (values[band]-offset)/scale;</pre></td>
+<td><pre>/**
+ * Retourne une couleur RGB en tons de
+<span class="add"> * gris pour le nombre r�el sp�cifi�.</span>
+ */
+public float[] toRGB(final float[] values) {
+    float value = (values[band]-offset)/scale;</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Retourne une valeur réelle pour</span>
+<span class="del"> * le ton de gris spécifié.</span>
+ */
+public float[] fromRGB(final float[] RGB) {
+    final float[] values = new float[getNumComponents()];</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Retourne une valeur r�elle pour</span>
+<span class="add"> * le ton de gris sp�cifi�.</span>
+ */
+public float[] fromRGB(final float[] RGB) {
+    final float[] values = new float[getNumComponents()];</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Retourne la valeur minimale autorisée.</span>
+ */
+public float getMinValue(final int component) {
+    return MIN_VALUE*scale + offset;</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Retourne la valeur minimale autoris�e.</span>
+ */
+public float getMinValue(final int component) {
+    return MIN_VALUE*scale + offset;</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Retourne la valeur maximale autorisée.</span>
+ */
+public float getMaxValue(final int component) {
+    return MAX_VALUE*scale + offset;</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Retourne la valeur maximale autoris�e.</span>
+ */
+public float getMaxValue(final int component) {
+    return MAX_VALUE*scale + offset;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10894/ScaledColorSpaceTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10894/ScaledColorSpaceTest.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/10894/ScaledColorSpaceTest.xhtml (added)
+++ sis/ip-review/rev/10894/ScaledColorSpaceTest.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,106 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ScaledColorSpaceTest changes for revisions 6274:10894</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ScaledColorSpaceTest changes for revisions 6274:10894</h1>
+
+      <p>Change in LGPL header is not relevant to SIS. Change in import statements is trivial.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r6274:10894 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/ScaledColorSpaceTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 6274</th><th>Revision 10894</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2002, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2002, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>*     UNITED KINGDOM: James Macgill
+*             mailto:j.macgill@geog.leeds.ac.uk
+*
+<span class="del">*     FRANCE: Surveillance de l'Environnement Assistée par Satellite</span>
+<span class="del">*             Institut de Recherche pour le Développement / US-Espace</span>
+*             mailto:seasnet@teledetection.fr
+*
+*     CANADA: Observatoire du Saint-Laurent</pre></td>
+<td><pre>*     UNITED KINGDOM: James Macgill
+*             mailto:j.macgill@geog.leeds.ac.uk
+*
+<span class="add">*     FRANCE: Surveillance de l'Environnement Assist�e par Satellite</span>
+<span class="add">*             Institut de Recherche pour le D�veloppement / US-Espace</span>
+*             mailto:seasnet@teledetection.fr
+*
+*     CANADA: Observatoire du Saint-Laurent</pre></td></tr>
+<tr><td><pre>package org.geotools.cv;
+
+// J2SE and JAI dependencies
+import java.util.Random;
+<span class="del">import java.awt.image.*;</span>
+<span class="del">import java.awt.*;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.gc.Viewer;</span>
+<span class="del">import org.geotools.resources.XMath;</span>
+<span class="del"></span>
+<span class="del">// JUnit dependencies</span>
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+
+/**
+ * Test the {@link ScaledColorSpace} implementation.
+ * This is a visual test.
+ *
+<span class="del"> * @version $Id: ScaledColorSpaceTest.java,v 1.2 2003/05/13 10:59:53 desruisseaux Exp $</span>
+ * @author Martin Desruisseaux
+ */
+public class ScaledColorSpaceTest extends TestCase {</pre></td>
+<td><pre>package org.geotools.cv;
+
+// J2SE and JAI dependencies
+<span class="add">import java.awt.Transparency;</span>
+<span class="add">import java.awt.image.BufferedImage;</span>
+<span class="add">import java.awt.image.ColorModel;</span>
+<span class="add">import java.awt.image.ComponentColorModel;</span>
+<span class="add">import java.awt.image.DataBuffer;</span>
+<span class="add">import java.awt.image.RenderedImage;</span>
+<span class="add">import java.awt.image.WritableRaster;</span>
+import java.util.Random;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+<span class="add">import org.geotools.gc.Viewer;</span>
+<span class="add">import org.geotools.resources.XMath;</span>
+
+<span class="add"></span>
+/**
+ * Test the {@link ScaledColorSpace} implementation.
+ * This is a visual test.
+ *
+<span class="add"> * @version $Id$</span>
+ * @author Martin Desruisseaux
+ */
+public class ScaledColorSpaceTest extends TestCase {</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20970/ColorModelFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/ColorModelFactory.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/20970/ColorModelFactory.xhtml (added)
+++ sis/ip-review/rev/20970/ColorModelFactory.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,179 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ColorModelFactory changes for revisions 20599:20970</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ColorModelFactory changes for revisions 20599:20970</h1>
+
+      <p>Change in LGPL header does not apply to Apache SIS.
+      Formatting changes are reverted.
+      Definition of variables for array lengths are reverted.
+      Changes in synchronization with <code>synchronized (colors)</code> is kept;
+      this change is wanted.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20599:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/ColorModelFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20599</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+<span class="del">*    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">*    License along with this library; if not, write to the Free Software</span>
+<span class="del">*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+<tr><td><pre> * @return The requested color model, suitable for {@link RenderedImage} objects with values
+ *         in the &lt;code&gt;{@link CategoryList#getRange}&lt;/code&gt; range.
+ */
+<span class="del">public static synchronized ColorModel getColorModel(final Category[] categories,</span>
+                                                    final int type,
+                                                    final int visibleBand,
+                                                    final int numBands)
+{
+    ColorModelFactory key = new ColorModelFactory(categories, type, visibleBand, numBands);
+    ColorModel model = (ColorModel) colors.get(key);
+    if (model == null) {</pre></td>
+<td><pre> * @return The requested color model, suitable for {@link RenderedImage} objects with values
+ *         in the &lt;code&gt;{@link CategoryList#getRange}&lt;/code&gt; range.
+ */
+<span class="add">public static  ColorModel getColorModel(final Category[] categories,</span>
+                                                    final int type,
+                                                    final int visibleBand,
+                                                    final int numBands)
+{
+<span class="add">    synchronized (colors) {</span>
+    ColorModelFactory key = new ColorModelFactory(categories, type, visibleBand, numBands);
+    ColorModel model = (ColorModel) colors.get(key);
+    if (model == null) {</pre></td></tr>
+<tr><td><pre>    }
+    return model;
+}
+
+/**
+ * Construct the color model.
+ */
+private ColorModel getColorModel() {
+<span class="del">    if (type != DataBuffer.TYPE_BYTE &amp;&amp;</span>
+<span class="del">        type != DataBuffer.TYPE_USHORT)</span>
+<span class="del">    {</span>
+<span class="del">        // If the requested type is any type not supported by IndexColorModel,</span>
+        // fallback on a generic (but very slow!) color model.
+        double min = 0;
+        double max = 1;
+<span class="del">        if (categories.length != 0) {</span>
+            min = categories[0].minimum;
+<span class="del">            for (int i=categories.length; --i&gt;=0;) {</span>
+                final double val = categories[i].maximum;
+                if (!Double.isNaN(val)) {
+                    max = val;</pre></td>
+<td><pre>    }
+    return model;
+}
+<span class="add">}</span>
+
+/**
+ * Construct the color model.
+ */
+private ColorModel getColorModel() {
+<span class="add">   final int length = categories.length;</span>
+<span class="add">   if (type != DataBuffer.TYPE_BYTE &amp;&amp; type != DataBuffer.TYPE_USHORT) {</span>
+<span class="add">     // If the requested type is any type not supported by</span>
+<span class="add">     // IndexColorModel,</span>
+        // fallback on a generic (but very slow!) color model.
+        double min = 0;
+        double max = 1;
+<span class="add"></span>
+<span class="add">     if (length != 0) {</span>
+            min = categories[0].minimum;
+<span class="add">      for (int i = length; --i &gt;= 0;) {</span>
+                final double val = categories[i].maximum;
+                if (!Double.isNaN(val)) {
+                    max = val;</pre></td></tr>
+<tr><td><pre>    // with something.
+    return RasterFactory.createComponentColorModel(type, colors, false, false, transparency);
+}
+<span class="del">if (numBands==1 &amp;&amp; categories.length==0) {</span>
+    // Construct a gray scale palette.
+    final ColorSpace cs = ColorSpace.getInstance(ColorSpace.CS_GRAY);
+    final int[] nBits = {DataBuffer.getDataTypeSize(type)};</pre></td>
+<td><pre>     // with something.
+     return RasterFactory.createComponentColorModel(type, colors, false, false, transparency);
+ }
+<span class="add">if (numBands == 1 &amp;&amp; length == 0) {</span>
+     // Construct a gray scale palette.
+     final ColorSpace cs = ColorSpace.getInstance(ColorSpace.CS_GRAY);
+     final int[] nBits = {DataBuffer.getDataTypeSize(type)};</pre></td></tr>
+<tr><td><pre> * Computes the number of entries required for the color palette.
+ * We take the upper range value of the last category.
+ */
+<span class="del">final int mapSize = (int)Math.round(categories[categories.length-1].maximum)+1;</span>
+final int[]  ARGB = new int[mapSize];
+/*
+ * Interpolate the colors in the color palette. Colors that do not fall
+ * in the range of a category will be set to a transparent color.
+ */
+<span class="del">for (int i=0; i&lt;categories.length; i++) {</span>
+    final Category category = categories[i];
+    ColorUtilities.expand(category.getColors(), ARGB,
+                          (int)Math.round(category.minimum),</pre></td>
+<td><pre>  * Computes the number of entries required for the color palette.
+  * We take the upper range value of the last category.
+  */
+<span class="add">final int mapSize = (int) Math.round(categories[length - 1].maximum) + 1;</span>
+ final int[]  ARGB = new int[mapSize];
+ /*
+  * Interpolate the colors in the color palette. Colors that do not fall
+  * in the range of a category will be set to a transparent color.
+  */
+<span class="add">for (int i = 0; i &lt; length; i++) {</span>
+     final Category category = categories[i];
+     ColorUtilities.expand(category.getColors(), ARGB,
+                           (int)Math.round(category.minimum),</pre></td></tr>
+<tr><td><pre> */
+public int hashCode() {
+    int code = 962745549 + (numBands*37 + visibleBand)*37 + categories.length;
+<span class="del">    for (int i=0; i&lt;categories.length; i++) {</span>
+        code += categories[i].hashCode();
+        // Better be independant of categories order.
+    }</pre></td>
+<td><pre> */
+public int hashCode() {
+    int code = 962745549 + (numBands*37 + visibleBand)*37 + categories.length;
+<span class="add">   final int length = categories.length;</span>
+<span class="add">   for (int i = 0; i &lt; length; i++) {</span>
+        code += categories[i].hashCode();
+        // Better be independant of categories order.
+    }</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20970/ScaledColorSpace.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/ScaledColorSpace.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/20970/ScaledColorSpace.xhtml (added)
+++ sis/ip-review/rev/20970/ScaledColorSpace.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ScaledColorSpace changes for revisions 20969:20970</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ScaledColorSpace changes for revisions 20969:20970</h1>
+
+      <p>Change in LGPL header does not apply to Apache SIS.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20969:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/ScaledColorSpace.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20969</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+ */
+package org.geotools.coverage;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.coverage;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20970/ScaledColorSpaceTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/ScaledColorSpaceTest.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/20970/ScaledColorSpaceTest.xhtml (added)
+++ sis/ip-review/rev/20970/ScaledColorSpaceTest.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ScaledColorSpaceTest changes for revisions 20969:20970</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ScaledColorSpaceTest changes for revisions 20969:20970</h1>
+
+      <p>Change in LGPL header does not apply to Apache SIS.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20969:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/ScaledColorSpaceTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20969</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2002, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2002, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+ */
+package org.geotools.coverage;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.coverage;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/24476/ColorModelFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24476/ColorModelFactory.xhtml?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/24476/ColorModelFactory.xhtml (added)
+++ sis/ip-review/rev/24476/ColorModelFactory.xhtml Mon Dec 10 08:50:52 2018
@@ -0,0 +1,49 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ColorModelFactory changes for revisions 24475:24476</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ColorModelFactory changes for revisions 24475:24476</h1>
+<p>TBD</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24475:24476 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/ColorModelFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24475</th><th>Revision 24476</th></tr>
+<tr><td><pre>import org.geotools.resources.i18n.ErrorKeys;
+import org.geotools.resources.image.ColorUtilities;
+import org.geotools.resources.image.ComponentColorModelJAI;
+<span class="del">import org.geotools.util.WeakValueHashMap;</span>
+
+
+/**</pre></td>
+<td><pre>import org.geotools.resources.i18n.ErrorKeys;
+import org.geotools.resources.image.ColorUtilities;
+import org.geotools.resources.image.ComponentColorModelJAI;
+<span class="add">import org.geotools.util.SoftValueHashMap;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre> * peuvent être construits à partir des couleurs qui ont été définies dans les différentes
+ * catégories du tableau {@link #categories}.
+ */
+<span class="del">private static final Map colors = new WeakValueHashMap();</span>
+
+/**
+ * The list of categories for the construction of a single instance of a {@link ColorModel}.</pre></td>
+<td><pre> * peuvent être construits à partir des couleurs qui ont été définies dans les différentes
+ * catégories du tableau {@link #categories}.
+ */
+<span class="add">private static final Map colors = new SoftValueHashMap();</span>
+
+/**
+ * The list of categories for the construction of a single instance of a {@link ColorModel}.</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/24476/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24476/HEADER.html?rev=1848556&view=auto
==============================================================================
--- sis/ip-review/rev/24476/HEADER.html (added)
+++ sis/ip-review/rev/24476/HEADER.html Mon Dec 10 08:50:52 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 24476</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 24476</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>simboss</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-02-16</td></tr>
+  <tr><td><b>Message:</b></td><td>-first bunch of changes for the alignment of trunk with 2.3.x</td></tr>
+</table>
+    </div>
+  </body>
+</html>



Mime
View raw message