sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1847794 [1/2] - in /sis/ip-review: ./ rev/10796/ rev/10874/ rev/10906/ rev/13332/ rev/20970/ rev/24925/ rev/29037/
Date Fri, 30 Nov 2018 09:52:08 GMT
Author: desruisseaux
Date: Fri Nov 30 09:52:08 2018
New Revision: 1847794

URL: http://svn.apache.org/viewvc?rev=1847794&view=rev
Log:
Add IP review for Category, CategoryList and SampleDimension.

Added:
    sis/ip-review/Category.xhtml
    sis/ip-review/CategoryList.xhtml
    sis/ip-review/SampleDimension.xhtml
    sis/ip-review/rev/10796/Category.xhtml
    sis/ip-review/rev/10874/
    sis/ip-review/rev/10874/HEADER.html
    sis/ip-review/rev/10874/SampleDimension.xhtml
    sis/ip-review/rev/10906/
    sis/ip-review/rev/10906/CategoryList.xhtml
    sis/ip-review/rev/10906/HEADER.html
    sis/ip-review/rev/13332/
    sis/ip-review/rev/13332/Category.xhtml
    sis/ip-review/rev/13332/HEADER.html
    sis/ip-review/rev/20970/Category.xhtml
    sis/ip-review/rev/20970/CategoryList.xhtml
    sis/ip-review/rev/20970/SampleDimension.xhtml
    sis/ip-review/rev/24925/CategoryList.xhtml
    sis/ip-review/rev/29037/
    sis/ip-review/rev/29037/HEADER.html
    sis/ip-review/rev/29037/SampleDimension.xhtml

Added: sis/ip-review/Category.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/Category.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/Category.xhtml (added)
+++ sis/ip-review/Category.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,73 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Category history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Category history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/Category.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28852</td><td>2008-01-21</td><td>desruisseaux</td><td>Reverted back "view(ViewType)" methods to "geophysics(boolean)" in Category and GridSampleDimension because views other than "geophysics" and "packed" don't make sense in current design. However those various views still in GridCoverage2D, which can support a richer set including "photographic" because it know about all bands together (as opposite to Category/GridSampleDimension which don't know what the other bands are). Also removed a few deprecated constructors and changed ViewType constants.</td></tr>
+<tr><td class="rev">28846</td><td>2008-01-20</td><td>desruisseaux</td><td>Covariant return type for inverse() method in MathTransform1D and MathTransform2D. Also javadoc fixes and Java 5 type safety. Changed ViewType to an enum and initial implementation of GridCoverageViews (not yet connected to GridCoverage2D).</td></tr>
+<tr><td class="rev">28700</td><td>2008-01-10</td><td>desruisseaux</td><td>Reformating and Java 5 type safety.</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28464</td><td>2007-12-21</td><td>desruisseaux</td><td>First draft of a TileCollection helper class. Not yet tested.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">27500</td><td>2007-10-15</td><td>desruisseaux</td><td>First round of Java 5 generic types applied to org.geotools.resources and org.geotools.util packages. As a side effect, removed the deprecated org.geotools.resources.TestData class (moved to org.geotools.test).</td></tr>
+<tr><td class="rev">26709</td><td>2007-08-27</td><td>desruisseaux</td><td>Merged the unsupported/coverageio work from the 2.4 branch.</td></tr>
+<tr><td class="rev">26593</td><td>2007-08-19</td><td>desruisseaux</td><td>Merged work from the 2.4 branch.</td></tr>
+<tr><td class="rev">22482</td><td>2006-10-31</td><td>desruisseaux</td><td>Fixed svn:ignore property and removed svn:executable.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/Category.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">15803</td><td>2005-09-22</td><td>desruisseaux</td><td>Bux fix in automatic axis swapping during GridCoverage(..., Envelope, ...) construction.</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added convenience methods or constructors</td></tr>
+<tr><td class="rev">15016</td><td>2005-08-02</td><td>desruisseaux</td><td>Coverage bug fix: convenience constructors should create IndexColorModel using the user-specified colors</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">14608</td><td>2005-06-25</td><td>desruisseaux</td><td>EPSG authority factory now uses path informations for ConcatenatedOperation object creations / Added PostgreSQL plugin (mostly as a demo) / Javadoc fixes</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13354</td><td>2005-05-02</td><td>desruisseaux</td><td>First draft of a FactoryFinder for JTS factories</td></tr>
+<tr><td class="rev">13332</td><td>2005-04-29</td><td class="unav">simboss</td><td><a href="rev/13332/Category.xhtml">Solved a simple problem that may arise when trying to specify a geophysic transformation between two ranges composed by a single value. The old way to evaluate scale and offset would have generated an exception for a bad affine transform.</a></td></tr>
+<tr><td class="rev">13129</td><td>2005-04-15</td><td>desruisseaux</td><td>Name change: removed 'GT' suffix in org.geotools.coverage implementations. Some on them were replaced by 'General' prefix for consistency with 'GeneralEnvelope' and 'GeneralDirectPosition'. In this context 'General' means "Can work with an arbitrary number of dimension". Other name changes in org.geotools.referencing and org.geotools.metadata are pending the choice between 'Default' prefix and 'Impl' suffix</td></tr>
+<tr><td class="rev">11738</td><td>2005-03-02</td><td>desruisseaux</td><td>First working version of GridCoverage2D</td></tr>
+<tr><td class="rev">11572</td><td>2005-02-23</td><td>desruisseaux</td><td>Initial port of sub-transform, required for some grid coverages</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10796/Category.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">8521</td><td>2004-10-11</td><td>desruisseaux</td><td>Fixed compilation errors caused by latest CRS commit</td></tr>
+<tr><td class="rev">6375</td><td>2004-06-10</td><td>desruisseaux</td><td>Work on parameters handling</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS implementation</td></tr>
+<tr><td class="rev">6301</td><td>2004-06-03</td><td>desruisseaux</td><td>Refactored basic transform in their own package</td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added more implementations for Coverage support</td></tr>
+<tr><td class="rev">6244</td><td>2004-05-28</td><td>desruisseaux</td><td>Added new GeoAPI implementations / deprecated legacy implementations</td></tr>
+<tr><td class="rev">6238</td><td>2004-05-28</td><td>desruisseaux</td><td>Replaced org.geotools.[...].TransformException by org.opengis.[...].TransformException</td></tr>
+<tr><td class="rev">6210</td><td>2004-05-27</td><td>desruisseaux</td><td>Javadoc fixes / Added Id keyword property</td></tr>
+<tr><td class="rev">6160</td><td>2004-05-25</td><td>desruisseaux</td><td>Initial refactoring of Category</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/CategoryList.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/CategoryList.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/CategoryList.xhtml (added)
+++ sis/ip-review/CategoryList.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,82 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CategoryList history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CategoryList history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/CategoryList.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31549</td><td>2008-09-18</td><td>desruisseaux</td><td>Anticipating GEO-143.</td></tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.</td></tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29356</td><td>2008-02-18</td><td>desruisseaux</td><td>Bug fixes: new working version of TileBuilder.</td></tr>
+<tr><td class="rev">29093</td><td>2008-02-05</td><td>desruisseaux</td><td>First draft of a test suite for ViewsManager in an attempt to understand why our "Piecewise" operation produces different results than what we would expect. Some bug fixes.</td></tr>
+<tr><td class="rev">29052</td><td>2008-02-01</td><td>desruisseaux</td><td>More information in GridCoverage2D.toString(). Attempt to enable "Piecewise" JAI operation when converting from packed to geophysics (not finished). Bug fix in Resampler2D when the only work to do is a Crop.</td></tr>
+<tr><td class="rev">29023</td><td>2008-01-31</td><td>desruisseaux</td><td>GridSampleDimension.toString() now includes the description given at construction time.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28852</td><td>2008-01-21</td><td>desruisseaux</td><td>Reverted back "view(ViewType)" methods to "geophysics(boolean)" in Category and GridSampleDimension because views other than "geophysics" and "packed" don't make sense in current design. However those various views still in GridCoverage2D, which can support a richer set including "photographic" because it know about all bands together (as opposite to Category/GridSampleDimension which don't know what the other bands are). Also removed a few deprecated constructors and changed ViewType constants.</td></tr>
+<tr><td class="rev">28846</td><td>2008-01-20</td><td>desruisseaux</td><td>Covariant return type for inverse() method in MathTransform1D and MathTransform2D. Also javadoc fixes and Java 5 type safety. Changed ViewType to an enum and initial implementation of GridCoverageViews (not yet connected to GridCoverage2D).</td></tr>
+<tr><td class="rev">28821</td><td>2008-01-18</td><td>desruisseaux</td><td>Covariant return type on GridCoverage2D.getSampleDimension(int).</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28464</td><td>2007-12-21</td><td>desruisseaux</td><td>First draft of a TileCollection helper class. Not yet tested.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28198</td><td>2007-11-30</td><td>desruisseaux</td><td>Covariant return type for NumberRange.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25449</td><td>2007-05-07</td><td>desruisseaux</td><td>Reformatted code (especially Resample2D) in a way closer to the way it was at revision 17672. The purpose it to make easier to spot with 'svn diff' the changes applied since that time. Revision 17672 was just before significant work were commited by a new contributor and we would like to compare with original code with less distriction caused by reformatting. This commit should not bring any functionality change.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a href="rev/24925/CategoryList.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">24607</td><td>2007-02-26</td><td>desruisseaux</td><td>Avoid UnformattableObjectException for 'LOCAL_CS' and 'VERT_CS' WKT elements. Try to provides some hints about the cause for the other cases of unformattable WKT.</td></tr>
+<tr><td class="rev">23632</td><td>2006-12-29</td><td>desruisseaux</td><td>GEOT-859: Refactored the URN syntax adapter for CRS factories. The adapter now apply to any factory. Some progress toward version management (but not yet there). NOTE: this new implementation forces axis order "as specified in the database", which is different from the original "URNEPSGAdapter" implementation which used (x,y) order. Various changes in many corners of "org.geotools.referencing.factory" as a side-effect of this work. Minor opportunist javadoc fixes in other modules.</td></tr>
+<tr><td class="rev">22997</td><td>2006-11-26</td><td>desruisseaux</td><td>Replaced the use of some deprecated methods (MonolineFormatter.initGeotools --> Logging.forceMonolineConsoleOutput; Utilities.unexpectedException --> Logging.unexpectedException; GeneralEnvelope.getCoordinateReferenceSystem --> Envelope.getCoordinateReferenceSystem).</td></tr>
+<tr><td class="rev">22817</td><td>2006-11-17</td><td>desruisseaux</td><td>Fixed SVN properties for all Java files.</td></tr>
+<tr><td class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review of coverage branch merge: In 'CategoryList', check for the 'no data' category name only if the geophysics value is some NaN value. Moved XAffineTransform to a public place and added methods for testing axis swapping, as a proposed replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)' (replacement not yet done; waiting for the okay from the mailing list). In GeneralGridGeometry, added methods for returning a math transform relative to some pixel corner instead of pixel center, as a proposed replacement for the 'getTransform(...)' public static methods (I would like to remove those static methods in order to keep the API a little bit more orthogonal).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/CategoryList.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">20600</td><td>2006-07-18</td><td class="unav">simboss</td><td><a href="rev/20970/CategoryList.xhtml">-committing first bunch of changes from the coverage branch. Modules involved are*api *referencing *coverage *main *renderer *shaperenderer</a></td></tr>
+<tr><td class="rev">20167</td><td>2006-06-23</td><td>desruisseaux</td><td>GEOT-873: partial merge of ImageUtilities to trunk. Not yet finished, since I'm refactoring the new code in the process.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">15803</td><td>2005-09-22</td><td>desruisseaux</td><td>Bux fix in automatic axis swapping during GridCoverage(..., Envelope, ...) construction.</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added convenience methods or constructors</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">14608</td><td>2005-06-25</td><td>desruisseaux</td><td>EPSG authority factory now uses path informations for ConcatenatedOperation object creations / Added PostgreSQL plugin (mostly as a demo) / Javadoc fixes</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13129</td><td>2005-04-15</td><td>desruisseaux</td><td>Name change: removed 'GT' suffix in org.geotools.coverage implementations. Some on them were replaced by 'General' prefix for consistency with 'GeneralEnvelope' and 'GeneralDirectPosition'. In this context 'General' means "Can work with an arbitrary number of dimension". Other name changes in org.geotools.referencing and org.geotools.metadata are pending the choice between 'Default' prefix and 'Impl' suffix</td></tr>
+<tr><td class="rev">11738</td><td>2005-03-02</td><td>desruisseaux</td><td>First working version of GridCoverage2D</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10906</td><td>2005-01-31</td><td class="unav">dzwiers</td><td><a href="rev/10906/CategoryList.xhtml">compile errors - maven</a></td></tr>
+<tr><td class="rev">10826</td><td>2005-01-28</td><td class="unav">rgould</td><td><a href="rev/10906/CategoryList.xhtml">Fixed import</a></td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10906/CategoryList.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">10253</td><td>2005-01-05</td><td>desruisseaux</td><td>Fixed compiler error caused by a change in MathTransform API</td></tr>
+<tr><td class="rev">8521</td><td>2004-10-11</td><td>desruisseaux</td><td>Fixed compilation errors caused by latest CRS commit</td></tr>
+<tr><td class="rev">6565</td><td>2004-06-26</td><td>desruisseaux</td><td>First draft of a MapProjection port</td></tr>
+<tr><td class="rev">6538</td><td>2004-06-25</td><td>desruisseaux</td><td>Fixed broken build</td></tr>
+<tr><td class="rev">6375</td><td>2004-06-10</td><td>desruisseaux</td><td>Work on parameters handling</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS implementation</td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added more implementations for Coverage support</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/SampleDimension.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/SampleDimension.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/SampleDimension.xhtml (added)
+++ sis/ip-review/SampleDimension.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,84 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>SampleDimension history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>SampleDimension history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GridSampleDimension.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.</td></tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29356</td><td>2008-02-18</td><td>desruisseaux</td><td>Bug fixes: new working version of TileBuilder.</td></tr>
+<tr><td class="rev">29093</td><td>2008-02-05</td><td>desruisseaux</td><td>First draft of a test suite for ViewsManager in an attempt to understand why our "Piecewise" operation produces different results than what we would expect. Some bug fixes.</td></tr>
+<tr><td class="rev">29052</td><td>2008-02-01</td><td>desruisseaux</td><td>More information in GridCoverage2D.toString(). Attempt to enable "Piecewise" JAI operation when converting from packed to geophysics (not finished). Bug fix in Resampler2D when the only work to do is a Crop.</td></tr>
+<tr><td class="rev">29037</td><td>2008-02-01</td><td class="unav">simboss</td><td><a href="rev/29037/SampleDimension.xhtml">-improving bands creations for simple rasters</a></td></tr>
+<tr><td class="rev">29023</td><td>2008-01-31</td><td>desruisseaux</td><td>GridSampleDimension.toString() now includes the description given at construction time.</td></tr>
+<tr><td class="rev">28951</td><td>2008-01-25</td><td>desruisseaux</td><td>Try harder to reuse existing view in order to reduce the (potentially large) amount of computation done. Note that the build fails in the WFS module, but it seems to be unrelated to this change since WFS do not depends on the coverage module.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28852</td><td>2008-01-21</td><td>desruisseaux</td><td>Reverted back "view(ViewType)" methods to "geophysics(boolean)" in Category and GridSampleDimension because views other than "geophysics" and "packed" don't make sense in current design. However those various views still in GridCoverage2D, which can support a richer set including "photographic" because it know about all bands together (as opposite to Category/GridSampleDimension which don't know what the other bands are). Also removed a few deprecated constructors and changed ViewType constants.</td></tr>
+<tr><td class="rev">28846</td><td>2008-01-20</td><td>desruisseaux</td><td>Covariant return type for inverse() method in MathTransform1D and MathTransform2D. Also javadoc fixes and Java 5 type safety. Changed ViewType to an enum and initial implementation of GridCoverageViews (not yet connected to GridCoverage2D).</td></tr>
+<tr><td class="rev">28779</td><td>2008-01-16</td><td>desruisseaux</td><td>In referencing module, changed the DirectPosition2D.hashCode() and equals(Object) implementation in order to comply with DirectPosition contract, which fix an AssertionError. It has the unfortunate side-effect of violating the Point2D.hashCode() contract. Unfortunatly it is not possible to comply to both in same time. I added a note in javadoc trying to make that clear.In the coverage module, applied the ImageWorker changes mentioned on the mailing list. Also provided a first draft of an ImageWorkerTest. Note that the build still fail in the shapefile-renderer module for a reason that I believe unrelated to those changes. The same changes have already been applied to the 2.4 branch, which build fine.</td></tr>
+<tr><td class="rev">28700</td><td>2008-01-10</td><td>desruisseaux</td><td>Reformating and Java 5 type safety.</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28464</td><td>2007-12-21</td><td>desruisseaux</td><td>First draft of a TileCollection helper class. Not yet tested.</td></tr>
+<tr><td class="rev">28267</td><td>2007-12-06</td><td>desruisseaux</td><td>GeoTools trunk now build against GeoAPI 2.2-SNAPSHOT.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">27500</td><td>2007-10-15</td><td>desruisseaux</td><td>First round of Java 5 generic types applied to org.geotools.resources and org.geotools.util packages. As a side effect, removed the deprecated org.geotools.resources.TestData class (moved to org.geotools.test).</td></tr>
+<tr><td class="rev">23398</td><td>2006-12-12</td><td>desruisseaux</td><td>First step toward a 'GridCoverage2D.view(ViewType)' as an evolution of 'GridCoverage2D.geophysics(boolean)'.</td></tr>
+<tr><td class="rev">23308</td><td>2006-12-07</td><td>desruisseaux</td><td>In Coverage module: added 'throws CoverageProcessingException' clauses. In xml-gml3 module: just reformating performed automatically by 'mvn install', since I tested on the whole Geotools trunk before to commit.</td></tr>
+<tr><td class="rev">22817</td><td>2006-11-17</td><td>desruisseaux</td><td>Fixed SVN properties for all Java files.</td></tr>
+<tr><td class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review of coverage branch merge: In 'CategoryList', check for the 'no data' category name only if the geophysics value is some NaN value. Moved XAffineTransform to a public place and added methods for testing axis swapping, as a proposed replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)' (replacement not yet done; waiting for the okay from the mailing list). In GeneralGridGeometry, added methods for returning a math transform relative to some pixel corner instead of pixel center, as a proposed replacement for the 'getTransform(...)' public static methods (I would like to remove those static methods in order to keep the API a little bit more orthogonal).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">22226</td><td>2006-10-18</td><td>acuster</td><td>Javadoc: purge the @params</td></tr>
+<tr><td class="rev">21855</td><td>2006-10-05</td><td>acuster</td><td>Javadoc lots more cleanup</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/SampleDimension.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">20741</td><td>2006-07-28</td><td class="unav">simboss</td><td><a href="rev/20970/SampleDimension.xhtml">-cleaning up a bit and improving coverages code</a></td></tr>
+<tr><td class="rev">20600</td><td>2006-07-18</td><td class="unav">simboss</td><td><a href="rev/20970/SampleDimension.xhtml">-committing first bunch of changes from the coverage branch. Modules involved are*api *referencing *coverage *main *renderer *shaperenderer</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">15803</td><td>2005-09-22</td><td>desruisseaux</td><td>Bux fix in automatic axis swapping during GridCoverage(..., Envelope, ...) construction.</td></tr>
+<tr><td class="rev">15556</td><td>2005-08-30</td><td>desruisseaux</td><td>Bug fix in 'createTransformedShape' / Clarification in the way a GridCoverage2D convenience constructor handle axis</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">14773</td><td>2005-07-12</td><td>desruisseaux</td><td>Completed ColorRamp / Moved test case for widgets</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13129</td><td>2005-04-15</td><td>desruisseaux</td><td>Name change: removed 'GT' suffix in org.geotools.coverage implementations. Some on them were replaced by 'General' prefix for consistency with 'GeneralEnvelope' and 'GeneralDirectPosition'. In this context 'General' means "Can work with an arbitrary number of dimension". Other name changes in org.geotools.referencing and org.geotools.metadata are pending the choice between 'Default' prefix and 'Impl' suffix</td></tr>
+<tr><td class="rev">11738</td><td>2005-03-02</td><td>desruisseaux</td><td>First working version of GridCoverage2D</td></tr>
+<tr><td class="rev">11722</td><td>2005-03-01</td><td>desruisseaux</td><td>Partial port of GridCoverage2D</td></tr>
+<tr><td class="rev">11698</td><td>2005-02-28</td><td>desruisseaux</td><td>Moved tests from legacy to main module</td></tr>
+<tr><td class="rev">11654</td><td>2005-02-25</td><td>desruisseaux</td><td>GridGeometry work, which includes a first working version of DimensionFilter</td></tr>
+<tr><td class="rev">11572</td><td>2005-02-23</td><td>desruisseaux</td><td>Initial port of sub-transform, required for some grid coverages</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10874</td><td>2005-01-31</td><td class="unav">jgarnett</td><td><a href="rev/10874/SampleDimension.xhtml">Lots in a bit of InternationalString.toString madness, I love International String but consistency is going to kill us.</a></td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10874/SampleDimension.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">8521</td><td>2004-10-11</td><td>desruisseaux</td><td>Fixed compilation errors caused by latest CRS commit</td></tr>
+<tr><td class="rev">6301</td><td>2004-06-03</td><td>desruisseaux</td><td>Refactored basic transform in their own package</td></tr>
+<tr><td class="rev">6295</td><td>2004-06-02</td><td>desruisseaux</td><td>Partial port of GridRange and GridGeometry implementations</td></tr>
+<tr><td class="rev">6265</td><td>2004-05-31</td><td>desruisseaux</td><td>Added an initial Coverage implementation</td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added more implementations for Coverage support</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10796/Category.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/Category.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/10796/Category.xhtml (added)
+++ sis/ip-review/rev/10796/Category.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,132 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Category changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Category changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite> tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite> import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/Category.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>// J2SE dependencies
+import java.awt.Color;
+import java.util.Arrays;
+<span class="del">import java.util.Locale;</span>
+<span class="del">import java.io.Serializable;</span>
+<span class="del">import java.io.ObjectStreamException;</span>
+
+<span class="del">// JAI dependencies</span>
+<span class="del">import javax.media.jai.util.Range;</span>
+<span class="del">import javax.media.jai.operator.PiecewiseDescriptor; // For Javadoc</span>
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.util.InternationalString;</span>
+<span class="del">import org.opengis.referencing.operation.MathTransform; // For Javadoc</span>
+<span class="del">import org.opengis.referencing.operation.MathTransform1D;</span>
+<span class="del">import org.opengis.referencing.operation.TransformException;</span>
+<span class="del">import org.opengis.referencing.operation.MathTransformFactory;</span>
+<span class="del"></span>
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.util.NumberRange;</span>
+<span class="del">import org.geotools.util.WeakHashSet;</span>
+import org.geotools.referencing.operation.transform.LinearTransform1D;
+<span class="del"></span>
+<span class="del">// Resources</span>
+import org.geotools.resources.XMath;
+<span class="del">import org.geotools.resources.Utilities;</span>
+import org.geotools.resources.gcs.Resources;
+<span class="del">import org.geotools.resources.gcs.ResourceKeys;</span>
+
+
+/**</pre></td>
+<td><pre>// J2SE dependencies
+import java.awt.Color;
+<span class="add">import java.io.ObjectStreamException;</span>
+<span class="add">import java.io.Serializable;</span>
+import java.util.Arrays;
+
+<span class="add">import javax.media.jai.operator.PiecewiseDescriptor;</span>
+
+import org.geotools.referencing.operation.transform.LinearTransform1D;
+<span class="add">import org.geotools.resources.Utilities;</span>
+import org.geotools.resources.XMath;
+<span class="add">import org.geotools.resources.gcs.ResourceKeys;</span>
+import org.geotools.resources.gcs.Resources;
+<span class="add">import org.geotools.util.NumberRange;</span>
+<span class="add">import org.geotools.util.WeakHashSet;</span>
+<span class="add">import org.opengis.referencing.operation.MathTransform;</span>
+<span class="add">import org.opengis.referencing.operation.MathTransform1D;</span>
+<span class="add">import org.opengis.referencing.operation.MathTransformFactory;</span>
+<span class="add">import org.opengis.referencing.operation.TransformException;</span>
+<span class="add">import org.opengis.util.InternationalString;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre>*
+* Some image mixes both qualitative and quantitative categories. For example,
+* images of Sea Surface Temperature  (SST)  may have a quantitative category
+<span class="del">* for temperature with values ranging from –2 to 35°C,  and three qualitative</span>
+* categories for cloud, land and ice.
+* &lt;br&gt;&lt;br&gt;
+* All categories must have a human readable name. In addition, quantitative</pre></td>
+<td><pre>*
+* Some image mixes both qualitative and quantitative categories. For example,
+* images of Sea Surface Temperature  (SST)  may have a quantitative category
+<span class="add">* for temperature with values ranging from �2 to 35�C,  and three qualitative</span>
+* categories for cloud, land and ice.
+* &lt;br&gt;&lt;br&gt;
+* All categories must have a human readable name. In addition, quantitative</pre></td></tr>
+<tr><td><pre>final Category inverse;
+
+/**
+<span class="del"> * Codes ARGB des couleurs de la catégorie. Les couleurs par</span>
+<span class="del"> * défaut seront un gradient allant du noir au blanc opaque.</span>
+ */
+private final int[] ARGB;
+
+/**
+<span class="del"> * Codes ARGB par défaut. On utilise un exemplaire unique</span>
+<span class="del"> * pour toutes les création d'objets {@link Category}.</span>
+ */
+private static final int[] DEFAULT = {0xFF000000, 0xFFFFFFFF};</pre></td>
+<td><pre>final Category inverse;
+
+/**
+<span class="add"> * Codes ARGB des couleurs de la cat�gorie. Les couleurs par</span>
+<span class="add"> * d�faut seront un gradient allant du noir au blanc opaque.</span>
+ */
+private final int[] ARGB;
+
+/**
+<span class="add"> * Codes ARGB par d�faut. On utilise un exemplaire unique</span>
+<span class="add"> * pour toutes les cr�ation d'objets {@link Category}.</span>
+ */
+private static final int[] DEFAULT = {0xFF000000, 0xFFFFFFFF};</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10874/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10874/HEADER.html?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/10874/HEADER.html (added)
+++ sis/ip-review/rev/10874/HEADER.html Fri Nov 30 09:52:08 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 10874</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 10874</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-01-31</td></tr>
+  <tr><td><b>Message:</b></td><td>Lots in a bit of InternationalString.toString madness, I love International String but consistency is going to kill us.</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10874/SampleDimension.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10874/SampleDimension.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/10874/SampleDimension.xhtml (added)
+++ sis/ip-review/rev/10874/SampleDimension.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,233 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>SampleDimension changes for revisions 10795:10874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>SampleDimension changes for revisions 10795:10874</h1>
+
+      <p>Code modified by this commit has changed again. The <code>InternationalString</code> arguments
+        have been replaced by <code>CharSequence</code> arguments, and the handling of them modified.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10874 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/GridSampleDimension.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10874</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>// J2SE dependencies
+import java.awt.Color;
+<span class="del">import java.util.List;</span>
+<span class="del">import java.util.Locale;</span>
+<span class="del">import java.util.Arrays;</span>
+<span class="del">import java.util.ArrayList;</span>
+<span class="del">import java.io.Serializable;</span>
+import java.awt.color.ColorSpace;
+import java.awt.image.ColorModel;
+import java.awt.image.DataBuffer;
+import java.awt.image.SampleModel;
+<span class="del">import java.awt.image.RenderedImage;   // For Javadoc</span>
+<span class="del">import java.awt.image.IndexColorModel;</span>
+
+<span class="del">// J2SE extensions</span>
+<span class="del">import javax.units.Unit;</span>
+import javax.media.jai.JAI;
+import javax.media.jai.util.Range;
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.util.InternationalString;</span>
+<span class="del">import org.opengis.coverage.SampleDimensionType;</span>
+import org.opengis.coverage.ColorInterpretation;
+import org.opengis.coverage.PaletteInterpretation;
+<span class="del">import org.opengis.coverage.MetadataNameNotFoundException;</span>
+import org.opengis.referencing.operation.MathTransform1D;
+import org.opengis.referencing.operation.TransformException;
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.util.SimpleInternationalString;</span>
+<span class="del">import org.geotools.util.NumberRange;</span>
+<span class="del">import org.geotools.resources.XMath;</span>
+<span class="del">import org.geotools.resources.XArray;</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.ClassChanger;</span>
+<span class="del">import org.geotools.resources.gcs.Resources;</span>
+<span class="del">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="del">import org.geotools.resources.image.ColorUtilities;</span>
+<span class="del">import org.geotools.referencing.operation.transform.LinearTransform1D;</span>
+
+<span class="del"></span>
+/**
+ * Describes the data values for a coverage. For a grid coverage a sample dimension is a band.
+ * Sample values in a band may be organized in categories.  This &lt;code&gt;SampleDimension&lt;/code&gt;</pre></td>
+<td><pre>// J2SE dependencies
+import java.awt.Color;
+import java.awt.color.ColorSpace;
+import java.awt.image.ColorModel;
+import java.awt.image.DataBuffer;
+<span class="add">import java.awt.image.IndexColorModel;</span>
+<span class="add">import java.awt.image.RenderedImage;</span>
+import java.awt.image.SampleModel;
+<span class="add">import java.io.Serializable;</span>
+<span class="add">import java.util.ArrayList;</span>
+<span class="add">import java.util.Arrays;</span>
+<span class="add">import java.util.List;</span>
+<span class="add">import java.util.Locale;</span>
+
+import javax.media.jai.JAI;
+import javax.media.jai.util.Range;
+<span class="add">import javax.units.Unit;</span>
+
+<span class="add">import org.geotools.referencing.operation.transform.LinearTransform1D;</span>
+<span class="add">import org.geotools.resources.ClassChanger;</span>
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.XArray;</span>
+<span class="add">import org.geotools.resources.XMath;</span>
+<span class="add">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.gcs.Resources;</span>
+<span class="add">import org.geotools.resources.image.ColorUtilities;</span>
+<span class="add">import org.geotools.util.NumberRange;</span>
+<span class="add">import org.geotools.util.SimpleInternationalString;</span>
+import org.opengis.coverage.ColorInterpretation;
+<span class="add">import org.opengis.coverage.MetadataNameNotFoundException;</span>
+import org.opengis.coverage.PaletteInterpretation;
+<span class="add">import org.opengis.coverage.SampleDimensionType;</span>
+import org.opengis.referencing.operation.MathTransform1D;
+import org.opengis.referencing.operation.TransformException;
+<span class="add">import org.opengis.util.InternationalString;</span>
+
+
+/**
+ * Describes the data values for a coverage. For a grid coverage a sample dimension is a band.
+ * Sample values in a band may be organized in categories.  This &lt;code&gt;SampleDimension&lt;/code&gt;</pre></td></tr>
+<tr><td><pre> *
+ * @throws IllegalArgumentException if the range &lt;code&gt;[minimum..maximum]&lt;/code&gt; is not valid.
+ */
+<span class="del">public SampleDimension(final String description,</span>
+                       SampleDimensionType type,
+                       ColorInterpretation color,
+                       final Color [] palette,
+<span class="del">                       final String[] categories,</span>
+                       final double[] nodata,
+                             double   minimum,
+                             double   maximum,</pre></td>
+<td><pre> *
+ * @throws IllegalArgumentException if the range &lt;code&gt;[minimum..maximum]&lt;/code&gt; is not valid.
+ */
+<span class="add">public SampleDimension(final InternationalString description,</span>
+                       SampleDimensionType type,
+                       ColorInterpretation color,
+                       final Color [] palette,
+<span class="add">                       final InternationalString[] categories,</span>
+                       final double[] nodata,
+                             double   minimum,
+                             double   maximum,</pre></td></tr>
+<tr><td><pre>}
+
+/** Constructs a list of categories. Used by constructors only. */
+<span class="del">private static CategoryList list(final String description,</span>
+                                 SampleDimensionType type,
+                                 ColorInterpretation color,
+                                 final Color [] palette,
+<span class="del">                                 final String[] categories,</span>
+                                 final double[] nodata,
+                                       double   minimum,
+                                       double   maximum,</pre></td>
+<td><pre>}
+
+/** Constructs a list of categories. Used by constructors only. */
+<span class="add">private static CategoryList list(final InternationalString description,</span>
+                                 SampleDimensionType type,
+                                 ColorInterpretation color,
+                                 final Color [] palette,
+<span class="add">                                 final InternationalString[] categories,</span>
+                                 final double[] nodata,
+                                       double   minimum,
+                                       double   maximum,</pre></td></tr>
+<tr><td><pre>        // This category will be added in step 2 below.
+        continue;
+    }
+<span class="del">    name = categories[intValue];</span>
+}
+final Number value = wrapSample(padValue, type, false);
+if (name == null) {</pre></td>
+<td><pre>        // This category will be added in step 2 below.
+        continue;
+    }
+<span class="add">    name = categories[intValue].toString();</span>
+}
+final Number value = wrapSample(padValue, type, false);
+if (name == null) {</pre></td></tr>
+<tr><td><pre>if (nameCount != 0) {
+    int lower = 0;
+    for (int upper=1; upper&lt;=categories.length; upper++) {
+<span class="del">        final String name = categories[lower].trim();</span>
+<span class="del">        if (upper!=categories.length &amp;&amp; name.equalsIgnoreCase(categories[upper].trim())) {</span>
+            // If there is a suite of categories with identical name,  create only one
+            // category with range [lower..upper] instead of one new category for each
+            // sample value.</pre></td>
+<td><pre>if (nameCount != 0) {
+    int lower = 0;
+    for (int upper=1; upper&lt;=categories.length; upper++) {
+<span class="add">        final String name = categories[lower].toString().trim();</span>
+<span class="add">        if (upper!=categories.length &amp;&amp; name.equalsIgnoreCase(categories[upper].toString().trim())) {</span>
+            // If there is a suite of categories with identical name,  create only one
+            // category with range [lower..upper] instead of one new category for each
+            // sample value.</pre></td></tr>
+<tr><td><pre>                                         (int)Math.ceil (minimum),
+                                         (int)Math.floor(maximum));
+    categoryList.add(new Category(
+<span class="del">        new SimpleInternationalString(description!=null ? description : "(automatic)"),</span>
+        colors, range, scale, offset));
+    needQuantitative = false;
+}</pre></td>
+<td><pre>                                         (int)Math.ceil (minimum),
+                                         (int)Math.floor(maximum));
+    categoryList.add(new Category(
+<span class="add">        description!=null ? description : new SimpleInternationalString("(automatic)"),</span>
+        colors, range, scale, offset));
+    needQuantitative = false;
+}</pre></td></tr>
+<tr><td><pre>} else {
+    colors = null;
+}
+<span class="del">final Locale locale = Locale.getDefault();</span>
+<span class="del">return new SampleDimension(sd.getDescription(locale),</span>
+                           sd.getSampleDimensionType(),
+                           sd.getColorInterpretation(),
+                           colors,
+<span class="del">                           sd.getCategoryNames(locale),</span>
+                           sd.getNoDataValues(),
+                           sd.getMinimumValue(),
+                           sd.getMaximumValue(),</pre></td>
+<td><pre>} else {
+    colors = null;
+}
+<span class="add">return new SampleDimension(sd.getDescription(),</span>
+                           sd.getSampleDimensionType(),
+                           sd.getColorInterpretation(),
+                           colors,
+<span class="add">                           sd.getCategoryNames(),</span>
+                           sd.getNoDataValues(),
+                           sd.getMinimumValue(),
+                           sd.getMaximumValue(),</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10906/CategoryList.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10906/CategoryList.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/10906/CategoryList.xhtml (added)
+++ sis/ip-review/rev/10906/CategoryList.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,204 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CategoryList changes for revisions 10795:10906</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CategoryList changes for revisions 10795:10906</h1>
+<p>This is only a change of import order and a change of file encoding. Those changes have been reverted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10906 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/CategoryList.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10906</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.coverage;
+
+// J2SE dependencies
+<span class="del">import java.util.Arrays;</span>
+<span class="del">import java.util.Locale;</span>
+<span class="del">import java.util.Comparator;</span>
+<span class="del">import java.util.AbstractList;</span>
+import java.awt.image.ColorModel;
+import java.awt.image.DataBuffer;
+import java.awt.image.RasterFormatException;
+import java.io.IOException;
+<span class="del">import java.io.Serializable;</span>
+import java.io.ObjectInputStream;
+import java.io.ObjectStreamException;
+
+<span class="del">// J2SE Extensions</span>
+import javax.units.Unit;
+<span class="del">import javax.media.jai.iterator.WritableRectIter;</span>
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.referencing.operation.Matrix;</span>
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform1D;
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.spatialschema.geometry.DirectPosition;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.util.NumberRange;</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.gcs.Resources;</span>
+<span class="del">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="del">import org.geotools.geometry.GeneralDirectPosition;</span>
+<span class="del">import org.geotools.referencing.operation.GeneralMatrix;</span>
+<span class="del">import org.geotools.referencing.wkt.UnformattableObjectException;</span>
+
+<span class="del"></span>
+/**
+ * An immutable list of categories. Categories are sorted by their sample values.
+ * Overlapping ranges of sample values are not allowed. A &lt;code&gt;CategoryList&lt;/code&gt; can</pre></td>
+<td><pre>package org.geotools.coverage;
+
+// J2SE dependencies
+import java.awt.image.ColorModel;
+import java.awt.image.DataBuffer;
+import java.awt.image.RasterFormatException;
+<span class="add">import java.awt.image.RenderedImage;</span>
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectStreamException;
+<span class="add">import java.io.Serializable;</span>
+<span class="add">import java.util.AbstractList;</span>
+<span class="add">import java.util.Arrays;</span>
+<span class="add">import java.util.Comparator;</span>
+<span class="add">import java.util.Locale;</span>
+
+<span class="add">import javax.media.jai.iterator.WritableRectIter;</span>
+import javax.units.Unit;
+
+<span class="add">import org.geotools.geometry.GeneralDirectPosition;</span>
+<span class="add">import org.geotools.referencing.operation.GeneralMatrix;</span>
+<span class="add">import org.geotools.referencing.wkt.UnformattableObjectException;</span>
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.gcs.Resources;</span>
+<span class="add">import org.geotools.util.NumberRange;</span>
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform1D;
+<span class="add">import org.opengis.referencing.operation.Matrix;</span>
+import org.opengis.referencing.operation.TransformException;
+import org.opengis.spatialschema.geometry.DirectPosition;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+
+/**
+ * An immutable list of categories. Categories are sorted by their sample values.
+ * Overlapping ranges of sample values are not allowed. A &lt;code&gt;CategoryList&lt;/code&gt; can</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Compare deux valeurs de type &lt;code&gt;double&lt;/code&gt;. Cette méthode</span>
+<span class="del"> * est similaire à {@link Double#compare(double,double)}, excepté</span>
+<span class="del"> * qu'elle ordonne aussi les différentes valeurs NaN.</span>
+ */
+private static int compare(final double v1, final double v2) {
+    if (Double.isNaN(v1) &amp;&amp; Double.isNaN(v2)) {</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Compare deux valeurs de type &lt;code&gt;double&lt;/code&gt;. Cette m�thode</span>
+<span class="add"> * est similaire � {@link Double#compare(double,double)}, except�</span>
+<span class="add"> * qu'elle ordonne aussi les diff�rentes valeurs NaN.</span>
+ */
+private static int compare(final double v1, final double v2) {
+    if (Double.isNaN(v1) &amp;&amp; Double.isNaN(v2)) {</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Vérifie si le tableau de catégories spécifié est bien en ordre croissant.</span>
+ * La comparaison ne tient pas compte des valeurs &lt;code&gt;NaN&lt;/code&gt;. Cette
+<span class="del"> * méthode n'est utilisée que pour les &lt;code&gt;assert&lt;/code&gt;.</span>
+ */
+static boolean isSorted(final Category[] categories) {
+    for (int i=1; i&lt;categories.length; i++) {</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * V�rifie si le tableau de cat�gories sp�cifi� est bien en ordre croissant.</span>
+ * La comparaison ne tient pas compte des valeurs &lt;code&gt;NaN&lt;/code&gt;. Cette
+<span class="add"> * m�thode n'est utilis�e que pour les &lt;code&gt;assert&lt;/code&gt;.</span>
+ */
+static boolean isSorted(final Category[] categories) {
+    for (int i=1; i&lt;categories.length; i++) {</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Effectue une recherche bi-linéaire de la valeur spécifiée. Cette</span>
+<span class="del"> * méthode est semblable à {@link Arrays#binarySearch(double[],double)},</span>
+<span class="del"> * excepté qu'elle peut distinguer différentes valeurs de NaN.</span>
+ *
+ * Note: This method is not private in order to allows testing by {@link CategoryTest}.
+ */</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Effectue une recherche bi-lin�aire de la valeur sp�cifi�e. Cette</span>
+<span class="add"> * m�thode est semblable � {@link Arrays#binarySearch(double[],double)},</span>
+<span class="add"> * except� qu'elle peut distinguer diff�rentes valeurs de NaN.</span>
+ *
+ * Note: This method is not private in order to allows testing by {@link CategoryTest}.
+ */</pre></td></tr>
+<tr><td><pre> */
+public final Category getCategory(final double sample) {
+    /*
+<span class="del">     * Recherche à quelle catégorie pourrait appartenir la valeur.</span>
+<span class="del">     * Note: Les valeurs 'NaN' sont à la fin du tableau 'values'. Donc:</span>
+     *
+<span class="del">     * 1) Si 'value' est NaN,  alors 'i' pointera forcément sur une catégorie NaN.</span>
+<span class="del">     * 2) Si 'value' est réel, alors 'i' peut pointer sur une des catégories de</span>
+<span class="del">     *    valeurs réels ou sur la première catégorie de NaN.</span>
+     */
+    int i = binarySearch(minimums, sample); // Special 'binarySearch' for NaN
+    if (i &gt;= 0) {</pre></td>
+<td><pre> */
+public final Category getCategory(final double sample) {
+    /*
+<span class="add">     * Recherche � quelle cat�gorie pourrait appartenir la valeur.</span>
+<span class="add">     * Note: Les valeurs 'NaN' sont � la fin du tableau 'values'. Donc:</span>
+     *
+<span class="add">     * 1) Si 'value' est NaN,  alors 'i' pointera forc�ment sur une cat�gorie NaN.</span>
+<span class="add">     * 2) Si 'value' est r�el, alors 'i' peut pointer sur une des cat�gories de</span>
+<span class="add">     *    valeurs r�els ou sur la premi�re cat�gorie de NaN.</span>
+     */
+    int i = binarySearch(minimums, sample); // Special 'binarySearch' for NaN
+    if (i &gt;= 0) {</pre></td></tr>
+<tr><td><pre>}
+buffer.append(lineSeparator);
+/*
+<span class="del"> * Ecrit la liste des catégories en dessous.</span>
+ */
+for (int i=0; i&lt;categories.length; i++) {
+    buffer.append("   ");</pre></td>
+<td><pre>}
+buffer.append(lineSeparator);
+/*
+<span class="add"> * Ecrit la liste des cat�gories en dessous.</span>
+ */
+for (int i=0; i&lt;categories.length; i++) {
+    buffer.append("   ");</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10906/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10906/HEADER.html?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/10906/HEADER.html (added)
+++ sis/ip-review/rev/10906/HEADER.html Fri Nov 30 09:52:08 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 10906</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 10906</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>dzwiers</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-01-31</td></tr>
+  <tr><td><b>Message:</b></td><td>compile errors - maven</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/13332/Category.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/13332/Category.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/13332/Category.xhtml (added)
+++ sis/ip-review/rev/13332/Category.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,42 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Category changes for revisions 13331:13332</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Category changes for revisions 13331:13332</h1>
+
+<p>This commit is not accepted: NaN values can not be replaced by 1.
+  The correct behavior is to state that the scale is unknown or that there is no scale.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r13331:13332 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/Category.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 13331</th><th>Revision 13332</th></tr>
+<tr><td><pre>    final double maxSample = doubleValue(sType,     sampleValueRange.getMaxValue(), sMaxInc);
+    final double minValue  = doubleValue(gType, geophysicsValueRange.getMinValue(), gMinInc);
+    final double maxValue  = doubleValue(gType, geophysicsValueRange.getMaxValue(), gMaxInc);
+<span class="del">    final double scale     = (maxValue-minValue) / (maxSample-minSample);</span>
+    final double offset    = minValue - scale*minSample;
+    return createLinearTransform(scale, offset);
+}</pre></td>
+<td><pre>    final double maxSample = doubleValue(sType,     sampleValueRange.getMaxValue(), sMaxInc);
+    final double minValue  = doubleValue(gType, geophysicsValueRange.getMinValue(), gMinInc);
+    final double maxValue  = doubleValue(gType, geophysicsValueRange.getMaxValue(), gMaxInc);
+<span class="add">    double scale     = (maxValue-minValue) / (maxSample-minSample);</span>
+<span class="add">  if(Double.isNaN(scale)&amp;&amp;</span>
+<span class="add">   !Double.isNaN(maxValue-minValue)&amp;&amp;</span>
+<span class="add">   !Double.isNaN(maxSample-minSample))</span>
+<span class="add">     scale=1.0;</span>
+    final double offset    = minValue - scale*minSample;
+    return createLinearTransform(scale, offset);
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/13332/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/13332/HEADER.html?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/13332/HEADER.html (added)
+++ sis/ip-review/rev/13332/HEADER.html Fri Nov 30 09:52:08 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 13332</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 13332</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>simboss</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-04-29</td></tr>
+  <tr><td><b>Message:</b></td><td>Solved a simple problem that may arise when trying to specify a geophysic transformation between two ranges composed by a single value. The old way to evaluate scale and offset would have generated an exception for a bad affine transform.</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20970/Category.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/Category.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/20970/Category.xhtml (added)
+++ sis/ip-review/rev/20970/Category.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,52 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Category changes for revisions 20969:20970</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>Category changes for revisions 20969:20970</h1>
+      <p>Change irrelevant to Apache SIS.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20969:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/Category.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20969</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+<span class="del">*    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">*    License along with this library; if not, write to the Free Software</span>
+<span class="del">*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20970/CategoryList.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/CategoryList.xhtml?rev=1847794&view=auto
==============================================================================
--- sis/ip-review/rev/20970/CategoryList.xhtml (added)
+++ sis/ip-review/rev/20970/CategoryList.xhtml Fri Nov 30 09:52:08 2018
@@ -0,0 +1,159 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CategoryList changes for revisions 20599:20970</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CategoryList changes for revisions 20599:20970</h1>
+      <p>All changes in this commit are discarded:</p>
+      <ul>
+        <li>Change in LGPL header is irrelevant to Apache SIS.</li>
+        <li>Replacement of <code>array.length</code> by a variable in loop condition are not retained.</li>
+        <li>Special check for "No data" name is not accepted.</li>
+      </ul>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20599:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/CategoryList.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20599</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+<span class="del">*    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">*    License along with this library; if not, write to the Free Software</span>
+<span class="del">*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+<tr><td><pre>final boolean isGeophysics = (this instanceof GeophysicsCategoryList);
+assert (inverse != null) == isGeophysics;
+this.categories = categories = (Category[]) categories.clone();
+<span class="del">for (int i=0; i&lt;categories.length; i++) {</span>
+    categories[i] = categories[i].geophysics(isGeophysics);
+}
+Arrays.sort(categories, this);</pre></td>
+<td><pre>final boolean isGeophysics = (this instanceof GeophysicsCategoryList);
+assert (inverse != null) == isGeophysics;
+this.categories = categories = (Category[]) categories.clone();
+<span class="add">final int categoriesLength=categories.length;</span>
+<span class="add">for (int i=0; i&lt;categoriesLength; i++) {</span>
+    categories[i] = categories[i].geophysics(isGeophysics);
+}
+Arrays.sort(categories, this);</pre></td></tr>
+<tr><td><pre>    range1.getMinValue(), range1.getMaxValue(),
+    range2.getMinValue(), range2.getMaxValue()
+};
+<span class="del">for (int j=0; j&lt;args.length; j++) {</span>
+    if (args[j] instanceof Number) {
+        final float value = ((Number) args[j]).floatValue();
+        if (Float.isNaN(value)) {</pre></td>
+<td><pre>    range1.getMinValue(), range1.getMaxValue(),
+    range2.getMinValue(), range2.getMaxValue()
+};
+<span class="add">final int argsLength=args.length;</span>
+<span class="add">for (int j=0; j&lt;argsLength; j++) {</span>
+    if (args[j] instanceof Number) {
+        final float value = ((Number) args[j]).floatValue();
+        if (Float.isNaN(value)) {</pre></td></tr>
+<tr><td><pre> */
+Category nodata = Category.NODATA;
+final long nodataBits = Double.doubleToRawLongBits(Double.NaN);
+<span class="del">for (int i=categories.length; --i&gt;=0;) {</span>
+    final Category candidate = categories[i];
+    final double value = candidate.geophysics(true).minimum;
+    if (Double.isNaN(value)) {
+        nodata = candidate;</pre></td>
+<td><pre> */
+Category nodata = Category.NODATA;
+final long nodataBits = Double.doubleToRawLongBits(Double.NaN);
+<span class="add">for (int i=categoriesLength; --i&gt;=0;) {</span>
+    final Category candidate = categories[i];
+<span class="add">    ////////</span>
+<span class="add">    //</span>
+<span class="add">    //</span>
+<span class="add">    final String candidateName=candidate.getName().toString().trim();</span>
+<span class="add">    final String noDataName=Vocabulary.formatInternational(VocabularyKeys.NODATA).toString().trim();</span>
+<span class="add">    if(candidateName.equalsIgnoreCase(noDataName)){</span>
+<span class="add">        nodata = candidate;</span>
+<span class="add">        break;</span>
+<span class="add">    }</span>
+<span class="add"></span>
+<span class="add">    //</span>
+<span class="add">    //</span>
+<span class="add">    ////////</span>
+    final double value = candidate.geophysics(true).minimum;
+    if (Double.isNaN(value)) {
+        nodata = candidate;</pre></td></tr>
+<tr><td><pre> */
+double range = 0;
+Category main = null;
+<span class="del">for (int i=categories.length; --i&gt;=0;) {</span>
+    final Category candidate = categories[i];
+    if (candidate.isQuantitative()) {
+        final Category candidatePeer = candidate.geophysics(false);
+        final double candidateRange = candidatePeer.maximum - candidatePeer.minimum;</pre></td>
+<td><pre> */
+double range = 0;
+Category main = null;
+<span class="add">for (int i=categoriesLength; --i&gt;=0;) {</span>
+    final Category candidate = categories[i];
+<span class="add">    ////////</span>
+<span class="add">    //</span>
+<span class="add">    //</span>
+<span class="add">    final String candidateName=candidate.getName().toString().trim();</span>
+<span class="add">    final String noDataName=Vocabulary.formatInternational(VocabularyKeys.NODATA).toString().trim();</span>
+<span class="add">    if(candidateName.equalsIgnoreCase(noDataName)){</span>
+<span class="add">        nodata = candidate;</span>
+<span class="add">        continue;</span>
+<span class="add">    }</span>
+<span class="add"></span>
+<span class="add">    //</span>
+<span class="add">    //</span>
+<span class="add">    ////////</span>
+    if (candidate.isQuantitative()) {
+        final Category candidatePeer = candidate.geophysics(false);
+        final double candidateRange = candidatePeer.maximum - candidatePeer.minimum;</pre></td></tr>
+<tr><td><pre> */
+Category overflowFallback = null;
+if (searchNearest) {
+<span class="del">    for (int i=categories.length; --i&gt;=0;) {</span>
+        final Category category = categories[i];
+        if (!Double.isNaN(category.maximum)) {
+            overflowFallback = category;</pre></td>
+<td><pre> */
+Category overflowFallback = null;
+if (searchNearest) {
+<span class="add">    for (int i=categoriesLength; --i&gt;=0;) {</span>
+        final Category category = categories[i];
+        if (!Double.isNaN(category.maximum)) {
+            overflowFallback = category;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>



Mime
View raw message