sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject [sis] 05/15: Fix the comment about test accuracy.
Date Thu, 21 Jun 2018 09:19:45 GMT
This is an automated email from the ASF dual-hosted git repository.

desruisseaux pushed a commit to tag 0.8
in repository https://gitbox.apache.org/repos/asf/sis.git

commit 666e574755d880cf76c73d872da988a0d2c0583b
Author: Martin Desruisseaux <desruisseaux@apache.org>
AuthorDate: Tue Oct 31 11:07:05 2017 +0000

    Fix the comment about test accuracy.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/sis/branches/0.8@1813873 13f79535-47bb-0310-9956-ffa450edef68
---
 .../operation/DefaultCoordinateOperationFactoryTest.java     | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/core/sis-referencing/src/test/java/org/apache/sis/referencing/operation/DefaultCoordinateOperationFactoryTest.java
b/core/sis-referencing/src/test/java/org/apache/sis/referencing/operation/DefaultCoordinateOperationFactoryTest.java
index 6c24d96..ec1f784 100644
--- a/core/sis-referencing/src/test/java/org/apache/sis/referencing/operation/DefaultCoordinateOperationFactoryTest.java
+++ b/core/sis-referencing/src/test/java/org/apache/sis/referencing/operation/DefaultCoordinateOperationFactoryTest.java
@@ -169,16 +169,18 @@ public final strictfp class DefaultCoordinateOperationFactoryTest extends
MathTr
         assertSame      ("targetCRS", targetCRS, operation.getTargetCRS());
         assertInstanceOf("operation", ConcatenatedOperation.class, operation);
         /*
-         * The accuracy of the coordinate operation depends on whether a path as been found
with the help
+         * The accuracy of the coordinate operation depends on whether a path has been found
with the help
          * of the EPSG database (in which case the reported accuracy is 2 metres) or if we
had to find an
-         * operation by ourselves (in which case we conservatively report an accuracy of
3000 metres, bu
-         * in practice observe an error of about 80 metres for this test).
+         * operation by ourselves (in which case we conservatively report an accuracy of
3000 metres, but
+         * in practice observe an error between 80 and 515 metres for this test depending
on the operation
+         * method used). By comparison, the translation declared in EPSG database is about
370 metres in
+         * geocentric coordinates.
          */
         final boolean isUsingEpsgFactory = verifyParametersNTF(((ConcatenatedOperation) operation).getOperations(),
1);
         assertEquals("linearAccuracy", isUsingEpsgFactory ? 2 : PositionalAccuracyConstant.UNKNOWN_ACCURACY,
                                        CRS.getLinearAccuracy(operation), STRICT);
 
-        tolerance = isUsingEpsgFactory ? Formulas.LINEAR_TOLERANCE : 1000;
+        tolerance = isUsingEpsgFactory ? Formulas.LINEAR_TOLERANCE : 600;
         transform = operation.getMathTransform();
         /*
          * Test using the location of Paris (48.856578°N, 2.351828°E) first,
@@ -236,7 +238,7 @@ public final strictfp class DefaultCoordinateOperationFactoryTest extends
MathTr
         assertEquals("linearAccuracy", isUsingEpsgFactory ? 2 : PositionalAccuracyConstant.UNKNOWN_ACCURACY,
                                        CRS.getLinearAccuracy(operation), STRICT);
 
-        tolerance = isUsingEpsgFactory ? Formulas.LINEAR_TOLERANCE : 1000;
+        tolerance = isUsingEpsgFactory ? Formulas.LINEAR_TOLERANCE : 600;
         transform = operation.getMathTransform();
         isInverseTransformSupported = false;
         /*


Mime
View raw message