Author: desruisseaux Date: Thu May 31 13:44:52 2018 New Revision: 1832614 URL: http://svn.apache.org/viewvc?rev=1832614&view=rev Log: Add IP review for GridGeometryTest. Added: sis/ip-review/GridGeometryTest.xhtml sis/ip-review/rev/05901/ sis/ip-review/rev/05901/GridGeometryTest.xhtml sis/ip-review/rev/05901/HEADER.html sis/ip-review/rev/10894/GridGeometryTest.xhtml sis/ip-review/rev/20970/GridGeometryTest.xhtml sis/ip-review/rev/25050/GridGeometryTest.xhtml Added: sis/ip-review/GridGeometryTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/GridGeometryTest.xhtml?rev=1832614&view=auto ============================================================================== --- sis/ip-review/GridGeometryTest.xhtml (added) +++ sis/ip-review/GridGeometryTest.xhtml Thu May 31 13:44:52 2018 @@ -0,0 +1,65 @@ + + + + + GridGeometryTest history + + + +
+

GridGeometryTest history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/grid/GridGeometryTest.java
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
308362008-07-01desruisseauxBest effort in an attempt to bring a little bit of order in the coverage test bazar. A lonely test file moved to the sample-data module. Operation tests moved to the processing package. A few utility methods consolidated in base classes ending in "TestBase.java". Removed redundancy introduced by copy-and-paste. Merged the two occurences of ImageWorkerTest. Examples of coverages provided in a more "Java collection" way. Comparaison of values performed with "assertEquals(a,b)" rather than "assertTrue(a==b)" so we know what was the expected value in case of failure. Tests upgrated to JUnit 4 framework.
306432008-06-12acusterCopyright headers: lib/coverage, this time with feeling (and the el in Toolkit)
305412008-06-06acusterCopyright review: update headers on lib/coverage
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
298912008-04-10desruisseauxFixed test failures.
298262008-04-07desruisseauxMore support for PixelOrientation in GridGeometry construction and queries. A side effect of this work is the refactoring of GridGeometry2D translation method into a separated PixelTranslation class.
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
285402007-12-29acusterHide buttons which are not yet used
284962007-12-24desruisseauxAvoid usage of deprecated methods.
275752007-10-22desruisseauxConverted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).
250502007-04-06jgarnettexample of custom file based TestSutie, copy JTS parsing code over to unsupported/geometry
249252007-03-27jgarnettchange to org.opengis.geometry
227102006-11-12desruisseauxReview of coverage branch merge: In 'CategoryList', check for the 'no data' category name only if the geophysics value is some NaN value. Moved XAffineTransform to a public place and added methods for testing axis swapping, as a proposed replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)' (replacement not yet done; waiting for the okay from the mailing list). In GeneralGridGeometry, added methods for returning a math transform relative to some pixel corner instead of pixel center, as a proposed replacement for the 'getTransform(...)' public static methods (I would like to remove those static methods in order to keep the API a little bit more orthogonal).
223272006-10-23desruisseauxGEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.
223172006-10-22desruisseauxReorganisation of directory tree structure (GEOT-982) phase 3: moved 'test' to 'src/test/java'.
209702006-08-11jgarnettIP review.txt updated, along with headers
176722006-01-19desruisseauxAdded @source tag.
176602006-01-18desruisseauxFixed SVN attributes, including the addition of URL attribute.
165722005-11-02desruisseauxMoved coverage implementation to its own module (GEOT-745)
165262005-10-27desruisseauxMore responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This refactoring had a significant impact on Resample2D; the rest of the code should stay neutral.
153502005-08-16desruisseauxMerged the 'split-main' branch to trunk (GEOT-662)
131292005-04-15desruisseauxName change: removed 'GT' suffix in org.geotools.coverage implementations. Some on them were replaced by 'General' prefix for consistency with 'GeneralEnvelope' and 'GeneralDirectPosition'. In this context 'General' means "Can work with an arbitrary number of dimension". Other name changes in org.geotools.referencing and org.geotools.metadata are pending the choice between 'Default' prefix and 'Impl' suffix
129652005-04-05desruisseauxMerged 'factory-hints' branch r12393:12964 into the trunk. Added 'getImplementationHints()' method after the merge into Factory implementations, in order to get Geotools to compile with Maven.
117382005-03-02desruisseauxFirst working version of GridCoverage2D
116982005-02-28desruisseauxMoved tests from legacy to main module
110042005-02-02desruisseauxFixed wrong encoding in legacy/test
108942005-01-31dzwiersmoved legacy
108222005-01-28dzwiersmoving tests
107962005-01-28dzwiersimports cleaned
62752004-05-31jgarnettfixed format test problem
62552004-05-31desruisseauxBug fix for horizontal and vertical line colinear with an axis
59012004-05-23jgarnettgcs-coverage moved to main
58432004-05-23jgarnettTest directory now assumed to be junit
57742004-05-23jgarnettgeotools-src serves as the start of our new module directory (the data access modules will escape off to plugin directory soon)
57692004-05-23jgarnettProject renamed to gt
56192004-05-13(no author)Move repository under gt.
28582003-05-13desruisseauxAdded PMC owner to copyright notice
28522003-05-12desruisseauxFixed resampling problem, especially apparent when bounding box was close to -180 to +180 degrees of longitude
+
+ + Added: sis/ip-review/rev/05901/GridGeometryTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05901/GridGeometryTest.xhtml?rev=1832614&view=auto ============================================================================== --- sis/ip-review/rev/05901/GridGeometryTest.xhtml (added) +++ sis/ip-review/rev/05901/GridGeometryTest.xhtml Thu May 31 13:44:52 2018 @@ -0,0 +1,21 @@ + + + + + GridGeometryTest changes for revisions 5618:5901 + + + +
+

GridGeometryTest changes for revisions 5618:5901

+

No change.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r5618:5901 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/grid/GridGeometryTest.java
+ + +
Revision 5618Revision 5901
+
+ + Added: sis/ip-review/rev/05901/HEADER.html URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05901/HEADER.html?rev=1832614&view=auto ============================================================================== --- sis/ip-review/rev/05901/HEADER.html (added) +++ sis/ip-review/rev/05901/HEADER.html Thu May 31 13:44:52 2018 @@ -0,0 +1,17 @@ + + + + + Revision 5901 + + +
+

Revision 5901

+ + + + +
Author:jgarnett
Date:2004-05-23
Message:gcs-coverage moved to main
+
+ + Added: sis/ip-review/rev/10894/GridGeometryTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10894/GridGeometryTest.xhtml?rev=1832614&view=auto ============================================================================== --- sis/ip-review/rev/10894/GridGeometryTest.xhtml (added) +++ sis/ip-review/rev/10894/GridGeometryTest.xhtml Thu May 31 13:44:52 2018 @@ -0,0 +1,98 @@ + + + + + GridGeometryTest changes for revisions 6274:10894 + + + +
+

GridGeometryTest changes for revisions 6274:10894

+ +

No change in this commit apply to Apache SIS (breaking of encoding are of course not taken, + all those imports are different in SIS, and $Id$ SVN tag is not used in SIS).

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r6274:10894 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/grid/GridGeometryTest.java
+ + + + + + +
Revision 6274Revision 10894
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+ * (C) 2003, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+ * (C) 2003, Institut de Recherche pour le D�veloppement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
 *     UNITED KINGDOM: James Macgill
+ *             mailto:j.macgill@geog.leeds.ac.uk
+ *
+ *     FRANCE: Surveillance de l'Environnement Assistée par Satellite
+ *             Institut de Recherche pour le Développement / US-Espace
+ *             mailto:seasnet@teledetection.fr
+ */
+package org.geotools.gc;
+
+// J2SE dependencies
+import java.util.Arrays;
+import java.awt.geom.*;
+
+// Geotools dependencies
+import org.geotools.gc.*;
+import org.geotools.cs.*;
+import org.geotools.ct.*;
+import org.geotools.pt.*;
+
+// JUnit dependencies
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+
+/**
+ * Test the {@link GridGeometry} implementation.
+ *
+ * @version $Id: GridGeometryTest.java,v 1.2 2003/05/13 10:59:53 desruisseaux Exp $
+ * @author Martin Desruisseaux
+ */
+public class GridGeometryTest extends TestCase {
 *     UNITED KINGDOM: James Macgill
+ *             mailto:j.macgill@geog.leeds.ac.uk
+ *
+ *     FRANCE: Surveillance de l'Environnement Assist�e par Satellite
+ *             Institut de Recherche pour le D�veloppement / US-Espace
+ *             mailto:seasnet@teledetection.fr
+ */
+package org.geotools.gc;
+
+// J2SE dependencies
+import java.awt.geom.AffineTransform;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+import org.geotools.ct.MathTransform;
+import org.geotools.ct.MathTransformFactory;
+import org.geotools.pt.Envelope;
+
+
+/**
+ * Test the {@link GridGeometry} implementation.
+ *
+ * @version $Id$
+ * @author Martin Desruisseaux
+ */
+public class GridGeometryTest extends TestCase {
+
+ + Added: sis/ip-review/rev/20970/GridGeometryTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/GridGeometryTest.xhtml?rev=1832614&view=auto ============================================================================== --- sis/ip-review/rev/20970/GridGeometryTest.xhtml (added) +++ sis/ip-review/rev/20970/GridGeometryTest.xhtml Thu May 31 13:44:52 2018 @@ -0,0 +1,50 @@ + + + + + GridGeometryTest changes for revisions 20969:20970 + + + +
+

GridGeometryTest changes for revisions 20969:20970

+ +

This change in header does not apply to SIS.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20969:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/grid/GridGeometryTest.java
+ + + + + + +
Revision 20969Revision 20970
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+ * (C) 2003, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
/*
+ *    GeoTools - OpenSource mapping toolkit
+ *    http://geotools.org
+ *    (C) 2003-2006, Geotools Project Managment Committee (PMC)
+ * (C) 2003, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
 *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+ *    You should have received a copy of the GNU Lesser General Public
+ *    License along with this library; if not, write to the Free Software
+ *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+package org.geotools.coverage.grid;
 *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.coverage.grid;
+
+ + Added: sis/ip-review/rev/25050/GridGeometryTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/GridGeometryTest.xhtml?rev=1832614&view=auto ============================================================================== --- sis/ip-review/rev/25050/GridGeometryTest.xhtml (added) +++ sis/ip-review/rev/25050/GridGeometryTest.xhtml Thu May 31 13:44:52 2018 @@ -0,0 +1,56 @@ + + + + + GridGeometryTest changes for revisions 24924:25050 + + + +
+

GridGeometryTest changes for revisions 24924:25050

+ +

Change of Envelope package name can not be avoided since this is a GeoAPI change. + Change of FactoryFinder does not apply to SIS since we do not use it anymore.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24924:25050 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/test/java/org/geotools/coverage/grid/GridGeometryTest.java
+ + + + + + +
Revision 24924Revision 25050
import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransformFactory;
+import org.opengis.spatialschema.geometry.Envelope;
+
+// Geotools dependencies
+import org.geotools.geometry.GeneralEnvelope;
+import org.geotools.referencing.FactoryFinder;
+import org.geotools.referencing.operation.matrix.MatrixFactory;
import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransformFactory;
+import org.opengis.geometry.Envelope;
+
+// Geotools dependencies
+import org.geotools.geometry.GeneralEnvelope;
+import org.geotools.referencing.ReferencingFactoryFinder;
+import org.geotools.referencing.operation.matrix.MatrixFactory;
 * Tests the construction with an identity transform.
+ */
+public void testIdentity() throws FactoryException {
+    final MathTransformFactory factory = FactoryFinder.getMathTransformFactory(null);
+    final int[] lower = new int[] {0,     0, 2};
+    final int[] upper = new int[] {100, 200, 4};
+    final MathTransform identity = factory.createAffineTransform(MatrixFactory.create(4));
 * Tests the construction with an identity transform.
+ */
+public void testIdentity() throws FactoryException {
+    final MathTransformFactory factory = ReferencingFactoryFinder.getMathTransformFactory(null);
+    final int[] lower = new int[] {0,     0, 2};
+    final int[] upper = new int[] {100, 200, 4};
+    final MathTransform identity = factory.createAffineTransform(MatrixFactory.create(4));
+
+ +