Author: desruisseaux Date: Mon May 28 16:26:07 2018 New Revision: 1832410 URL: http://svn.apache.org/viewvc?rev=1832410&view=rev Log: Add IP review for GeneralGridEnvelope. Added: sis/ip-review/GeneralGridEnvelope.xhtml sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml Added: sis/ip-review/GeneralGridEnvelope.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/GeneralGridEnvelope.xhtml?rev=1832410&view=auto ============================================================================== --- sis/ip-review/GeneralGridEnvelope.xhtml (added) +++ sis/ip-review/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018 @@ -0,0 +1,64 @@ + + + + + GeneralGridEnvelope history + + + +
+

GeneralGridEnvelope history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
307762008-06-20desruisseauxGeoTools implementation update for GeoAPI change (GEO-136): Envelope.getCenter renamed as getMedian and getLength renamed as getSpan. Deprecated GridRange, to be replaced by GridEnvelope.
306432008-06-12acusterCopyright headers: lib/coverage, this time with feeling (and the el in Toolkit)
305412008-06-06acusterCopyright review: update headers on lib/coverage
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
299622008-04-17simboss-typos
298262008-04-07desruisseauxMore support for PixelOrientation in GridGeometry construction and queries. A side effect of this work is the refactoring of GridGeometry2D translation method into a separated PixelTranslation class.
294162008-02-21desruisseauxAdded a GeneralEnvelope.validate() method for restricting an envelope to its CRS or CS domain of validity, wraping around longitude if needed. Relaxed the transformations between GeographicBoundingBox and Envelope, accepting GeographicCRS that are not necessarly WGS84.
289372008-01-25desruisseauxReverted the whole trunk to revision 28921.
289262008-01-24acusterRevert geotools trunk to reversion 29822, hopefully.
289232008-01-24acusterMerge from gtbranches
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
285402007-12-29acusterHide buttons which are not yet used
285002007-12-24desruisseauxAdded a new GridGeometry implementation (ImageGeometry) has a lightweight placeholder for 'gridRange' as a Rectangle and 'gridToCRS' as an AffineTransform. Used by TileBuilder.
283742007-12-14desruisseauxUse some java 5 features. Added javadoc. Removed AbstractCoverage.dispose() deprecated method (replaced by dispose(boolean)). Cleaning.
282522007-12-04desruisseauxMore MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.
280812007-11-27desruisseauxJava 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.
275752007-10-22desruisseauxConverted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).
249252007-03-27jgarnettchange to org.opengis.geometry
231202006-11-29desruisseauxCoverage branch review. Reformatted code (including javadoc work), modification of AbstractCoverage.show and AbstractCoverage.evaluate(DirectPosition,Set).
229592006-11-24desruisseauxAligned Geotools build along latest GeoAPI interfaces (2.1-SNAPSHOT).
228172006-11-17desruisseauxFixed SVN properties for all Java files.
223272006-10-23desruisseauxGEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.
223152006-10-22desruisseauxReorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.
209702006-08-11jgarnettIP review.txt updated, along with headers
176722006-01-19desruisseauxAdded @source tag.
176602006-01-18desruisseauxFixed SVN attributes, including the addition of URL attribute.
165722005-11-02desruisseauxMoved coverage implementation to its own module (GEOT-745)
165362005-10-28desruisseauxAdded a 'Default CRS' hint for GridCoverageFactory (post GEOT-701 cleaning) + javadoc fixes.
165262005-10-27desruisseauxMore responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This refactoring had a significant impact on Resample2D; the rest of the code should stay neutral.
148342005-07-20desruisseauxReorganized I18N resources
139252005-05-30desruisseauxAdded @since javadoc tag
131292005-04-15desruisseauxName change: removed 'GT' suffix in org.geotools.coverage implementations. Some on them were replaced by 'General' prefix for consistency with 'GeneralEnvelope' and 'GeneralDirectPosition'. In this context 'General' means "Can work with an arbitrary number of dimension". Other name changes in org.geotools.referencing and org.geotools.metadata are pending the choice between 'Default' prefix and 'Impl' suffix
117382005-03-02desruisseauxFirst working version of GridCoverage2D
115722005-02-23desruisseauxInitial port of sub-transform, required for some grid coverages
110012005-02-02desruisseauxFixed wrong encoding in main/src
107962005-01-28dzwiersimports cleaned
62952004-06-02desruisseauxPartial port of GridRange and GridGeometry implementations
+
+ + Added: sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml?rev=1832410&view=auto ============================================================================== --- sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml (added) +++ sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018 @@ -0,0 +1,83 @@ + + + + + GeneralGridEnvelope changes for revisions 10795:10796 + + + +
+

GeneralGridEnvelope changes for revisions 10795:10796

+

Changes in this commit seem to be the result of some "auto reformat" tool execution. +The Java - GeoAPI - GeoTools import ordering is altered, +imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken. +This commit has been reverted, except for the removal of really unused imports which are keep removed.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java
+ + + + + + + + +
Revision 10795Revision 10796
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le D�veloppement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
package org.geotools.coverage.grid;
+
+// J2SE dependencies
+import java.io.Serializable;
+import java.util.Arrays;
+import java.awt.Rectangle;
+import java.awt.image.Raster;
+import java.awt.image.RenderedImage;
+
+// Geotools dependencies
+import org.geotools.resources.Utilities;
+import org.geotools.resources.gcs.Resources;
+import org.geotools.resources.gcs.ResourceKeys;
+
+
+/**
package org.geotools.coverage.grid;
+
+// J2SE dependencies
+import java.awt.Rectangle;
+import java.awt.image.Raster;
+import java.awt.image.RenderedImage;
+import java.io.Serializable;
+import java.util.Arrays;
+
+import org.geotools.resources.Utilities;
+import org.geotools.resources.gcs.ResourceKeys;
+import org.geotools.resources.gcs.Resources;
+
+
+/**
}
+
+/**
+ * Returns a string représentation of this grid range.
+ * The returned string is implementation dependent. It
+ * is usually provided for debugging purposes.
+ */
}
+
+/**
+ * Returns a string repr�sentation of this grid range.
+ * The returned string is implementation dependent. It
+ * is usually provided for debugging purposes.
+ */
+
+ + Added: sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml?rev=1832410&view=auto ============================================================================== --- sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml (added) +++ sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018 @@ -0,0 +1,51 @@ + + + + + GeneralGridEnvelope changes for revisions 20969:20970 + + + +
+

GeneralGridEnvelope changes for revisions 20969:20970

+

Change irrelevant to Apache SIS.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20969:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java
+ + + + + + +
Revision 20969Revision 20970
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
/*
+ *    GeoTools - OpenSource mapping toolkit
+ *    http://geotools.org
+ *    (C) 2003-2006, Geotools Project Managment Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    You should have received a copy of the GNU Lesser General Public
+*    License along with this library; if not, write to the Free Software
+*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+*
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/
*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/
+
+ + Added: sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml?rev=1832410&view=auto ============================================================================== --- sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml (added) +++ sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018 @@ -0,0 +1,37 @@ + + + + + GeneralGridEnvelope changes for revisions 24924:24925 + + + +
+

GeneralGridEnvelope changes for revisions 24924:24925

+

This commit propagates the package names change which was done in GeoAPI. +There is no way such change could be done differently, +since not renaming the packages cause a compilation error.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java
+ + + + +
Revision 24924Revision 24925
import org.opengis.coverage.grid.GridRange;
+import org.opengis.coverage.grid.GridGeometry; // For javadoc
+import org.opengis.coverage.grid.GridCoordinates;
+import org.opengis.spatialschema.geometry.Envelope;
+
+// Geotools dependencies
+import org.geotools.resources.Utilities;
import org.opengis.coverage.grid.GridRange;
+import org.opengis.coverage.grid.GridGeometry; // For javadoc
+import org.opengis.coverage.grid.GridCoordinates;
+import org.opengis.geometry.Envelope;
+
+// Geotools dependencies
+import org.geotools.resources.Utilities;
+
+ + Added: sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml?rev=1832410&view=auto ============================================================================== --- sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml (added) +++ sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018 @@ -0,0 +1,39 @@ + + + + + GeneralGridEnvelope changes for revisions 29961:29962 + + + +
+

GeneralGridEnvelope changes for revisions 29961:29962

+

This change does not apply to SIS since the modified method is removed. + We do not want to encourage constructing a GridEnvelope from an Envelope.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r29961:29962 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java
+ + + + +
Revision 29961Revision 29962
* only if {@code anchor} is {@link PixelInCell#CELL_CENTER}. Users who don't want such
+* offset should specify {@link PixelInCell#CELL_CORNER}.
+* <p>
+* The convention is specified as a {@link PixelInCell} code instead than the more detailled
+* {@link org.opengis.metadata.spatial.PixelOrientation} because the later is restricted to
+* the two-dimensional case while the former can be used for any number of dimensions.
+*
+* @param envelope
* only if {@code anchor} is {@link PixelInCell#CELL_CENTER}. Users who don't want such
+* offset should specify {@link PixelInCell#CELL_CORNER}.
+* <p>
+* The convention is specified as a {@link PixelInCell} code instead than the more detailed
+* {@link org.opengis.metadata.spatial.PixelOrientation} because the latter is restricted to
+* the two-dimensional case while the former can be used for any number of dimensions.
+*
+* @param envelope
+
+ +