sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1832410 - in /sis/ip-review: GeneralGridEnvelope.xhtml rev/10796/GeneralGridEnvelope.xhtml rev/20970/GeneralGridEnvelope.xhtml rev/24925/GeneralGridEnvelope.xhtml rev/29962/GeneralGridEnvelope.xhtml
Date Mon, 28 May 2018 16:26:07 GMT
Author: desruisseaux
Date: Mon May 28 16:26:07 2018
New Revision: 1832410

URL: http://svn.apache.org/viewvc?rev=1832410&view=rev
Log:
Add IP review for GeneralGridEnvelope.

Added:
    sis/ip-review/GeneralGridEnvelope.xhtml
    sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml
    sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml
    sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml
    sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml

Added: sis/ip-review/GeneralGridEnvelope.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/GeneralGridEnvelope.xhtml?rev=1832410&view=auto
==============================================================================
--- sis/ip-review/GeneralGridEnvelope.xhtml (added)
+++ sis/ip-review/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018
@@ -0,0 +1,64 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralGridEnvelope history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralGridEnvelope history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30776</td><td>2008-06-20</td><td>desruisseaux</td><td>GeoTools
implementation update for GeoAPI change (GEO-136): Envelope.getCenter renamed as getMedian
and getLength renamed as getSpan. Deprecated GridRange, to be replaced by GridEnvelope.</td></tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright
review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29962</td><td>2008-04-17</td><td class="unav">simboss</td><td><a
href="rev/29962/GeneralGridEnvelope.xhtml">-typos</a></td></tr>
+<tr><td class="rev">29826</td><td>2008-04-07</td><td>desruisseaux</td><td>More
support for PixelOrientation in GridGeometry construction and queries. A side effect of this
work is the refactoring of GridGeometry2D translation method into a separated PixelTranslation
class.</td></tr>
+<tr><td class="rev">29416</td><td>2008-02-21</td><td>desruisseaux</td><td>Added
a GeneralEnvelope.validate() method for restricting an envelope to its CRS or CS domain of
validity, wraping around longitude if needed. Relaxed the transformations between GeographicBoundingBox
and Envelope, accepting GeographicCRS that are not necessarly WGS84.</td></tr>
+<tr><td class="rev">28937</td><td>2008-01-25</td><td>desruisseaux</td><td>Reverted
the whole trunk to revision 28921.</td></tr>
+<tr><td class="rev">28926</td><td>2008-01-24</td><td>acuster</td><td>Revert
geotools trunk to reversion 29822, hopefully.</td></tr>
+<tr><td class="rev">28923</td><td>2008-01-24</td><td>acuster</td><td>Merge
from gtbranches</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28500</td><td>2007-12-24</td><td>desruisseaux</td><td>Added
a new GridGeometry implementation (ImageGeometry) has a lightweight placeholder for 'gridRange'
as a Rectangle and 'gridToCRS' as an AffineTransform. Used by TileBuilder.</td></tr>
+<tr><td class="rev">28374</td><td>2007-12-14</td><td>desruisseaux</td><td>Use
some java 5 features. Added javadoc. Removed AbstractCoverage.dispose() deprecated method
(replaced by dispose(boolean)). Cleaning.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More
MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated
utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation;
rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/24925/GeneralGridEnvelope.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">23120</td><td>2006-11-29</td><td>desruisseaux</td><td>Coverage
branch review. Reformatted code (including javadoc work), modification of AbstractCoverage.show
and AbstractCoverage.evaluate(DirectPosition,Set).</td></tr>
+<tr><td class="rev">22959</td><td>2006-11-24</td><td>desruisseaux</td><td>Aligned
Geotools build along latest GeoAPI interfaces (2.1-SNAPSHOT).</td></tr>
+<tr><td class="rev">22817</td><td>2006-11-17</td><td>desruisseaux</td><td>Fixed
SVN properties for all Java files.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a
href="rev/20970/GeneralGridEnvelope.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved
coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">16536</td><td>2005-10-28</td><td>desruisseaux</td><td>Added
a 'Default CRS' hint for GridCoverageFactory (post GEOT-701 cleaning) + javadoc fixes.</td></tr>
+<tr><td class="rev">16526</td><td>2005-10-27</td><td>desruisseaux</td><td>More
responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This refactoring
had a significant impact on Resample2D; the rest of the code should stay neutral.</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added
@since javadoc tag</td></tr>
+<tr><td class="rev">13129</td><td>2005-04-15</td><td>desruisseaux</td><td>Name
change: removed 'GT' suffix in org.geotools.coverage implementations. Some on them were replaced
by 'General' prefix for consistency with 'GeneralEnvelope' and 'GeneralDirectPosition'. In
this context 'General' means "Can work with an arbitrary number of dimension". Other name
changes in org.geotools.referencing and org.geotools.metadata are pending the choice between
'Default' prefix and 'Impl' suffix</td></tr>
+<tr><td class="rev">11738</td><td>2005-03-02</td><td>desruisseaux</td><td>First
working version of GridCoverage2D</td></tr>
+<tr><td class="rev">11572</td><td>2005-02-23</td><td>desruisseaux</td><td>Initial
port of sub-transform, required for some grid coverages</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed
wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a
href="rev/10796/GeneralGridEnvelope.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">6295</td><td>2004-06-02</td><td>desruisseaux</td><td>Partial
port of GridRange and GridGeometry implementations</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml?rev=1832410&view=auto
==============================================================================
--- sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml (added)
+++ sis/ip-review/rev/10796/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018
@@ -0,0 +1,83 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralGridEnvelope changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralGridEnvelope changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite>
tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite>
import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are
keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.coverage.grid;
+
+// J2SE dependencies
+<span class="del">import java.io.Serializable;</span>
+<span class="del">import java.util.Arrays;</span>
+import java.awt.Rectangle;
+import java.awt.image.Raster;
+import java.awt.image.RenderedImage;
+
+<span class="del">// Geotools dependencies</span>
+import org.geotools.resources.Utilities;
+import org.geotools.resources.gcs.Resources;
+<span class="del">import org.geotools.resources.gcs.ResourceKeys;</span>
+
+
+/**</pre></td>
+<td><pre>package org.geotools.coverage.grid;
+
+// J2SE dependencies
+import java.awt.Rectangle;
+import java.awt.image.Raster;
+import java.awt.image.RenderedImage;
+<span class="add">import java.io.Serializable;</span>
+<span class="add">import java.util.Arrays;</span>
+
+import org.geotools.resources.Utilities;
+<span class="add">import org.geotools.resources.gcs.ResourceKeys;</span>
+import org.geotools.resources.gcs.Resources;
+
+
+/**</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Returns a string représentation of this grid range.</span>
+ * The returned string is implementation dependent. It
+ * is usually provided for debugging purposes.
+ */</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Returns a string repr�sentation of this grid range.</span>
+ * The returned string is implementation dependent. It
+ * is usually provided for debugging purposes.
+ */</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml?rev=1832410&view=auto
==============================================================================
--- sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml (added)
+++ sis/ip-review/rev/20970/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018
@@ -0,0 +1,51 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralGridEnvelope changes for revisions 20969:20970</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralGridEnvelope changes for revisions 20969:20970</h1>
+      <p>Change irrelevant to Apache SIS.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20969:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20969</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 See the GNU
+*    Lesser General Public License for more details.
+*
+<span class="del">*    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">*    License along with this library; if not, write to the Free Software</span>
+<span class="del">*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml?rev=1832410&view=auto
==============================================================================
--- sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml (added)
+++ sis/ip-review/rev/24925/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralGridEnvelope changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralGridEnvelope changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>import org.opengis.coverage.grid.GridRange;
+import org.opengis.coverage.grid.GridGeometry; // For javadoc
+import org.opengis.coverage.grid.GridCoordinates;
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+
+// Geotools dependencies
+import org.geotools.resources.Utilities;</pre></td>
+<td><pre>import org.opengis.coverage.grid.GridRange;
+import org.opengis.coverage.grid.GridGeometry; // For javadoc
+import org.opengis.coverage.grid.GridCoordinates;
+<span class="add">import org.opengis.geometry.Envelope;</span>
+
+// Geotools dependencies
+import org.geotools.resources.Utilities;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml?rev=1832410&view=auto
==============================================================================
--- sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml (added)
+++ sis/ip-review/rev/29962/GeneralGridEnvelope.xhtml Mon May 28 16:26:07 2018
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GeneralGridEnvelope changes for revisions 29961:29962</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GeneralGridEnvelope changes for revisions 29961:29962</h1>
+      <p>This change does not apply to SIS since the modified method is removed.
+      We do not want to encourage constructing a <code>GridEnvelope</code> from
an <code>Envelope</code>.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r29961:29962 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridEnvelope.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 29961</th><th>Revision 29962</th></tr>
+<tr><td><pre>* only if {@code anchor} is {@link PixelInCell#CELL_CENTER}.
Users who don't want such
+* offset should specify {@link PixelInCell#CELL_CORNER}.
+* &lt;p&gt;
+<span class="del">* The convention is specified as a {@link PixelInCell} code instead
than the more detailled</span>
+<span class="del">* {@link org.opengis.metadata.spatial.PixelOrientation} because the
later is restricted to</span>
+* the two-dimensional case while the former can be used for any number of dimensions.
+*
+* @param envelope</pre></td>
+<td><pre>* only if {@code anchor} is {@link PixelInCell#CELL_CENTER}. Users who
don't want such
+* offset should specify {@link PixelInCell#CELL_CORNER}.
+* &lt;p&gt;
+<span class="add">* The convention is specified as a {@link PixelInCell} code instead
than the more detailed</span>
+<span class="add">* {@link org.opengis.metadata.spatial.PixelOrientation} because the
latter is restricted to</span>
+* the two-dimensional case while the former can be used for any number of dimensions.
+*
+* @param envelope</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>



Mime
View raw message