sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1832403 - in /sis/ip-review: ./ rev/10867/ rev/11186/ rev/16529/ rev/20970/ rev/24925/ rev/29962/
Date Mon, 28 May 2018 15:15:54 GMT
Author: desruisseaux
Date: Mon May 28 15:15:53 2018
New Revision: 1832403

URL: http://svn.apache.org/viewvc?rev=1832403&view=rev
Log:
IP review for GridGeometry.

Added:
    sis/ip-review/GridGeometry.xhtml
    sis/ip-review/rev/10867/
    sis/ip-review/rev/10867/GridGeometry.xhtml
    sis/ip-review/rev/10867/HEADER.html
    sis/ip-review/rev/11186/
    sis/ip-review/rev/11186/GridGeometry.xhtml
    sis/ip-review/rev/11186/HEADER.html
    sis/ip-review/rev/16529/
    sis/ip-review/rev/16529/GridGeometry.xhtml
    sis/ip-review/rev/16529/HEADER.html
    sis/ip-review/rev/20970/GridGeometry.xhtml
    sis/ip-review/rev/24925/GridGeometry.xhtml
    sis/ip-review/rev/29962/
    sis/ip-review/rev/29962/GridGeometry.xhtml
    sis/ip-review/rev/29962/HEADER.html

Added: sis/ip-review/GridGeometry.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/GridGeometry.xhtml?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/GridGeometry.xhtml (added)
+++ sis/ip-review/GridGeometry.xhtml Mon May 28 15:15:53 2018
@@ -0,0 +1,91 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GridGeometry history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GridGeometry history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridGeometry.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30776</td><td>2008-06-20</td><td>desruisseaux</td><td>GeoTools implementation update for GeoAPI change (GEO-136): Envelope.getCenter renamed as getMedian and getLength renamed as getSpan. Deprecated GridRange, to be replaced by GridEnvelope.</td></tr>
+<tr><td class="rev">30643</td><td>2008-06-12</td><td>acuster</td><td>Copyright headers: lib/coverage, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30541</td><td>2008-06-06</td><td>acuster</td><td>Copyright review: update headers on lib/coverage</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few tests show that the compiler always select the best overloaded flavor working on primitive types (except if an argument is a boolean and the other a different primitive type). Updated a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29962</td><td>2008-04-17</td><td class="unav">simboss</td><td><a href="rev/29962/GridGeometry.xhtml">-typos</a></td></tr>
+<tr><td class="rev">29829</td><td>2008-04-07</td><td>desruisseaux</td><td>Inside synchronized blocks, avoid to call methods that user could override.</td></tr>
+<tr><td class="rev">29826</td><td>2008-04-07</td><td>desruisseaux</td><td>More support for PixelOrientation in GridGeometry construction and queries. A side effect of this work is the refactoring of GridGeometry2D translation method into a separated PixelTranslation class.</td></tr>
+<tr><td class="rev">29744</td><td>2008-03-31</td><td>desruisseaux</td><td>Added a GridGeometry2D.getSize2D() convenience method.</td></tr>
+<tr><td class="rev">28937</td><td>2008-01-25</td><td>desruisseaux</td><td>Reverted the whole trunk to revision 28921.</td></tr>
+<tr><td class="rev">28926</td><td>2008-01-24</td><td>acuster</td><td>Revert geotools trunk to reversion 29822, hopefully.</td></tr>
+<tr><td class="rev">28923</td><td>2008-01-24</td><td>acuster</td><td>Merge from gtbranches</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28801</td><td>2008-01-17</td><td>desruisseaux</td><td>Made CoverageStack more tolerant to heterogenous CRS (unfinished work). Some Java 5 type safety added.</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide buttons which are not yet used</td></tr>
+<tr><td class="rev">28500</td><td>2007-12-24</td><td>desruisseaux</td><td>Added a new GridGeometry implementation (ImageGeometry) has a lightweight placeholder for 'gridRange' as a Rectangle and 'gridToCRS' as an AffineTransform. Used by TileBuilder.</td></tr>
+<tr><td class="rev">28496</td><td>2007-12-24</td><td>desruisseaux</td><td>Avoid usage of deprecated methods.</td></tr>
+<tr><td class="rev">28374</td><td>2007-12-14</td><td>desruisseaux</td><td>Use some java 5 features. Added javadoc. Removed AbstractCoverage.dispose() deprecated method (replaced by dispose(boolean)). Cleaning.</td></tr>
+<tr><td class="rev">28252</td><td>2007-12-04</td><td>desruisseaux</td><td>More MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java 5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation; rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">27094</td><td>2007-09-20</td><td>desruisseaux</td><td>Merged changes from 2.4 branch.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a href="rev/24925/GridGeometry.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">22959</td><td>2006-11-24</td><td>desruisseaux</td><td>Aligned Geotools build along latest GeoAPI interfaces (2.1-SNAPSHOT).</td></tr>
+<tr><td class="rev">22826</td><td>2006-11-20</td><td>desruisseaux</td><td>Minor bug fixes. Removed deprecated methods in GeneralGridGeometry. Added a 'toBackingFactoryCode' method in AuthorityFactoryAdapter.</td></tr>
+<tr><td class="rev">22817</td><td>2006-11-17</td><td>desruisseaux</td><td>Fixed SVN properties for all Java files.</td></tr>
+<tr><td class="rev">22715</td><td>2006-11-14</td><td>desruisseaux</td><td>Added GridToEnvelopeMapper implementation as a proposed replacement for GeneralGridGeometry.getTransform static method.</td></tr>
+<tr><td class="rev">22711</td><td>2006-11-12</td><td>desruisseaux</td><td>Moved the GeneralGridGeometry.getEnvelope(...) static method as a GeneralEnvelope constructor.</td></tr>
+<tr><td class="rev">22710</td><td>2006-11-12</td><td>desruisseaux</td><td>Review of coverage branch merge: In 'CategoryList', check for the 'no data' category name only if the geophysics value is some NaN value. Moved XAffineTransform to a public place and added methods for testing axis swapping, as a proposed replacement for 'GeneralGridGeometry.swapXY(CoordinateSystem)' (replacement not yet done; waiting for the okay from the mailing list). In GeneralGridGeometry, added methods for returning a math transform relative to some pixel corner instead of pixel center, as a proposed replacement for the 'getTransform(...)' public static methods (I would like to remove those static methods in order to keep the API a little bit more orthogonal).</td></tr>
+<tr><td class="rev">22452</td><td>2006-10-28</td><td>desruisseaux</td><td>Moved some methods from CRSUtilities to CRS (GEOT-547).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">22226</td><td>2006-10-18</td><td>acuster</td><td>Javadoc: purge the @params</td></tr>
+<tr><td class="rev">20970</td><td>2006-08-11</td><td class="unav">jgarnett</td><td><a href="rev/20970/GridGeometry.xhtml">IP review.txt updated, along with headers</a></td></tr>
+<tr><td class="rev">20600</td><td>2006-07-18</td><td class="unav">simboss</td><td><a href="rev/20970/GridGeometry.xhtml">-committing first bunch of changes from the coverage branch. Modules involved are*api *referencing *coverage *main *renderer *shaperenderer</a></td></tr>
+<tr><td class="rev">20243</td><td>2006-06-30</td><td>desruisseaux</td><td>Javadoc fixes. Factored out icon management in a small IconFactory class.</td></tr>
+<tr><td class="rev">20167</td><td>2006-06-23</td><td>desruisseaux</td><td>GEOT-873: partial merge of ImageUtilities to trunk. Not yet finished, since I'm refactoring the new code in the process.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added @source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">16572</td><td>2005-11-02</td><td>desruisseaux</td><td>Moved coverage implementation to its own module (GEOT-745)</td></tr>
+<tr><td class="rev">16536</td><td>2005-10-28</td><td>desruisseaux</td><td>Added a 'Default CRS' hint for GridCoverageFactory (post GEOT-701 cleaning) + javadoc fixes.</td></tr>
+<tr><td class="rev">16529</td><td>2005-10-27</td><td class="unav">afabiani</td><td><a href="rev/16529/GridGeometry.xhtml">Very small bug fixes for Java 1.4 compiler plus first RasterSymbolizer implementation</a></td></tr>
+<tr><td class="rev">16526</td><td>2005-10-27</td><td>desruisseaux</td><td>More responsabilities moved from GridCoverage2D to GridGeometry2D (GEOT-701). This refactoring had a significant impact on Resample2D; the rest of the code should stay neutral.</td></tr>
+<tr><td class="rev">15803</td><td>2005-09-22</td><td>desruisseaux</td><td>Bux fix in automatic axis swapping during GridCoverage(..., Envelope, ...) construction.</td></tr>
+<tr><td class="rev">15736</td><td>2005-09-19</td><td>desruisseaux</td><td>Added convenience methods or constructors</td></tr>
+<tr><td class="rev">15556</td><td>2005-08-30</td><td>desruisseaux</td><td>Bug fix in 'createTransformedShape' / Clarification in the way a GridCoverage2D convenience constructor handle axis</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added @since javadoc tag</td></tr>
+<tr><td class="rev">13129</td><td>2005-04-15</td><td>desruisseaux</td><td>Name change: removed 'GT' suffix in org.geotools.coverage implementations. Some on them were replaced by 'General' prefix for consistency with 'GeneralEnvelope' and 'GeneralDirectPosition'. In this context 'General' means "Can work with an arbitrary number of dimension". Other name changes in org.geotools.referencing and org.geotools.metadata are pending the choice between 'Default' prefix and 'Impl' suffix</td></tr>
+<tr><td class="rev">11738</td><td>2005-03-02</td><td>desruisseaux</td><td>First working version of GridCoverage2D</td></tr>
+<tr><td class="rev">11654</td><td>2005-02-25</td><td>desruisseaux</td><td>GridGeometry work, which includes a first working version of DimensionFilter</td></tr>
+<tr><td class="rev">11572</td><td>2005-02-23</td><td>desruisseaux</td><td>Initial port of sub-transform, required for some grid coverages</td></tr>
+<tr><td class="rev">11549</td><td>2005-02-22</td><td>desruisseaux</td><td>Initial cleaning for restarting GridCoverage work</td></tr>
+<tr><td class="rev">11186</td><td>2005-02-08</td><td class="unav">rgould</td><td><a href="rev/11186/GridGeometry.xhtml">Attempts to get GridCoverage to work. Made GridGeometry implement the GeoAPI GridGeometry interface. Added GridGeometry support to GridCoverageImpl. Added GridCoverage into GridCoverageRenderer.</a></td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed wrong encoding in main/src</td></tr>
+<tr><td class="rev">10944</td><td>2005-02-01</td><td>desruisseaux</td><td>Bug fix in ProjectedCRS: axis swapping and units conversion were not correctly handled</td></tr>
+<tr><td class="rev">10867</td><td>2005-01-31</td><td class="unav">dzwiers</td><td><a href="rev/10867/GridGeometry.xhtml">dep fix</a></td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a href="rev/10867/GridGeometry.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface for DirectPosition and Point</td></tr>
+<tr><td class="rev">6362</td><td>2004-06-08</td><td>desruisseaux</td><td>Initial work for an OperationProvider</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing CRS implementation</td></tr>
+<tr><td class="rev">6301</td><td>2004-06-03</td><td>desruisseaux</td><td>Refactored basic transform in their own package</td></tr>
+<tr><td class="rev">6295</td><td>2004-06-02</td><td>desruisseaux</td><td>Partial port of GridRange and GridGeometry implementations</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10867/GridGeometry.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10867/GridGeometry.xhtml?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/10867/GridGeometry.xhtml (added)
+++ sis/ip-review/rev/10867/GridGeometry.xhtml Mon May 28 15:15:53 2018
@@ -0,0 +1,227 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GridGeometry changes for revisions 10795:10867</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GridGeometry changes for revisions 10795:10867</h1>
+
+<p>This commit changes import order, messes with non-ASCII characters, comment-out some code and apply the renaming of GeoAPI methods.
+The change in import order does not affect Apache SIS since we have different imports. The messing with non-ASCII characters is reverted.
+The commented-out code will be removed and the renaming of GeoAPI methods is forced by GeoAPI interfaces.
+</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10867 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridGeometry.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10867</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Management Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.coverage.grid;
+
+// J2SE dependencies
+<span class="del">import java.io.Serializable;</span>
+import java.awt.Rectangle;
+import java.awt.geom.Point2D;
+import java.awt.geom.Rectangle2D;
+<span class="del">import java.awt.geom.AffineTransform;</span>
+<span class="del">import java.awt.image.RenderedImage;  // For Javadoc</span>
+<span class="del">import java.awt.image.BufferedImage;  // For Javadoc</span>
+
+<span class="del">// JAI dependencies</span>
+<span class="del">import javax.media.jai.IntegerSequence;</span>
+<span class="del"></span>
+<span class="del">// OpenGIS dependencies</span>
+import org.opengis.coverage.grid.GridRange;
+<span class="del">import org.opengis.coverage.CannotEvaluateException;</span>
+<span class="del">import org.opengis.referencing.FactoryException;</span>
+<span class="del">import org.opengis.referencing.operation.Matrix;</span>
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform2D;
+import org.opengis.referencing.operation.TransformException;
+<span class="del">import org.opengis.referencing.operation.MathTransformFactory;</span>
+<span class="del">import org.opengis.referencing.operation.NoninvertibleTransformException;</span>
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.geometry.GeneralEnvelope;</span>
+<span class="del">import org.geotools.geometry.DirectPosition2D;</span>
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+<span class="del">import org.geotools.referencing.operation.GeneralMatrix;</span>
+<span class="del">import org.geotools.referencing.operation.transform.ProjectiveTransform;</span>
+
+<span class="del">// Resources</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+<span class="del">import org.geotools.resources.CRSUtilities;</span>
+<span class="del">import org.geotools.resources.gcs.Resources;</span>
+<span class="del">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="del">import org.geotools.resources.image.JAIUtilities;</span>
+<span class="del"></span>
+<span class="del"></span>
+/**
+ * Describes the valid range of grid coordinates and the math
+ * transform to transform grid coordinates to real world coordinates.</pre></td>
+<td><pre>package org.geotools.coverage.grid;
+
+// J2SE dependencies
+import java.awt.Rectangle;
+<span class="add">import java.awt.geom.AffineTransform;</span>
+import java.awt.geom.Point2D;
+import java.awt.geom.Rectangle2D;
+<span class="add">import java.awt.image.BufferedImage;</span>
+<span class="add">import java.awt.image.RenderedImage;</span>
+<span class="add">import java.io.Serializable;</span>
+
+<span class="add">import org.geotools.geometry.DirectPosition2D;</span>
+<span class="add">import org.geotools.geometry.GeneralEnvelope;</span>
+<span class="add">import org.geotools.referencing.operation.GeneralMatrix;</span>
+<span class="add">import org.geotools.referencing.operation.transform.ProjectiveTransform;</span>
+<span class="add">import org.geotools.resources.CRSUtilities;</span>
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.gcs.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.gcs.Resources;</span>
+<span class="add">import org.opengis.coverage.CannotEvaluateException;</span>
+import org.opengis.coverage.grid.GridRange;
+<span class="add">import org.opengis.gc.GC_GridGeometry;</span>
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransform2D;
+<span class="add">import org.opengis.referencing.operation.Matrix;</span>
+<span class="add">import org.opengis.referencing.operation.NoninvertibleTransformException;</span>
+import org.opengis.referencing.operation.TransformException;
+<span class="add">import org.opengis.spatialschema.geometry.Envelope;</span>
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+
+/**
+ * Describes the valid range of grid coordinates and the math
+ * transform to transform grid coordinates to real world coordinates.</pre></td></tr>
+<tr><td><pre>this.gridFromCoordinateSystem2D = inverse(gridToCoordinateSystem2D);
+if (gridRange!=null &amp;&amp; gridToCoordinateSystem!=null) {
+    final int dimRange  = gridRange.getDimension();
+<span class="del">    final int dimSource = gridToCoordinateSystem.getDimSource();</span>
+<span class="del">    final int dimTarget = gridToCoordinateSystem.getDimTarget();</span>
+    if (dimRange != dimSource) {
+        throw new MismatchedDimensionException(format(dimRange, dimSource));
+    }</pre></td>
+<td><pre>this.gridFromCoordinateSystem2D = inverse(gridToCoordinateSystem2D);
+if (gridRange!=null &amp;&amp; gridToCoordinateSystem!=null) {
+    final int dimRange  = gridRange.getDimension();
+<span class="add">    final int dimSource = gridToCoordinateSystem.getSourceDimensions();</span>
+<span class="add">    final int dimTarget = gridToCoordinateSystem.getTargetDimensions();</span>
+    if (dimRange != dimSource) {
+        throw new MismatchedDimensionException(format(dimRange, dimSource));
+    }</pre></td></tr>
+<tr><td><pre> */
+public int getDimension() {
+    if (gridToCoordinateSystem != null) {
+<span class="del">        return gridToCoordinateSystem.getDimSource();</span>
+    }
+    return getGridRange().getDimension();
+}</pre></td>
+<td><pre> */
+public int getDimension() {
+    if (gridToCoordinateSystem != null) {
+<span class="add">        return gridToCoordinateSystem.getSourceDimensions();</span>
+    }
+    return getGridRange().getDimension();
+}</pre></td></tr>
+<tr><td><pre>public GridRange getGridRange() throws InvalidGridGeometryException {
+    if (gridRange != null) {
+        return gridRange;
+<span class="del">    } else {</span>
+        throw new InvalidGridGeometryException(Resources.format(
+                  ResourceKeys.ERROR_UNSPECIFIED_IMAGE_SIZE));
+    }
+<span class="del">}</span>
+
+/**
+ * Returns the math transform which allows  for the transformations from grid coordinates to</pre></td>
+<td><pre>public GridRange getGridRange() throws InvalidGridGeometryException {
+    if (gridRange != null) {
+        return gridRange;
+<span class="add">    }</span>
+        throw new InvalidGridGeometryException(Resources.format(
+                  ResourceKeys.ERROR_UNSPECIFIED_IMAGE_SIZE));
+    }
+
+/**
+ * Returns the math transform which allows  for the transformations from grid coordinates to</pre></td></tr>
+<tr><td><pre>public MathTransform getGridToCoordinateSystem() throws InvalidGridGeometryException {
+    if (gridToCoordinateSystem != null) {
+        return gridToCoordinateSystem;
+<span class="del">    } else {</span>
+        throw new InvalidGridGeometryException();
+    }
+<span class="del">}</span>
+
+/**
+ * Returns a math transform for the first two dimensions, if such a transform exists.</pre></td>
+<td><pre>public MathTransform getGridToCoordinateSystem() throws InvalidGridGeometryException {
+    if (gridToCoordinateSystem != null) {
+        return gridToCoordinateSystem;
+<span class="add">    }</span>
+        throw new InvalidGridGeometryException();
+    }
+
+/**
+ * Returns a math transform for the first two dimensions, if such a transform exists.</pre></td></tr>
+<tr><td><pre>        if (transform==null || transform instanceof MathTransform2D) {
+            return (MathTransform2D) transform;
+        }
+<span class="del">        final MathTransformFactory factory = FactoryFinder.getMathTransformFactory();</span>
+<span class="del">        final IntegerSequence  inputDimensions = JAIUtilities.createSequence(0, 1);</span>
+<span class="del">        final IntegerSequence outputDimensions = new IntegerSequence();</span>
+<span class="del">// TODO</span>
+//        try {
+<span class="del">//            transform = factory.createSubTransform(transform, inputDimensions, outputDimensions);</span>
+//        } catch (FactoryException exception) {
+//            // A MathTransform2D is not mandatory. Just tell that we have none.
+//            return null;</pre></td>
+<td><pre>        if (transform==null || transform instanceof MathTransform2D) {
+            return (MathTransform2D) transform;
+        }
+<span class="add">//        final MathTransformFactory factory = FactoryFinder.getMathTransformFactory();</span>
+<span class="add">//        final IntegerSequence  inputDimensions = JAIUtilities.createSequence(0, 1);</span>
+<span class="add">//        final IntegerSequence outputDimensions = new IntegerSequence();</span>
+<span class="add">//// TODO</span>
+//        try {
+<span class="add">//            transform = factory.(transform, inputDimensions, outputDimensions);</span>
+//        } catch (FactoryException exception) {
+//            // A MathTransform2D is not mandatory. Just tell that we have none.
+//            return null;</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Returns a string représentation of this grid range.</span>
+ * The returned string is implementation dependent. It
+ * is usually provided for debugging purposes.
+ */</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Returns a string repr�sentation of this grid range.</span>
+ * The returned string is implementation dependent. It
+ * is usually provided for debugging purposes.
+ */</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10867/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10867/HEADER.html?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/10867/HEADER.html (added)
+++ sis/ip-review/rev/10867/HEADER.html Mon May 28 15:15:53 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 10867</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 10867</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>dzwiers</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-01-31</td></tr>
+  <tr><td><b>Message:</b></td><td>dep fix</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/11186/GridGeometry.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/11186/GridGeometry.xhtml?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/11186/GridGeometry.xhtml (added)
+++ sis/ip-review/rev/11186/GridGeometry.xhtml Mon May 28 15:15:53 2018
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GridGeometry changes for revisions 11185:11186</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GridGeometry changes for revisions 11185:11186</h1>
+
+      <p>
+        This change is reverted for Apache SIS because we will not implement the GeoAPI <code>GridGeometry</code> interface anymore.
+        The reason is that <code>GridGeometry</code> was inferred from legacy OGC 01-004 and is not part of ISO 19123.
+      </p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r11185:11186 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridGeometry.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 11185</th><th>Revision 11186</th></tr>
+<tr><td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ */
+<span class="del">public class GridGeometry implements Serializable {</span>
+    /**
+     * Serial number for interoperability with different versions.
+     */</pre></td>
+<td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ */
+<span class="add">public class GridGeometry implements org.opengis.coverage.grid.GridGeometry, Serializable {</span>
+    /**
+     * Serial number for interoperability with different versions.
+     */</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/11186/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/11186/HEADER.html?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/11186/HEADER.html (added)
+++ sis/ip-review/rev/11186/HEADER.html Mon May 28 15:15:53 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 11186</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 11186</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>rgould</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-02-08</td></tr>
+  <tr><td><b>Message:</b></td><td>Attempts to get GridCoverage to work. Made GridGeometry implement the GeoAPI GridGeometry interface. Added GridGeometry support to GridCoverageImpl. Added GridCoverage into GridCoverageRenderer.</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/16529/GridGeometry.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/16529/GridGeometry.xhtml?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/16529/GridGeometry.xhtml (added)
+++ sis/ip-review/rev/16529/GridGeometry.xhtml Mon May 28 15:15:53 2018
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GridGeometry changes for revisions 16528:16529</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GridGeometry changes for revisions 16528:16529</h1>
+
+<p>This change is reverted for Apache SIS: we keep the exception cause.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r16528:16529 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridGeometry.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 16528</th><th>Revision 16529</th></tr>
+<tr><td><pre>    envelope = CRSUtilities.transform(gridToCRS, envelope);
+} catch (TransformException exception) {
+    throw new IllegalArgumentException(Errors.format(ErrorKeys.BAD_TRANSFORM_$1,
+<span class="del">                            Utilities.getShortClassName(gridToCRS)), exception);</span>
+}
+envelope.setCoordinateReferenceSystem(crs);
+this.envelope = envelope;</pre></td>
+<td><pre>    envelope = CRSUtilities.transform(gridToCRS, envelope);
+} catch (TransformException exception) {
+    throw new IllegalArgumentException(Errors.format(ErrorKeys.BAD_TRANSFORM_$1,
+<span class="add">                            Utilities.getShortClassName(gridToCRS))/*, exception*/);</span>
+}
+envelope.setCoordinateReferenceSystem(crs);
+this.envelope = envelope;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/16529/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/16529/HEADER.html?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/16529/HEADER.html (added)
+++ sis/ip-review/rev/16529/HEADER.html Mon May 28 15:15:53 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 16529</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 16529</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>afabiani</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-10-27</td></tr>
+  <tr><td><b>Message:</b></td><td>Very small bug fixes for Java 1.4 compiler plus first RasterSymbolizer implementation</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20970/GridGeometry.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20970/GridGeometry.xhtml?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/20970/GridGeometry.xhtml (added)
+++ sis/ip-review/rev/20970/GridGeometry.xhtml Mon May 28 15:15:53 2018
@@ -0,0 +1,266 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GridGeometry changes for revisions 20599:20970</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GridGeometry changes for revisions 20599:20970</h1>
+
+<p>This commit moves into public API some methods which were used to be package-private.
+We do not want to make such move. Some code added by this commit are for handling the half-pixel translations,
+which we do differently in Apache SIS.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20599:20970 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridGeometry.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20599</th><th>Revision 20970</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Management Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA</span>
+ */
+package org.geotools.coverage.grid;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.coverage.grid;</pre></td></tr>
+<tr><td><pre>import java.awt.image.BufferedImage;   // For javadoc
+import java.awt.image.RenderedImage;   // For javadoc
+import java.io.Serializable;
+
+// OpenGIS dependencies
+import org.opengis.coverage.grid.GridRange;</pre></td>
+<td><pre>import java.awt.image.BufferedImage;   // For javadoc
+import java.awt.image.RenderedImage;   // For javadoc
+import java.io.Serializable;
+<span class="add">import java.util.MissingResourceException;</span>
+
+// OpenGIS dependencies
+import org.opengis.coverage.grid.GridRange;</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Constructs a new grid geometry from a {@linkplain MathTransform math transform}. This is</span>
+ * the most general constructor, the one that gives the maximal control on the grid geometry
+ * to be created.
+ *</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Constructs a new grid geometry from a math transform.</span>
+<span class="add"> *</span>
+<span class="add"> * @param gridRange</span>
+<span class="add"> *            The valid coordinate range of a grid coverage, or {@code null}</span>
+<span class="add"> *            if none.</span>
+<span class="add"> * @param gridToCRS</span>
+<span class="add"> *            The math transform which allows for the transformations from</span>
+<span class="add"> *            grid coordinates (pixel's &lt;em&gt;center&lt;/em&gt;) to real world</span>
+<span class="add"> *            earth coordinates.</span>
+<span class="add"> *</span>
+<span class="add"> * @deprecated Replaced by</span>
+<span class="add"> *             &lt;code&gt;{@linkplain #GeneralGridGeometry(GridRange, MathTransform,</span>
+<span class="add"> *             CoordinateReferenceSystem) GeneralGridGeometry}(gridRange, gridToCRS, null)&lt;/code&gt;.</span>
+<span class="add"> */</span>
+<span class="add">public GeneralGridGeometry(final GridRange gridRange,</span>
+<span class="add">     final MathTransform gridToCRS) {</span>
+<span class="add">   this(gridRange, gridToCRS, (CoordinateReferenceSystem) null);</span>
+<span class="add">}</span>
+<span class="add"></span>
+<span class="add">/**</span>
+<span class="add"> * Constructs a new grid geometry from a</span>
+<span class="add"> * {@linkplain MathTransform math transform}. This is the most general</span>
+ * the most general constructor, the one that gives the maximal control on the grid geometry
+ * to be created.
+ *</pre></td></tr>
+<tr><td><pre>{
+    this.gridRange = gridRange;
+    this.gridToCRS = gridToCRS;
+    if (gridRange!=null &amp;&amp; gridToCRS!=null) {
+        /*
+         * Checks arguments.</pre></td>
+<td><pre>{
+    this.gridRange = gridRange;
+    this.gridToCRS = gridToCRS;
+<span class="add">   envelope = getEnvelope(gridRange, gridToCRS, crs, true);</span>
+<span class="add">}</span>
+<span class="add"></span>
+<span class="add">/**</span>
+<span class="add"> * @param gridRange</span>
+<span class="add"> * @param gridToCRS</span>
+<span class="add"> * @param crs</span>
+<span class="add"> * @throws MismatchedDimensionException</span>
+<span class="add"> * @throws IllegalArgumentException</span>
+<span class="add"> * @throws MissingResourceException</span>
+<span class="add"> */</span>
+<span class="add">public static GeneralEnvelope getEnvelope(final GridRange gridRange,</span>
+<span class="add">     final MathTransform gridToCRS, final CoordinateReferenceSystem crs,</span>
+<span class="add">     final boolean halfPix) throws MismatchedDimensionException,</span>
+<span class="add">     IllegalArgumentException, MissingResourceException {</span>
+    if (gridRange!=null &amp;&amp; gridToCRS!=null) {
+        /*
+         * Checks arguments.</pre></td></tr>
+<tr><td><pre>            // TODO: uncomment the exception cause when we will be allowed to target J2SE 1.5.
+        }
+        envelope.setCoordinateReferenceSystem(crs);
+<span class="del">        this.envelope = envelope;</span>
+    } else if (crs != null) {
+<span class="del">        envelope = new GeneralEnvelope(crs);</span>
+<span class="del">        envelope.setToNull();</span>
+    } else {
+<span class="del">        envelope = null;</span>
+    }
+}</pre></td>
+<td><pre>            // TODO: uncomment the exception cause when we will be allowed to target J2SE 1.5.
+        }
+        envelope.setCoordinateReferenceSystem(crs);
+<span class="add">        return envelope;</span>
+    } else if (crs != null) {
+<span class="add">     GeneralEnvelope retEnvelope = new GeneralEnvelope(crs);</span>
+<span class="add">     retEnvelope.setToNull();</span>
+<span class="add">     return retEnvelope;</span>
+    } else {
+<span class="add">     return null;</span>
+    }
+}</pre></td></tr>
+<tr><td><pre>}
+
+/**
+ * Constructs a new grid geometry from an {@linkplain Envelope envelope}. An
+ * {@linkplain AffineTransform affine transform} will be computed automatically from the
+ * specified envelope. The two last arguments ({@code swapXY} and {@code reverse}) are hints</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Constructs a new grid geometry from an envelope.</span>
+<span class="add"> *</span>
+<span class="add"> * @deprecated Replaced by</span>
+<span class="add"> *             {@code GeneralGridGeometry(gridRange, userRange, reverse, false)}.</span>
+<span class="add"> *             Users just need to append the {@code false} argument value,</span>
+<span class="add"> *             so this constructor will be removed in a future version in</span>
+<span class="add"> *             order to keep the API lighter.</span>
+<span class="add"> */</span>
+<span class="add">public GeneralGridGeometry(final GridRange gridRange,</span>
+<span class="add">     final Envelope userRange, final boolean[] reverse) {</span>
+<span class="add">   this(gridRange, userRange, reverse, false);</span>
+<span class="add">}</span>
+<span class="add">/**</span>
+ * Constructs a new grid geometry from an {@linkplain Envelope envelope}. An
+ * {@linkplain AffineTransform affine transform} will be computed automatically from the
+ * specified envelope. The two last arguments ({@code swapXY} and {@code reverse}) are hints</pre></td></tr>
+<tr><td><pre>{
+    this.gridRange = gridRange;
+    this.envelope  = new GeneralEnvelope(userRange);
+    /*
+     * Checks arguments validity. Grid range and envelope dimensions must match.
+     * We are more tolerant for the coordinate system dimension (if any), since</pre></td>
+<td><pre>{
+    this.gridRange = gridRange;
+    this.envelope  = new GeneralEnvelope(userRange);
+<span class="add">   gridToCRS = getTransform(gridRange, userRange, reverse, swapXY, true);</span>
+<span class="add">}</span>
+<span class="add"></span>
+<span class="add">/**</span>
+<span class="add"> * @param gridRange</span>
+<span class="add"> * @param userRange</span>
+<span class="add"> * @param reverse</span>
+<span class="add"> * @param swapXY</span>
+<span class="add"> * @param b</span>
+<span class="add"> * @return</span>
+<span class="add"> * @throws MismatchedDimensionException</span>
+<span class="add"> */</span>
+<span class="add">public static MathTransform getTransform(final GridRange gridRange,</span>
+<span class="add">     final Envelope userRange, final boolean[] reverse,</span>
+<span class="add">     final boolean swapXY, boolean halfPix)</span>
+<span class="add">     throws MismatchedDimensionException {</span>
+    /*
+     * Checks arguments validity. Grid range and envelope dimensions must match.
+     * We are more tolerant for the coordinate system dimension (if any), since</pre></td></tr>
+<tr><td><pre>            scale  = -scale;
+            offset = userRange.getMaximum(j);
+        }
+<span class="del">        offset -= scale * (gridRange.getLower(i)-0.5);</span>
+        matrix.setElement(j, j,         0.0   );
+        matrix.setElement(j, i,         scale );
+        matrix.setElement(j, dimension, offset);
+    }
+<span class="del">    gridToCRS = ProjectiveTransform.create(matrix);</span>
+}
+
+/**
+ * Returns the coordinate system in use with the specified envelope. This method
+ * is invoked by the {@link #GeneralGridGeometry(GridRange,Envelope)} constructor.</pre></td>
+<td><pre>            scale  = -scale;
+            offset = userRange.getMaximum(j);
+        }
+<span class="add">     offset -= scale * (gridRange.getLower(i) - (halfPix ? 0.5 : 0));</span>
+        matrix.setElement(j, j,         0.0   );
+        matrix.setElement(j, i,         scale );
+        matrix.setElement(j, dimension, offset);
+    }
+<span class="add">   return ProjectiveTransform.create(matrix);</span>
+}
+
+<span class="add">public static MathTransform getTransform(final GridRange gridRange,</span>
+<span class="add">     final Envelope userRange, boolean halfPix)</span>
+<span class="add">     throws MismatchedDimensionException {</span>
+<span class="add">   final CoordinateSystem cs = getCoordinateSystem(userRange);</span>
+<span class="add">   return getTransform(gridRange, userRange, reverse(cs), swapXY(cs),</span>
+<span class="add">      halfPix);</span>
+<span class="add">}</span>
+/**
+ * Returns the coordinate system in use with the specified envelope. This method
+ * is invoked by the {@link #GeneralGridGeometry(GridRange,Envelope)} constructor.</pre></td></tr>
+<tr><td><pre> * Applies heuristic rules in order to determine which axis should be reversed. This
+ * method is invoked by the {@link #GeneralGridGeometry(GridRange,Envelope)} constructor.
+ */
+<span class="del">static boolean[] reverse(final CoordinateSystem cs) {</span>
+    if (cs == null) {
+        return null;
+    }</pre></td>
+<td><pre> * Applies heuristic rules in order to determine which axis should be reversed. This
+ * method is invoked by the {@link #GeneralGridGeometry(GridRange,Envelope)} constructor.
+ */
+<span class="add">static public boolean[] reverse(final CoordinateSystem cs) {</span>
+    if (cs == null) {
+        return null;
+    }</pre></td></tr>
+<tr><td><pre> * Applies heuristic rules in order to determine if the two first axis should be interchanged.
+ * This method is invoked by the {@link #GeneralGridGeometry(GridRange,Envelope)} constructor.
+ */
+<span class="del">static boolean swapXY(final CoordinateSystem cs) {</span>
+    boolean swapXY = false;
+    if (cs!=null &amp;&amp; cs.getDimension() &gt;= 2) {
+        swapXY = AxisDirection.NORTH.equals(cs.getAxis(0).getDirection().absolute()) &amp;&amp;</pre></td>
+<td><pre> * Applies heuristic rules in order to determine if the two first axis should be interchanged.
+ * This method is invoked by the {@link #GeneralGridGeometry(GridRange,Envelope)} constructor.
+ */
+<span class="add">static public boolean swapXY(final CoordinateSystem cs) {</span>
+    boolean swapXY = false;
+    if (cs!=null &amp;&amp; cs.getDimension() &gt;= 2) {
+        swapXY = AxisDirection.NORTH.equals(cs.getAxis(0).getDirection().absolute()) &amp;&amp;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/24925/GridGeometry.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/GridGeometry.xhtml?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/24925/GridGeometry.xhtml (added)
+++ sis/ip-review/rev/24925/GridGeometry.xhtml Mon May 28 15:15:53 2018
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GridGeometry changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GridGeometry changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridGeometry.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.TransformException;
+import org.geotools.referencing.operation.transform.ConcatenatedTransform;
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="del">import org.opengis.spatialschema.geometry.Envelope;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.geometry.GeneralEnvelope;</pre></td>
+<td><pre>import org.opengis.referencing.operation.TransformException;
+import org.geotools.referencing.operation.transform.ConcatenatedTransform;
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+<span class="add">import org.opengis.geometry.Envelope;</span>
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.geometry.GeneralEnvelope;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/29962/GridGeometry.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/29962/GridGeometry.xhtml?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/29962/GridGeometry.xhtml (added)
+++ sis/ip-review/rev/29962/GridGeometry.xhtml Mon May 28 15:15:53 2018
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>GridGeometry changes for revisions 29961:29962</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>GridGeometry changes for revisions 29961:29962</h1>
+
+      <p>This kind of typos are now identified by NetBeans spell checker.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r29961:29962 http://svn.osgeo.org/geotools/trunk/modules/library/coverage/src/main/java/org/geotools/coverage/grid/GeneralGridGeometry.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 29961</th><th>Revision 29962</th></tr>
+<tr><td><pre>*                  {@link PixelInCell#CELL_CORNER CELL_CORNER} for Java2D/JAI conventions.
+* @param gridToCRS The math transform which allows for the transformations from grid
+*                  coordinates to real world earth coordinates. May be {@code null},
+<span class="del">*                  but this is not recommanded.</span>
+* @param envelope  The envelope (including CRS) of a grid coverage, or {@code null} if none.
+*
+* @throws MismatchedDimensionException if the math transform and the envelope doesn't have</pre></td>
+<td><pre>*                  {@link PixelInCell#CELL_CORNER CELL_CORNER} for Java2D/JAI conventions.
+* @param gridToCRS The math transform which allows for the transformations from grid
+*                  coordinates to real world earth coordinates. May be {@code null},
+<span class="add">*                  but this is not recommended.</span>
+* @param envelope  The envelope (including CRS) of a grid coverage, or {@code null} if none.
+*
+* @throws MismatchedDimensionException if the math transform and the envelope doesn't have</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/29962/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/29962/HEADER.html?rev=1832403&view=auto
==============================================================================
--- sis/ip-review/rev/29962/HEADER.html (added)
+++ sis/ip-review/rev/29962/HEADER.html Mon May 28 15:15:53 2018
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 29962</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 29962</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>simboss</td></tr>
+  <tr><td><b>Date:</b></td><td>2008-04-17</td></tr>
+  <tr><td><b>Message:</b></td><td>-typos</td></tr>
+</table>
+    </div>
+  </body>
+</html>



Mime
View raw message