sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1813514 - in /sis/branches/JDK8/core: sis-referencing/src/main/java/org/apache/sis/referencing/operation/CoordinateOperationFinder.java sis-utility/src/main/java/org/apache/sis/internal/util/CollectionsExt.java
Date Fri, 27 Oct 2017 12:00:48 GMT
Author: desruisseaux
Date: Fri Oct 27 12:00:48 2017
New Revision: 1813514

URL: http://svn.apache.org/viewvc?rev=1813514&view=rev
Log:
Notes about futur work that still need to be done after 0.8 release.

Modified:
    sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/CoordinateOperationFinder.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/util/CollectionsExt.java

Modified: sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/CoordinateOperationFinder.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/CoordinateOperationFinder.java?rev=1813514&r1=1813513&r2=1813514&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/CoordinateOperationFinder.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/CoordinateOperationFinder.java
[UTF-8] Fri Oct 27 12:00:48 2017
@@ -507,6 +507,9 @@ public class CoordinateOperationFinder e
                 /*
                  * Failed to select a coordinate operation. Maybe because the coordinate
system types are not the same.
                  * Convert unconditionally to XYZ geocentric coordinates and apply the datum
shift in that CS space.
+                 *
+                 * TODO: operation name should not be "Affine" if 'before' or 'after' transforms
are not identity.
+                 *       Reminder: the parameter group name here determines the OperationMethod
later in this method.
                  */
                 if (datumShift != null) {
                     parameters = TensorParameters.WKT1.createValueGroup(properties(Constants.AFFINE),
datumShift);
@@ -536,6 +539,12 @@ public class CoordinateOperationFinder e
                 parameters = (sourceDim == 2 ? Geographic2Dto3D.PARAMETERS
                                              : Geographic3Dto2D.PARAMETERS).createValue();
             } else {
+                /*
+                 * TODO: instead than creating parameters for an identity operation, we should
create the
+                 *       CoordinateOperation directly from the MathTransform created by mtFactory
below.
+                 *       The intend if to get the correct OperationMethod, which should not
be "Affine"
+                 *       if there is a CS type change.
+                 */
                 parameters = Affine.identity(targetDim);
                 /*
                  * createCoordinateSystemChange(…) needs the ellipsoid associated to the
ellipsoidal coordinate system,

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/util/CollectionsExt.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/util/CollectionsExt.java?rev=1813514&r1=1813513&r2=1813514&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/util/CollectionsExt.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/util/CollectionsExt.java
[UTF-8] Fri Oct 27 12:00:48 2017
@@ -321,6 +321,8 @@ public final class CollectionsExt extend
      * @return a set containing the array elements, or {@code null} if the given array was
null.
      *
      * @see Collections#unmodifiableSet(Set)
+     *
+     * @todo Consider replacing by {@code Set.of(...)} in JDK9.
      */
     @SafeVarargs
     @SuppressWarnings("fallthrough")



Mime
View raw message