sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1789939 - in /sis/branches/JDK8: ./ application/sis-webapp/src/main/java/org/apache/sis/index/tree/ core/sis-build-helper/src/main/java/org/apache/sis/internal/book/ core/sis-build-helper/src/main/java/org/apache/sis/internal/doclet/ core/...
Date Mon, 03 Apr 2017 10:02:24 GMT
Author: desruisseaux
Date: Mon Apr  3 10:02:24 2017
New Revision: 1789939

URL: http://svn.apache.org/viewvc?rev=1789939&view=rev
Log:
Complete the selection of Checkstyle rules (except javadoc rules, which can not be activated
for now).

Modified:
    sis/branches/JDK8/application/sis-webapp/src/main/java/org/apache/sis/index/tree/QuadTreeReader.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_en.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_fr.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/doclet/Doclet.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/Assembler.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/BundleCreator.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/JarCollector.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/taglet/Preformat.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/JavaMaker.java
    sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/UnoPkg.java
    sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/distance/DistanceUtils.java
    sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/parameter/DefaultParameterValue.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gco/UnitAdapter.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gml/CodeType.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/ServletListener.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/ArgumentChecks.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/BackingStoreException.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/IntegerList.java
    sis/branches/JDK8/pom.xml
    sis/branches/JDK8/storage/sis-storage/src/main/java/org/apache/sis/index/tree/QuadTreeWriter.java

Modified: sis/branches/JDK8/application/sis-webapp/src/main/java/org/apache/sis/index/tree/QuadTreeReader.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/application/sis-webapp/src/main/java/org/apache/sis/index/tree/QuadTreeReader.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/application/sis-webapp/src/main/java/org/apache/sis/index/tree/QuadTreeReader.java
[UTF-8] (original)
+++ sis/branches/JDK8/application/sis-webapp/src/main/java/org/apache/sis/index/tree/QuadTreeReader.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -30,7 +30,9 @@ import org.apache.sis.geometry.DirectPos
  * Class to reload the quad tree index from file.
  *
  */
-public class QuadTreeReader {
+public final class QuadTreeReader {
+  private QuadTreeReader() {
+  }
 
   /**
    * Loads the quad tree index from file.

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -27,6 +27,17 @@ import java.util.ListResourceBundle;
  * @since   0.7
  */
 public class Resources extends ListResourceBundle {
+    /**
+     * Invoked by resource bundle reflection mechanism.
+     */
+    public Resources() {
+    }
+
+    /**
+     * Returns resources as pair of key-value.
+     *
+     * @return an array of key-value pairs.
+     */
     @Override
     protected Object[][] getContents() {
         return new Object[][] {

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_en.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_en.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_en.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_en.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -25,4 +25,9 @@ package org.apache.sis.internal.book;
  * @since   0.7
  */
 public final class Resources_en extends Resources {
+    /**
+     * Invoked by resource bundle reflection mechanism.
+     */
+    public Resources_en() {
+    }
 }

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_fr.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_fr.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_fr.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/book/Resources_fr.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -25,6 +25,17 @@ package org.apache.sis.internal.book;
  * @since   0.7
  */
 public final class Resources_fr extends Resources {
+    /**
+     * Invoked by resource bundle reflection mechanism.
+     */
+    public Resources_fr() {
+    }
+
+    /**
+     * Returns resources as pair of key-value.
+     *
+     * @return an array of key-value pairs.
+     */
     @Override
     protected Object[][] getContents() {
         final Object[][] resources = super.getContents();

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/doclet/Doclet.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/doclet/Doclet.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/doclet/Doclet.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/doclet/Doclet.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -76,6 +76,12 @@ public final class Doclet extends HtmlDo
     private static final String ENCODING = "UTF-8";
 
     /**
+     * Invoked by reflection for creating the doclet.
+     */
+    public Doclet() {
+    }
+
+    /**
      * Invoked by Javadoc for starting the doclet.
      *
      * @param  root  the root document.

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/Assembler.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/Assembler.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/Assembler.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/Assembler.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -68,6 +68,12 @@ public class Assembler extends AbstractM
     private String rootDirectory;
 
     /**
+     * Invoked by reflection for creating the MOJO.
+     */
+    public Assembler() {
+    }
+
+    /**
      * Creates the distribution file.
      *
      * @throws MojoExecutionException if the plugin execution failed.

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/BundleCreator.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/BundleCreator.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/BundleCreator.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/BundleCreator.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -62,6 +62,12 @@ public class BundleCreator extends Abstr
     private String rootDirectory;
 
     /**
+     * Invoked by reflection for creating the MOJO.
+     */
+    public BundleCreator() {
+    }
+
+    /**
      * Creates the Pack200 file from the JAR files collected in the "<code>target/binaries</code>"
directory.
      *
      * @throws MojoExecutionException if the plugin execution failed.

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/JarCollector.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/JarCollector.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/JarCollector.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/maven/JarCollector.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -69,6 +69,12 @@ public final class JarCollector extends
     private String rootDirectory;
 
     /**
+     * Invoked by reflection for creating the MOJO.
+     */
+    public JarCollector() {
+    }
+
+    /**
      * Copies the {@code *.jar} files to the collect directory.
      *
      * @throws MojoExecutionException if the plugin execution failed.

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/taglet/Preformat.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/taglet/Preformat.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/taglet/Preformat.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/taglet/Preformat.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -173,7 +173,7 @@ all:    while (tk.hasMoreTokens()) {
      * Adds syntactic coloration for the given line.
      */
     private static void colorJava(final String line, final StringBuilder buffer) {
-        char quote = 0; // The kind of quoting in progress (" or ').
+        char quote = 0;                             // The kind of quoting in progress ("
or ').
         final int length = line.length();
         for (int i=0; i<length; i++) {
             final char c = line.charAt(i);

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/JavaMaker.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/JavaMaker.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/JavaMaker.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/JavaMaker.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -58,6 +58,12 @@ public final class JavaMaker extends Abs
     private String outputDirectory;
 
     /**
+     * Invoked by reflection for creating the MOJO.
+     */
+    public JavaMaker() {
+    }
+
+    /**
      * Copies the {@code .class} files generated by OpenOffice.
      *
      * @throws MojoExecutionException if the plugin execution failed.

Modified: sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/UnoPkg.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/UnoPkg.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/UnoPkg.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-build-helper/src/main/java/org/apache/sis/internal/unopkg/UnoPkg.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -112,6 +112,12 @@ public final class UnoPkg extends Abstra
     private transient String prefixGroup;
 
     /**
+     * Invoked by reflection for creating the MOJO.
+     */
+    public UnoPkg() {
+    }
+
+    /**
      * Tests if a specified file should be included in a file list.
      *
      * @param  directory  the directory in which the file was found.

Modified: sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/distance/DistanceUtils.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/distance/DistanceUtils.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/distance/DistanceUtils.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/distance/DistanceUtils.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -28,7 +28,9 @@ import org.apache.sis.geometry.DirectPos
  * performs computations on a sphere of hard-coded radius. A future implementation should
perform computations
  * on a given ellipsoid.</div>
  */
-public class DistanceUtils {
+public final class DistanceUtils {
+  private DistanceUtils() {
+  }
 
   public static final int EARTH_RADIUS = 6371; // in km
   public static final double HALF_EARTH_CIRCUMFERENCE = 20037.58; // in km

Modified: sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/parameter/DefaultParameterValue.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/parameter/DefaultParameterValue.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/parameter/DefaultParameterValue.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/parameter/DefaultParameterValue.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -517,22 +517,22 @@ public class DefaultParameterValue<T> ex
      * Same as {@link #isFile(Object)}, but accepts also a {@link String} if the type specified
      * in the parameter descriptor is one of the types documented in {@link #valueFile()}.
      */
-    private boolean isOrNeedFile(final Object value) {
-        if (value instanceof String) {
+    private boolean isOrNeedFile(final Object newValue) {
+        if (newValue instanceof String) {
             final Class<?> type = descriptor.getValueClass();
             return (type == URI.class) || (type == URL.class)
                    || Path.class.isAssignableFrom(type)
                    || File.class.isAssignableFrom(type);
         }
-        return isFile(value);
+        return isFile(newValue);
     }
 
     /**
      * Returns the exception to throw when an incompatible method is invoked for the value
type.
      */
-    private IllegalStateException missingOrIncompatibleValue(final Object value) {
+    private IllegalStateException missingOrIncompatibleValue(final Object newValue) {
         final String name = Verifier.getDisplayName(descriptor);
-        if (value != null) {
+        if (newValue != null) {
             return new InvalidParameterTypeException(getClassTypeError(), name);
         }
         return new IllegalStateException(Resources.format(Resources.Keys.MissingValueForParameter_1,
name));
@@ -556,22 +556,22 @@ public class DefaultParameterValue<T> ex
      * This implementation does not clone the given value. In particular, references to {@code
int[]}
      * and {@code double[]} arrays are stored <cite>as-is</cite>.</p>
      *
-     * @param  value  the parameter value, or {@code null} to restore the default.
+     * @param  newValue  the parameter value, or {@code null} to restore the default.
      * @throws InvalidParameterValueException if the type of {@code value} is inappropriate
for this parameter,
      *         or if the value is illegal for some other reason (for example the value is
numeric and out of range).
      *
      * @see #getValue()
      */
     @Override
-    public void setValue(Object value) throws InvalidParameterValueException {
+    public void setValue(Object newValue) throws InvalidParameterValueException {
         /*
          * Try to convert the value only for a limited amount of types. In particular we
want to allow conversions
          * between java.io.File and java.nio.file.Path for easier transition between JDK6
and JDK7. We do not want
          * to allow too many conversions for reducing the risk of unexpected behavior.  If
we fail to convert, try
          * to set the value anyway since the user may have redefined the setValue(Object,
Unit) method.
          */
-        if (isOrNeedFile(value)) try {
-            value = ObjectConverters.convert(value, descriptor.getValueClass());
+        if (isOrNeedFile(newValue)) try {
+            newValue = ObjectConverters.convert(newValue, descriptor.getValueClass());
         } catch (UnconvertibleObjectException e) {
             // Level.FINE (not WARNING) because this log duplicates the exception
             // that 'setValue(Object, Unit)' may throw (with a better message).
@@ -582,7 +582,7 @@ public class DefaultParameterValue<T> ex
          * Use 'unit' instead than 'getUnit()' despite class Javadoc claims because units
are not expected
          * to be involved in this method. We just want the current unit setting to be unchanged.
          */
-        setValue(value, unit);
+        setValue(newValue, unit);
     }
 
     /**
@@ -590,16 +590,16 @@ public class DefaultParameterValue<T> ex
      *
      * <p>The default implementation delegates to {@link #setValue(Object, Unit)}.</p>
      *
-     * @param  value  the parameter value.
+     * @param  newValue  the parameter value.
      * @throws InvalidParameterValueException if the boolean type is inappropriate for this
parameter.
      *
      * @see #booleanValue()
      */
     @Override
-    public void setValue(final boolean value) throws InvalidParameterValueException {
+    public void setValue(final boolean newValue) throws InvalidParameterValueException {
         // Use 'unit' instead than 'getUnit()' despite class Javadoc claims because units
are not expected
         // to be involved in this method. We just want the current unit setting to be unchanged.
-        setValue(value, unit);
+        setValue(newValue, unit);
     }
 
     /**
@@ -608,20 +608,20 @@ public class DefaultParameterValue<T> ex
      * <p>The default implementation wraps the given integer in an object of the type
specified by the
      * {@linkplain #getDescriptor() descriptor}, then delegates to {@link #setValue(Object,
Unit)}.</p>
      *
-     * @param  value  the parameter value.
+     * @param  newValue  the parameter value.
      * @throws InvalidParameterValueException if the integer type is inappropriate for this
parameter,
      *         or if the value is illegal for some other reason (for example a value out
of range).
      *
      * @see #intValue()
      */
     @Override
-    public void setValue(final int value) throws InvalidParameterValueException {
-        Number n = value;
+    public void setValue(final int newValue) throws InvalidParameterValueException {
+        Number n = newValue;
         final Class<T> valueClass = descriptor.getValueClass();
         if (Number.class.isAssignableFrom(valueClass)) {
             @SuppressWarnings("unchecked")
-            final Number c = Numbers.cast(value, (Class<? extends Number>) valueClass);
-            if (c.intValue() == value) {
+            final Number c = Numbers.cast(newValue, (Class<? extends Number>) valueClass);
+            if (c.intValue() == newValue) {
                 n = c;
             }
         }
@@ -650,7 +650,7 @@ public class DefaultParameterValue<T> ex
      * <p>The default implementation wraps the given number in an object of the type
specified by the
      * {@linkplain #getDescriptor() descriptor}, then delegates to {@link #setValue(Object,
Unit)}.</p>
      *
-     * @param  value  the parameter value.
+     * @param  newValue  the parameter value.
      * @throws InvalidParameterValueException if the floating point type is inappropriate
for this parameter,
      *         or if the value is illegal for some other reason (for example a value out
of range).
      *
@@ -658,13 +658,13 @@ public class DefaultParameterValue<T> ex
      * @see #doubleValue()
      */
     @Override
-    public void setValue(final double value) throws InvalidParameterValueException {
+    public void setValue(final double newValue) throws InvalidParameterValueException {
         try {
             // Use 'unit' instead than 'getUnit()' despite class Javadoc claims because units
are not expected
             // to be involved in this method. We just want the current unit setting to be
unchanged.
-            setValue(wrap(value, descriptor.getValueClass()), unit);
+            setValue(wrap(newValue, descriptor.getValueClass()), unit);
         } catch (IllegalArgumentException e) {
-            throw new InvalidParameterValueException(e.getLocalizedMessage(), Verifier.getDisplayName(descriptor),
value);
+            throw new InvalidParameterValueException(e.getLocalizedMessage(), Verifier.getDisplayName(descriptor),
newValue);
         }
     }
 
@@ -674,8 +674,8 @@ public class DefaultParameterValue<T> ex
      * <p>The default implementation wraps the given number in an object of the type
specified by the
      * {@linkplain #getDescriptor() descriptor}, then delegates to {@link #setValue(Object,
Unit)}.</p>
      *
-     * @param  value  the parameter value.
-     * @param  unit   the unit for the specified value.
+     * @param  newValue  the parameter value.
+     * @param  unit      the unit for the specified value.
      * @throws InvalidParameterValueException if the floating point type is inappropriate
for this parameter,
      *         or if the value is illegal for some other reason (for example a value out
of range).
      *
@@ -683,14 +683,14 @@ public class DefaultParameterValue<T> ex
      * @see #doubleValue(Unit)
      */
     @Override
-    public void setValue(final double value, final Unit<?> unit) throws InvalidParameterValueException
{
+    public void setValue(final double newValue, final Unit<?> unit) throws InvalidParameterValueException
{
         try {
-            setValue(wrap(value, descriptor.getValueClass()), unit);
+            setValue(wrap(newValue, descriptor.getValueClass()), unit);
         } catch (InvalidParameterValueException e) {
             throw e;        // Need to be thrown explicitely because it is a subclass of
IllegalArgumentException.
         } catch (IllegalArgumentException e) {
             throw (InvalidParameterValueException) new InvalidParameterValueException(
-                    e.getLocalizedMessage(), Verifier.getDisplayName(descriptor), value).initCause(e);
+                    e.getLocalizedMessage(), Verifier.getDisplayName(descriptor), newValue).initCause(e);
         }
     }
 
@@ -699,14 +699,14 @@ public class DefaultParameterValue<T> ex
      *
      * <p>The default implementation delegates to {@link #setValue(Object, Unit)}.</p>
      *
-     * @param  values  the parameter values.
-     * @param  unit    the unit for the specified value.
+     * @param  newValues  the parameter values.
+     * @param  unit       the unit for the specified value.
      * @throws InvalidParameterValueException if the floating point array type is inappropriate
for this parameter,
      *         or if the value is illegal for some other reason (for example a value out
of range).
      */
     @Override
-    public void setValue(final double[] values, final Unit<?> unit) throws InvalidParameterValueException
{
-        setValue((Object) values, unit);
+    public void setValue(final double[] newValues, final Unit<?> unit) throws InvalidParameterValueException
{
+        setValue((Object) newValues, unit);
     }
 
     /**
@@ -722,19 +722,19 @@ public class DefaultParameterValue<T> ex
      * subclasses can override if they want to perform more processing on the value before
its storage,
      * or to be notified about value changes.
      *
-     * @param  value  the parameter value, or {@code null} to restore the default.
-     * @param  unit   the unit associated to the new parameter value, or {@code null}.
+     * @param  newValue  the parameter value, or {@code null} to restore the default.
+     * @param  unit      the unit associated to the new parameter value, or {@code null}.
      * @throws InvalidParameterValueException if the type of {@code value} is inappropriate
for this parameter,
      *         or if the value is illegal for some other reason (for example the value is
numeric and out of range).
      *
      * @see #validate(Object)
      */
     @SuppressWarnings("unchecked")
-    protected void setValue(final Object value, final Unit<?> unit) throws InvalidParameterValueException
{
-        final T convertedValue = Verifier.ensureValidValue(descriptor, value, unit);
-        if (value != null) {
+    protected void setValue(final Object newValue, final Unit<?> unit) throws InvalidParameterValueException
{
+        final T convertedValue = Verifier.ensureValidValue(descriptor, newValue, unit);
+        if (newValue != null) {
             validate(convertedValue);
-            this.value = (T) value;                 // Type has been verified by Verifier.ensureValidValue(…).
+            this.value = (T) newValue;              // Type has been verified by Verifier.ensureValidValue(…).
         } else {
             this.value = descriptor.getDefaultValue();
         }
@@ -757,10 +757,10 @@ public class DefaultParameterValue<T> ex
      * {@linkplain DefaultParameterDescriptor#getValidValues() valid values} are performed
      * before this method is invoked. The default implementation of this method does nothing.
      *
-     * @param  value  the value converted to the unit of measurement specified by the descriptor.
+     * @param  newValue  the value converted to the unit of measurement specified by the
descriptor.
      * @throws InvalidParameterValueException if the given value is invalid for implementation-specific
reasons.
      */
-    protected void validate(final T value) throws InvalidParameterValueException {
+    protected void validate(final T newValue) throws InvalidParameterValueException {
     }
 
     /**

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gco/UnitAdapter.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gco/UnitAdapter.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gco/UnitAdapter.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gco/UnitAdapter.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -36,6 +36,12 @@ import org.apache.sis.internal.jaxb.gml.
  */
 public class UnitAdapter extends XmlAdapter<String, Unit<?>> {
     /**
+     * Invoked by reflection by JAXB.
+     */
+    public UnitAdapter() {
+    }
+
+    /**
      * Returns a unit for the given string.
      *
      * @param  value  the unit symbol.

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gml/CodeType.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gml/CodeType.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gml/CodeType.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/jaxb/gml/CodeType.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -77,6 +77,12 @@ public class CodeType {
     String codeSpace;
 
     /**
+     * Invoked by reflection by JAXB on unmarshalling.
+     */
+    public CodeType() {
+    }
+
+    /**
      * Sets the value from the given name.
      *
      * @param name  the name to marshal.

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/ServletListener.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/ServletListener.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/ServletListener.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/ServletListener.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -36,6 +36,12 @@ import javax.servlet.annotation.WebListe
 @WebListener("Apache SIS shutdown hook")
 public final class ServletListener implements ServletContextListener {
     /**
+     * Invoked by reflection by the container.
+     */
+    public ServletListener() {
+    }
+
+    /**
      * Receives notification that the web application initialization process is starting.
      *
      * @param  event  the context of the servlet being initialized.

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/ArgumentChecks.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/ArgumentChecks.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/ArgumentChecks.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/ArgumentChecks.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -407,9 +407,8 @@ public final class ArgumentChecks extend
      * @throws IllegalArgumentException if the given value is NaN or infinite.
      */
     public static void ensureFinite(final String name, final float value) {
-        final boolean isNaN;
-        if ((isNaN = Float.isNaN(value)) == true || Float.isInfinite(value)) {
-            throw new IllegalArgumentException(Errors.format(isNaN ?
+        if (!Float.isFinite(value)) {
+            throw new IllegalArgumentException(Errors.format(Float.isNaN(value) ?
                     Errors.Keys.NotANumber_1 : Errors.Keys.InfiniteArgumentValue_1, name));
         }
     }
@@ -424,9 +423,8 @@ public final class ArgumentChecks extend
      * @throws IllegalArgumentException if the given value is NaN or infinite.
      */
     public static void ensureFinite(final String name, final double value) {
-        final boolean isNaN;
-        if ((isNaN = Double.isNaN(value)) == true || Double.isInfinite(value)) {
-            throw new IllegalArgumentException(Errors.format(isNaN ?
+        if (!Double.isFinite(value)) {
+            throw new IllegalArgumentException(Errors.format(Double.isNaN(value) ?
                     Errors.Keys.NotANumber_1 : Errors.Keys.InfiniteArgumentValue_1, name));
         }
     }

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/BackingStoreException.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/BackingStoreException.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/BackingStoreException.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/BackingStoreException.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -98,10 +98,8 @@ public class BackingStoreException exten
      * or re-throw the exception. More specifically, this method makes the following choices:
      *
      * <ul>
-     *   <li>If the cause {@linkplain Class#isInstance(Object) is an instance} of the
given
-     *       type, returns the cause.</li>
-     *   <li>Otherwise if the cause is an instance of {@link RuntimeException}, throws
-     *       that exception.</li>
+     *   <li>If the cause {@linkplain Class#isInstance(Object) is an instance} of the
given type, returns the cause.</li>
+     *   <li>Otherwise if the cause is an instance of {@link RuntimeException}, throws
that exception.</li>
      *   <li>Otherwise re-throws {@code this}.</li>
      * </ul>
      *

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/IntegerList.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/IntegerList.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/IntegerList.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/util/collection/IntegerList.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -116,13 +116,13 @@ public class IntegerList extends Abstrac
     /**
      * Returns the array length required for holding a list of the given size.
      *
-     * @param  size  the list size.
+     * @param  capacity  the desired list size.
      * @return the array length for holding a list of the given size.
      */
-    private int length(int size) {
-        size *= bitCount;
-        int length = size >>> BASE_SHIFT;
-        if ((size & OFFSET_MASK) != 0) {
+    private int length(int capacity) {
+        capacity *= bitCount;
+        int length = capacity >>> BASE_SHIFT;
+        if ((capacity & OFFSET_MASK) != 0) {
             length++;
         }
         return length;

Modified: sis/branches/JDK8/pom.xml
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/pom.xml?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/pom.xml (original)
+++ sis/branches/JDK8/pom.xml Mon Apr  3 10:02:24 2017
@@ -699,23 +699,23 @@ Apache SIS is a free software, Java lang
                     Whether whitespaces should be present before or after various kind of
tokens,
                     and where line wraps are allowed or mandated.
                   -->
-                  <module name="FileTabCharacter"/>         <!-- No tab characters
in the file. -->
-                  <module name="NewlineAtEndOfFile"/>       <!-- Newline at the
end of each file. -->
+                  <module name="FileTabCharacter"/>                 <!-- No tab
characters in the file. -->
+                  <module name="NewlineAtEndOfFile"/>               <!-- Newline
at the end of each file. -->
                   <module name="TreeWalker">
-                    <module name="NoLineWrap"/>             <!-- Imports and package
statements are not line-wrapped. -->
-                    <module name="RedundantImport"/>        <!-- No redundant import
statements. -->
-                    <module name="GenericWhitespace"/>      <!-- Whitespace around
the Generic tokens follow typical convention. -->
-                    <module name="TypecastParenPad"/>       <!-- No space inside
parentheses for typecasts. -->
-                    <module name="SeparatorWrap">           <!-- No line wrapping
before comma. -->
+                    <module name="NoLineWrap"/>                     <!-- Imports
and package statements are not line-wrapped. -->
+                    <module name="RedundantImport"/>                <!-- No redundant
import statements. -->
+                    <module name="GenericWhitespace"/>              <!-- Whitespace
around the Generic tokens follow typical convention. -->
+                    <module name="TypecastParenPad"/>               <!-- No space
inside parentheses for typecasts. -->
+                    <module name="SeparatorWrap">                   <!-- No line
wrapping before comma. -->
                       <property name="tokens" value="COMMA"/>
                     </module>
-                    <module name="WhitespaceAfter">         <!-- Checks that a token
is followed by whitespace. -->
+                    <module name="WhitespaceAfter">                 <!-- Checks
that a token is followed by whitespace. -->
                       <property name="tokens" value="TYPECAST, LITERAL_IF, LITERAL_ELSE,
LITERAL_WHILE, LITERAL_DO, LITERAL_FOR, DO_WHILE"/>
                     </module>
-                    <module name="NoWhitespaceAfter">       <!-- No whitespace after
"++" in ++x, etc. -->
+                    <module name="NoWhitespaceAfter">               <!-- No whitespace
after "++" in ++x, etc. -->
                       <property name="tokens" value="INC, DEC, BNOT, LNOT"/>
                     </module>
-                    <module name="NoWhitespaceBefore">      <!-- No whitespace before
"++" in x++, etc. -->
+                    <module name="NoWhitespaceBefore">              <!-- No whitespace
before "++" in x++, etc. -->
                       <property name="tokens" value="COMMA, POST_INC, POST_DEC, ELLIPSIS"/>
                     </module>
                     <module name="WhitespaceAround">
@@ -740,9 +740,9 @@ Apache SIS is a free software, Java lang
                       the same thing (e.g. Java-style versus C-style of array declarations),
the following rules
                       enforce one specific convention.
                     -->
-                    <module name="UpperEll"/>               <!-- Upper-case 'L'
suffix for longs, not 'l'. -->
-                    <module name="ArrayTypeStyle"/>         <!-- Java-style arrays,
not C-style. -->
-                    <module name="ModifierOrder"/>          <!-- Order of public,
static, etc. keywords. -->
+                    <module name="UpperEll"/>                       <!-- Upper-case
'L' suffix for longs, not 'l'. -->
+                    <module name="ArrayTypeStyle"/>                 <!-- Java-style
arrays, not C-style. -->
+                    <module name="ModifierOrder"/>                  <!-- Order of
public, static, etc. keywords. -->
                     <module name="AvoidEscapedUnicodeCharacters">
                       <property name="allowEscapesForControlCharacters" value="true"/>
                       <property name="allowNonPrintableEscapes"         value="true"/>
@@ -752,13 +752,23 @@ Apache SIS is a free software, Java lang
                     <!--
                       Programming language constructs: number of elements, modifiers, etc.
                     -->
-                    <module name="OuterTypeFilename"/>      <!-- Outer type name
and file name shall match. -->
-                    <module name="OuterTypeNumber"/>        <!-- Only one outer
type per file. -->
-                    <module name="RedundantModifier">       <!-- No modifiers that
were implicit. -->
+                    <module name="OuterTypeNumber"/>                <!-- Only one
outer type per file. -->
+                    <module name="OuterTypeFilename"/>              <!-- Outer type
name and file name shall match. -->
+                    <module name="InterfaceIsType"/>                <!-- Do not
allow interface without methods. -->
+                    <module name="FinalClass"/>                     <!-- Class having
only private constructors should be final. -->
+                    <module name="PackageDeclaration"/>             <!-- All classes
shall be in a package. -->
+                    <module name="HideUtilityClassConstructor"/>    <!-- No public
constructor in utility classes. -->
+                    <module name="MissingOverride"/>                <!-- @Override
annotation everywhere applicable. -->
+                    <module name="PackageAnnotation"/>              <!-- Package
annotations shall be used only in package-info files. -->
+                    <module name="EmptyCatchBlock"/>                <!-- No empty
catch unless there is a comment inside. -->
+                    <module name="CovariantEquals"/>                <!-- No equals(Foo),
unless equals(Object) also exists. -->
+                    <module name="ExplicitInitialization"/>         <!-- No unnecessary
initialization to 0 or null. -->
+                    <module name="SimplifyBooleanReturn"/>          <!-- No if (boolean)
return true; else return false. -->
+                    <module name="RedundantModifier">               <!-- No modifiers
that were implicit. -->
                       <property name="tokens" value="VARIABLE_DEF, ANNOTATION_FIELD_DEF,
INTERFACE_DEF, CLASS_DEF, ENUM_DEF, RESOURCE"/>
                     </module>
                   </module>
-                  <module name="UniqueProperties"/>       <!-- No duplicated keys
in *.properties files. -->
+                  <module name="UniqueProperties"/>                 <!-- No duplicated
keys in *.properties files. -->
                 </module>
               </checkstyleRules>
             </configuration>

Modified: sis/branches/JDK8/storage/sis-storage/src/main/java/org/apache/sis/index/tree/QuadTreeWriter.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/storage/sis-storage/src/main/java/org/apache/sis/index/tree/QuadTreeWriter.java?rev=1789939&r1=1789938&r2=1789939&view=diff
==============================================================================
--- sis/branches/JDK8/storage/sis-storage/src/main/java/org/apache/sis/index/tree/QuadTreeWriter.java
[UTF-8] (original)
+++ sis/branches/JDK8/storage/sis-storage/src/main/java/org/apache/sis/index/tree/QuadTreeWriter.java
[UTF-8] Mon Apr  3 10:02:24 2017
@@ -27,7 +27,9 @@ import java.io.IOException;
  * Class to save the quad tree index from file.
  *
  */
-public class QuadTreeWriter {
+public final class QuadTreeWriter {
+  private QuadTreeWriter() {
+  }
 
   /**
    * Writes the entire quad tree index to file with each node in saved in a



Mime
View raw message