sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1781501 - in /sis/ip-review: CoordinateFormat.xhtml rev/10796/CoordinateFormat.xhtml rev/20874/CoordinateFormat.xhtml rev/24925/CoordinateFormat.xhtml
Date Fri, 03 Feb 2017 07:38:04 GMT
Author: desruisseaux
Date: Fri Feb  3 07:38:03 2017
New Revision: 1781501

URL: http://svn.apache.org/viewvc?rev=1781501&view=rev
Log:
Add IP review for CoordinateFormat.

Added:
    sis/ip-review/CoordinateFormat.xhtml
    sis/ip-review/rev/10796/CoordinateFormat.xhtml
    sis/ip-review/rev/20874/CoordinateFormat.xhtml
    sis/ip-review/rev/24925/CoordinateFormat.xhtml

Added: sis/ip-review/CoordinateFormat.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/CoordinateFormat.xhtml?rev=1781501&view=auto
==============================================================================
--- sis/ip-review/CoordinateFormat.xhtml (added)
+++ sis/ip-review/CoordinateFormat.xhtml Fri Feb  3 07:38:03 2017
@@ -0,0 +1,62 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CoordinateFormat history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CoordinateFormat history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/measure/CoordinateFormat.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated
from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations
in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation;
rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">28069</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 generics in org.geotools.image.io, and partially in org.geotools.parameters.</td></tr>
+<tr><td class="rev">28051</td><td>2007-11-26</td><td>desruisseaux</td><td>More
Java 5 parameterized types. Include a fix for GEOT-1599 (CitationImpl.getIdentifiers() should
returns a set of Identifiers, not a set of Strings).</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/24925/CoordinateFormat.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted
referencing, extracting metadata in their own module (GEOT-983). As a side effect, replaced
some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/CoordinateFormat.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">17460</td><td>2006-01-05</td><td>desruisseaux</td><td>Added
support classes for GO-1 implementation. Partial Maven 2 fixes for the new module/renderer
module.</td></tr>
+<tr><td class="rev">16205</td><td>2005-10-11</td><td>desruisseaux</td><td>Cleaned
javadoc warning. More work done on Maven 2 configuration (GEOT-691)</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction
of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added
@since javadoc tag</td></tr>
+<tr><td class="rev">13907</td><td>2005-05-28</td><td>desruisseaux</td><td>More
additions of 'Default' prefix in CRS package</td></tr>
+<tr><td class="rev">13869</td><td>2005-05-27</td><td>desruisseaux</td><td>Added
'Default' or 'Abstract' prefix in CRS's 'datum' and 'cs' packages</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed
wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a
href="rev/10796/CoordinateFormat.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply
changes voted in OGC meeting at Southampton: use of Identifier and GenericName</td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added
SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface
for DirectPosition and Point</td></tr>
+<tr><td class="rev">6343</td><td>2004-06-07</td><td>desruisseaux</td><td>More
ports of legacy CTS to new CRS</td></tr>
+<tr><td class="rev">6285</td><td>2004-06-01</td><td>desruisseaux</td><td>Fixed
missing timezone setting</td></tr>
+<tr><td class="rev">6254</td><td>2004-05-30</td><td>desruisseaux</td><td>Added
new CRS</td></tr>
+<tr><td class="rev">6210</td><td>2004-05-27</td><td>desruisseaux</td><td>Javadoc
fixes / Added Id keyword property</td></tr>
+<tr><td class="rev">6098</td><td>2004-05-23</td><td>desruisseaux</td><td>Partial
implementation of GeoAPI referencing package</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/10796/CoordinateFormat.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/CoordinateFormat.xhtml?rev=1781501&view=auto
==============================================================================
--- sis/ip-review/rev/10796/CoordinateFormat.xhtml (added)
+++ sis/ip-review/rev/10796/CoordinateFormat.xhtml Fri Feb  3 07:38:03 2017
@@ -0,0 +1,128 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CoordinateFormat changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CoordinateFormat changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite>
tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite>
import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are
keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/measure/CoordinateFormat.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+<span class="del"> * (C) 1998, Pêches et Océans Canada</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+<span class="add"> * (C) 1998, P�ches et Oc�ans Canada</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.measure;
+
+// J2SE dependencies
+<span class="del">import java.util.Date;</span>
+<span class="del">import java.util.Locale;</span>
+<span class="del">import java.util.TimeZone;</span>
+<span class="del">import java.text.Format;</span>
+import java.text.DateFormat;
+<span class="del">import java.text.NumberFormat;</span>
+import java.text.DecimalFormat;
+import java.text.FieldPosition;
+import java.text.ParsePosition;
+import java.text.SimpleDateFormat;
+import javax.units.Unit;
+<span class="del">import javax.units.SI;</span>
+<span class="del">import javax.units.NonSI;</span>
+<span class="del">import javax.units.Converter;</span>
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.referencing.datum.Datum;</span>
+<span class="del">import org.opengis.referencing.datum.TemporalDatum;</span>
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.cs.CoordinateSystem;
+import org.opengis.referencing.cs.CoordinateSystemAxis;
+<span class="del">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+import org.opengis.spatialschema.geometry.DirectPosition;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.resources.CRSUtilities;</span>
+<span class="del">import org.geotools.resources.cts.Resources;</span>
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="del">import org.geotools.referencing.crs.TemporalCRS;</span>
+
+<span class="del"></span>
+/**
+ * Format a {@linkplain org.geotools.geometry.GeneralDirectPosition direct position} in an
+ * arbitrary {@linkplain org.geotools.referencing.crs.CoordinateReferenceSystem coordinate</pre></td>
+<td><pre>package org.geotools.measure;
+
+// J2SE dependencies
+import java.text.DateFormat;
+import java.text.DecimalFormat;
+import java.text.FieldPosition;
+<span class="add">import java.text.Format;</span>
+<span class="add">import java.text.NumberFormat;</span>
+import java.text.ParsePosition;
+import java.text.SimpleDateFormat;
+<span class="add">import java.util.Date;</span>
+<span class="add">import java.util.Locale;</span>
+<span class="add">import java.util.TimeZone;</span>
+<span class="add"></span>
+<span class="add">import javax.units.Converter;</span>
+<span class="add">import javax.units.NonSI;</span>
+<span class="add">import javax.units.SI;</span>
+import javax.units.Unit;
+
+<span class="add">import org.geotools.referencing.crs.TemporalCRS;</span>
+<span class="add">import org.geotools.resources.CRSUtilities;</span>
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.cts.Resources;</span>
+<span class="add">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.cs.CoordinateSystem;
+import org.opengis.referencing.cs.CoordinateSystemAxis;
+<span class="add">import org.opengis.referencing.datum.Datum;</span>
+<span class="add">import org.opengis.referencing.datum.TemporalDatum;</span>
+import org.opengis.spatialschema.geometry.DirectPosition;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+
+/**
+ * Format a {@linkplain org.geotools.geometry.GeneralDirectPosition direct position} in an
+ * arbitrary {@linkplain org.geotools.referencing.crs.CoordinateReferenceSystem coordinate</pre></td></tr>
+<tr><td><pre>/////////////////
+if (NonSI.DEGREE_ANGLE.equals(unit)) {
+    if (angleFormat == null) {
+<span class="del">        angleFormat = new AngleFormat("DD°MM.m'", locale);</span>
+    }
+    formats[i] = angleFormat;
+    final AxisDirection axis = cs.getAxis(i).getDirection().absolute();</pre></td>
+<td><pre>/////////////////
+if (NonSI.DEGREE_ANGLE.equals(unit)) {
+    if (angleFormat == null) {
+<span class="add">        angleFormat = new AngleFormat("DD�MM.m'", locale);</span>
+    }
+    formats[i] = angleFormat;
+    final AxisDirection axis = cs.getAxis(i).getDirection().absolute();</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/20874/CoordinateFormat.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/CoordinateFormat.xhtml?rev=1781501&view=auto
==============================================================================
--- sis/ip-review/rev/20874/CoordinateFormat.xhtml (added)
+++ sis/ip-review/rev/20874/CoordinateFormat.xhtml Fri Feb  3 07:38:03 2017
@@ -0,0 +1,62 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CoordinateFormat changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CoordinateFormat changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the <cite>"or (at your option)
any later version"</cite> clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/measure/CoordinateFormat.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ * (C) 1998, Pêches et Océans Canada
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.measure;</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ * (C) 1998, Pêches et Océans Canada
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.measure;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Added: sis/ip-review/rev/24925/CoordinateFormat.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/CoordinateFormat.xhtml?rev=1781501&view=auto
==============================================================================
--- sis/ip-review/rev/24925/CoordinateFormat.xhtml (added)
+++ sis/ip-review/rev/24925/CoordinateFormat.xhtml Fri Feb  3 07:38:03 2017
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CoordinateFormat changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CoordinateFormat changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/measure/CoordinateFormat.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>import org.opengis.referencing.cs.CoordinateSystemAxis;
+import org.opengis.referencing.datum.Datum;
+import org.opengis.referencing.datum.TemporalDatum;
+<span class="del">import org.opengis.spatialschema.geometry.DirectPosition;</span>
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.referencing.CRS;</pre></td>
+<td><pre>import org.opengis.referencing.cs.CoordinateSystemAxis;
+import org.opengis.referencing.datum.Datum;
+import org.opengis.referencing.datum.TemporalDatum;
+<span class="add">import org.opengis.geometry.DirectPosition;</span>
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.referencing.CRS;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>



Mime
View raw message