Author: desruisseaux Date: Tue Jul 19 12:39:59 2016 New Revision: 1753378 URL: http://svn.apache.org/viewvc?rev=1753378&view=rev Log: Add IP review for the classes that infer coordinate operation paths. Added: sis/ip-review/CoordinateOperationFinder.xhtml (with props) sis/ip-review/CoordinateOperationRegistry.xhtml (with props) sis/ip-review/rev/05125/ sis/ip-review/rev/05125/CoordinateOperationFinder.xhtml (with props) sis/ip-review/rev/05125/HEADER.html (with props) sis/ip-review/rev/05923/ sis/ip-review/rev/05923/CoordinateOperationFinder.xhtml (with props) sis/ip-review/rev/05923/HEADER.html (with props) sis/ip-review/rev/08660/ sis/ip-review/rev/08660/CoordinateOperationFinder.xhtml (with props) sis/ip-review/rev/08660/HEADER.html (with props) sis/ip-review/rev/10796/CoordinateOperationFinder.xhtml (with props) sis/ip-review/rev/20874/CoordinateOperationFinder.xhtml (with props) sis/ip-review/rev/20874/CoordinateOperationRegistry.xhtml (with props) sis/ip-review/rev/25050/CoordinateOperationFinder.xhtml (with props) sis/ip-review/rev/25050/CoordinateOperationRegistry.xhtml (with props) Added: sis/ip-review/CoordinateOperationFinder.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/CoordinateOperationFinder.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/CoordinateOperationFinder.xhtml (added) +++ sis/ip-review/CoordinateOperationFinder.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,132 @@ + + + + + CoordinateOperationFinder history + + + +
+

CoordinateOperationFinder history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultCoordinateOperationFactory.java
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
307602008-06-18desruisseauxUpgrated from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations in the process.
306412008-06-12acusterCopyright headers: lib/referencing, this time with feeling (and the el in Toolkit)
305212008-06-05acusterCopyright: Update referencing headers
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
298522008-04-08desruisseauxThe previous commit was about simplifying (in the sense of simplier MathTransform result, not simplier code) ConcatenatedTransform. This commit is about simplifying the ConcatenatedOperation which contains that ConcatenatedTransform. Related to GEOT-1419.
298452008-04-08desruisseauxMore aggressive simplification of MathTransforms during concatenation. It is probably related to GEOT-1419, but I have not verified. This fix results in drastic performance improvement for the cases where DefaultConcatenatedTransform previously failed to see concatenation that could be simplified to identity transform. Those cases occured more often in 3D or 4D cases. It may have some benefit in the pure 2D case as well, but probably less often.
297532008-04-01desruisseauxApplied parameterized types as a side-effect of hunting for a DimensionMismatchException during reprojection.
296982008-03-21desruisseauxMosaicImageReader select preferably a ColorModel with transparency if available. A few Java 5 constructs in referencing module.
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
285402007-12-29acusterHide buttons which are not yet used
282522007-12-04desruisseauxMore MosaicImageReader work. As a side effect, moved Utilities.getShort[Class]Name in a separated utilities class named 'Classes'. Also added a couple of @Override annotations.
280692007-11-27desruisseauxJava 5 generics in org.geotools.image.io, and partially in org.geotools.parameters.
280302007-11-23desruisseauxMore Java 5 generics. Added implementation for three new GeoAPI methods for alignment with RFC 07-073r1.
279952007-11-22desruisseauxMore generics type, and moved two methods from ReferencingFactoryContainer to GeoAPI MathTransformFactory interface. Note that the build fails in the arcsde module for a reason that seems unrelated to this work.
275752007-10-22desruisseauxConverted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).
257552007-06-06desruisseauxAvoid an UnsupportedOperationException with ConcatenatedTransform. Added more test point in the Stereographic projection test.
254062007-05-03desruisseaux-Dorg.geotools.referencing.forceXY system property was broken. Should now be fixed.
252622007-04-23desruisseauxFinished review of metadata and factory hints change. Fixed a potential glitch in parameter names handling (some code were disabled in AbstractIdentifiedObject apparently in order to avoid a ClassCastException caused by the spit of org.opengis.metadata.Identifier in two interfaces, Identifier and ReferenceIdentifier. Fixed the exception and reenabled the code). Not sure yet what the consequence was. It may help for the stereographic projection issue, but need to check.
250502007-04-06jgarnettexample of custom file based TestSutie, copy JTS parsing code over to unsupported/geometry
245812007-02-26desruisseauxRewrote 'createLinearConversion' from scratch, since testing of 'South Oriented' cases of map projections show some issues with the old implementation.
224822006-10-31desruisseauxFixed svn:ignore property and removed svn:executable.
223272006-10-23desruisseauxGEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.
223152006-10-22desruisseauxReorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.
215642006-09-23desruisseauxProvide a BufferedCoordinateOperationFactory as a replacement of BufferedDefaultCoordinateOperationFactory. The new implementation work as a wrapper around an arbitrary CoordinateOperationFactory instead of extending DefaultCoordinateOperationFactory. This is especially important since the actual backing factory doesn't need to be DefaultCoordinateOperationFactory, but can also be a AuthorityBackedFactory. The new implementation is automatically registered for FactoryFinder use, so users doesn't need to create instance of it explicitly.
208742006-08-07jgarnettip review
197692006-06-02desruisseauxJavadoc fix: replaced 'degrees' by 'decimal degrees' when relevant (GEOT-855)
197552006-05-31desruisseauxAdded FORCE_LONGITUDE_FIRST_AXIS_ORDER hint (GEOT-858). This work implied a large amount of work, hunting for infinite recursive method calls in many places.
196432006-05-24desruisseauxFirst fix attempt for GEOT-854: CRS with modified axis order now preserve the metadata, including the authority code. The dangerous thing is that two CRS may now have the same authority code while being really different CRS. It caused an infinite loop in AuthorityBackedFactory, which was fixed in this commit as well. However, there is a risk that similar problems appear in user's code as well.
195572006-05-18desruisseauxAuthorityBackedFactory now take inverse transform in account. Improved pseudo-WKT formatting for CoordinateOperation.
195152006-05-17desruisseauxConstruction of transformation chain now query the database for intermediate steps. Revisited documentation.
176722006-01-19desruisseauxAdded @source tag.
176602006-01-18desruisseauxFixed SVN attributes, including the addition of URL attribute.
153502005-08-16desruisseauxMerged the 'split-main' branch to trunk (GEOT-662)
153252005-08-13desruisseauxCreated a matrix package on top of vecmath / Fixed 'getPositionalAccuracy' issues
153192005-08-12desruisseauxBug fix for GEOT-660 and GEOT-661: BursaWolfParameters now used even if Hints.LENIENT_DATUM_SHIFT is true
152562005-08-09desruisseauxExtraction of referencing module from main
152552005-08-09desruisseauxPrepare branch for splitting main
149342005-07-27desruisseauxTransformations between 3D ProjectedCRS should propagate the height (GEOT-637, 638 and 639)
148342005-07-20desruisseauxReorganized I18N resources
146082005-06-25desruisseauxEPSG authority factory now uses path informations for ConcatenatedOperation object creations / Added PostgreSQL plugin (mostly as a demo) / Javadoc fixes
145932005-06-23desruisseauxFirst JUnit test for 'createCoordinateOperation' (GEOT-589)
145642005-06-20desruisseauxInitial implementation of GEOT-589. Partially tested, more tests to come
145502005-06-16desruisseauxRemoved deprecated fields and methods
145452005-06-15desruisseauxInitial port of coverage I/O helper classes (work in progress)
139252005-05-30desruisseauxAdded @since javadoc tag
139222005-05-29desruisseauxRenaming of remainding GeoAPI implementations. Renaming is now finished.
139072005-05-28desruisseauxMore additions of 'Default' prefix in CRS package
139062005-05-28desruisseauxRenamed some 'Default' prefix as 'Abstract'
138692005-05-27desruisseauxAdded 'Default' or 'Abstract' prefix in CRS's 'datum' and 'cs' packages
138362005-05-26desruisseauxAdded 'Default' suffix to some CRS implementations: partial work
133962005-05-07desruisseauxImplemented MolodenskiTransform.inverse(). Merged AbridgedMolodenskiTransform with MolodenskiTransform as a side effect.
133872005-05-06desruisseauxAdded Hints.LENIENT_DATUM_SHIFT and the necessary mechanic to honor it
129652005-04-05desruisseauxMerged 'factory-hints' branch r12393:12964 into the trunk. Added 'getImplementationHints()' method after the merge into Factory implementations, in order to get Geotools to compile with Maven.
113702005-02-13desruisseauxRefactored factories in an 'org.geotools.referencing.factory' package
113332005-02-11desruisseauxFirst draft of an EPSG authority factory port
112492005-02-10desruisseauxMoved axis framework from 'legacy' to 'migrate'
112482005-02-10desruisseauxLimited support for transformations between 3D CRS
112122005-02-09desruisseauxInitial work on Z-values handling
111742005-02-08desruisseauxCoordinateOperationFactory now make use of 'Molodenski' transform (GEOT-399)
111732005-02-08desruisseauxAxis changes steps now collapsed (GEOT-402)
111462005-02-07desruisseauxCoordinateOperationFactory refactoring
111442005-02-07desruisseauxFixed GEOT-400 (create appropriate instance of Operation subclasses)
111402005-02-06desruisseauxWork in progres for GEOT-400 (CoordinateOperationFactory should create appropriate subclass of CoordinateOperation)
111372005-02-05desruisseauxTune CRS tests (e.g. allow different tolerance level for assertions in different projections)
111002005-02-04desruisseauxMore tests and bug fixes in CRS
110932005-02-03desruisseauxRoolback to createParameterizedTransform without classification parameter
110752005-02-03desruisseauxFixed never-ending loop in CoordinateTransformationFactory
110742005-02-03desruisseauxRevisited CRSFactory.createProjectedCRS(...) API
110012005-02-02desruisseauxFixed wrong encoding in main/src
107962005-01-28dzwiersimports cleaned
104692005-01-11desruisseauxReplaced calls to 'getDim[Source|Target]' by 'get[Source|Target]Dimensions
102282005-01-04desruisseauxRenamed 'getDimSource' as 'getSourceDimension'
101832005-01-03desruisseauxMoved tests from legacy CTS to new CRS packages
93462004-11-30desruisseauxFirst working version of CoordinateOperationFactory
92672004-11-23desruisseauxFirst draft of a coordinate transformation factory
86602004-10-17rschulzupdated for recent change from InternationalString to Identifier
78482004-09-08jgarnettround 2 of sync with geoapi
67292004-07-06desruisseauxRemoved some deprecated classes
62392004-05-28desruisseauxReplaced org.geotools.[...].NoninvertibleTransformException by org.opengis.[...].NoninvertibleTransformException
62102004-05-27desruisseauxJavadoc fixes / Added Id keyword property
61492004-05-25desruisseauxMoved image related resources in org.geotools.resources.image package
59232004-05-23jgarnettcts-coordtrans moved to main
57742004-05-23jgarnettgeotools-src serves as the start of our new module directory (the data access modules will escape off to plugin directory soon)
57692004-05-23jgarnettProject renamed to gt
56192004-05-13(pas d'auteur)Move repository under gt.
51272004-03-08desruisseauxAdded PROMISCUOUS coordinate system / removed deprecated methods
51252004-03-07aaimeAdded partial support for CARTESIAN coordinate system that will be treated as a wildcard.
36532003-08-07desruisseauxBug fix in prime meridian handling
36062003-08-04desruisseauxPMD fixes
28582003-05-13desruisseauxAdded PMC owner to copyright notice
28512003-05-12desruisseauxFixed 'createSubTransform' method
27722003-04-29desruisseauxRMI objects now extend 'UnicastRemoteObject' instead of 'RemoteObject'
21482003-01-20desruisseauxAdded FittedCoordinateSystem / Overrided hashCode() / Use factories in Adapters
21422003-01-18desruisseauxReorganized exception hierarchy
21332003-01-15desruisseauxReorganized Adapters as an hierarchy for consistency with gcs-coverage
16552002-10-13desruisseauxTake vertical axis in account during transformations between ProjectedCS
16532002-10-13desruisseauxTake vertical axis in account during transformation between two geographic CS
16502002-10-10desruisseauxJavadoc fix
16352002-10-09desruisseauxBug fix in CoordinateTransformationFactory
16342002-10-09desruisseauxBug fix in CoordinateTransformationFactory
16242002-10-07desruisseauxImproved doc and added the OpenGIS test case
16232002-10-07desruisseauxBug fix: units was not properly converted if their transformation were not on the matrix's diagonal
13242002-07-31desruisseauxImproved caching
10402002-07-12desruisseauxRemoved use of a deprecated method
6192002-06-01desruisseauxInitial CT implementation (moved from SEAGIS project)
+
+ + Propchange: sis/ip-review/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/CoordinateOperationRegistry.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/CoordinateOperationRegistry.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/CoordinateOperationRegistry.xhtml (added) +++ sis/ip-review/CoordinateOperationRegistry.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,65 @@ + + + + + CoordinateOperationRegistry history + + + +
+

CoordinateOperationRegistry history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AuthorityBackedFactory.java
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
314452008-09-07desruisseauxGEOT-1667: Need to invoke LogRecord.setLoggerName(String) before Logger.log(LogRecord).
306412008-06-12acusterCopyright headers: lib/referencing, this time with feeling (and the el in Toolkit)
305212008-06-05acusterCopyright: Update referencing headers
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
298522008-04-08desruisseauxThe previous commit was about simplifying (in the sense of simplier MathTransform result, not simplier code) ConcatenatedTransform. This commit is about simplifying the ConcatenatedOperation which contains that ConcatenatedTransform. Related to GEOT-1419.
298252008-04-07desruisseauxAdded synchronized statements. While the old approach was not exactly the deprecated double-check idiom, it was too close of that. A few unsynchronized blocks still exist which may need to be revisited later.
297702008-04-02desruisseauxAdded a check against DimensionMismatchException during reprojection backed by the EPSG database. Added some TemporalDatum predefined constants for some kind of julian days.
297532008-04-01desruisseauxApplied parameterized types as a side-effect of hunting for a DimensionMismatchException during reprojection.
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
287902008-01-16desruisseauxRenamed resources.i18n.Logging as resources.i18n.Loggings (with an s) for avoiding name clash with util.logging.Logging. The name clash would not have been an issue if those two classes were not typically used together... Also performed a few javadoc fixes in DirectPosition2D.
285402007-12-29acusterHide buttons which are not yet used
283912007-12-16desruisseauxAttempt to make FactoryCreator more tolerant to dependencies that can't be fetched for a given set of hints (GEOT-1618). Also cleaned a little bit of calls to 'unexpectedException' as a side effect.
280302007-11-23desruisseauxMore Java 5 generics. Added implementation for three new GeoAPI methods for alignment with RFC 07-073r1.
279232007-11-18desruisseauxApplying some more generic types, especially in the factory package. Required slight changes in the way FactoryRegistry is used, as documented in http://docs.codehaus.org/display/GEOTOOLS/Fixing+compilation+errors
275752007-10-22desruisseauxConverted Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).
254852007-05-11desruisseauxAdded special cases for 'x' and 'y' axis names.
254062007-05-03desruisseaux-Dorg.geotools.referencing.forceXY system property was broken. Should now be fixed.
250502007-04-06jgarnettexample of custom file based TestSutie, copy JTS parsing code over to unsupported/geometry
243852007-02-14desruisseauxFix attempt for GEOT-1161 (infinite recursivity in CRS.findMathTransform). Need more tests.
236352007-01-01desruisseauxUses fully-qualified class name (instead of last name only) in logging. More work on versioned URN:OGC:DEF factory.
223272006-10-23desruisseauxGEOT-982: regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.
223152006-10-22desruisseauxReorganisation of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.
215642006-09-23desruisseauxProvide a BufferedCoordinateOperationFactory as a replacement of BufferedDefaultCoordinateOperationFactory. The new implementation work as a wrapper around an arbitrary CoordinateOperationFactory instead of extending DefaultCoordinateOperationFactory. This is especially important since the actual backing factory doesn't need to be DefaultCoordinateOperationFactory, but can also be a AuthorityBackedFactory. The new implementation is automatically registered for FactoryFinder use, so users doesn't need to create instance of it explicitly.
208742006-08-07jgarnettip review
197552006-05-31desruisseauxAdded FORCE_LONGITUDE_FIRST_AXIS_ORDER hint (GEOT-858). This work implied a large amount of work, hunting for infinite recursive method calls in many places.
196432006-05-24desruisseauxFirst fix attempt for GEOT-854: CRS with modified axis order now preserve the metadata, including the authority code. The dangerous thing is that two CRS may now have the same authority code while being really different CRS. It caused an infinite loop in AuthorityBackedFactory, which was fixed in this commit as well. However, there is a risk that similar problems appear in user's code as well.
195572006-05-18desruisseauxAuthorityBackedFactory now take inverse transform in account. Improved pseudo-WKT formatting for CoordinateOperation.
195152006-05-17desruisseauxConstruction of transformation chain now query the database for intermediate steps. Revisited documentation.
176722006-01-19desruisseauxAdded @source tag.
176602006-01-18desruisseauxFixed SVN attributes, including the addition of URL attribute.
169422005-11-23desruisseauxFirst draft of OrderedAxisAuthorityFactory (GEOT-694)
153502005-08-16desruisseauxMerged the 'split-main' branch to trunk (GEOT-662)
152562005-08-09desruisseauxExtraction of referencing module from main
152552005-08-09desruisseauxPrepare branch for splitting main
146572005-07-01desruisseauxOngoing work for the port of grid coverage operations from 'legacy' to 'main' (GEOT-413): ported SampleDimensionSelect
146102005-06-26desruisseauxCoordinateOperationFactory is now backed by an EPSG authority when available (GEOT-592)
145702005-06-21desruisseauxAddition of geocentric affine transform as of GEOT-591
145642005-06-20desruisseauxInitial implementation of GEOT-589. Partially tested, more tests to come
+
+ + Propchange: sis/ip-review/CoordinateOperationRegistry.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/CoordinateOperationRegistry.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/05125/CoordinateOperationFinder.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05125/CoordinateOperationFinder.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/05125/CoordinateOperationFinder.xhtml (added) +++ sis/ip-review/rev/05125/CoordinateOperationFinder.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,71 @@ + + + + + CoordinateOperationFinder changes for revisions 5124:5125 + + + +
+

CoordinateOperationFinder changes for revisions 5124:5125

+

This change has not been ported to Apache SIS. We do not support "wildcard" in coordinate operations.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r5124:5125 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultCoordinateOperationFactory.java
+ + + + + + + + +
Revision 5124Revision 5125
import org.geotools.pt.Matrix;
+import org.geotools.cs.AxisInfo;
+import org.geotools.cs.Ellipsoid;
+import org.geotools.cs.Projection;
+import org.geotools.cs.PrimeMeridian;
+import org.geotools.cs.HorizontalDatum;
import org.geotools.pt.Matrix;
+import org.geotools.cs.AxisInfo;
+import org.geotools.cs.Ellipsoid;
+import org.geotools.cs.LocalCoordinateSystem;
+import org.geotools.cs.Projection;
+import org.geotools.cs.PrimeMeridian;
+import org.geotools.cs.HorizontalDatum;
/**
+ * Creates coordinate transformations.
+ *
+ * @version $Id: CoordinateTransformationFactory.java,v 1.18 2003/08/07 11:14:44 desruisseaux Exp $
+ * @author <A HREF="http://www.opengis.org">OpenGIS</A>
+ * @author Martin Desruisseaux
+ *
/**
+ * Creates coordinate transformations.
+ *
+ * @version $Id: CoordinateTransformationFactory.java,v 1.19 2004/03/07 19:55:52 aaime Exp $
+ * @author <A HREF="http://www.opengis.org">OpenGIS</A>
+ * @author Martin Desruisseaux
+ *
        step = factory.createConcatenatedTransform(step, step2.getMathTransform());
+        return createFromMathTransform(sourceCS, targetCS, step, step2.getTransformType());
+    }
+    throw new CannotCreateTransformException(sourceCS, targetCS);
+}
        step = factory.createConcatenatedTransform(step, step2.getMathTransform());
+        return createFromMathTransform(sourceCS, targetCS, step, step2.getTransformType());
+    }
+
+   ///////////////////////////////////////////
+    ////                                   ////
+    ////     Cartesian  -->  various CS    ////
+    ////     Various CS --> Cartesian      ////
+    ////                                   ////
+    ///////////////////////////////////////////
+    if(sourceCS == LocalCoordinateSystem.CARTESIAN || targetCS == LocalCoordinateSystem.CARTESIAN) {
+     final int dimSource = sourceCS.getDimension();
+     MathTransform step = factory.createIdentityTransform(dimSource);
+       return createFromMathTransform(sourceCS, targetCS, step);
+    }
+    throw new CannotCreateTransformException(sourceCS, targetCS);
+}
+
+ + Propchange: sis/ip-review/rev/05125/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/05125/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/05125/HEADER.html URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05125/HEADER.html?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/05125/HEADER.html (added) +++ sis/ip-review/rev/05125/HEADER.html Tue Jul 19 12:39:59 2016 @@ -0,0 +1,17 @@ + + + + + Revision 5125 + + +
+

Revision 5125

+ + + + +
Author:aaime
Date:2004-03-07
Message:Added partial support for CARTESIAN coordinate system that will be treated as a wildcard.
+
+ + Propchange: sis/ip-review/rev/05125/HEADER.html ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/05125/HEADER.html ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/05923/CoordinateOperationFinder.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05923/CoordinateOperationFinder.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/05923/CoordinateOperationFinder.xhtml (added) +++ sis/ip-review/rev/05923/CoordinateOperationFinder.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,22 @@ + + + + + CoordinateOperationFinder changes for revisions 5618:5923 + + + +
+

CoordinateOperationFinder changes for revisions 5618:5923

+

No change in this group of commits.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r5618:5923 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultCoordinateOperationFactory.java
+ + +
Revision 5618Revision 5923
+
+ + Propchange: sis/ip-review/rev/05923/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/05923/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/05923/HEADER.html URL: http://svn.apache.org/viewvc/sis/ip-review/rev/05923/HEADER.html?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/05923/HEADER.html (added) +++ sis/ip-review/rev/05923/HEADER.html Tue Jul 19 12:39:59 2016 @@ -0,0 +1,17 @@ + + + + + Revision 5923 + + +
+

Revision 5923

+ + + + +
Author:jgarnett
Date:2004-05-23
Message:cts-coordtrans moved to main
+
+ + Propchange: sis/ip-review/rev/05923/HEADER.html ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/05923/HEADER.html ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/08660/CoordinateOperationFinder.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/08660/CoordinateOperationFinder.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/08660/CoordinateOperationFinder.xhtml (added) +++ sis/ip-review/rev/08660/CoordinateOperationFinder.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,52 @@ + + + + + CoordinateOperationFinder changes for revisions 7847:8660 + + + +
+

CoordinateOperationFinder changes for revisions 7847:8660

+

This commit has been forced by a change in GeoAPI. + Reverting this commit (replacement of getName(null) by getName().getCode()) + causes a compilation error, which is fixed by redoing the same replacement or by using toString().

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r7847:8660 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultCoordinateOperationFactory.java
+ + + + + + +
Revision 7847Revision 8660
private static String getTemporaryName(final CoordinateSystem source) {
+    final StringBuffer buffer = new StringBuffer("Temporary-");
+    buffer.append(++temporaryID);
+    String name = source.getName(null);
+    if (name != null) {
+        final String suffix = " derived from ";
+        name = name.trim();
private static String getTemporaryName(final CoordinateSystem source) {
+    final StringBuffer buffer = new StringBuffer("Temporary-");
+    buffer.append(++temporaryID);
+    String name = source.getName().getCode();
+    if (name != null) {
+        final String suffix = " derived from ";
+        name = name.trim();
private static String getTemporaryName(final CoordinateSystem source,
+                                       final CoordinateSystem existing)
+{
+    return (source!=existing) ? existing.getName(null) : getTemporaryName(source);
+}
+
+/**
private static String getTemporaryName(final CoordinateSystem source,
+                                       final CoordinateSystem existing)
+{
+    return (source!=existing) ? existing.getName().toString() : getTemporaryName(source);
+}
+
+/**
+
+ + Propchange: sis/ip-review/rev/08660/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/08660/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/08660/HEADER.html URL: http://svn.apache.org/viewvc/sis/ip-review/rev/08660/HEADER.html?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/08660/HEADER.html (added) +++ sis/ip-review/rev/08660/HEADER.html Tue Jul 19 12:39:59 2016 @@ -0,0 +1,17 @@ + + + + + Revision 8660 + + +
+

Revision 8660

+ + + + +
Author:rschulz
Date:2004-10-17
Message:updated for recent change from InternationalString to Identifier
+
+ + Propchange: sis/ip-review/rev/08660/HEADER.html ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/08660/HEADER.html ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/10796/CoordinateOperationFinder.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/CoordinateOperationFinder.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/10796/CoordinateOperationFinder.xhtml (added) +++ sis/ip-review/rev/10796/CoordinateOperationFinder.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,220 @@ + + + + + CoordinateOperationFinder changes for revisions 10795:10796 + + + +
+

CoordinateOperationFinder changes for revisions 10795:10796

+

Changes in this commit seem to be the result of some "auto reformat" tool execution. +The Java - GeoAPI - GeoTools import ordering is altered, +imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken. +This commit has been reverted, except for the removal of really unused imports which are keep removed.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultCoordinateOperationFactory.java
+ + + + + + + + + + + + +
Revision 10795Revision 10796
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le D�veloppement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
package org.geotools.referencing.operation;
+
+// J2SE dependencies and extensions
+import java.util.Map;
+import java.util.HashMap;
+import java.util.Collections;
+import javax.units.Unit;
+import javax.units.SI;
+import javax.units.NonSI;
+import javax.units.ConversionException;
+import javax.vecmath.GMatrix;
+import javax.vecmath.SingularMatrixException;
+
+// OpenGIS dependencies: general
+import org.opengis.metadata.Identifier;
+import org.opengis.util.InternationalString;
+import org.opengis.parameter.ParameterValueGroup;
+import org.opengis.parameter.GeneralParameterValue;
+import org.opengis.referencing.IdentifiedObject;
+import org.opengis.referencing.FactoryException;
+
+// OpenGIS dependencies: datum
+import org.opengis.referencing.datum.Datum;
+import org.opengis.referencing.datum.Ellipsoid;
+import org.opengis.referencing.datum.PrimeMeridian;
+import org.opengis.referencing.datum.GeodeticDatum;
+import org.opengis.referencing.datum.TemporalDatum;
+import org.opengis.referencing.datum.VerticalDatum;
+
+// OpenGIS dependencies: coordinate systems
+import org.opengis.referencing.cs.TimeCS;
+import org.opengis.referencing.cs.VerticalCS;
+import org.opengis.referencing.cs.CartesianCS;
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.cs.EllipsoidalCS;
+import org.opengis.referencing.cs.CoordinateSystem;
+import org.opengis.referencing.cs.CoordinateSystemAxis;
+
+// OpenGIS dependencies: coordinate reference systems
+import org.opengis.referencing.crs.SingleCRS;
+import org.opengis.referencing.crs.CompoundCRS;
+import org.opengis.referencing.crs.TemporalCRS;
+import org.opengis.referencing.crs.VerticalCRS;
+import org.opengis.referencing.crs.ProjectedCRS;
+import org.opengis.referencing.crs.GeocentricCRS;
+import org.opengis.referencing.crs.GeographicCRS;
+import org.opengis.referencing.crs.GeneralDerivedCRS;
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+
+// OpenGIS dependencies: operations
+import org.opengis.referencing.operation.Matrix;
+import org.opengis.referencing.operation.Conversion;
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.Transformation;
+import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.CoordinateOperation;
+import org.opengis.referencing.operation.MathTransformFactory;
+import org.opengis.referencing.operation.OperationNotFoundException;
+import org.opengis.referencing.operation.NoninvertibleTransformException;
+
+// Geotools dependencies
+import org.geotools.referencing.Factory;
+import org.geotools.referencing.FactoryFinder;
+import org.geotools.referencing.operation.GeneralMatrix;
+import org.geotools.referencing.operation.transform.ProjectiveTransform;
+import org.geotools.referencing.datum.BursaWolfParameters;
+
+// Resources
+import org.geotools.util.WeakHashSet;
+import org.geotools.resources.Utilities;
+import org.geotools.resources.CRSUtilities;
+import org.geotools.resources.cts.Resources;
+import org.geotools.resources.cts.ResourceKeys;
+
+
+/**
+ * Creates {@linkplain CoordinateOperation coordinate operations}. This factory is capable to find
+ * coordinate {@linkplain Transformation transformations} or {@linkplain Conversion conversions}
package org.geotools.referencing.operation;
+
+// J2SE dependencies and extensions
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.units.ConversionException;
+import javax.units.NonSI;
+import javax.units.SI;
+import javax.units.Unit;
+import javax.vecmath.GMatrix;
+import javax.vecmath.SingularMatrixException;
+
+import org.geotools.referencing.Factory;
+import org.geotools.referencing.FactoryFinder;
+import org.geotools.referencing.operation.transform.ProjectiveTransform;
+import org.geotools.resources.CRSUtilities;
+import org.geotools.resources.Utilities;
+import org.geotools.resources.cts.ResourceKeys;
+import org.geotools.resources.cts.Resources;
+import org.geotools.util.WeakHashSet;
+import org.opengis.metadata.Identifier;
+import org.opengis.parameter.ParameterValueGroup;
+import org.opengis.referencing.FactoryException;
+import org.opengis.referencing.IdentifiedObject;
+import org.opengis.referencing.crs.CompoundCRS;
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+import org.opengis.referencing.crs.GeneralDerivedCRS;
+import org.opengis.referencing.crs.GeocentricCRS;
+import org.opengis.referencing.crs.GeographicCRS;
+import org.opengis.referencing.crs.ProjectedCRS;
+import org.opengis.referencing.crs.SingleCRS;
+import org.opengis.referencing.crs.TemporalCRS;
+import org.opengis.referencing.crs.VerticalCRS;
+import org.opengis.referencing.cs.AxisDirection;
+import org.opengis.referencing.cs.CartesianCS;
+import org.opengis.referencing.cs.CoordinateSystem;
+import org.opengis.referencing.cs.CoordinateSystemAxis;
+import org.opengis.referencing.cs.EllipsoidalCS;
+import org.opengis.referencing.cs.TimeCS;
+import org.opengis.referencing.cs.VerticalCS;
+import org.opengis.referencing.datum.Ellipsoid;
+import org.opengis.referencing.datum.GeodeticDatum;
+import org.opengis.referencing.datum.PrimeMeridian;
+import org.opengis.referencing.datum.TemporalDatum;
+import org.opengis.referencing.datum.VerticalDatum;
+import org.opengis.referencing.operation.Conversion;
+import org.opengis.referencing.operation.CoordinateOperation;
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.MathTransformFactory;
+import org.opengis.referencing.operation.Matrix;
+import org.opengis.referencing.operation.NoninvertibleTransformException;
+import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.OperationNotFoundException;
+import org.opengis.referencing.operation.Transformation;
+import org.opengis.util.InternationalString;
+
+
+/**
+ * Creates {@linkplain CoordinateOperation coordinate operations}. This factory is capable to find
+ * coordinate {@linkplain Transformation transformations} or {@linkplain Conversion conversions}
 * WEST). Compute the amount of angle to add to the source longitude in order to
+ * get the destination longitude. This amount is measured in units of the target
+ * axis.  The affine transform is then updated in order to take this rotation in
+ * account. Note that the resulting longitude may be outside the usual [-180..180°]
+ * range.
+ */
+final Unit              unit = axis.getUnit();
 * WEST). Compute the amount of angle to add to the source longitude in order to
+ * get the destination longitude. This amount is measured in units of the target
+ * axis.  The affine transform is then updated in order to take this rotation in
+ * account. Note that the resulting longitude may be outside the usual [-180..180�]
+ * range.
+ */
+final Unit              unit = axis.getUnit();
* @throws FactoryException If the operation can't be constructed.
+*
+* @todo When rotating the prime meridian, we should ensure that
+*       transformed longitudes stay in the range [-180..+180°].
+*
+* @todo We should use Molodenski transforms when applicable.
+*/
* @throws FactoryException If the operation can't be constructed.
+*
+* @todo When rotating the prime meridian, we should ensure that
+*       transformed longitudes stay in the range [-180..+180�].
+*
+* @todo We should use Molodenski transforms when applicable.
+*/
 * different. Note: this special block is mandatory for avoiding never-ending loop,
+ * since it is invoked by 'createOperationStep(GeocentricCRS...)'.
+ *
+ * TODO: We should ensure that longitude is in range [-180..+180°].
+ */
+// TODO: remove cast once we will be allowed to compile for J2SE 1.5.
+final EllipsoidalCS sourceCS = (EllipsoidalCS) sourceCRS.getCoordinateSystem();
 * different. Note: this special block is mandatory for avoiding never-ending loop,
+ * since it is invoked by 'createOperationStep(GeocentricCRS...)'.
+ *
+ * TODO: We should ensure that longitude is in range [-180..+180�].
+ */
+// TODO: remove cast once we will be allowed to compile for J2SE 1.5.
+final EllipsoidalCS sourceCS = (EllipsoidalCS) sourceCRS.getCoordinateSystem();
+
+ + Propchange: sis/ip-review/rev/10796/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/10796/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/20874/CoordinateOperationFinder.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/CoordinateOperationFinder.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/20874/CoordinateOperationFinder.xhtml (added) +++ sis/ip-review/rev/20874/CoordinateOperationFinder.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,65 @@ + + + + + CoordinateOperationFinder changes for revisions 20873:20874 + + + +
+

CoordinateOperationFinder changes for revisions 20873:20874

+

Changes in GeoTools header only. The removal of the "or (at your option) any later version" clause +must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing. +This header does not apply to Apache SIS, since the above-cited contributions are omitted.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultCoordinateOperationFactory.java
+ + + + + + +
Revision 20873Revision 20874
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2004, Geotools Project Managment Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+ *    License as published by the Free Software Foundation; either
+ *    version 2.1 of the License, or (at your option) any later version.
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
/*
+ *    GeoTools - OpenSource mapping toolkit
+ *    http://geotools.org
+ *    (C) 2004-2006, GeoTools Project Managment Committee (PMC)
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+ *    License as published by the Free Software Foundation;
+ *    version 2.1 of the License.
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    You should have received a copy of the GNU Lesser General Public
+*    License along with this library; if not, write to the Free Software
+*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+*
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/
*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/
+
+ + Propchange: sis/ip-review/rev/20874/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/20874/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/20874/CoordinateOperationRegistry.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/CoordinateOperationRegistry.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/20874/CoordinateOperationRegistry.xhtml (added) +++ sis/ip-review/rev/20874/CoordinateOperationRegistry.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,60 @@ + + + + + CoordinateOperationRegistry changes for revisions 20873:20874 + + + +
+

CoordinateOperationRegistry changes for revisions 20873:20874

+

Changes in GeoTools header only. The removal of the "or (at your option) any later version" clause +must be keep in Geotk for every classes having contribution from a developer other than those who accepted re-licensing. +This header does not apply to Apache SIS, since the above-cited contributions are omitted.

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AuthorityBackedFactory.java
+ + + + +
Revision 20873Revision 20874
/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2005, Geotools Project Managment Committee (PMC)
+ * (C) 2005, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+ *    License as published by the Free Software Foundation; either
+ *    version 2.1 of the License, or (at your option) any later version.
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ *
+ *    You should have received a copy of the GNU Lesser General Public
+ *    License along with this library; if not, write to the Free Software
+ *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+package org.geotools.referencing.operation;
/*
+ *    GeoTools - OpenSource mapping toolkit
+ *    http://geotools.org
+ *    (C) 2005-2006, GeoTools Project Managment Committee (PMC)
+ * (C) 2005, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+ *    License as published by the Free Software Foundation;
+ *    version 2.1 of the License.
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing.operation;
+
+ + Propchange: sis/ip-review/rev/20874/CoordinateOperationRegistry.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/20874/CoordinateOperationRegistry.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/25050/CoordinateOperationFinder.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/CoordinateOperationFinder.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/25050/CoordinateOperationFinder.xhtml (added) +++ sis/ip-review/rev/25050/CoordinateOperationFinder.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,36 @@ + + + + + CoordinateOperationFinder changes for revisions 25049:25050 + + + +
+

CoordinateOperationFinder changes for revisions 25049:25050

+ +

This class renaming (FactoryFinder to ReferencingFactoryFinder) does not apply to Apache SIS +since we did not ported those finders. We intend to use dependency injection instead.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/DefaultCoordinateOperationFactory.java
+ + + + +
Revision 25049Revision 25050
// Geotools dependencies
+import org.geotools.factory.Hints;
+import org.geotools.referencing.FactoryFinder;
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.crs.DefaultCompoundCRS;
+import org.geotools.referencing.crs.DefaultEngineeringCRS;
// Geotools dependencies
+import org.geotools.factory.Hints;
+import org.geotools.referencing.ReferencingFactoryFinder;
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.crs.DefaultCompoundCRS;
+import org.geotools.referencing.crs.DefaultEngineeringCRS;
+
+ + Propchange: sis/ip-review/rev/25050/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/25050/CoordinateOperationFinder.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/25050/CoordinateOperationRegistry.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/CoordinateOperationRegistry.xhtml?rev=1753378&view=auto ============================================================================== --- sis/ip-review/rev/25050/CoordinateOperationRegistry.xhtml (added) +++ sis/ip-review/rev/25050/CoordinateOperationRegistry.xhtml Tue Jul 19 12:39:59 2016 @@ -0,0 +1,66 @@ + + + + + CoordinateOperationRegistry changes for revisions 25049:25050 + + + +
+

CoordinateOperationRegistry changes for revisions 25049:25050

+ +

This class renaming (FactoryFinder to ReferencingFactoryFinder) does not apply to Apache SIS +since we did not ported those finders. We intend to use dependency injection instead.

+ +

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AuthorityBackedFactory.java
+ + + + + + + + +
Revision 25049Revision 25050
import org.geotools.factory.OptionalFactory;
+import org.geotools.factory.FactoryRegistryException;
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.FactoryFinder;
+import org.geotools.referencing.factory.BackingStoreException;
+import org.geotools.resources.i18n.Logging;
+import org.geotools.resources.i18n.LoggingKeys;
import org.geotools.factory.OptionalFactory;
+import org.geotools.factory.FactoryRegistryException;
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.ReferencingFactoryFinder;
+import org.geotools.referencing.factory.BackingStoreException;
+import org.geotools.resources.i18n.Logging;
+import org.geotools.resources.i18n.LoggingKeys;
    hints.keySet().removeAll(this.hints.keySet());
+    if (!hints.isEmpty()) {
+        noForce(hints);
+        authorityFactory = FactoryFinder.getCoordinateOperationAuthorityFactory(
+                DEFAULT_AUTHORITY, hints);
+    }
+}
    hints.keySet().removeAll(this.hints.keySet());
+    if (!hints.isEmpty()) {
+        noForce(hints);
+        authorityFactory = ReferencingFactoryFinder.getCoordinateOperationAuthorityFactory(
+                DEFAULT_AUTHORITY, hints);
+    }
+}
     */
+    final Hints hints = new Hints(null);
+    noForce(hints);
+    authorityFactory = FactoryFinder
+            .getCoordinateOperationAuthorityFactory(DEFAULT_AUTHORITY, hints);
+}
+return authorityFactory;
     */
+    final Hints hints = new Hints(null);
+    noForce(hints);
+    authorityFactory = ReferencingFactoryFinder
+            .getCoordinateOperationAuthorityFactory(DEFAULT_AUTHORITY, hints);
+}
+return authorityFactory;
+
+ + Propchange: sis/ip-review/rev/25050/CoordinateOperationRegistry.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/25050/CoordinateOperationRegistry.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html