Author: desruisseaux Date: Thu Dec 10 14:11:24 2015 New Revision: 1719084 URL: http://svn.apache.org/viewvc?rev=1719084&view=rev Log: Add IP review for AuthorityFactoryProxyTest. Added: sis/ip-review/AuthorityFactoryProxyTest.xhtml (with props) sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml (with props) Added: sis/ip-review/AuthorityFactoryProxyTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/AuthorityFactoryProxyTest.xhtml?rev=1719084&view=auto ============================================================================== --- sis/ip-review/AuthorityFactoryProxyTest.xhtml (added) +++ sis/ip-review/AuthorityFactoryProxyTest.xhtml Thu Dec 10 14:11:24 2015 @@ -0,0 +1,38 @@ + + + + + AuthorityFactoryProxyTest history + + + +
+

AuthorityFactoryProxyTest history

+

Click on the commit message for inspecting the diff and how the code has been rewritten.

+

Command line:

+
svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/AuthorityFactoryProxyTest.java
+ + + + + + + + + + + + + + + + + + + +
Rev.DateAuthorMessage
306412008-06-12acusterCopyright headers: lib/referencing, this time with feeling (and the el in Toolkit)
305212008-06-05acusterCopyright: Update referencing headers
302582008-05-08acusterReshuffle the top level repo: drop uDig, move up trunk, tags, and branches.
302572008-05-08acusterMove trunk/gt/ directory contents up to trunk/ and drop gt
297682008-04-02desruisseauxUpgrated the metadata and referencing tests to JUnit 4.
289222008-01-24acusterBump the (at)since version to 2.5 since WKTParser was cut from 2.4
285402007-12-29acusterHide buttons which are not yet used
253962007-05-01desruisseauxGEOT-1160 now work with ordered axis (tests added). Added an implementation for fallback factories, but not yet tested.
253742007-04-27desruisseauxMore GEOT-1160 work: should now work with TransformedAuthorityFactory (not yet tested).
250502007-04-06jgarnettexample of custom file based TestSutie, copy JTS parsing code over to unsupported/geometry
245762007-02-24desruisseauxRenamed 'StereographicFoo' classes as 'FooStereographic' for consistency with EPSG and OGC naming. Note that 'ObliqueStereographic' is NOT the new name for 'StereographicOblique'; it is rather the new name for 'StereographicDouble'. The old name was confusing since 'StereographicOblique' was not for the EPSG 'Oblique_Stereographic' projection. The new naming scheme should match more closely the common usage. In addition, also renamed some JUnit test classes in an attempt to make clearer what they are testing.
243842007-02-14desruisseauxGEOT-1160: First working implementation of AbstractAuthorityFactory.find(IdentifiedObject). This includes a package-privated AuthorityFactoryProxy class, together with many fix in the code base in order to get CRS.equalsIgnoreCase to work in the ProjectedCRS case.
+
+ + Propchange: sis/ip-review/AuthorityFactoryProxyTest.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/AuthorityFactoryProxyTest.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html Added: sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml?rev=1719084&view=auto ============================================================================== --- sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml (added) +++ sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml Thu Dec 10 14:11:24 2015 @@ -0,0 +1,67 @@ + + + + + AuthorityFactoryProxyTest changes for revisions 25049:25050 + + + +
+

AuthorityFactoryProxyTest changes for revisions 25049:25050

+

+ The only change in this commit is to rename FactoryFinder as ReferencingFactoryFinder. + However this change does not apply to SIS since we do not plan to port [Referencing]FactoryFinder. + The plan is to replace them by some dependency injection mechanism. +

+

Command line:

+
svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/AuthorityFactoryProxyTest.java
+ + + + + + + + +
Revision 25049Revision 25050
// Geotools dependencies
+import org.geotools.referencing.crs.*;
+import org.geotools.referencing.datum.*;
+import org.geotools.referencing.FactoryFinder;
+
+
+/**
// Geotools dependencies
+import org.geotools.referencing.crs.*;
+import org.geotools.referencing.datum.*;
+import org.geotools.referencing.ReferencingFactoryFinder;
+
+
+/**
 * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreate() throws FactoryException {
+    final CRSAuthorityFactory factory = FactoryFinder.getCRSAuthorityFactory("CRS", null);
+    final CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("83");
+    AuthorityFactoryProxy proxy;
+    /*
 * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreate() throws FactoryException {
+    final CRSAuthorityFactory factory = ReferencingFactoryFinder.getCRSAuthorityFactory("CRS", null);
+    final CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("83");
+    AuthorityFactoryProxy proxy;
+    /*
 * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreateEquivalent() throws FactoryException {
+    final CRSAuthorityFactory factory = FactoryFinder.getCRSAuthorityFactory("CRS", null);
+    final AuthorityFactoryProxy proxy = AuthorityFactoryProxy.getInstance(GeographicCRS.class, factory);
+    CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("84");
+    assertSame   (expected, proxy.create("84"));
 * Tests {@link AuthorityFactoryProxy#create}. We uses the CRS factory for testing purpose.
+ */
+public void testCreateEquivalent() throws FactoryException {
+    final CRSAuthorityFactory factory = ReferencingFactoryFinder.getCRSAuthorityFactory("CRS", null);
+    final AuthorityFactoryProxy proxy = AuthorityFactoryProxy.getInstance(GeographicCRS.class, factory);
+    CoordinateReferenceSystem expected = factory.createCoordinateReferenceSystem("84");
+    assertSame   (expected, proxy.create("84"));
+
+ + Propchange: sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml ------------------------------------------------------------------------------ svn:eol-style = native Propchange: sis/ip-review/rev/25050/AuthorityFactoryProxyTest.xhtml ------------------------------------------------------------------------------ svn:mime-type = text/html