sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1719045 - in /sis/ip-review: ./ rev/11096/ rev/20874/ rev/25050/ rev/25896/ rev/26212/
Date Thu, 10 Dec 2015 09:49:57 GMT
Author: desruisseaux
Date: Thu Dec 10 09:49:56 2015
New Revision: 1719045

URL: http://svn.apache.org/viewvc?rev=1719045&view=rev
Log:
Added IP review for the factory of "CRS:xx" codes.

Added:
    sis/ip-review/CommonAuthorityFactory.xhtml   (with props)
    sis/ip-review/CommonAuthorityFactoryTest.xhtml   (with props)
    sis/ip-review/rev/11096/CommonAuthorityFactoryTest.xhtml   (with props)
    sis/ip-review/rev/20874/CommonAuthorityFactory.xhtml   (with props)
    sis/ip-review/rev/20874/CommonAuthorityFactoryTest.xhtml   (with props)
    sis/ip-review/rev/25050/CommonAuthorityFactoryTest.xhtml   (with props)
    sis/ip-review/rev/25896/
    sis/ip-review/rev/25896/CommonAuthorityFactoryTest.xhtml   (with props)
    sis/ip-review/rev/25896/HEADER.html   (with props)
    sis/ip-review/rev/26212/CommonAuthorityFactoryTest.xhtml   (with props)

Added: sis/ip-review/CommonAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/CommonAuthorityFactory.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/CommonAuthorityFactory.xhtml (added)
+++ sis/ip-review/CommonAuthorityFactory.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,46 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactory history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactory history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/wms/WebCRSFactory.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31593</td><td>2008-09-25</td><td>desruisseaux</td><td>Bug
fixes: 1) wrong field set in metadata 2) missing conversion between float[] and double[] array.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation;
rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">27567</td><td>2007-10-20</td><td>desruisseaux</td><td>Merged
changes form 2.4 branch (include addition of Hints.FORCE_AXIS_ORDER_HONORING).</td></tr>
+<tr><td class="rev">25972</td><td>2007-06-21</td><td>desruisseaux</td><td>Replaced
usage of deprecated classes/methods by the new ones. A side effect is to restore the buffering
in ThreadedEpsgFactory, which was partially disabled by class name changes.</td></tr>
+<tr><td class="rev">23632</td><td>2006-12-29</td><td>desruisseaux</td><td>GEOT-859:
Refactored the URN syntax adapter for CRS factories. The adapter now apply to any factory.
Some progress toward version management (but not yet there). NOTE: this new implementation
forces axis order "as specified in the database", which is different from the original "URNEPSGAdapter"
implementation which used (x,y) order. Various changes in many corners of "org.geotools.referencing.factory"
as a side-effect of this work. Minor opportunist javadoc fixes in other modules.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">21175</td><td>2006-08-23</td><td>desruisseaux</td><td>Fixed
deadlock (GEOT-935)</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/CommonAuthorityFactory.xhtml">ip review</a></td></tr>
+<tr><td class="rev">19755</td><td>2006-05-31</td><td>desruisseaux</td><td>Added
FORCE_LONGITUDE_FIRST_AXIS_ORDER hint (GEOT-858). This work implied a large amount of work,
hunting for infinite recursive method calls in many places.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">17449</td><td>2006-01-03</td><td>desruisseaux</td><td>Added
AllAuthoritiesFactory in referencing module. Maven 2 build fixes. Javadoc fixes.</td></tr>
+<tr><td class="rev">16982</td><td>2005-11-25</td><td>desruisseaux</td><td>Copied
AUTO factory from plugin/epsg-wkt to module/referencing (GEOT-773). Not yet tested neither
enabled.</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/CommonAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/CommonAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/CommonAuthorityFactoryTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/CommonAuthorityFactoryTest.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/CommonAuthorityFactoryTest.xhtml (added)
+++ sis/ip-review/CommonAuthorityFactoryTest.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,61 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactoryTest history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactoryTest history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/wms/CRSTest.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30639</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: cleanup library/referencing</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">29768</td><td>2008-04-02</td><td>desruisseaux</td><td>Upgrated
the metadata and referencing tests to JUnit 4.</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28051</td><td>2007-11-26</td><td>desruisseaux</td><td>More
Java 5 parameterized types. Include a fix for GEOT-1599 (CitationImpl.getIdentifiers() should
returns a set of Identifiers, not a set of Strings).</td></tr>
+<tr><td class="rev">27847</td><td>2007-11-12</td><td>desruisseaux</td><td>Replaced
some references to 'org.geotools.util' by references to 'org.geotools.util.logging'. Removed
the old classes to make sure that there is no more accidental references. Note that the old
classes will not be removed from the 2.4 branch.</td></tr>
+<tr><td class="rev">26212</td><td>2007-07-12</td><td class="unav">jgarnett</td><td><a
href="rev/26212/CommonAuthorityFactoryTest.xhtml">Took AuthorityFactory2 out of the way,
extended AbstractAuthorityFactory the way martin intentended, and started hooking up Finder
implementations that use a shared ObjectCache. Set up a Level1/Level2 ObjectCache chain in
order to allow the finder's cache to pull in values from the real one.</a></td></tr>
+<tr><td class="rev">25943</td><td>2007-06-20</td><td>desruisseaux</td><td>Minor
cleaning (mainly reformating).</td></tr>
+<tr><td class="rev">25896</td><td>2007-06-19</td><td class="unav">jgarnett</td><td><a
href="rev/25896/CommonAuthorityFactoryTest.xhtml">Grabbed out BufferedAuthorityFactory
functionality into ThreadedAuthorityFactory as prep high volume crs services</a></td></tr>
+<tr><td class="rev">25396</td><td>2007-05-01</td><td>desruisseaux</td><td>GEOT-1160
now work with ordered axis (tests added). Added an implementation for fallback factories,
but not yet tested.</td></tr>
+<tr><td class="rev">25389</td><td>2007-04-30</td><td>desruisseaux</td><td>GEOT-1160:
Make IdentifiedObjectFinder public, so we can keep AbstractAuthorityFactory a little bit simplier
(less methods there).</td></tr>
+<tr><td class="rev">25050</td><td>2007-04-06</td><td class="unav">jgarnett</td><td><a
href="rev/25050/CommonAuthorityFactoryTest.xhtml">example of custom file based TestSutie,
copy JTS parsing code over to unsupported/geometry</a></td></tr>
+<tr><td class="rev">24990</td><td>2007-04-03</td><td class="unav">chorner</td><td><a
href="rev/25050/CommonAuthorityFactoryTest.xhtml">Metadata; corrections after review of
r24868</a></td></tr>
+<tr><td class="rev">24868</td><td>2007-03-22</td><td class="unav">jgarnett</td><td><a
href="rev/25050/CommonAuthorityFactoryTest.xhtml">clean up metadata and referencing in
response to GEO-93</a></td></tr>
+<tr><td class="rev">24576</td><td>2007-02-24</td><td>desruisseaux</td><td>Renamed
'StereographicFoo' classes as 'FooStereographic' for consistency with EPSG and OGC naming.
Note that 'ObliqueStereographic' is NOT the new name for 'StereographicOblique'; it is rather
the new name for 'StereographicDouble'. The old name was confusing since 'StereographicOblique'
was not for the EPSG 'Oblique_Stereographic' projection. The new naming scheme should match
more closely the common usage. In addition, also renamed some JUnit test classes in an attempt
to make clearer what they are testing.</td></tr>
+<tr><td class="rev">24384</td><td>2007-02-14</td><td>desruisseaux</td><td>GEOT-1160:
First working implementation of AbstractAuthorityFactory.find(IdentifiedObject). This includes
a package-privated AuthorityFactoryProxy class, together with many fix in the code base in
order to get CRS.equalsIgnoreCase to work in the ProjectedCRS case.</td></tr>
+<tr><td class="rev">23632</td><td>2006-12-29</td><td>desruisseaux</td><td>GEOT-859:
Refactored the URN syntax adapter for CRS factories. The adapter now apply to any factory.
Some progress toward version management (but not yet there). NOTE: this new implementation
forces axis order "as specified in the database", which is different from the original "URNEPSGAdapter"
implementation which used (x,y) order. Various changes in many corners of "org.geotools.referencing.factory"
as a side-effect of this work. Minor opportunist javadoc fixes in other modules.</td></tr>
+<tr><td class="rev">22997</td><td>2006-11-26</td><td>desruisseaux</td><td>Replaced
the use of some deprecated methods (MonolineFormatter.initGeotools --> Logging.forceMonolineConsoleOutput;
Utilities.unexpectedException --> Logging.unexpectedException; GeneralEnvelope.getCoordinateReferenceSystem
--> Envelope.getCoordinateReferenceSystem).</td></tr>
+<tr><td class="rev">22443</td><td>2006-10-27</td><td>desruisseaux</td><td>Splitted
referencing, extracting metadata in their own module (GEOT-983). As a side effect, replaced
some calls of CRSUtilities.foo(...) by CRS.foo(...).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22317</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 3: moved 'test' to 'src/test/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/CommonAuthorityFactoryTest.xhtml">ip review</a></td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">17449</td><td>2006-01-03</td><td>desruisseaux</td><td>Added
AllAuthoritiesFactory in referencing module. Maven 2 build fixes. Javadoc fixes.</td></tr>
+<tr><td class="rev">17039</td><td>2005-11-28</td><td>desruisseaux</td><td>Enabled
the new AUTO authority factory as a replacement of the old one (GEOT-773)</td></tr>
+<tr><td class="rev">17038</td><td>2005-11-28</td><td>desruisseaux</td><td>Copied
the AutoTest. Tuned AutoCRSFactory implementation (GEOT-773)</td></tr>
+<tr><td class="rev">13117</td><td>2005-04-14</td><td>desruisseaux</td><td>Renamed
'plugin/epsg' as 'plugin/epsg-wkt' in anticipation to the addition of HSQL based EPSG factory</td></tr>
+<tr><td class="rev">11096</td><td>2005-02-04</td><td class="unav">jgarnett</td><td><a
href="rev/11096/CommonAuthorityFactoryTest.xhtml">Updated AUTO, AUTO2 and EPSG metadata
with appropriate identifier and contact info</a></td></tr>
+<tr><td class="rev">11035</td><td>2005-02-02</td><td class="unav">jgarnett</td><td><a
href="rev/11096/CommonAuthorityFactoryTest.xhtml">And here is the test AUTO works as expected.</a></td></tr>
+<tr><td class="rev">11006</td><td>2005-02-02</td><td class="unav">jgarnett</td><td><a
href="rev/11096/CommonAuthorityFactoryTest.xhtml">CRS decode and FactoryFinder (Referencing)
can now locate CRSEPSGAuthorityFactory</a></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/11096/CommonAuthorityFactoryTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/11096/CommonAuthorityFactoryTest.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/rev/11096/CommonAuthorityFactoryTest.xhtml (added)
+++ sis/ip-review/rev/11096/CommonAuthorityFactoryTest.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,72 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactoryTest changes for revisions 11005:11096</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactoryTest changes for revisions 11005:11096</h1>
+      <p>The test added by this commit will not be ported to SIS.
+      Replaced by GIGS tests.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r11005:11096 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/wms/CRSTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 11096</th></tr>
+<tr>
+<td><pre><span class="add">/*</span>
+<span class="add"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="add"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+<span class="add"> *</span>
+<span class="add"> *    This library is free software; you can redistribute it and/or</span>
+<span class="add"> *    modify it under the terms of the GNU Lesser General Public</span>
+<span class="add"> *    License as published by the Free Software Foundation; either</span>
+<span class="add"> *    version 2.1 of the License, or (at your option) any later version.</span>
+<span class="add"> *</span>
+<span class="add"> *    This library is distributed in the hope that it will be useful,</span>
+<span class="add"> *    but WITHOUT ANY WARRANTY; without even the implied warranty
of</span>
+<span class="add"> *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU</span>
+<span class="add"> *    Lesser General Public License for more details.</span>
+<span class="add"> *</span>
+<span class="add"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="add"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="add"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+<span class="add"> */</span>
+<span class="add">package org.geotools.referencing.crs;</span>
+<span class="add"></span>
+<span class="add">import junit.framework.TestCase;</span>
+<span class="add"></span>
+<span class="add">import org.geotools.referencing.CRS;</span>
+<span class="add">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+<span class="add"></span>
+<span class="add">/**</span>
+<span class="add"> * Ensure that FactoryFinder can cope.</span>
+<span class="add"> *</span>
+<span class="add"> * @author Jody Garnett</span>
+<span class="add"> * @since 2.1.M3</span>
+<span class="add"> * @version 2.1.M3</span>
+<span class="add"> */</span>
+<span class="add">public class AUTOTest extends TestCase {</span>
+<span class="add">    AUTOCRSAuthorityFactory factory;</span>
+<span class="add">    /*</span>
+<span class="add">     * @see junit.framework.TestCase#setUp()</span>
+<span class="add">     */</span>
+<span class="add">    protected void setUp() throws Exception {</span>
+<span class="add">        super.setUp();</span>
+<span class="add">        factory = new AUTOCRSAuthorityFactory();</span>
+<span class="add">    }</span>
+<span class="add">    /** UDIG requires this to work */</span>
+<span class="add">    public void test42001() throws Exception {</span>
+<span class="add">        CoordinateReferenceSystem utm =</span>
+<span class="add">            (CoordinateReferenceSystem) factory.createObject("AUTO:42001,0.0,0.0");</span>
+<span class="add">        assertNotNull( "auto-utm", utm );</span>
+<span class="add">    }</span>
+<span class="add">}</span></pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/11096/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/11096/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/CommonAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/CommonAuthorityFactory.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/rev/20874/CommonAuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/20874/CommonAuthorityFactory.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,58 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactory changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactory changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the <cite>"or (at your option)
any later version"</cite> clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/wms/WebCRSFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2005 Geotools Project Managment Committee (PMC)</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.referencing.factory.wms;</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2005-2006, GeoTools Project Managment Committee (PMC)</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing.factory.wms;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/CommonAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/CommonAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/CommonAuthorityFactoryTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/CommonAuthorityFactoryTest.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/rev/20874/CommonAuthorityFactoryTest.xhtml (added)
+++ sis/ip-review/rev/20874/CommonAuthorityFactoryTest.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactoryTest changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactoryTest changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the <cite>"or (at your option)
any later version"</cite> clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/wms/CRSTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2004, Geotools Project Managment Committee (PMC)</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2004-2006, Geotools Project Managment Committee (PMC)</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty
of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+<span class="del"> *</span>
+<span class="del"> *    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del"> *    License along with this library; if not, write to the Free
Software</span>
+<span class="del"> *    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+ */
+package org.geotools.referencing.factory.wms;</pre></td>
+<td><pre> *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *    Lesser General Public License for more details.
+ */
+package org.geotools.referencing.factory.wms;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/CommonAuthorityFactoryTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/CommonAuthorityFactoryTest.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/rev/25050/CommonAuthorityFactoryTest.xhtml (added)
+++ sis/ip-review/rev/25050/CommonAuthorityFactoryTest.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactoryTest changes for revisions 24867:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactoryTest changes for revisions 24867:25050</h1>
+<p>
+  The only change in this commit is to rename <code>FactoryFinder</code> as <code>ReferencingFactoryFinder</code>.
+  However this change does not apply to SIS since we do not plan to port <code>[Referencing]FactoryFinder</code>.
+  The plan is to replace them by some dependency injection mechanism.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24867:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/wms/CRSTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24867</th><th>Revision 25050</th></tr>
+<tr><td><pre>// Geotools dependencies
+import org.geotools.referencing.CRS;
+import org.geotools.resources.Arguments;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.referencing.crs.DefaultGeographicCRS;
+import org.geotools.referencing.factory.AbstractAuthorityFactory;</pre></td>
+<td><pre>// Geotools dependencies
+import org.geotools.referencing.CRS;
+import org.geotools.resources.Arguments;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.referencing.crs.DefaultGeographicCRS;
+import org.geotools.referencing.factory.AbstractAuthorityFactory;</pre></td></tr>
+<tr><td><pre>}
+
+/**
+<span class="del"> * Tests the registration in {@link FactoryFinder}.</span>
+ */
+public void testFactoryFinder() {
+<span class="del">    final Collection authorities = FactoryFinder.getAuthorityNames();</span>
+    assertTrue(authorities.contains("CRS"));
+<span class="del">    factory = FactoryFinder.getCRSAuthorityFactory("CRS", null);</span>
+    assertTrue(factory instanceof WebCRSFactory);
+}</pre></td>
+<td><pre>}
+
+/**
+<span class="add"> * Tests the registration in {@link ReferencingFactoryFinder}.</span>
+ */
+public void testFactoryFinder() {
+<span class="add">    final Collection authorities = ReferencingFactoryFinder.getAuthorityNames();</span>
+    assertTrue(authorities.contains("CRS"));
+<span class="add">    factory = ReferencingFactoryFinder.getCRSAuthorityFactory("CRS",
null);</span>
+    assertTrue(factory instanceof WebCRSFactory);
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25896/CommonAuthorityFactoryTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25896/CommonAuthorityFactoryTest.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/rev/25896/CommonAuthorityFactoryTest.xhtml (added)
+++ sis/ip-review/rev/25896/CommonAuthorityFactoryTest.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,49 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactoryTest changes for revisions 25895:25896</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactoryTest changes for revisions 25895:25896</h1>
+      <p>This change does not apply to SIS since there is no more separation between
<code>BufferedAuthorityFactory</code> and <code>ThreadedAuthorityFactory</code>.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r25895:25896 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/wms/CRSTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25895</th><th>Revision 25896</th></tr>
+<tr><td><pre>import org.geotools.referencing.factory.IdentifiedObjectFinder;
+import org.geotools.referencing.factory.AbstractAuthorityFactory;
+import org.geotools.referencing.factory.BufferedAuthorityFactory;
+
+
+/**</pre></td>
+<td><pre>import org.geotools.referencing.factory.IdentifiedObjectFinder;
+import org.geotools.referencing.factory.AbstractAuthorityFactory;
+import org.geotools.referencing.factory.BufferedAuthorityFactory;
+<span class="add">import org.geotools.referencing.factory.ThreadedAuthorityFactory;</span>
+
+
+/**</pre></td></tr>
+<tr><td><pre>/**
+ * For {@link #testBufferedFind}.
+ */
+<span class="del">private static final class Buffered extends BufferedAuthorityFactory
implements CRSAuthorityFactory {</span>
+    Buffered(final AbstractAuthorityFactory factory) {
+        super(factory);
+    }</pre></td>
+<td><pre>/**
+ * For {@link #testBufferedFind}.
+ */
+<span class="add">private static final class Buffered extends ThreadedAuthorityFactory
implements CRSAuthorityFactory {</span>
+    Buffered(final AbstractAuthorityFactory factory) {
+        super(factory);
+    }</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25896/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25896/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25896/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25896/HEADER.html?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/rev/25896/HEADER.html (added)
+++ sis/ip-review/rev/25896/HEADER.html Thu Dec 10 09:49:56 2015
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 25896</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 25896</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-06-19</td></tr>
+  <tr><td><b>Message:</b></td><td>Grabbed out BufferedAuthorityFactory
functionality into ThreadedAuthorityFactory as prep high volume crs services</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25896/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25896/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/26212/CommonAuthorityFactoryTest.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/26212/CommonAuthorityFactoryTest.xhtml?rev=1719045&view=auto
==============================================================================
--- sis/ip-review/rev/26212/CommonAuthorityFactoryTest.xhtml (added)
+++ sis/ip-review/rev/26212/CommonAuthorityFactoryTest.xhtml Thu Dec 10 09:49:56 2015
@@ -0,0 +1,113 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CommonAuthorityFactoryTest changes for revisions 26211:26212</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CommonAuthorityFactoryTest changes for revisions 26211:26212</h1>
+      <p>This change does not apply to SIS since we did not ported any of the <code>AuthorityDecorator</code>.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r26211:26212 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/test/java/org/geotools/referencing/factory/wms/CRSTest.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 26211</th><th>Revision 26212</th></tr>
+<tr><td><pre>import java.util.Collection;
+import java.util.logging.Level;
+
+<span class="del">// JUnit dependencies</span>
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.referencing.FactoryException;</span>
+<span class="del">import org.opengis.referencing.crs.GeographicCRS;</span>
+<span class="del">import org.opengis.referencing.crs.CRSAuthorityFactory;</span>
+<span class="del">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+<span class="del"></span>
+<span class="del">// Geotools dependencies</span>
+import org.geotools.referencing.CRS;
+<span class="del">import org.geotools.resources.Arguments;</span>
+import org.geotools.referencing.ReferencingFactoryFinder;
+import org.geotools.referencing.crs.DefaultGeographicCRS;
+import org.geotools.referencing.factory.IdentifiedObjectFinder;
+<span class="del">import org.geotools.referencing.factory.AbstractAuthorityFactory;</span>
+<span class="del">import org.geotools.referencing.factory.ThreadedAuthorityFactory;</span>
+
+<span class="del"></span>
+/**
+ * Tests {@link WebCRSFactory}.
+ *</pre></td>
+<td><pre>import java.util.Collection;
+import java.util.logging.Level;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+import org.geotools.referencing.CRS;
+import org.geotools.referencing.ReferencingFactoryFinder;
+import org.geotools.referencing.crs.DefaultGeographicCRS;
+<span class="add">import org.geotools.referencing.factory.AbstractAuthorityFactory;</span>
+<span class="add">import org.geotools.referencing.factory.CachedCRSAuthorityDecorator;</span>
+import org.geotools.referencing.factory.IdentifiedObjectFinder;
+<span class="add">import org.geotools.resources.Arguments;</span>
+<span class="add">import org.opengis.referencing.FactoryException;</span>
+<span class="add">import org.opengis.referencing.crs.CRSAuthorityFactory;</span>
+<span class="add">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+<span class="add">import org.opengis.referencing.crs.GeographicCRS;</span>
+
+/**
+ * Tests {@link WebCRSFactory}.
+ *</pre></td></tr>
+<tr><td><pre>/**
+ * The factory to test.
+ */
+<span class="del">private AbstractAuthorityFactory factory;</span>
+
+/**
+ * Run the suite from the command line.</pre></td>
+<td><pre>/**
+ * The factory to test.
+ */
+<span class="add">private WebCRSFactory factory;</span>
+
+/**
+ * Run the suite from the command line.</pre></td></tr>
+<tr><td><pre> * The objects found are expected to be cached.
+ */
+public void testBufferedFind() throws FactoryException {
+<span class="del">    final AbstractAuthorityFactory factory = new Buffered(this.factory);</span>
+    final GeographicCRS CRS84 = factory.createGeographicCRS("CRS:84");
+    final IdentifiedObjectFinder finder = factory.getIdentifiedObjectFinder(CoordinateReferenceSystem.class);</pre></td>
+<td><pre> * The objects found are expected to be cached.
+ */
+public void testBufferedFind() throws FactoryException {
+<span class="add">    final AbstractAuthorityFactory factory = new CachedCRSAuthorityDecorator(this.factory);</span>
+    final GeographicCRS CRS84 = factory.createGeographicCRS("CRS:84");
+    final IdentifiedObjectFinder finder = factory.getIdentifiedObjectFinder(CoordinateReferenceSystem.class);</pre></td></tr>
+<tr><td><pre>        assertEquals("CRS:84", finder.findIdentifier(DefaultGeographicCRS.WGS84));
+    }
+
+<span class="del">    /**</span>
+<span class="del">     * For {@link #testBufferedFind}.</span>
+<span class="del">     */</span>
+<span class="del">    private static final class Buffered extends ThreadedAuthorityFactory
implements CRSAuthorityFactory {</span>
+<span class="del">        Buffered(final AbstractAuthorityFactory factory) {</span>
+<span class="del">            super(factory);</span>
+        }
+<span class="del">    }</span>
+<span class="del">}</span></pre></td>
+<td><pre>    assertEquals("CRS:84", finder.findIdentifier(DefaultGeographicCRS.WGS84));
+}
+
+    }</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/26212/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/26212/CommonAuthorityFactoryTest.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html




Mime
View raw message