sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1718599 [5/6] - in /sis/ip-review: ./ rev/10799/ rev/11112/ rev/12132/ rev/20874/ rev/23110/ rev/24689/ rev/25050/ rev/25916/ rev/25919/ rev/25940/ rev/26059/ rev/26212/ rev/26250/ rev/26290/ rev/29105/ rev/29125/
Date Tue, 08 Dec 2015 13:33:16 GMT
Added: sis/ip-review/rev/24689/FallbackAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24689/FallbackAuthorityFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/24689/FallbackAuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/24689/FallbackAuthorityFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,807 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>FallbackAuthorityFactory changes for revisions 24688:24689</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>FallbackAuthorityFactory changes for revisions 24688:24689</h1>
+      <p>This is a useful commit and it would be hard to ignore if we ported that class…
+        But we do not plan to port <code>FallbackAuthorityFactory</code> to SIS, in an effort to reduce
+        the complexity of authority factory stack.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r24688:24689 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/FallbackAuthorityFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24688</th><th>Revision 24689</th></tr>
+<tr><td><pre>import org.opengis.referencing.IdentifiedObject;
+import org.opengis.referencing.AuthorityFactory;
+import org.opengis.referencing.FactoryException;
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.citation.Citation;
+import org.opengis.parameter.ParameterDescriptor;</pre></td>
+<td><pre>import org.opengis.referencing.IdentifiedObject;
+import org.opengis.referencing.AuthorityFactory;
+import org.opengis.referencing.FactoryException;
+<span class="add">import org.opengis.referencing.NoSuchAuthorityCodeException;</span>
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.citation.Citation;
+import org.opengis.parameter.ParameterDescriptor;</pre></td></tr>
+<tr><td><pre>        return super.getDescriptionText(code);
+    } catch (FactoryException exception) {
+        notifyFailure("getDescriptionText", exception);
+        return fallback.getDescriptionText(code);
+    }
+}
+
+/**
+ * Returns an arbitrary object from a code.</pre></td>
+<td><pre>        return super.getDescriptionText(code);
+    } catch (FactoryException exception) {
+        notifyFailure("getDescriptionText", exception);
+<span class="add">        try {</span>
+        return fallback.getDescriptionText(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns an arbitrary object from a code.</pre></td></tr>
+<tr><td><pre>        return super.createObject(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createObject", exception);
+        return fallback.createObject(code);
+    }
+}
+
+/**
+ * Returns an arbitrary {@linkplain org.opengis.referencing.datum.Datum datum} from a code.</pre></td>
+<td><pre>        return super.createObject(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createObject", exception);
+<span class="add">        try {</span>
+        return fallback.createObject(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns an arbitrary {@linkplain org.opengis.referencing.datum.Datum datum} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createDatum", exception);
+        return fallback.createDatum(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain EngineeringDatum engineering datum} from a code.</pre></td>
+<td><pre>        return super.createDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createDatum", exception);
+<span class="add">        try {</span>
+        return fallback.createDatum(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain EngineeringDatum engineering datum} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createEngineeringDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEngineeringDatum", exception);
+        return fallback.createEngineeringDatum(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain ImageDatum image datum} from a code.</pre></td>
+<td><pre>        return super.createEngineeringDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEngineeringDatum", exception);
+<span class="add">        try {</span>
+        return fallback.createEngineeringDatum(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain ImageDatum image datum} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createImageDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createImageDatum", exception);
+        return fallback.createImageDatum(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain VerticalDatum vertical datum} from a code.</pre></td>
+<td><pre>        return super.createImageDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createImageDatum", exception);
+<span class="add">        try {</span>
+        return fallback.createImageDatum(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain VerticalDatum vertical datum} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createVerticalDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createVerticalDatum", exception);
+        return fallback.createVerticalDatum(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain TemporalDatum temporal datum} from a code.</pre></td>
+<td><pre>        return super.createVerticalDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createVerticalDatum", exception);
+<span class="add">        try {</span>
+        return fallback.createVerticalDatum(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain TemporalDatum temporal datum} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createTemporalDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createTemporalDatum", exception);
+        return fallback.createTemporalDatum(code);
+    }
+}
+
+/**
+ * Returns a {@linkplain GeodeticDatum geodetic datum} from a code.</pre></td>
+<td><pre>        return super.createTemporalDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createTemporalDatum", exception);
+<span class="add">        try {</span>
+        return fallback.createTemporalDatum(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns a {@linkplain GeodeticDatum geodetic datum} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createGeodeticDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createGeodeticDatum", exception);
+        return fallback.createGeodeticDatum(code);
+    }
+}
+
+/**
+ * Returns an {@linkplain Ellipsoid ellipsoid} from a code.</pre></td>
+<td><pre>        return super.createGeodeticDatum(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createGeodeticDatum", exception);
+<span class="add">        try {</span>
+        return fallback.createGeodeticDatum(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns an {@linkplain Ellipsoid ellipsoid} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createEllipsoid(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEllipsoid", exception);
+        return fallback.createEllipsoid(code);
+    }
+}
+
+/**
+ * Returns a {@linkplain PrimeMeridian prime meridian} from a code.</pre></td>
+<td><pre>        return super.createEllipsoid(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEllipsoid", exception);
+<span class="add">        try {</span>
+        return fallback.createEllipsoid(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns a {@linkplain PrimeMeridian prime meridian} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createPrimeMeridian(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createPrimeMeridian", exception);
+        return fallback.createPrimeMeridian(code);
+    }
+}
+
+/**
+ * Returns a {@linkplain Extent extent} (usually an area of validity) from a code.</pre></td>
+<td><pre>        return super.createPrimeMeridian(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createPrimeMeridian", exception);
+<span class="add">        try {</span>
+        return fallback.createPrimeMeridian(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns a {@linkplain Extent extent} (usually an area of validity) from a code.</pre></td></tr>
+<tr><td><pre>        return super.createExtent(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createExtent", exception);
+        return fallback.createExtent(code);
+    }
+}
+
+/**
+ * Returns an arbitrary {@linkplain CoordinateSystem coordinate system} from a code.</pre></td>
+<td><pre>        return super.createExtent(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createExtent", exception);
+<span class="add">        try {</span>
+        return fallback.createExtent(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns an arbitrary {@linkplain CoordinateSystem coordinate system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createCoordinateSystem(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateSystem", exception);
+        return fallback.createCoordinateSystem(code);
+    }
+}
+
+/**
+ * Creates a cartesian coordinate system from a code.</pre></td>
+<td><pre>        return super.createCoordinateSystem(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateSystem", exception);
+<span class="add">        try {</span>
+        return fallback.createCoordinateSystem(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a cartesian coordinate system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createCartesianCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCartesianCS", exception);
+        return fallback.createCartesianCS(code);
+    }
+}
+
+/**
+ * Creates a polar coordinate system from a code.</pre></td>
+<td><pre>        return super.createCartesianCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCartesianCS", exception);
+<span class="add">        try {</span>
+        return fallback.createCartesianCS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a polar coordinate system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createPolarCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createPolarCS", exception);
+        return fallback.createPolarCS(code);
+    }
+}
+
+/**
+ * Creates a cylindrical coordinate system from a code.</pre></td>
+<td><pre>        return super.createPolarCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createPolarCS", exception);
+<span class="add">        try {</span>
+        return fallback.createPolarCS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a cylindrical coordinate system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createCylindricalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCylindricalCS", exception);
+        return fallback.createCylindricalCS(code);
+    }
+}
+
+/**
+ * Creates a spherical coordinate system from a code.</pre></td>
+<td><pre>        return super.createCylindricalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCylindricalCS", exception);
+<span class="add">        try {</span>
+        return fallback.createCylindricalCS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a spherical coordinate system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createSphericalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createSphericalCS", exception);
+        return fallback.createSphericalCS(code);
+    }
+}
+
+/**
+ * Creates an ellipsoidal coordinate system from a code.</pre></td>
+<td><pre>        return super.createSphericalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createSphericalCS", exception);
+<span class="add">        try {</span>
+        return fallback.createSphericalCS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates an ellipsoidal coordinate system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createEllipsoidalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEllipsoidalCS", exception);
+        return fallback.createEllipsoidalCS(code);
+    }
+}
+
+/**
+ * Creates a vertical coordinate system from a code.</pre></td>
+<td><pre>        return super.createEllipsoidalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEllipsoidalCS", exception);
+<span class="add">        try {</span>
+        return fallback.createEllipsoidalCS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a vertical coordinate system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createVerticalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createVerticalCS", exception);
+        return fallback.createVerticalCS(code);
+    }
+}
+
+/**
+ * Creates a temporal coordinate system from a code.</pre></td>
+<td><pre>        return super.createVerticalCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createVerticalCS", exception);
+<span class="add">        try {</span>
+        return fallback.createVerticalCS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a temporal coordinate system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createTimeCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createTimeCS", exception);
+        return fallback.createTimeCS(code);
+    }
+}
+
+/**
+ * Returns a {@linkplain CoordinateSystemAxis coordinate system axis} from a code.</pre></td>
+<td><pre>        return super.createTimeCS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createTimeCS", exception);
+<span class="add">        try {</span>
+        return fallback.createTimeCS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns a {@linkplain CoordinateSystemAxis coordinate system axis} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createCoordinateSystemAxis(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateSystemAxis", exception);
+        return fallback.createCoordinateSystemAxis(code);
+    }
+}
+
+/**
+ * Returns an {@linkplain Unit unit} from a code.</pre></td>
+<td><pre>        return super.createCoordinateSystemAxis(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateSystemAxis", exception);
+<span class="add">        try {</span>
+        return fallback.createCoordinateSystemAxis(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns an {@linkplain Unit unit} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createUnit(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createUnit", exception);
+        return fallback.createUnit(code);
+    }
+}
+
+/**
+ * Returns an arbitrary {@linkplain CoordinateReferenceSystem coordinate reference system}</pre></td>
+<td><pre>        return super.createUnit(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createUnit", exception);
+<span class="add">        try {</span>
+        return fallback.createUnit(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns an arbitrary {@linkplain CoordinateReferenceSystem coordinate reference system}</pre></td></tr>
+<tr><td><pre>        return super.createCoordinateReferenceSystem(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateReferenceSystem", exception);
+        return fallback.createCoordinateReferenceSystem(code);
+    }
+}
+
+/**
+ * Creates a 3D coordinate reference system from a code.</pre></td>
+<td><pre>        return super.createCoordinateReferenceSystem(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateReferenceSystem", exception);
+<span class="add">        try {</span>
+        return fallback.createCoordinateReferenceSystem(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a 3D coordinate reference system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createCompoundCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCompoundCRS", exception);
+        return fallback.createCompoundCRS(code);
+    }
+}
+
+/**
+ * Creates a derived coordinate reference system from a code.</pre></td>
+<td><pre>        return super.createCompoundCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCompoundCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createCompoundCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a derived coordinate reference system from a code.</pre></td></tr>
+<tr><td><pre>        return super.createDerivedCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createDerivedCRS", exception);
+        return fallback.createDerivedCRS(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain EngineeringCRS engineering coordinate reference system} from a code.</pre></td>
+<td><pre>        return super.createDerivedCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createDerivedCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createDerivedCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain EngineeringCRS engineering coordinate reference system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createEngineeringCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEngineeringCRS", exception);
+        return fallback.createEngineeringCRS(code);
+    }
+}
+
+/**
+ * Returns a {@linkplain GeographicCRS geographic coordinate reference system} from a code.</pre></td>
+<td><pre>        return super.createEngineeringCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createEngineeringCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createEngineeringCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns a {@linkplain GeographicCRS geographic coordinate reference system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createGeographicCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createGeographicCRS", exception);
+        return fallback.createGeographicCRS(code);
+    }
+}
+
+/**
+ * Returns a {@linkplain GeocentricCRS geocentric coordinate reference system} from a code.</pre></td>
+<td><pre>        return super.createGeographicCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createGeographicCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createGeographicCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns a {@linkplain GeocentricCRS geocentric coordinate reference system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createGeocentricCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createGeocentricCRS", exception);
+        return fallback.createGeocentricCRS(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain ImageCRS image coordinate reference system} from a code.</pre></td>
+<td><pre>        return super.createGeocentricCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createGeocentricCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createGeocentricCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain ImageCRS image coordinate reference system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createImageCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createImageCRS", exception);
+        return fallback.createImageCRS(code);
+    }
+}
+
+/**
+ * Returns a {@linkplain ProjectedCRS projected coordinate reference system} from a code.</pre></td>
+<td><pre>        return super.createImageCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createImageCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createImageCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Returns a {@linkplain ProjectedCRS projected coordinate reference system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createProjectedCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createProjectedCRS", exception);
+        return fallback.createProjectedCRS(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain TemporalCRS temporal coordinate reference system} from a code.</pre></td>
+<td><pre>        return super.createProjectedCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createProjectedCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createProjectedCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain TemporalCRS temporal coordinate reference system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createTemporalCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createTemporalCRS", exception);
+        return fallback.createTemporalCRS(code);
+    }
+}
+
+/**
+ * Creates a {@linkplain VerticalCRS vertical coordinate reference system} from a code.</pre></td>
+<td><pre>        return super.createTemporalCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createTemporalCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createTemporalCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a {@linkplain VerticalCRS vertical coordinate reference system} from a code.</pre></td></tr>
+<tr><td><pre>        return super.createVerticalCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createVerticalCRS", exception);
+        return fallback.createVerticalCRS(code);
+    }
+}
+
+/**
+ * Creates a parameter descriptor from a code.</pre></td>
+<td><pre>        return super.createVerticalCRS(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createVerticalCRS", exception);
+<span class="add">        try {</span>
+        return fallback.createVerticalCRS(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates a parameter descriptor from a code.</pre></td></tr>
+<tr><td><pre>        return super.createParameterDescriptor(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createParameterDescriptor", exception);
+        return fallback.createParameterDescriptor(code);
+    }
+}
+
+/**
+ * Creates an operation method from a code.</pre></td>
+<td><pre>        return super.createParameterDescriptor(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createParameterDescriptor", exception);
+<span class="add">        try {</span>
+        return fallback.createParameterDescriptor(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates an operation method from a code.</pre></td></tr>
+<tr><td><pre>        return super.createOperationMethod(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createOperationMethod", exception);
+        return fallback.createOperationMethod(code);
+    }
+}
+
+/**
+ * Creates an operation from a single operation code.</pre></td>
+<td><pre>        return super.createOperationMethod(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createOperationMethod", exception);
+<span class="add">        try {</span>
+        return fallback.createOperationMethod(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates an operation from a single operation code.</pre></td></tr>
+<tr><td><pre>        return super.createCoordinateOperation(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateOperation", exception);
+        return fallback.createCoordinateOperation(code);
+    }
+}
+
+/**
+ * Creates an operation from coordinate reference system codes.</pre></td>
+<td><pre>        return super.createCoordinateOperation(code);
+    } catch (FactoryException exception) {
+        notifyFailure("createCoordinateOperation", exception);
+<span class="add">        try {</span>
+        return fallback.createCoordinateOperation(code);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Creates an operation from coordinate reference system codes.</pre></td></tr>
+<tr><td><pre>        return super.createFromCoordinateReferenceSystemCodes(sourceCode, targetCode);
+    } catch (FactoryException exception) {
+        notifyFailure("createFromCoordinateReferenceSystemCodes", exception);
+        return fallback.createFromCoordinateReferenceSystemCodes(sourceCode, targetCode);
+    }
+}
+
+/**
+ * Invoked by &lt;code&gt;create&lt;/code&gt;&lt;var&gt;Foo&lt;/var&gt;&lt;code&gt;(String)&lt;/code&gt; methods when the</pre></td>
+<td><pre>        return super.createFromCoordinateReferenceSystemCodes(sourceCode, targetCode);
+    } catch (FactoryException exception) {
+        notifyFailure("createFromCoordinateReferenceSystemCodes", exception);
+<span class="add">        try {</span>
+        return fallback.createFromCoordinateReferenceSystemCodes(sourceCode, targetCode);
+<span class="add">        } catch (NoSuchAuthorityCodeException ignore) {</span>
+<span class="add">            throw exception;</span>
+    }
+}
+<span class="add">}</span>
+
+/**
+ * Invoked by &lt;code&gt;create&lt;/code&gt;&lt;var&gt;Foo&lt;/var&gt;&lt;code&gt;(String)&lt;/code&gt; methods when the</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24689/FallbackAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24689/FallbackAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24689/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24689/HEADER.html?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/24689/HEADER.html (added)
+++ sis/ip-review/rev/24689/HEADER.html Tue Dec  8 13:33:15 2015
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 24689</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 24689</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>aaime</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-03-06</td></tr>
+  <tr><td><b>Message:</b></td><td>Fix for the fallback system, when falling back because of an error, make sure to report that error if the fallback just does not know about the required code</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24689/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24689/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/AllAuthoritiesFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/AllAuthoritiesFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25050/AllAuthoritiesFactory.xhtml (added)
+++ sis/ip-review/rev/25050/AllAuthoritiesFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,169 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AllAuthoritiesFactory changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AllAuthoritiesFactory changes for revisions 25049:25050</h1>
+<p>
+  The only change in this commit is to rename <code>FactoryFinder</code> as <code>ReferencingFactoryFinder</code>.
+  However this change does not apply to SIS since we do not plan to port <code>[Referencing]FactoryFinder</code>.
+  The plan is to replace them by some dependency injection mechanism.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/AllAuthoritiesFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>import org.geotools.factory.Hints;
+import org.geotools.factory.Factory;
+import org.geotools.factory.FactoryRegistryException;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.metadata.iso.citation.Citations;
+import org.geotools.metadata.iso.citation.CitationImpl;
+import org.geotools.util.GenericName;</pre></td>
+<td><pre>import org.geotools.factory.Hints;
+import org.geotools.factory.Factory;
+import org.geotools.factory.FactoryRegistryException;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.metadata.iso.citation.Citations;
+import org.geotools.metadata.iso.citation.CitationImpl;
+import org.geotools.util.GenericName;</pre></td></tr>
+<tr><td><pre>* This class parses the authority name and delegates the work the corresponding factory. For
+* example if any {@code createFoo(...)} method in this class is invoked with a code starting
+* by {@code "EPSG:"}, then this class delegates the object creation to the authority factory
+<span class="del">* provided by &lt;code&gt;FactoryFinder.{@linkplain FactoryFinder#getCRSAuthorityFactory</span>
+* getCRSAuthorityFactory}("EPSG", hints)&lt;/code&gt;.
+* &lt;p&gt;
+<span class="del">* This class is not registered in {@link FactoryFinder}, because it is not a real authority</span>
+* factory. There is not a single authority name associated to this factory, but rather a set
+* of names determined from all available authority factories. If this "authority" factory is
+* wanted, then users need to refer explicitly to the {@link #DEFAULT} constant or to create</pre></td>
+<td><pre>* This class parses the authority name and delegates the work the corresponding factory. For
+* example if any {@code createFoo(...)} method in this class is invoked with a code starting
+* by {@code "EPSG:"}, then this class delegates the object creation to the authority factory
+<span class="add">* provided by &lt;code&gt;FactoryFinder.{@linkplain ReferencingFactoryFinder#getCRSAuthorityFactory</span>
+* getCRSAuthorityFactory}("EPSG", hints)&lt;/code&gt;.
+* &lt;p&gt;
+<span class="add">* This class is not registered in {@link ReferencingFactoryFinder}, because it is not a real authority</span>
+* factory. There is not a single authority name associated to this factory, but rather a set
+* of names determined from all available authority factories. If this "authority" factory is
+* wanted, then users need to refer explicitly to the {@link #DEFAULT} constant or to create</pre></td></tr>
+<tr><td><pre>};
+
+/**
+<span class="del"> * A set of user-specified factories to try before to delegate to {@link FactoryFinder},</span>
+ * or {@code null} if none.
+ */
+private final Collection/*&lt;AuthorityFactory&gt;*/ factories;</pre></td>
+<td><pre>};
+
+/**
+<span class="add"> * A set of user-specified factories to try before to delegate to {@link ReferencingFactoryFinder},</span>
+ * or {@code null} if none.
+ */
+private final Collection/*&lt;AuthorityFactory&gt;*/ factories;</pre></td></tr>
+<tr><td><pre>* first scan the supplied factories in their iteration order. The first factory implementing
+* the appropriate interface and having the expected {@linkplain AuthorityFactory#getAuthority
+* authority name} will be used. Only if no suitable factory is found, then this class delegates
+<span class="del">* to {@link FactoryFinder}.</span>
+* &lt;p&gt;
+* If the {@code factories} collection contains more than one factory for the same authority
+* and interface, then all additional factories will be {@linkplain FallbackAuthorityFactory</pre></td>
+<td><pre>* first scan the supplied factories in their iteration order. The first factory implementing
+* the appropriate interface and having the expected {@linkplain AuthorityFactory#getAuthority
+* authority name} will be used. Only if no suitable factory is found, then this class delegates
+<span class="add">* to {@link ReferencingFactoryFinder}.</span>
+* &lt;p&gt;
+* If the {@code factories} collection contains more than one factory for the same authority
+* and interface, then all additional factories will be {@linkplain FallbackAuthorityFactory</pre></td></tr>
+<tr><td><pre> *
+ * @param hints An optional set of hints, or {@code null} if none.
+ * @param factories A set of user-specified factories to try before to delegate
+<span class="del"> *        to {@link FactoryFinder}, or {@code null} if none.</span>
+ */
+public AllAuthoritiesFactory(final Hints hints,
+                             final Collection/*&lt;? extends AuthorityFactory&gt;*/ factories)</pre></td>
+<td><pre> *
+ * @param hints An optional set of hints, or {@code null} if none.
+ * @param factories A set of user-specified factories to try before to delegate
+<span class="add"> *        to {@link ReferencingFactoryFinder}, or {@code null} if none.</span>
+ */
+public AllAuthoritiesFactory(final Hints hints,
+                             final Collection/*&lt;? extends AuthorityFactory&gt;*/ factories)</pre></td></tr>
+<tr><td><pre>*
+* @param hints An optional set of hints, or {@code null} if none.
+* @param factories A set of user-specified factories to try before to delegate
+<span class="del">*        to {@link FactoryFinder}, or {@code null} if none.</span>
+* @param separator The separator between the authority name and the code.
+*
+* @deprecated Override the {@link #getSeparator} method instead.</pre></td>
+<td><pre>*
+* @param hints An optional set of hints, or {@code null} if none.
+* @param factories A set of user-specified factories to try before to delegate
+<span class="add">*        to {@link ReferencingFactoryFinder}, or {@code null} if none.</span>
+* @param separator The separator between the authority name and the code.
+*
+* @deprecated Override the {@link #getSeparator} method instead.</pre></td></tr>
+<tr><td><pre>/**
+ * Searchs for a factory of the given type. This method first search in user-supplied
+ * factories. If no user factory is found, then this method request for a factory using
+<span class="del"> * {@link FactoryFinder}. The authority name is inferred from the specified code.</span>
+ *
+ * @param  type The interface to be implemented.
+ * @param  code The code of the object to create.</pre></td>
+<td><pre>/**
+ * Searchs for a factory of the given type. This method first search in user-supplied
+ * factories. If no user factory is found, then this method request for a factory using
+<span class="add"> * {@link ReferencingFactoryFinder}. The authority name is inferred from the specified code.</span>
+ *
+ * @param  type The interface to be implemented.
+ * @param  code The code of the object to create.</pre></td></tr>
+<tr><td><pre>final AuthorityFactory factory;
+try {
+    if (CRSAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getCRSAuthorityFactory(authority, userHints);</span>
+    } else if (CSAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getCSAuthorityFactory(authority, userHints);</span>
+    } else if (DatumAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getDatumAuthorityFactory(authority, userHints);</span>
+    } else if (CoordinateOperationAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getCoordinateOperationAuthorityFactory(authority, userHints);</span>
+    } else {
+        continue;
+    }</pre></td>
+<td><pre>final AuthorityFactory factory;
+try {
+    if (CRSAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getCRSAuthorityFactory(authority, userHints);</span>
+    } else if (CSAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getCSAuthorityFactory(authority, userHints);</span>
+    } else if (DatumAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getDatumAuthorityFactory(authority, userHints);</span>
+    } else if (CoordinateOperationAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getCoordinateOperationAuthorityFactory(authority, userHints);</span>
+    } else {
+        continue;
+    }</pre></td></tr>
+<tr><td><pre>done.add(this); // Safety for avoiding recursive calls.
+inProgress.set(Boolean.TRUE);
+try {
+<span class="del">    for (final Iterator it=FactoryFinder.getAuthorityNames().iterator(); it.hasNext();) {</span>
+        final String authority = ((String) it.next()).trim();
+        final char separator = getSeparator(authority);
+        /*</pre></td>
+<td><pre>done.add(this); // Safety for avoiding recursive calls.
+inProgress.set(Boolean.TRUE);
+try {
+<span class="add">    for (final Iterator it=ReferencingFactoryFinder.getAuthorityNames().iterator(); it.hasNext();) {</span>
+        final String authority = ((String) it.next()).trim();
+        final char separator = getSeparator(authority);
+        /*</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/AllAuthoritiesFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/AllAuthoritiesFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/AuthorityFactoryAdapter.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/AuthorityFactoryAdapter.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25050/AuthorityFactoryAdapter.xhtml (added)
+++ sis/ip-review/rev/25050/AuthorityFactoryAdapter.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,53 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AuthorityFactoryAdapter changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AuthorityFactoryAdapter changes for revisions 25049:25050</h1>
+<p>
+  The only change in this commit is to rename <code>FactoryFinder</code> as <code>ReferencingFactoryFinder</code>.
+  However this change does not apply to SIS since we do not plan to port <code>[Referencing]FactoryFinder</code>.
+  The plan is to replace them by some dependency injection mechanism.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/AuthorityFactoryAdapter.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>import org.geotools.factory.Factory;
+import org.geotools.factory.AbstractFactory;
+import org.geotools.factory.OptionalFactory;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.resources.i18n.Logging;
+import org.geotools.resources.i18n.LoggingKeys;
+import org.geotools.resources.i18n.ErrorKeys;</pre></td>
+<td><pre>import org.geotools.factory.Factory;
+import org.geotools.factory.AbstractFactory;
+import org.geotools.factory.OptionalFactory;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.resources.i18n.Logging;
+import org.geotools.resources.i18n.LoggingKeys;
+import org.geotools.resources.i18n.ErrorKeys;</pre></td></tr>
+<tr><td><pre>            return (CoordinateOperationFactory) candidate;
+        }
+    }
+<span class="del">    return FactoryFinder.getCoordinateOperationFactory(hints());</span>
+}
+
+/**</pre></td>
+<td><pre>            return (CoordinateOperationFactory) candidate;
+        }
+    }
+<span class="add">    return ReferencingFactoryFinder.getCoordinateOperationFactory(hints());</span>
+}
+
+/**</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/AuthorityFactoryAdapter.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/AuthorityFactoryAdapter.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/DatumAliases.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/DatumAliases.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25050/DatumAliases.xhtml (added)
+++ sis/ip-review/rev/25050/DatumAliases.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,61 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DatumAliases changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DatumAliases changes for revisions 25049:25050</h1>
+      <p>This class will not be ported to SIS.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/DatumAliases.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>import org.opengis.util.ScopedName;
+
+// Geotools dependencies
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.datum.AbstractDatum;        // For javadoc
+import org.geotools.referencing.datum.BursaWolfParameters;  // For javadoc</pre></td>
+<td><pre>import org.opengis.util.ScopedName;
+
+// Geotools dependencies
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.datum.AbstractDatum;        // For javadoc
+import org.geotools.referencing.datum.BursaWolfParameters;  // For javadoc</pre></td></tr>
+<tr><td><pre>/**
+ * The underlying datum factory. If {@code null}, a default factory will be fetch
+<span class="del"> * from {@link FactoryFinder} when first needed. A default value can't be set at</span>
+ * construction time, since all factories may not be registered at this time.
+ */
+private DatumFactory factory;</pre></td>
+<td><pre>/**
+ * The underlying datum factory. If {@code null}, a default factory will be fetch
+<span class="add"> * from {@link ReferencingFactoryFinder} when first needed. A default value can't be set at</span>
+ * construction time, since all factories may not be registered at this time.
+ */
+private DatumFactory factory;</pre></td></tr>
+<tr><td><pre>assert Thread.holdsLock(this);
+if (factory == null) {
+    DatumFactory candidate;
+<span class="del">    final Iterator it = FactoryFinder.getDatumFactories(null).iterator();</span>
+    do candidate = (DatumFactory) it.next();
+    while (candidate == this);
+    factory = candidate;</pre></td>
+<td><pre>assert Thread.holdsLock(this);
+if (factory == null) {
+    DatumFactory candidate;
+<span class="add">    final Iterator it = ReferencingFactoryFinder.getDatumFactories(null).iterator();</span>
+    do candidate = (DatumFactory) it.next();
+    while (candidate == this);
+    factory = candidate;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/DatumAliases.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/DatumAliases.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/ManyAuthoritiesFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/ManyAuthoritiesFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25050/ManyAuthoritiesFactory.xhtml (added)
+++ sis/ip-review/rev/25050/ManyAuthoritiesFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,169 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ManyAuthoritiesFactory changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ManyAuthoritiesFactory changes for revisions 25049:25050</h1>
+<p>
+  The only change in this commit is to rename <code>FactoryFinder</code> as <code>ReferencingFactoryFinder</code>.
+  However this change does not apply to SIS since we do not plan to port <code>[Referencing]FactoryFinder</code>.
+  The plan is to replace them by some dependency injection mechanism.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/ManyAuthoritiesFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>import org.geotools.factory.Hints;
+import org.geotools.factory.Factory;
+import org.geotools.factory.FactoryRegistryException;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.metadata.iso.citation.Citations;
+import org.geotools.metadata.iso.citation.CitationImpl;
+import org.geotools.util.GenericName;</pre></td>
+<td><pre>import org.geotools.factory.Hints;
+import org.geotools.factory.Factory;
+import org.geotools.factory.FactoryRegistryException;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.metadata.iso.citation.Citations;
+import org.geotools.metadata.iso.citation.CitationImpl;
+import org.geotools.util.GenericName;</pre></td></tr>
+<tr><td><pre>* This class parses the authority name and delegates the work the corresponding factory. For
+* example if any {@code createFoo(...)} method in this class is invoked with a code starting
+* by {@code "EPSG:"}, then this class delegates the object creation to the authority factory
+<span class="del">* provided by &lt;code&gt;FactoryFinder.{@linkplain FactoryFinder#getCRSAuthorityFactory</span>
+* getCRSAuthorityFactory}("EPSG", hints)&lt;/code&gt;.
+* &lt;p&gt;
+<span class="del">* This class is not registered in {@link FactoryFinder}, because it is not a real authority</span>
+* factory. There is not a single authority name associated to this factory, but rather a set
+* of names determined from all available authority factories. If this "authority" factory is
+* wanted, then users need to refer explicitly to the {@link #DEFAULT} constant or to create</pre></td>
+<td><pre>* This class parses the authority name and delegates the work the corresponding factory. For
+* example if any {@code createFoo(...)} method in this class is invoked with a code starting
+* by {@code "EPSG:"}, then this class delegates the object creation to the authority factory
+<span class="add">* provided by &lt;code&gt;FactoryFinder.{@linkplain ReferencingFactoryFinder#getCRSAuthorityFactory</span>
+* getCRSAuthorityFactory}("EPSG", hints)&lt;/code&gt;.
+* &lt;p&gt;
+<span class="add">* This class is not registered in {@link ReferencingFactoryFinder}, because it is not a real authority</span>
+* factory. There is not a single authority name associated to this factory, but rather a set
+* of names determined from all available authority factories. If this "authority" factory is
+* wanted, then users need to refer explicitly to the {@link #DEFAULT} constant or to create</pre></td></tr>
+<tr><td><pre>};
+
+/**
+<span class="del"> * A set of user-specified factories to try before to delegate to {@link FactoryFinder},</span>
+ * or {@code null} if none.
+ */
+private final Collection/*&lt;AuthorityFactory&gt;*/ factories;</pre></td>
+<td><pre>};
+
+/**
+<span class="add"> * A set of user-specified factories to try before to delegate to {@link ReferencingFactoryFinder},</span>
+ * or {@code null} if none.
+ */
+private final Collection/*&lt;AuthorityFactory&gt;*/ factories;</pre></td></tr>
+<tr><td><pre>* first scan the supplied factories in their iteration order. The first factory implementing
+* the appropriate interface and having the expected {@linkplain AuthorityFactory#getAuthority
+* authority name} will be used. Only if no suitable factory is found, then this class delegates
+<span class="del">* to {@link FactoryFinder}.</span>
+* &lt;p&gt;
+* If the {@code factories} collection contains more than one factory for the same authority
+* and interface, then all additional factories will be {@linkplain FallbackAuthorityFactory</pre></td>
+<td><pre>* first scan the supplied factories in their iteration order. The first factory implementing
+* the appropriate interface and having the expected {@linkplain AuthorityFactory#getAuthority
+* authority name} will be used. Only if no suitable factory is found, then this class delegates
+<span class="add">* to {@link ReferencingFactoryFinder}.</span>
+* &lt;p&gt;
+* If the {@code factories} collection contains more than one factory for the same authority
+* and interface, then all additional factories will be {@linkplain FallbackAuthorityFactory</pre></td></tr>
+<tr><td><pre> *
+ * @param hints An optional set of hints, or {@code null} if none.
+ * @param factories A set of user-specified factories to try before to delegate
+<span class="del"> *        to {@link FactoryFinder}, or {@code null} if none.</span>
+ */
+public AllAuthoritiesFactory(final Hints hints,
+                             final Collection/*&lt;? extends AuthorityFactory&gt;*/ factories)</pre></td>
+<td><pre> *
+ * @param hints An optional set of hints, or {@code null} if none.
+ * @param factories A set of user-specified factories to try before to delegate
+<span class="add"> *        to {@link ReferencingFactoryFinder}, or {@code null} if none.</span>
+ */
+public AllAuthoritiesFactory(final Hints hints,
+                             final Collection/*&lt;? extends AuthorityFactory&gt;*/ factories)</pre></td></tr>
+<tr><td><pre>*
+* @param hints An optional set of hints, or {@code null} if none.
+* @param factories A set of user-specified factories to try before to delegate
+<span class="del">*        to {@link FactoryFinder}, or {@code null} if none.</span>
+* @param separator The separator between the authority name and the code.
+*
+* @deprecated Override the {@link #getSeparator} method instead.</pre></td>
+<td><pre>*
+* @param hints An optional set of hints, or {@code null} if none.
+* @param factories A set of user-specified factories to try before to delegate
+<span class="add">*        to {@link ReferencingFactoryFinder}, or {@code null} if none.</span>
+* @param separator The separator between the authority name and the code.
+*
+* @deprecated Override the {@link #getSeparator} method instead.</pre></td></tr>
+<tr><td><pre>/**
+ * Searchs for a factory of the given type. This method first search in user-supplied
+ * factories. If no user factory is found, then this method request for a factory using
+<span class="del"> * {@link FactoryFinder}. The authority name is inferred from the specified code.</span>
+ *
+ * @param  type The interface to be implemented.
+ * @param  code The code of the object to create.</pre></td>
+<td><pre>/**
+ * Searchs for a factory of the given type. This method first search in user-supplied
+ * factories. If no user factory is found, then this method request for a factory using
+<span class="add"> * {@link ReferencingFactoryFinder}. The authority name is inferred from the specified code.</span>
+ *
+ * @param  type The interface to be implemented.
+ * @param  code The code of the object to create.</pre></td></tr>
+<tr><td><pre>final AuthorityFactory factory;
+try {
+    if (CRSAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getCRSAuthorityFactory(authority, userHints);</span>
+    } else if (CSAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getCSAuthorityFactory(authority, userHints);</span>
+    } else if (DatumAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getDatumAuthorityFactory(authority, userHints);</span>
+    } else if (CoordinateOperationAuthorityFactory.class.equals(type)) {
+<span class="del">        factory = FactoryFinder.getCoordinateOperationAuthorityFactory(authority, userHints);</span>
+    } else {
+        continue;
+    }</pre></td>
+<td><pre>final AuthorityFactory factory;
+try {
+    if (CRSAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getCRSAuthorityFactory(authority, userHints);</span>
+    } else if (CSAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getCSAuthorityFactory(authority, userHints);</span>
+    } else if (DatumAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getDatumAuthorityFactory(authority, userHints);</span>
+    } else if (CoordinateOperationAuthorityFactory.class.equals(type)) {
+<span class="add">        factory = ReferencingFactoryFinder.getCoordinateOperationAuthorityFactory(authority, userHints);</span>
+    } else {
+        continue;
+    }</pre></td></tr>
+<tr><td><pre>done.add(this); // Safety for avoiding recursive calls.
+inProgress.set(Boolean.TRUE);
+try {
+<span class="del">    for (final Iterator it=FactoryFinder.getAuthorityNames().iterator(); it.hasNext();) {</span>
+        final String authority = ((String) it.next()).trim();
+        final char separator = getSeparator(authority);
+        /*</pre></td>
+<td><pre>done.add(this); // Safety for avoiding recursive calls.
+inProgress.set(Boolean.TRUE);
+try {
+<span class="add">    for (final Iterator it=ReferencingFactoryFinder.getAuthorityNames().iterator(); it.hasNext();) {</span>
+        final String authority = ((String) it.next()).trim();
+        final char separator = getSeparator(authority);
+        /*</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/ManyAuthoritiesFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/ManyAuthoritiesFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/OrderedAxisAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/OrderedAxisAuthorityFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25050/OrderedAxisAuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/25050/OrderedAxisAuthorityFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,77 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>OrderedAxisAuthorityFactory changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>OrderedAxisAuthorityFactory changes for revisions 25049:25050</h1>
+<p>
+  The only change in this commit is to rename <code>FactoryFinder</code> as <code>ReferencingFactoryFinder</code>.
+  However this change does not apply to SIS since we do not plan to port <code>[Referencing]FactoryFinder</code>.
+  The plan is to replace them by some dependency injection mechanism.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/OrderedAxisAuthorityFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>// Geotools dependencies
+import org.geotools.factory.Hints;
+import org.geotools.factory.FactoryRegistryException;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.referencing.cs.DefaultCoordinateSystemAxis;
+import org.geotools.resources.i18n.Errors;
+import org.geotools.resources.i18n.ErrorKeys;</pre></td>
+<td><pre>// Geotools dependencies
+import org.geotools.factory.Hints;
+import org.geotools.factory.FactoryRegistryException;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.referencing.cs.DefaultCoordinateSystemAxis;
+import org.geotools.resources.i18n.Errors;
+import org.geotools.resources.i18n.ErrorKeys;</pre></td></tr>
+<tr><td><pre>* &lt;p&gt;
+* For some authority factories, an instance of this class can be obtained by passing a
+* {@link Hints#FORCE_LONGITUDE_FIRST_AXIS_ORDER FORCE_LONGITUDE_FIRST_AXIS_ORDER} hint
+<span class="del">* to the &lt;code&gt;{@linkplain FactoryFinder#getCRSAuthorityFactory</span>
+* FactoryFinder.getCRSAuthorityFactory}(...)&lt;/code&gt; method. Whatever this hint is supported
+* or not is authority dependent. Example:
+*</pre></td>
+<td><pre>* &lt;p&gt;
+* For some authority factories, an instance of this class can be obtained by passing a
+* {@link Hints#FORCE_LONGITUDE_FIRST_AXIS_ORDER FORCE_LONGITUDE_FIRST_AXIS_ORDER} hint
+<span class="add">* to the &lt;code&gt;{@linkplain ReferencingFactoryFinder#getCRSAuthorityFactory</span>
+* FactoryFinder.getCRSAuthorityFactory}(...)&lt;/code&gt; method. Whatever this hint is supported
+* or not is authority dependent. Example:
+*</pre></td></tr>
+<tr><td><pre>/**
+ * Creates a factory which will reorder the axis of all objects created by the default
+<span class="del"> * authority factories. The factories are fetched using {@link FactoryFinder}. This</span>
+ * constructor accepts the following hints:
+ * &lt;p&gt;
+ * &lt;ul&gt;
+ *   &lt;li&gt;{@link Hints#FORCE_STANDARD_AXIS_UNITS}&lt;/li&gt;
+ *   &lt;li&gt;{@link Hints#FORCE_STANDARD_AXIS_DIRECTIONS}&lt;/li&gt;
+<span class="del"> *   &lt;li&gt;All hints understood by {@link FactoryFinder}&lt;/li&gt;</span>
+ * &lt;/ul&gt;
+ *
+ * @param  authority The authority to wraps (example: {@code "EPSG"}). If {@code null},</pre></td>
+<td><pre>/**
+ * Creates a factory which will reorder the axis of all objects created by the default
+<span class="add"> * authority factories. The factories are fetched using {@link ReferencingFactoryFinder}. This</span>
+ * constructor accepts the following hints:
+ * &lt;p&gt;
+ * &lt;ul&gt;
+ *   &lt;li&gt;{@link Hints#FORCE_STANDARD_AXIS_UNITS}&lt;/li&gt;
+ *   &lt;li&gt;{@link Hints#FORCE_STANDARD_AXIS_DIRECTIONS}&lt;/li&gt;
+<span class="add"> *   &lt;li&gt;All hints understood by {@link ReferencingFactoryFinder}&lt;/li&gt;</span>
+ * &lt;/ul&gt;
+ *
+ * @param  authority The authority to wraps (example: {@code "EPSG"}). If {@code null},</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/OrderedAxisAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/OrderedAxisAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/TransformedAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/TransformedAuthorityFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25050/TransformedAuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/25050/TransformedAuthorityFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,89 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>TransformedAuthorityFactory changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>TransformedAuthorityFactory changes for revisions 25049:25050</h1>
+<p>
+  The only change in this commit is to rename <code>FactoryFinder</code> as <code>ReferencingFactoryFinder</code>.
+  However this change does not apply to SIS since we do not plan to port <code>[Referencing]FactoryFinder</code>.
+  The plan is to replace them by some dependency injection mechanism.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/TransformedAuthorityFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>import org.geotools.factory.Hints;
+import org.geotools.factory.Factory;
+import org.geotools.factory.FactoryRegistryException;
+<span class="del">import org.geotools.referencing.FactoryFinder;</span>
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.operation.DefiningConversion;
+import org.geotools.referencing.cs.DefaultCoordinateSystemAxis;</pre></td>
+<td><pre>import org.geotools.factory.Hints;
+import org.geotools.factory.Factory;
+import org.geotools.factory.FactoryRegistryException;
+<span class="add">import org.geotools.referencing.ReferencingFactoryFinder;</span>
+import org.geotools.referencing.AbstractIdentifiedObject;
+import org.geotools.referencing.operation.DefiningConversion;
+import org.geotools.referencing.cs.DefaultCoordinateSystemAxis;</pre></td></tr>
+<tr><td><pre>/**
+ * Creates a wrappers around the default factories for the specified
+<span class="del"> * authority. The factories are fetched using {@link FactoryFinder}.</span>
+ * &lt;p&gt;
+ * &lt;strong&gt;WARNING:&lt;/strong&gt; Do not invoke this constructor from a subclass
+ * to be registered in a {@code META-INF/services/} file for use by
+<span class="del"> * {@link FactoryFinder}. It may lead to recursive calls until a</span>
+ * {@link StackOverflowError} is thrown.
+ *
+ * @param authority The authority to wraps (example: {@code "EPSG"}). If {@code null},</pre></td>
+<td><pre>/**
+ * Creates a wrappers around the default factories for the specified
+<span class="add"> * authority. The factories are fetched using {@link ReferencingFactoryFinder}.</span>
+ * &lt;p&gt;
+ * &lt;strong&gt;WARNING:&lt;/strong&gt; Do not invoke this constructor from a subclass
+ * to be registered in a {@code META-INF/services/} file for use by
+<span class="add"> * {@link ReferencingFactoryFinder}. It may lead to recursive calls until a</span>
+ * {@link StackOverflowError} is thrown.
+ *
+ * @param authority The authority to wraps (example: {@code "EPSG"}). If {@code null},</pre></td></tr>
+<tr><td><pre>TransformedAuthorityFactory(final String authority, final Hints hints)
+        throws FactoryRegistryException
+{
+<span class="del">    super(FactoryFinder.getCRSAuthorityFactory                (authority, hints),</span>
+<span class="del">          FactoryFinder.getCSAuthorityFactory                 (authority, hints),</span>
+<span class="del">          FactoryFinder.getDatumAuthorityFactory              (authority, hints),</span>
+<span class="del">          FactoryFinder.getCoordinateOperationAuthorityFactory(authority, hints));</span>
+}
+
+/**
+ * Returns the priority for this factory. Priorities are used by
+<span class="del"> * {@link FactoryFinder} for selecting a preferred factory when many are</span>
+ * found for the same service. The default implementation returns
+ * &lt;code&gt;{@linkplain #priority priority} + 1&lt;/code&gt;, which implies that
+ * this adapter has precedence over the wrapped factories. Subclasses should</pre></td>
+<td><pre>TransformedAuthorityFactory(final String authority, final Hints hints)
+        throws FactoryRegistryException
+{
+<span class="add">    super(ReferencingFactoryFinder.getCRSAuthorityFactory                (authority, hints),</span>
+<span class="add">          ReferencingFactoryFinder.getCSAuthorityFactory                 (authority, hints),</span>
+<span class="add">          ReferencingFactoryFinder.getDatumAuthorityFactory              (authority, hints),</span>
+<span class="add">          ReferencingFactoryFinder.getCoordinateOperationAuthorityFactory(authority, hints));</span>
+}
+
+/**
+ * Returns the priority for this factory. Priorities are used by
+<span class="add"> * {@link ReferencingFactoryFinder} for selecting a preferred factory when many are</span>
+ * found for the same service. The default implementation returns
+ * &lt;code&gt;{@linkplain #priority priority} + 1&lt;/code&gt;, which implies that
+ * this adapter has precedence over the wrapped factories. Subclasses should</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/TransformedAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/TransformedAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25050/URN_AuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25050/URN_AuthorityFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25050/URN_AuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/25050/URN_AuthorityFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>URN_AuthorityFactory changes for revisions 25049:25050</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>URN_AuthorityFactory changes for revisions 25049:25050</h1>
+      <p>This class will not be ported to SIS. Experience has shown that attempts to handle HTTP and URN factories
+        as <code>AuthorityFactory</code> was more a source of complications than conveniences.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25049:25050 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/URN_AuthorityFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25049</th><th>Revision 25050</th></tr>
+<tr><td><pre>* name space. An exemple of complete URN is {@code "urn:ogc:def:crs:EPSG:6.8:4326"}.
+* &lt;p&gt;
+* Users don't need to create an instance of this class, since one is automatically
+<span class="del">* registered for use in {@link org.opengis.referencing.FactoryFinder}.</span>
+*
+* @since 2.4
+* @source $URL$</pre></td>
+<td><pre>* name space. An exemple of complete URN is {@code "urn:ogc:def:crs:EPSG:6.8:4326"}.
+* &lt;p&gt;
+* Users don't need to create an instance of this class, since one is automatically
+<span class="add">* registered for use in {@link org.opengis.referencing.ReferencingFactoryFinder}.</span>
+*
+* @since 2.4
+* @source $URL$</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25050/URN_AuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25050/URN_AuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25916/CachingAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25916/CachingAuthorityFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25916/CachingAuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/25916/CachingAuthorityFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>CachingAuthorityFactory changes for revisions 25895:25916</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>CachingAuthorityFactory changes for revisions 25895:25916</h1>
+<p>Changes reverted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25895:25916 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/BufferedAuthorityFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25895</th><th>Revision 25916</th></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25916/CachingAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25916/CachingAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25916/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25916/HEADER.html?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25916/HEADER.html (added)
+++ sis/ip-review/rev/25916/HEADER.html Tue Dec  8 13:33:15 2015
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 25916</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 25916</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-06-19</td></tr>
+  <tr><td><b>Message:</b></td><td>rollback so I can svn mv like a normal person; this will break the build</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25916/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25916/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25916/ThreadedAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25916/ThreadedAuthorityFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25916/ThreadedAuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/25916/ThreadedAuthorityFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>ThreadedAuthorityFactory changes for revisions 25895:25916</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>ThreadedAuthorityFactory changes for revisions 25895:25916</h1>
+<p>Changes reverted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25895:25916 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/ThreadedAuthorityFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25895</th><th>Revision 25916</th></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25916/ThreadedAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25916/ThreadedAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25919/DeferredAuthorityFactory.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25919/DeferredAuthorityFactory.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25919/DeferredAuthorityFactory.xhtml (added)
+++ sis/ip-review/rev/25919/DeferredAuthorityFactory.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>DeferredAuthorityFactory changes for revisions 25895:25919</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>DeferredAuthorityFactory changes for revisions 25895:25919</h1>
+      <p>This change does not apply to SIS.</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25895:25919 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/DeferredAuthorityFactory.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25895</th><th>Revision 25919</th></tr>
+<tr><td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ */
+<span class="del">public abstract class DeferredAuthorityFactory extends BufferedAuthorityFactory</span>
+                                            implements OptionalFactory
+{
+    /**</pre></td>
+<td><pre> * @version $Id$
+ * @author Martin Desruisseaux
+ */
+<span class="add">public abstract class DeferredAuthorityFactory extends ThreadedAuthorityFactory</span>
+                                            implements OptionalFactory
+{
+    /**</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25919/DeferredAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25919/DeferredAuthorityFactory.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25919/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25919/HEADER.html?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25919/HEADER.html (added)
+++ sis/ip-review/rev/25919/HEADER.html Tue Dec  8 13:33:15 2015
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 25919</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 25919</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jgarnett</td></tr>
+  <tr><td><b>Date:</b></td><td>2007-06-19</td></tr>
+  <tr><td><b>Message:</b></td><td>juggle the code back into place</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25919/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25919/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/25940/AuthorityFactoryAdapter.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/25940/AuthorityFactoryAdapter.xhtml?rev=1718599&view=auto
==============================================================================
--- sis/ip-review/rev/25940/AuthorityFactoryAdapter.xhtml (added)
+++ sis/ip-review/rev/25940/AuthorityFactoryAdapter.xhtml Tue Dec  8 13:33:15 2015
@@ -0,0 +1,67 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AuthorityFactoryAdapter changes for revisions 25939:25940</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AuthorityFactoryAdapter changes for revisions 25939:25940</h1>
+<p>
+  The only change in this commit is to rename <code>FactoryGroup</code> as <code>ReferencingFactoryContainer</code>.
+  This change does not apply to SIS since we will try to avoid that <code>ReferencingFactoryContainer</code> class,
+  or find another name.
+</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space --ignore-eol-style" -r25939:25940 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/factory/AuthorityFactoryAdapter.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 25939</th><th>Revision 25940</th></tr>
+<tr><td><pre> *
+ * @see #getFactoryGroup
+ */
+<span class="del">private transient FactoryGroup factories;</span>
+
+/**
+ * Creates a wrapper around no factory. This constructor should never be used except by</pre></td>
+<td><pre> *
+ * @see #getFactoryGroup
+ */
+<span class="add">private transient ReferencingFactoryContainer factories;</span>
+
+/**
+ * Creates a wrapper around no factory. This constructor should never be used except by</pre></td></tr>
+<tr><td><pre> * {@link TransformedAuthorityFactory} that need low-level access to factories. Do not change
+ * this method into a public one; we would need a better API before to do such thing.
+ */
+<span class="del">final FactoryGroup getFactoryGroup(final boolean crs) {</span>
+    final AuthorityFactory factory;
+    if (crs) {
+        factory = crsFactory;</pre></td>
+<td><pre> * {@link TransformedAuthorityFactory} that need low-level access to factories. Do not change
+ * this method into a public one; we would need a better API before to do such thing.
+ */
+<span class="add">final ReferencingFactoryContainer getFactoryGroup(final boolean crs) {</span>
+    final AuthorityFactory factory;
+    if (crs) {
+        factory = crsFactory;</pre></td></tr>
+<tr><td><pre>    }
+    // No predefined factory group. Create one.
+    if (factories == null) {
+<span class="del">        factories = FactoryGroup.createInstance(hints());</span>
+    }
+    return factories;
+}</pre></td>
+<td><pre>    }
+    // No predefined factory group. Create one.
+    if (factories == null) {
+<span class="add">        factories = ReferencingFactoryContainer.instance(hints());</span>
+    }
+    return factories;
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/25940/AuthorityFactoryAdapter.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/25940/AuthorityFactoryAdapter.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message