sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "M. Le Bihan (JIRA)" <>
Subject [jira] [Resolved] (SIS-189) InvalidDbaseFileFormatException should extend DataStoreException
Date Sun, 22 Nov 2015 19:36:10 GMT


M. Le Bihan resolved SIS-189.
       Resolution: Incomplete
    Fix Version/s: 0.7

Shapefile can throw DatastoreException subclasses, but as soon as it call a JDBC method to
get data coming from DBase III file, it has to return the subclass of the SQLException returned
by them. (putting the SQLException that can be thrown by each method in a root cause of a
Dedicated subclass of DatasourceException would be hard to do).

I expect removing the SQLException use at the time we will archieve a compatibilty with JPA
2. At this time, SQL exceptions will be removed by the Hibernate/toplink or other used and
thrown as subclasses of PersistenceException which is a RuntimeException.

> InvalidDbaseFileFormatException should extend DataStoreException
> ----------------------------------------------------------------
>                 Key: SIS-189
>                 URL:
>             Project: Spatial Information Systems
>          Issue Type: Sub-task
>          Components: Shapefile
>            Reporter: Martin Desruisseaux
>            Assignee: M. Le Bihan
>             Fix For: 0.7
> {{InvalidDbaseFileFormatException}} currently extends {{SQLNonTransientException}}. But
the the fact that a {{DataStore}} uses SQL or I/O operations for fetching the data is considered
internal to the data store. The higher-level exception for data stores is rather {{DataStoreException}},
which may contain a {{SQLException}}, {{IOException}} or other kind of exceptions as its cause.

This message was sent by Atlassian JIRA

View raw message