sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1683715 - in /sis/branches/JDK8/core: sis-metadata/src/main/java/org/apache/sis/io/wkt/ sis-metadata/src/test/java/org/apache/sis/io/wkt/ sis-referencing/src/main/java/org/apache/sis/io/ sis-referencing/src/test/java/org/apache/sis/io/wkt/
Date Fri, 05 Jun 2015 11:33:55 GMT
Author: desruisseaux
Date: Fri Jun  5 11:33:54 2015
New Revision: 1683715

URL: http://svn.apache.org/r1683715
Log:
OSGi: moved GeodeticObjectParser from "sis-referencing" to "sis-metadata" module.
As a result of this move, there is no more "org.geotoolkit.io.wkt" package in "sis-referencing".

Note: we can not move the tests. Some of them stay in the "sis-referencing" module.
We have no plan to make the tests OSGi-compatible at this time.

Added:
    sis/branches/JDK8/core/sis-metadata/src/main/java/org/apache/sis/io/wkt/GeodeticObjectParser.java
      - copied unchanged from r1683714, sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/io/wkt/GeodeticObjectParser.java
    sis/branches/JDK8/core/sis-metadata/src/test/java/org/apache/sis/io/wkt/GeodeticObjectParserTest.txt
  (with props)
    sis/branches/JDK8/core/sis-referencing/src/test/java/org/apache/sis/io/wkt/package-info.txt
      - copied, changed from r1682275, sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/io/wkt/package-info.txt
Removed:
    sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/io/

Added: sis/branches/JDK8/core/sis-metadata/src/test/java/org/apache/sis/io/wkt/GeodeticObjectParserTest.txt
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-metadata/src/test/java/org/apache/sis/io/wkt/GeodeticObjectParserTest.txt?rev=1683715&view=auto
==============================================================================
--- sis/branches/JDK8/core/sis-metadata/src/test/java/org/apache/sis/io/wkt/GeodeticObjectParserTest.txt
(added)
+++ sis/branches/JDK8/core/sis-metadata/src/test/java/org/apache/sis/io/wkt/GeodeticObjectParserTest.txt
[UTF-8] Fri Jun  5 11:33:54 2015
@@ -0,0 +1,3 @@
+GeodeticObjectParser and MathTransformParser can not be tested here,
+because they need the "sis-referencing" module at execution time.
+Those test classes are added by the "sis-referencing" module.

Propchange: sis/branches/JDK8/core/sis-metadata/src/test/java/org/apache/sis/io/wkt/GeodeticObjectParserTest.txt
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/branches/JDK8/core/sis-metadata/src/test/java/org/apache/sis/io/wkt/GeodeticObjectParserTest.txt
------------------------------------------------------------------------------
    svn:mime-type = text/plain;charset=UTF-8

Copied: sis/branches/JDK8/core/sis-referencing/src/test/java/org/apache/sis/io/wkt/package-info.txt
(from r1682275, sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/io/wkt/package-info.txt)
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-referencing/src/test/java/org/apache/sis/io/wkt/package-info.txt?p2=sis/branches/JDK8/core/sis-referencing/src/test/java/org/apache/sis/io/wkt/package-info.txt&p1=sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/io/wkt/package-info.txt&r1=1682275&r2=1683715&rev=1683715&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/io/wkt/package-info.txt
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-referencing/src/test/java/org/apache/sis/io/wkt/package-info.txt
[UTF-8] Fri Jun  5 11:33:54 2015
@@ -1,12 +1,7 @@
-There is no package-info.java file in this directory because that file is
-defined in the sis-metadata module. Splitting a package in two modules is
-not a recommended practice, but we make an exception for this WKT package
-for dependencies reason. The split is:
+The "org.apache.sis.io.wkt" package is defined in the "sis-metadata" module,
+but some of their classes can not be tested there because they depend on the
+"sis-referencing" module. Those classes are tested here.
 
-* 'sis-metadata' module provides formatting capability and a base Parser.
-* 'sis-referencing' module adds parsing capability on top of above parser.
-
-Formatting does not need to know all classes in advance since we just
-invoke an overrideable method. But parsing needs to know all classes,
-which is why we have to define it in the referencing module (at least
-for the current SIS version).
+The reason for this split is that formatting does not need to know classes
+in advance since we just invoke an overrideable method.  But parsing needs
+to know all classes, which is why we can test it only in this module.



Mime
View raw message