sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "M. Le Bihan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SIS-189) InvalidDbaseFileFormatException should extend DataStoreException
Date Mon, 11 May 2015 05:40:00 GMT

    [ https://issues.apache.org/jira/browse/SIS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537598#comment-14537598
] 

M. Le Bihan commented on SIS-189:
---------------------------------

+Main problem to solve :+ Driver.connect (and all methods implementing java.sql JDBC interfaces)
awaits only exceptions extending SQLException
example : {{public Connection connect(String url, Properties info) throws SQLException}}

+Current progress+
- Shapefile {{findAll()}} method now throw exceptions {{InvalidDbaseFileFormatException, ShapefileNotFoundException,
DbaseFileNotFoundException, InvalidShapefileFormatException}} extending {{DataStoreException}}

- {{InputFeatureStream}} used by {{Shapefile}} to return {{Feature}} now returns only few
exceptions extending {{DataStoreException}}, of three kind : 
{{DataStoreClosedException}} if the current connection used to query the shapefile has been
closed.
{{DataStoreQueryException}} if the statement used to query the shapefile content is incorrect.
{{DataStoreQueryResultException}} if the shapefile content cause a trouble (wrong format,
for example).

Callers of {{Shapefile}} public methods won't have to handle SQLException anymore.

> InvalidDbaseFileFormatException should extend DataStoreException
> ----------------------------------------------------------------
>
>                 Key: SIS-189
>                 URL: https://issues.apache.org/jira/browse/SIS-189
>             Project: Spatial Information Systems
>          Issue Type: Sub-task
>          Components: Shapefile
>            Reporter: Martin Desruisseaux
>            Assignee: M. Le Bihan
>
> {{InvalidDbaseFileFormatException}} currently extends {{SQLNonTransientException}}. But
the the fact that a {{DataStore}} uses SQL or I/O operations for fetching the data is considered
internal to the data store. The higher-level exception for data stores is rather {{DataStoreException}},
which may contain a {{SQLException}}, {{IOException}} or other kind of exceptions as its cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message