sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1677908 - in /sis/branches/JDK8: application/sis-console/src/main/java/org/apache/sis/console/ application/sis-console/src/test/java/org/apache/sis/console/ core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/ core/sis-u...
Date Tue, 05 May 2015 22:53:09 GMT
Author: desruisseaux
Date: Tue May  5 22:53:08 2015
New Revision: 1677908

URL: http://svn.apache.org/r1677908
Log:
Minor documentation update and typo fix in method name.

Modified:
    sis/branches/JDK8/application/sis-console/src/main/java/org/apache/sis/console/AboutSC.java
    sis/branches/JDK8/application/sis-console/src/test/java/org/apache/sis/console/AboutSCTest.java
    sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/OperationMethods.java
    sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/DefaultFactories.java

Modified: sis/branches/JDK8/application/sis-console/src/main/java/org/apache/sis/console/AboutSC.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/application/sis-console/src/main/java/org/apache/sis/console/AboutSC.java?rev=1677908&r1=1677907&r2=1677908&view=diff
==============================================================================
--- sis/branches/JDK8/application/sis-console/src/main/java/org/apache/sis/console/AboutSC.java
[UTF-8] (original)
+++ sis/branches/JDK8/application/sis-console/src/main/java/org/apache/sis/console/AboutSC.java
[UTF-8] Tue May  5 22:53:08 2015
@@ -98,7 +98,7 @@ final class AboutSC extends SubCommand {
                  *
                  * Tutorial: http://docs.oracle.com/javase/tutorial/jmx/remote/custom.html
                  */
-                final String path = toRemoveURL(files.get(0));
+                final String path = toRemoteURL(files.get(0));
                 try {
                     final JMXServiceURL url = new JMXServiceURL(path);
                     try (JMXConnector jmxc = JMXConnectorFactory.connect(url)) {
@@ -121,7 +121,7 @@ final class AboutSC extends SubCommand {
      * Creates a {@code "service:jmx:rmi:///jndi/rmi://host:port/jmxrmi"} URL for the given
host name.
      * The host name can optionally be followed by a port number.
      */
-    static String toRemoveURL(final String host) {
+    static String toRemoteURL(final String host) {
         final StringBuilder buffer = new StringBuilder(60).append("service:jmx:rmi:///jndi/rmi://")
                 .append(host, host.regionMatches(true, 0, "localhost", 0, 9) ? 9 : 0, host.length());
         if (host.lastIndexOf(':') < 0) {

Modified: sis/branches/JDK8/application/sis-console/src/test/java/org/apache/sis/console/AboutSCTest.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/application/sis-console/src/test/java/org/apache/sis/console/AboutSCTest.java?rev=1677908&r1=1677907&r2=1677908&view=diff
==============================================================================
--- sis/branches/JDK8/application/sis-console/src/test/java/org/apache/sis/console/AboutSCTest.java
[UTF-8] (original)
+++ sis/branches/JDK8/application/sis-console/src/test/java/org/apache/sis/console/AboutSCTest.java
[UTF-8] Tue May  5 22:53:08 2015
@@ -95,15 +95,15 @@ public final strictfp class AboutSCTest
     }
 
     /**
-     * Tests the {@link AboutSC#toRemoveURL(String)} method.
+     * Tests the {@link AboutSC#toRemoteURL(String)} method.
      */
     @Test
-    public void testToRemoveURL() {
-        assertEquals("service:jmx:rmi:///jndi/rmi://myhost:9999/jmxrmi",    AboutSC.toRemoveURL("myhost:9999"));
-        assertEquals("service:jmx:rmi:///jndi/rmi://myhost:1099/jmxrmi",    AboutSC.toRemoveURL("myhost"));
-        assertEquals("service:jmx:rmi:///jndi/rmi://:9999/jmxrmi",          AboutSC.toRemoveURL("localhost:9999"));
-        assertEquals("service:jmx:rmi:///jndi/rmi://:1099/jmxrmi",          AboutSC.toRemoveURL("localhost"));
-        assertEquals("service:jmx:rmi:///jndi/rmi://:9999/jmxrmi",          AboutSC.toRemoveURL(":9999"));
-        assertEquals("service:jmx:rmi:///jndi/rmi://localhosx:1099/jmxrmi", AboutSC.toRemoveURL("localhosx"));
+    public void testToRemoteURL() {
+        assertEquals("service:jmx:rmi:///jndi/rmi://myhost:9999/jmxrmi",    AboutSC.toRemoteURL("myhost:9999"));
+        assertEquals("service:jmx:rmi:///jndi/rmi://myhost:1099/jmxrmi",    AboutSC.toRemoteURL("myhost"));
+        assertEquals("service:jmx:rmi:///jndi/rmi://:9999/jmxrmi",          AboutSC.toRemoteURL("localhost:9999"));
+        assertEquals("service:jmx:rmi:///jndi/rmi://:1099/jmxrmi",          AboutSC.toRemoteURL("localhost"));
+        assertEquals("service:jmx:rmi:///jndi/rmi://:9999/jmxrmi",          AboutSC.toRemoteURL(":9999"));
+        assertEquals("service:jmx:rmi:///jndi/rmi://localhosx:1099/jmxrmi", AboutSC.toRemoteURL("localhosx"));
     }
 }

Modified: sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/OperationMethods.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/OperationMethods.java?rev=1677908&r1=1677907&r2=1677908&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/OperationMethods.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/OperationMethods.java
[UTF-8] Tue May  5 22:53:08 2015
@@ -17,10 +17,10 @@
 package org.apache.sis.internal.referencing;
 
 import java.util.Collection;
-import org.opengis.util.Record;
 import javax.measure.unit.SI;
 import javax.measure.unit.Unit;
 import javax.measure.quantity.Length;
+import org.opengis.util.Record;
 import org.opengis.metadata.quality.Result;
 import org.opengis.metadata.quality.PositionalAccuracy;
 import org.opengis.metadata.quality.QuantitativeResult;

Modified: sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/DefaultFactories.java
URL: http://svn.apache.org/viewvc/sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/DefaultFactories.java?rev=1677908&r1=1677907&r2=1677908&view=diff
==============================================================================
--- sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/DefaultFactories.java
[UTF-8] (original)
+++ sis/branches/JDK8/core/sis-utility/src/main/java/org/apache/sis/internal/system/DefaultFactories.java
[UTF-8] Tue May  5 22:53:08 2015
@@ -25,11 +25,14 @@ import java.util.ServiceConfigurationErr
 /**
  * Default factories defined in the {@code sis-utility} module.
  * This is a temporary placeholder until we leverage the "dependency injection" pattern.
+ * A candidate replacement is JSR-330.
  *
  * @author  Martin Desruisseaux (Geomatys)
  * @since   0.3
  * @version 0.6
  * @module
+ *
+ * @see <a href="https://jcp.org/en/jsr/detail?id=330">JSR-330</a>
  */
 public final class DefaultFactories extends SystemListener {
     /**



Mime
View raw message