sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1675108 - in /sis/ip-review: ./ rev/10796/ rev/12214/ rev/20874/ rev/24925/ rev/28106/
Date Tue, 21 Apr 2015 12:55:13 GMT
Author: desruisseaux
Date: Tue Apr 21 12:55:13 2015
New Revision: 1675108

URL: http://svn.apache.org/r1675108
Log:
Added IP review for AbstractCoordinateOperation.

Added:
    sis/ip-review/AbstractCoordinateOperation.xhtml   (with props)
    sis/ip-review/rev/10796/AbstractCoordinateOperation.xhtml   (with props)
    sis/ip-review/rev/12214/
    sis/ip-review/rev/12214/AbstractCoordinateOperation.xhtml   (with props)
    sis/ip-review/rev/12214/HEADER.html   (with props)
    sis/ip-review/rev/20874/AbstractCoordinateOperation.xhtml   (with props)
    sis/ip-review/rev/24925/AbstractCoordinateOperation.xhtml   (with props)
    sis/ip-review/rev/28106/AbstractCoordinateOperation.xhtml   (with props)

Added: sis/ip-review/AbstractCoordinateOperation.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/AbstractCoordinateOperation.xhtml?rev=1675108&view=auto
==============================================================================
--- sis/ip-review/AbstractCoordinateOperation.xhtml (added)
+++ sis/ip-review/AbstractCoordinateOperation.xhtml Tue Apr 21 12:55:13 2015
@@ -0,0 +1,91 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractCoordinateOperation history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractCoordinateOperation history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AbstractCoordinateOperation.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31000</td><td>2008-07-10</td><td>desruisseaux</td><td>Avoid
usage of 2 deprecated constructors from CRSFactory. Their replacement were tricky and required
more sophesticated code in ReferencingFactoryContainer.toGeodetic3D.</td></tr>
+<tr><td class="rev">30760</td><td>2008-06-18</td><td>desruisseaux</td><td>Upgrated
from JSR-108 to JSR-275 (GEOT-1266). Some opportunist javadoc fixes and @Override annotations
in the process.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30313</td><td>2008-05-16</td><td>desruisseaux</td><td>Changed
my mind about Utilities.shallowEquals(Object,Object) and renamed it as equals, since a few
tests show that the compiler always select the best overloaded flavor working on primitive
types (except if an argument is a boolean and the other a different primitive type). Updated
a few references. Fixed a few javadoc warnings by explicit declaration of parameter and return
values.</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28107</td><td>2007-11-28</td><td>desruisseaux</td><td>Updated
for recent changes in GeoAPI interfaces.</td></tr>
+<tr><td class="rev">28106</td><td>2007-11-28</td><td class="unav">jgarnett</td><td><a
href="rev/28106/AbstractCoordinateOperation.xhtml">Line up with GeoAPI crs change to getDomainOfValidity,
remove DuplicatorFilterVistior</a></td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation;
rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">28057</td><td>2007-11-26</td><td>desruisseaux</td><td>More
parameterized types, which revealed an other bug: getResults() should returns a Collection
of Record, not Double.</td></tr>
+<tr><td class="rev">28030</td><td>2007-11-23</td><td>desruisseaux</td><td>More
Java 5 generics. Added implementation for three new GeoAPI methods for alignment with RFC
07-073r1.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25711</td><td>2007-06-01</td><td>desruisseaux</td><td>Aligned
with latest GeoAPI snapshot.</td></tr>
+<tr><td class="rev">25485</td><td>2007-05-11</td><td>desruisseaux</td><td>Added
special cases for 'x' and 'y' axis names.</td></tr>
+<tr><td class="rev">25262</td><td>2007-04-23</td><td>desruisseaux</td><td>Finished
review of metadata and factory hints change. Fixed a potential glitch in parameter names handling
(some code were disabled in AbstractIdentifiedObject apparently in order to avoid a ClassCastException
caused by the spit of org.opengis.metadata.Identifier in two interfaces, Identifier and ReferenceIdentifier.
Fixed the exception and reenabled the code). Not sure yet what the consequence was. It may
help for the stereographic projection issue, but need to check.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/24925/AbstractCoordinateOperation.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">24701</td><td>2007-03-07</td><td>desruisseaux</td><td>Fixed
a build failure on Java 6. Also fixed many small details in the referencing framework.</td></tr>
+<tr><td class="rev">24384</td><td>2007-02-14</td><td>desruisseaux</td><td>GEOT-1160:
First working implementation of AbstractAuthorityFactory.find(IdentifiedObject). This includes
a package-privated AuthorityFactoryProxy class, together with many fix in the code base in
order to get CRS.equalsIgnoreCase to work in the ProjectedCRS case.</td></tr>
+<tr><td class="rev">23632</td><td>2006-12-29</td><td>desruisseaux</td><td>GEOT-859:
Refactored the URN syntax adapter for CRS factories. The adapter now apply to any factory.
Some progress toward version management (but not yet there). NOTE: this new implementation
forces axis order "as specified in the database", which is different from the original "URNEPSGAdapter"
implementation which used (x,y) order. Various changes in many corners of "org.geotools.referencing.factory"
as a side-effect of this work. Minor opportunist javadoc fixes in other modules.</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/AbstractCoordinateOperation.xhtml">ip review</a></td></tr>
+<tr><td class="rev">19941</td><td>2006-06-13</td><td>desruisseaux</td><td>Implemented
CRS.decode(String) on top of AllAuthoritiesFactory.</td></tr>
+<tr><td class="rev">19557</td><td>2006-05-18</td><td>desruisseaux</td><td>AuthorityBackedFactory
now take inverse transform in account. Improved pseudo-WKT formatting for CoordinateOperation.</td></tr>
+<tr><td class="rev">17890</td><td>2006-02-06</td><td>desruisseaux</td><td>First
draft of a partial port of J2D-renderer to a GO-1 implementation.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15983</td><td>2005-10-03</td><td>desruisseaux</td><td>Partial
set of pom.xml files (for Maven 2). The work is still in progress (module/main do not yet
pass tests; I suspect that this is a ClassLoader issue).</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15331</td><td>2005-08-15</td><td>desruisseaux</td><td>Added
bridge to formulas for Sun elevation</td></tr>
+<tr><td class="rev">15299</td><td>2005-08-11</td><td>desruisseaux</td><td>Added
CRS.VALID.AREA formula in OpenOffice addin / Added convenience methods for fetching GeographicBoundingBox
and for fetching coordinate operation accuracy / Bug fix for parameter using dimensionless
unit in EPGS database</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction
of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">14602</td><td>2005-06-24</td><td>desruisseaux</td><td>EPSG
factory now have a standalone (and buffered) createOperationMethod (GEOT-596)</td></tr>
+<tr><td class="rev">14593</td><td>2005-06-23</td><td>desruisseaux</td><td>First
JUnit test for 'createCoordinateOperation' (GEOT-589)</td></tr>
+<tr><td class="rev">14550</td><td>2005-06-16</td><td>desruisseaux</td><td>Removed
deprecated fields and methods</td></tr>
+<tr><td class="rev">14235</td><td>2005-06-10</td><td>desruisseaux</td><td>Replaced
_PROPERTY suffix by _KEY as of GEOT-577</td></tr>
+<tr><td class="rev">14205</td><td>2005-06-09</td><td>desruisseaux</td><td>Updated
to GeoAPI 2.0 final release</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added
@since javadoc tag</td></tr>
+<tr><td class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming
of remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td class="rev">13907</td><td>2005-05-28</td><td>desruisseaux</td><td>More
additions of 'Default' prefix in CRS package</td></tr>
+<tr><td class="rev">13906</td><td>2005-05-28</td><td>desruisseaux</td><td>Renamed
some 'Default' prefix as 'Abstract'</td></tr>
+<tr><td class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added
'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td class="rev">13762</td><td>2005-05-24</td><td>desruisseaux</td><td>Added
DefiningConversion</td></tr>
+<tr><td class="rev">12214</td><td>2005-03-15</td><td class="unav">jmacgill</td><td><a
href="rev/12214/AbstractCoordinateOperation.xhtml">removed unicode char from constant</a></td></tr>
+<tr><td class="rev">11698</td><td>2005-02-28</td><td>desruisseaux</td><td>Moved
tests from legacy to main module</td></tr>
+<tr><td class="rev">11146</td><td>2005-02-07</td><td>desruisseaux</td><td>CoordinateOperationFactory
refactoring</td></tr>
+<tr><td class="rev">11144</td><td>2005-02-07</td><td>desruisseaux</td><td>Fixed
GEOT-400 (create appropriate instance of Operation subclasses)</td></tr>
+<tr><td class="rev">11140</td><td>2005-02-06</td><td>desruisseaux</td><td>Work
in progres for GEOT-400 (CoordinateOperationFactory should create appropriate subclass of
CoordinateOperation)</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed
wrong encoding in main/src</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a
href="rev/10796/AbstractCoordinateOperation.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">10469</td><td>2005-01-11</td><td>desruisseaux</td><td>Replaced
calls to 'getDim[Source|Target]' by 'get[Source|Target]Dimensions</td></tr>
+<tr><td class="rev">9267</td><td>2004-11-23</td><td>desruisseaux</td><td>First
draft of a coordinate transformation factory</td></tr>
+<tr><td class="rev">9220</td><td>2004-11-21</td><td>desruisseaux</td><td>WKT
bug fixes</td></tr>
+<tr><td class="rev">9203</td><td>2004-11-19</td><td>desruisseaux</td><td>WKT
debugging / cleaning</td></tr>
+<tr><td class="rev">8796</td><td>2004-10-22</td><td>desruisseaux</td><td>Cleaning
referencing's operation basic package</td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply
changes voted in OGC meeting at Southampton: use of Identifier and GenericName</td></tr>
+<tr><td class="rev">6888</td><td>2004-07-14</td><td>desruisseaux</td><td>Update
for GeoAPI changes (Info -->  IdentifiedObject)</td></tr>
+<tr><td class="rev">6343</td><td>2004-06-07</td><td>desruisseaux</td><td>More
ports of legacy CTS to new CRS</td></tr>
+<tr><td class="rev">6259</td><td>2004-05-31</td><td>desruisseaux</td><td>Added
more implementations for Coverage support</td></tr>
+<tr><td class="rev">6257</td><td>2004-05-31</td><td>desruisseaux</td><td>First
set of operation classes</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/AbstractCoordinateOperation.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/AbstractCoordinateOperation.xhtml?rev=1675108&view=auto
==============================================================================
--- sis/ip-review/rev/10796/AbstractCoordinateOperation.xhtml (added)
+++ sis/ip-review/rev/10796/AbstractCoordinateOperation.xhtml Tue Apr 21 12:55:13 2015
@@ -0,0 +1,89 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractCoordinateOperation changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractCoordinateOperation changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some <cite>"auto reformat"</cite>
tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite>
import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are
keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AbstractCoordinateOperation.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2001, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2001, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.referencing.operation;
+
+// J2SE dependencies
+<span class="del">import java.util.Map;</span>
+import java.util.Arrays;
+<span class="del">import java.util.Locale;</span>
+import java.util.HashMap;
+
+<span class="del">// OpenGIS dependencies</span>
+<span class="del">import org.opengis.util.InternationalString;</span>
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.quality.PositionalAccuracy;
+import org.opengis.referencing.operation.MathTransform;
+<span class="del">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.referencing.crs.GeneralDerivedCRS;</span>
+<span class="del">import org.geotools.referencing.IdentifiedObject;</span>
+<span class="del">import org.geotools.referencing.wkt.Formatter;</span>
+<span class="del">import org.geotools.resources.cts.Resources;</span>
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="del">import org.geotools.resources.CRSUtilities;</span>
+<span class="del">import org.geotools.resources.Utilities;</span>
+
+<span class="del"></span>
+/**
+ * Establishes an association between a source and a target coordinate reference system,
+ * and provides a {@linkplain MathTransform transform} for transforming coordinates in</pre></td>
+<td><pre>package org.geotools.referencing.operation;
+
+// J2SE dependencies
+import java.util.Arrays;
+import java.util.HashMap;
+<span class="add">import java.util.Map;</span>
+
+<span class="add">import org.geotools.referencing.IdentifiedObject;</span>
+<span class="add">import org.geotools.referencing.crs.GeneralDerivedCRS;</span>
+<span class="add">import org.geotools.referencing.wkt.Formatter;</span>
+<span class="add">import org.geotools.resources.Utilities;</span>
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.cts.Resources;</span>
+import org.opengis.metadata.extent.Extent;
+import org.opengis.metadata.quality.PositionalAccuracy;
+<span class="add">import org.opengis.referencing.crs.CoordinateReferenceSystem;</span>
+import org.opengis.referencing.operation.MathTransform;
+<span class="add">import org.opengis.util.InternationalString;</span>
+
+
+/**
+ * Establishes an association between a source and a target coordinate reference system,
+ * and provides a {@linkplain MathTransform transform} for transforming coordinates in</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/12214/AbstractCoordinateOperation.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/12214/AbstractCoordinateOperation.xhtml?rev=1675108&view=auto
==============================================================================
--- sis/ip-review/rev/12214/AbstractCoordinateOperation.xhtml (added)
+++ sis/ip-review/rev/12214/AbstractCoordinateOperation.xhtml Tue Apr 21 12:55:13 2015
@@ -0,0 +1,53 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractCoordinateOperation changes for revisions 12213:12214</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractCoordinateOperation changes for revisions 12213:12214</h1>
+<p>This name change does not apply to SIS since this constant got a different name,
different type and is located in a different place in Apache SIS.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r12213:12214 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AbstractCoordinateOperation.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 12213</th><th>Revision 12214</th></tr>
+<tr><td><pre>     * 'conversionFromBase' field that is set to this CoordinateOperation.
+     */
+    synchronized (GeneralDerivedCRS.class) {
+<span class="del">        if (GeneralDerivedCRS.\u00A4COMPARING != null) {</span>
+            // NOTE: the following assertion fails for deserialized objects.
+            // assert GeneralDerivedCRS.\u00A4COMPARING == targetCRS;
+            return true;
+        }
+        try {
+<span class="del">            GeneralDerivedCRS.\u00A4COMPARING = this;</span>
+            return equals(this.targetCRS, that.targetCRS, compareMetadata);
+        } finally {
+<span class="del">            GeneralDerivedCRS.\u00A4COMPARING = null;</span>
+        }
+    }
+}</pre></td>
+<td><pre>     * 'conversionFromBase' field that is set to this CoordinateOperation.
+     */
+    synchronized (GeneralDerivedCRS.class) {
+<span class="add">        if (GeneralDerivedCRS.COMPARING != null) {</span>
+            // NOTE: the following assertion fails for deserialized objects.
+            // assert GeneralDerivedCRS.\u00A4COMPARING == targetCRS;
+            return true;
+        }
+        try {
+<span class="add">            GeneralDerivedCRS.COMPARING = this;</span>
+            return equals(this.targetCRS, that.targetCRS, compareMetadata);
+        } finally {
+<span class="add">            GeneralDerivedCRS.COMPARING = null;</span>
+        }
+    }
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/12214/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/12214/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/12214/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/12214/HEADER.html?rev=1675108&view=auto
==============================================================================
--- sis/ip-review/rev/12214/HEADER.html (added)
+++ sis/ip-review/rev/12214/HEADER.html Tue Apr 21 12:55:13 2015
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 12214</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 12214</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>jmacgill</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-03-15</td></tr>
+  <tr><td><b>Message:</b></td><td>removed unicode char
from constant</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/12214/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/12214/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/AbstractCoordinateOperation.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/AbstractCoordinateOperation.xhtml?rev=1675108&view=auto
==============================================================================
--- sis/ip-review/rev/20874/AbstractCoordinateOperation.xhtml (added)
+++ sis/ip-review/rev/20874/AbstractCoordinateOperation.xhtml Tue Apr 21 12:55:13 2015
@@ -0,0 +1,65 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractCoordinateOperation changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractCoordinateOperation changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the <cite>"or (at your option)
any later version"</cite> clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AbstractCoordinateOperation.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2001, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of</pre></td></tr>
+<tr><td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 See the GNU
+*    Lesser General Public License for more details.
+*
+<span class="del">*    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">*    License along with this library; if not, write to the Free Software</span>
+<span class="del">*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+<span class="del">*</span>
+<span class="del">*</span>
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24925/AbstractCoordinateOperation.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/AbstractCoordinateOperation.xhtml?rev=1675108&view=auto
==============================================================================
--- sis/ip-review/rev/24925/AbstractCoordinateOperation.xhtml (added)
+++ sis/ip-review/rev/24925/AbstractCoordinateOperation.xhtml Tue Apr 21 12:55:13 2015
@@ -0,0 +1,69 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractCoordinateOperation changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractCoordinateOperation changes for revisions 24924:24925</h1>
+<p>This commit propagates the method signature changes in GeoAPI.
+  Reverting this change causes compilation errors, which are fixed by reapplying the changes
+  in a similar (but not identical) way.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AbstractCoordinateOperation.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>private static double getAccuracy0(final CoordinateOperation
operation) {
+    final Collection accuracies = operation.getPositionalAccuracy();
+    for (final Iterator it=accuracies.iterator(); it.hasNext();) {
+<span class="del">        final Result accuracy = ((PositionalAccuracy) it.next()).getResult();</span>
+        if (accuracy instanceof QuantitativeResult) {
+            final QuantitativeResult quantity = (QuantitativeResult) accuracy;
+<span class="del">            final double[] r = quantity.getValues();</span>
+<span class="del">            if (r!=null &amp;&amp; r.length!=0) {</span>
+                final Unit unit = quantity.getValueUnit();
+                if (unit!=null &amp;&amp; SI.METER.isCompatible(unit)) {
+<span class="del">                    return unit.getConverterTo(SI.METER).convert(r[0]);</span>
+                }
+            }
+        }
+    }
+    /*
+     * No quantitative, linear accuracy were found. If the coordinate operation is actually
+     * a conversion, the accuracy is up to rounding error (i.e. conceptually 0) by definition.</pre></td>
+<td><pre>private static double getAccuracy0(final CoordinateOperation operation)
{
+    final Collection accuracies = operation.getPositionalAccuracy();
+    for (final Iterator it=accuracies.iterator(); it.hasNext();) {
+<span class="add">        Collection results = ((PositionalAccuracy) it.next()).getResult();</span>
+<span class="add">        for( Iterator it2 = results.iterator(); it2.hasNext(); ){</span>
+<span class="add">            final Result accuracy = (Result) it2.next();</span>
+        if (accuracy instanceof QuantitativeResult) {
+            final QuantitativeResult quantity = (QuantitativeResult) accuracy;
+<span class="add">                Collection r = quantity.getValues();</span>
+<span class="add"></span>
+<span class="add">                if (r!=null &amp;&amp; r.size() !=0) {</span>
+                final Unit unit = quantity.getValueUnit();
+                if (unit!=null &amp;&amp; SI.METER.isCompatible(unit)) {
+<span class="add">                        for( Iterator i=r.iterator();i.hasNext();){</span>
+<span class="add">                            Double d = (Double) i.next();</span>
+<span class="add">                            if( d != null ){</span>
+<span class="add">                                double value = d.doubleValue();</span>
+<span class="add">                                return unit.getConverterTo(SI.METER).convert(
value );</span>
+                }
+            }
+        }
+    }
+<span class="add">            }</span>
+<span class="add">        }</span>
+<span class="add">    }</span>
+    /*
+     * No quantitative, linear accuracy were found. If the coordinate operation is actually
+     * a conversion, the accuracy is up to rounding error (i.e. conceptually 0) by definition.</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24925/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24925/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/28106/AbstractCoordinateOperation.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/28106/AbstractCoordinateOperation.xhtml?rev=1675108&view=auto
==============================================================================
--- sis/ip-review/rev/28106/AbstractCoordinateOperation.xhtml (added)
+++ sis/ip-review/rev/28106/AbstractCoordinateOperation.xhtml Tue Apr 21 12:55:13 2015
@@ -0,0 +1,95 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractCoordinateOperation changes for revisions 28105:28106</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractCoordinateOperation changes for revisions 28105:28106</h1>
+<p>This commit propagates the method signature changes in GeoAPI.
+  Reverting this change causes compilation errors, which are fixed by reapplying the changes
+  in a similar (but not identical) way. For example <code>getValidArea()</code>
has been renamed
+  <code>getDomainOfValidity()</code>, which we have no choice to add in SIS too.
But the old method
+  has been removed from SIS and the field has also been renamed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r28105:28106 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/operation/AbstractCoordinateOperation.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 28105</th><th>Revision 28106</th></tr>
+<tr><td><pre> * @see #getAccuracy()
+ */
+public Collection&lt;PositionalAccuracy&gt; getPositionalAccuracy() {
+<span class="del">    if (positionalAccuracy == null) {</span>
+<span class="del">        return Collections.emptySet();</span>
+    }
+<span class="del">    return positionalAccuracy;</span>
+<span class="del">}</span>
+
+/**
+ * Convenience method returning the accuracy in meters. The default implementation delegates</pre></td>
+<td><pre> * @see #getAccuracy()
+ */
+public Collection&lt;PositionalAccuracy&gt; getPositionalAccuracy() {
+<span class="add">    return getCoordinateOperationAccuracy();</span>
+    }
+
+/**
+ * Convenience method returning the accuracy in meters. The default implementation delegates</pre></td></tr>
+<tr><td><pre>public double getAccuracy() {
+    return getAccuracy0(this);
+}
+<span class="del"></span>
+/**
+ * Convenience method returning the accuracy in meters for the specified operation. This
method
+ * try each of the following procedures and returns the first successful one:
+ *</pre></td>
+<td><pre>public double getAccuracy() {
+    return getAccuracy0(this);
+}
+/**
+<span class="add"> * Estimate(s) of the impact of this operation on point accuracy.
Gives</span>
+<span class="add"> * position error estimates for target coordinates of this coordinate</span>
+<span class="add"> * operation, assuming no errors in source coordinates.</span>
+<span class="add"> *</span>
+<span class="add"> * @return The position error estimates, or an empty collection if
not available.</span>
+<span class="add"> */</span>
+<span class="add">public Collection&lt;PositionalAccuracy&gt; getCoordinateOperationAccuracy()
{</span>
+<span class="add">    if (positionalAccuracy == null) {</span>
+<span class="add">        return Collections.emptySet();</span>
+<span class="add">    }</span>
+<span class="add">    return positionalAccuracy;</span>
+<span class="add">}</span>
+<span class="add">/**</span>
+ * Convenience method returning the accuracy in meters for the specified operation. This
method
+ * try each of the following procedures and returns the first successful one:
+ *</pre></td></tr>
+<tr><td><pre>public Extent getValidArea() {
+    return validArea;
+}
+<span class="del"></span>
+/**
+ * Description of domain of usage, or limitations of usage, for which this operation is valid.
+ */
+public InternationalString getScope() {</pre></td>
+<td><pre>public Extent getValidArea() {
+    return validArea;
+}
+/**
+<span class="add"> * Area or region or timeframe in which this coordinate operation
is valid.</span>
+<span class="add"> *</span>
+<span class="add"> * @return The coordinate operation valid domain, or {@code null}
if not available.</span>
+<span class="add"> */</span>
+<span class="add">public Extent getDomainOfValidity() {</span>
+<span class="add">    return validArea;</span>
+<span class="add">}</span>
+<span class="add">/**</span>
+ * Description of domain of usage, or limitations of usage, for which this operation is valid.
+ */
+public InternationalString getScope() {</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/28106/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/28106/AbstractCoordinateOperation.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message