sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From desruisse...@apache.org
Subject svn commit: r1675092 - in /sis/ip-review: ./ rev/07848/ rev/10796/ rev/12215/ rev/20874/ rev/24925/
Date Tue, 21 Apr 2015 11:13:36 GMT
Author: desruisseaux
Date: Tue Apr 21 11:13:36 2015
New Revision: 1675092

URL: http://svn.apache.org/r1675092
Log:
Added IP review for AbstractDerivedCRS.

Added:
    sis/ip-review/AbstractDerivedCRS.xhtml   (with props)
    sis/ip-review/rev/07848/AbstractDerivedCRS.xhtml   (with props)
    sis/ip-review/rev/10796/AbstractDerivedCRS.xhtml   (with props)
    sis/ip-review/rev/12215/
    sis/ip-review/rev/12215/AbstractDerivedCRS.xhtml   (with props)
    sis/ip-review/rev/12215/HEADER.html   (with props)
    sis/ip-review/rev/20874/AbstractDerivedCRS.xhtml   (with props)
    sis/ip-review/rev/24925/AbstractDerivedCRS.xhtml   (with props)

Added: sis/ip-review/AbstractDerivedCRS.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/AbstractDerivedCRS.xhtml?rev=1675092&view=auto
==============================================================================
--- sis/ip-review/AbstractDerivedCRS.xhtml (added)
+++ sis/ip-review/AbstractDerivedCRS.xhtml Tue Apr 21 11:13:36 2015
@@ -0,0 +1,87 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDerivedCRS history</title>
+    <style type="text/css" media="all">
+      @import url("./reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDerivedCRS history</h1>
+  <p>Click on the commit message for inspecting the <code>diff</code> and
how the code has been rewritten.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn log -r31996:1 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/crs/AbstractDerivedCRS.java</code></blockquote>
+<table>
+  <tr>
+    <th>Rev.</th>
+    <th>Date</th>
+    <th>Author</th>
+    <th class="last">Message</th>
+  </tr>
+<tr><td class="rev">31000</td><td>2008-07-10</td><td>desruisseaux</td><td>Avoid
usage of 2 deprecated constructors from CRSFactory. Their replacement were tricky and required
more sophesticated code in ReferencingFactoryContainer.toGeodetic3D.</td></tr>
+<tr><td class="rev">30641</td><td>2008-06-12</td><td>acuster</td><td>Copyright
headers: lib/referencing, this time with feeling (and the el in Toolkit)</td></tr>
+<tr><td class="rev">30521</td><td>2008-06-05</td><td>acuster</td><td>Copyright:
Update referencing headers</td></tr>
+<tr><td class="rev">30258</td><td>2008-05-08</td><td>acuster</td><td>Reshuffle
the top level repo: drop uDig, move up trunk, tags, and branches.</td></tr>
+<tr><td class="rev">30257</td><td>2008-05-08</td><td>acuster</td><td>Move
trunk/gt/ directory contents up to trunk/ and drop gt</td></tr>
+<tr><td class="rev">28922</td><td>2008-01-24</td><td>acuster</td><td>Bump
the (at)since version to 2.5 since WKTParser was cut from 2.4</td></tr>
+<tr><td class="rev">28540</td><td>2007-12-29</td><td>acuster</td><td>Hide
buttons which are not yet used</td></tr>
+<tr><td class="rev">28393</td><td>2007-12-17</td><td>desruisseaux</td><td>WKT
formatting now includes the semi-major and semi-minor axis length if they differ from the
datum. Applied Java 5 features. Uses WarpAffine when applicable during Raster reprojection.</td></tr>
+<tr><td class="rev">28081</td><td>2007-11-27</td><td>desruisseaux</td><td>Java
5 constructs: replaced some StringBuffer by StringBuilder in order to avoid unecessary synchronisation;
rely on auto-boxing in order to give a chance to the JVM to reuse its cached values.</td></tr>
+<tr><td class="rev">28030</td><td>2007-11-23</td><td>desruisseaux</td><td>More
Java 5 generics. Added implementation for three new GeoAPI methods for alignment with RFC
07-073r1.</td></tr>
+<tr><td class="rev">27575</td><td>2007-10-22</td><td>desruisseaux</td><td>Converted
Java source files from ISO-LATIN-1 encoding to UTF-8 (GEOT-1516).</td></tr>
+<tr><td class="rev">25485</td><td>2007-05-11</td><td>desruisseaux</td><td>Added
special cases for 'x' and 'y' axis names.</td></tr>
+<tr><td class="rev">24925</td><td>2007-03-27</td><td class="unav">jgarnett</td><td><a
href="rev/24925/AbstractDerivedCRS.xhtml">change to org.opengis.geometry</a></td></tr>
+<tr><td class="rev">24609</td><td>2007-02-26</td><td>desruisseaux</td><td>Removed
the package-private 'getTypeWKT()' method; it was not needed after all.</td></tr>
+<tr><td class="rev">24607</td><td>2007-02-26</td><td>desruisseaux</td><td>Avoid
UnformattableObjectException for 'LOCAL_CS' and 'VERT_CS' WKT elements. Try to provides some
hints about the cause for the other cases of unformattable WKT.</td></tr>
+<tr><td class="rev">24384</td><td>2007-02-14</td><td>desruisseaux</td><td>GEOT-1160:
First working implementation of AbstractAuthorityFactory.find(IdentifiedObject). This includes
a package-privated AuthorityFactoryProxy class, together with many fix in the code base in
order to get CRS.equalsIgnoreCase to work in the ProjectedCRS case.</td></tr>
+<tr><td class="rev">22452</td><td>2006-10-28</td><td>desruisseaux</td><td>Moved
some methods from CRSUtilities to CRS (GEOT-547).</td></tr>
+<tr><td class="rev">22327</td><td>2006-10-23</td><td>desruisseaux</td><td>GEOT-982:
regroup 'module', 'plugin', 'ext' and 'unsupported' in a common directory.</td></tr>
+<tr><td class="rev">22315</td><td>2006-10-22</td><td>desruisseaux</td><td>Reorganisation
of directory tree structure (GEOT-982) phase 1: moved 'src' to 'src/main/java'.</td></tr>
+<tr><td class="rev">20874</td><td>2006-08-07</td><td class="unav">jgarnett</td><td><a
href="rev/20874/AbstractDerivedCRS.xhtml">ip review</a></td></tr>
+<tr><td class="rev">19941</td><td>2006-06-13</td><td>desruisseaux</td><td>Implemented
CRS.decode(String) on top of AllAuthoritiesFactory.</td></tr>
+<tr><td class="rev">17672</td><td>2006-01-19</td><td>desruisseaux</td><td>Added
@source tag.</td></tr>
+<tr><td class="rev">17660</td><td>2006-01-18</td><td>desruisseaux</td><td>Fixed
SVN attributes, including the addition of URL attribute.</td></tr>
+<tr><td class="rev">15350</td><td>2005-08-16</td><td>desruisseaux</td><td>Merged
the 'split-main' branch to trunk (GEOT-662)</td></tr>
+<tr><td class="rev">15256</td><td>2005-08-09</td><td>desruisseaux</td><td>Extraction
of referencing module from main</td></tr>
+<tr><td class="rev">15255</td><td>2005-08-09</td><td>desruisseaux</td><td>Prepare
branch for splitting main</td></tr>
+<tr><td class="rev">15150</td><td>2005-08-05</td><td>desruisseaux</td><td>Added
more localizations / Bug fix in image sample values table widget</td></tr>
+<tr><td class="rev">14834</td><td>2005-07-20</td><td>desruisseaux</td><td>Reorganized
I18N resources</td></tr>
+<tr><td class="rev">14602</td><td>2005-06-24</td><td>desruisseaux</td><td>EPSG
factory now have a standalone (and buffered) createOperationMethod (GEOT-596)</td></tr>
+<tr><td class="rev">14545</td><td>2005-06-15</td><td>desruisseaux</td><td>Initial
port of coverage I/O helper classes (work in progress)</td></tr>
+<tr><td class="rev">13925</td><td>2005-05-30</td><td>desruisseaux</td><td>Added
@since javadoc tag</td></tr>
+<tr><td class="rev">13922</td><td>2005-05-29</td><td>desruisseaux</td><td>Renaming
of remainding GeoAPI implementations. Renaming is now finished.</td></tr>
+<tr><td class="rev">13907</td><td>2005-05-28</td><td>desruisseaux</td><td>More
additions of 'Default' prefix in CRS package</td></tr>
+<tr><td class="rev">13906</td><td>2005-05-28</td><td>desruisseaux</td><td>Renamed
some 'Default' prefix as 'Abstract'</td></tr>
+<tr><td class="rev">13869</td><td>2005-05-27</td><td>desruisseaux</td><td>Added
'Default' or 'Abstract' prefix in CRS's 'datum' and 'cs' packages</td></tr>
+<tr><td class="rev">13836</td><td>2005-05-26</td><td>desruisseaux</td><td>Added
'Default' suffix to some CRS implementations: partial work</td></tr>
+<tr><td class="rev">13762</td><td>2005-05-24</td><td>desruisseaux</td><td>Added
DefiningConversion</td></tr>
+<tr><td class="rev">12289</td><td>2005-03-16</td><td>desruisseaux</td><td>Replaced
'CRSFactory.createProjectedCRS' call by call to the convenience method 'FactoryGroup.createProjectedCRS',
which build itself the MathTransform in a more elaborated way (taking in account axis order
and units, etc.)</td></tr>
+<tr><td class="rev">12215</td><td>2005-03-15</td><td class="unav">dzwiers</td><td><a
href="rev/12215/AbstractDerivedCRS.xhtml">Martin + unicode</a></td></tr>
+<tr><td class="rev">12214</td><td>2005-03-15</td><td class="unav">jmacgill</td><td><a
href="rev/12215/AbstractDerivedCRS.xhtml">removed unicode char from constant</a></td></tr>
+<tr><td class="rev">11698</td><td>2005-02-28</td><td>desruisseaux</td><td>Moved
tests from legacy to main module</td></tr>
+<tr><td class="rev">11140</td><td>2005-02-06</td><td>desruisseaux</td><td>Work
in progres for GEOT-400 (CoordinateOperationFactory should create appropriate subclass of
CoordinateOperation)</td></tr>
+<tr><td class="rev">11008</td><td>2005-02-02</td><td>desruisseaux</td><td>Ask
OperationMethod to be specified explicitly</td></tr>
+<tr><td class="rev">11001</td><td>2005-02-02</td><td>desruisseaux</td><td>Fixed
wrong encoding in main/src</td></tr>
+<tr><td class="rev">10944</td><td>2005-02-01</td><td>desruisseaux</td><td>Bug
fix in ProjectedCRS: axis swapping and units conversion were not correctly handled</td></tr>
+<tr><td class="rev">10796</td><td>2005-01-28</td><td class="unav">dzwiers</td><td><a
href="rev/10796/AbstractDerivedCRS.xhtml">imports cleaned</a></td></tr>
+<tr><td class="rev">10469</td><td>2005-01-11</td><td>desruisseaux</td><td>Replaced
calls to 'getDim[Source|Target]' by 'get[Source|Target]Dimensions</td></tr>
+<tr><td class="rev">9266</td><td>2004-11-23</td><td>desruisseaux</td><td>Last
WKT tuning; parsing and formatting should now be functional</td></tr>
+<tr><td class="rev">9220</td><td>2004-11-21</td><td>desruisseaux</td><td>WKT
bug fixes</td></tr>
+<tr><td class="rev">9203</td><td>2004-11-19</td><td>desruisseaux</td><td>WKT
debugging / cleaning</td></tr>
+<tr><td class="rev">8596</td><td>2004-10-12</td><td>desruisseaux</td><td>Redirected
javadoc links toward org.opengis.* instead org.geotools.* when the discussion is general enough</td></tr>
+<tr><td class="rev">8518</td><td>2004-10-11</td><td>desruisseaux</td><td>Apply
changes voted in OGC meeting at Southampton: use of Identifier and GenericName</td></tr>
+<tr><td class="rev">7848</td><td>2004-09-08</td><td class="unav">jgarnett</td><td><a
href="rev/07848/AbstractDerivedCRS.xhtml">round 2 of sync with geoapi</a></td></tr>
+<tr><td class="rev">6888</td><td>2004-07-14</td><td>desruisseaux</td><td>Update
for GeoAPI changes (Info -->  IdentifiedObject)</td></tr>
+<tr><td class="rev">6536</td><td>2004-06-25</td><td>desruisseaux</td><td>Added
SingleCRS class / Renamed ObliqueCartesianCS as AffineCS / Moved Position as super-interface
for DirectPosition and Point</td></tr>
+<tr><td class="rev">6362</td><td>2004-06-08</td><td>desruisseaux</td><td>Initial
work for an OperationProvider</td></tr>
+<tr><td class="rev">6343</td><td>2004-06-07</td><td>desruisseaux</td><td>More
ports of legacy CTS to new CRS</td></tr>
+<tr><td class="rev">6333</td><td>2004-06-06</td><td>desruisseaux</td><td>Continuing
CRS implementation</td></tr>
+<tr><td class="rev">6254</td><td>2004-05-30</td><td>desruisseaux</td><td>Added
new CRS</td></tr>
+<tr><td class="rev">6210</td><td>2004-05-27</td><td>desruisseaux</td><td>Javadoc
fixes / Added Id keyword property</td></tr>
+<tr><td class="rev">6098</td><td>2004-05-23</td><td>desruisseaux</td><td>Partial
implementation of GeoAPI referencing package</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/07848/AbstractDerivedCRS.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/07848/AbstractDerivedCRS.xhtml?rev=1675092&view=auto
==============================================================================
--- sis/ip-review/rev/07848/AbstractDerivedCRS.xhtml (added)
+++ sis/ip-review/rev/07848/AbstractDerivedCRS.xhtml Tue Apr 21 11:13:36 2015
@@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDerivedCRS changes for revisions 7847:7848</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDerivedCRS changes for revisions 7847:7848</h1>
+<p>
+  This commit has been forced by a change in GeoAPI interfaces.
+  Reverting this commit causes a compilation error, which is fixed by redoing the same change.
+</p>
+
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r7847:7848 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/crs/AbstractDerivedCRS.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 7847</th><th>Revision 7848</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.NoninvertibleTransformException;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+<span class="del">import org.opengis.parameter.GeneralOperationParameter;</span>
+import org.opengis.parameter.GeneralParameterValue;
+
+// Geotools dependencies</pre></td>
+<td><pre>import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.NoninvertibleTransformException;
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+<span class="add">import org.opengis.parameter.GeneralParameterDescriptor;</span>
+import org.opengis.parameter.GeneralParameterValue;
+
+// Geotools dependencies</pre></td></tr>
+<tr><td><pre>parameters = (GeneralParameterValue[]) properties.get("parameters");
+OperationMethod method = (OperationMethod) properties.get("method");
+if (method == null) {
+<span class="del">    final GeneralOperationParameter[] descriptors;</span>
+    if (parameters != null) {
+<span class="del">        descriptors = new GeneralOperationParameter[parameters.length];</span>
+        for (int i=0; i&lt;descriptors.length; i++) {
+            descriptors[i] = parameters[i].getDescriptor();
+        }</pre></td>
+<td><pre>parameters = (GeneralParameterValue[]) properties.get("parameters");
+OperationMethod method = (OperationMethod) properties.get("method");
+if (method == null) {
+<span class="add">    final GeneralParameterDescriptor[] descriptors;</span>
+    if (parameters != null) {
+<span class="add">        descriptors = new GeneralParameterDescriptor[parameters.length];</span>
+        for (int i=0; i&lt;descriptors.length; i++) {
+            descriptors[i] = parameters[i].getDescriptor();
+        }</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/07848/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/07848/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/10796/AbstractDerivedCRS.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/10796/AbstractDerivedCRS.xhtml?rev=1675092&view=auto
==============================================================================
--- sis/ip-review/rev/10796/AbstractDerivedCRS.xhtml (added)
+++ sis/ip-review/rev/10796/AbstractDerivedCRS.xhtml Tue Apr 21 11:13:36 2015
@@ -0,0 +1,99 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDerivedCRS changes for revisions 10795:10796</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDerivedCRS changes for revisions 10795:10796</h1>
+<p>Changes in this commit seem to be the result of some "<cite>auto reformat</cite>"
tool execution.
+The <cite>Java</cite> - <cite>GeoAPI</cite> - <cite>GeoTools</cite>
import ordering is altered,
+imports used only in Javadoc are lost and the encoding of non-ASCII characters is broken.
+This commit has been reverted, except for the removal of really unused imports which are
keep removed.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r10795:10796 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/crs/AbstractDerivedCRS.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 10795</th><th>Revision 10796</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2003, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2003, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre>package org.geotools.referencing.crs;
+
+// J2SE dependencies
+import java.util.Map;
+<span class="del">import java.util.HashMap;</span>
+<span class="del">import java.util.Collections;</span>
+
+<span class="del">// OpenGIS direct dependencies</span>
+<span class="del">import org.opengis.referencing.datum.Datum;</span>
+<span class="del">import org.opengis.referencing.cs.CoordinateSystem;</span>
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+import org.opengis.referencing.crs.SingleCRS;
+import org.opengis.referencing.operation.Conversion;
+<span class="del">import org.opengis.referencing.operation.Projection;</span>
+import org.opengis.referencing.operation.MathTransform;
+import org.opengis.referencing.operation.OperationMethod;
+<span class="del">import org.opengis.referencing.operation.NoninvertibleTransformException;</span>
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+<span class="del">import org.opengis.parameter.ParameterDescriptorGroup;</span>
+<span class="del">import org.opengis.parameter.ParameterValueGroup;</span>
+
+<span class="del">// Geotools dependencies</span>
+<span class="del">import org.geotools.referencing.wkt.Formatter;</span>
+<span class="del">import org.geotools.referencing.IdentifiedObject;</span>
+<span class="del">import org.geotools.referencing.operation.transform.AbstractMathTransform;</span>
+<span class="del">import org.geotools.resources.CRSUtilities;</span>
+<span class="del">import org.geotools.resources.cts.Resources;</span>
+<span class="del">import org.geotools.resources.cts.ResourceKeys;</span>
+
+<span class="del"></span>
+/**
+ * A coordinate reference system that is defined by its coordinate
+ * {@linkplain Conversion conversion} from another coordinate reference system</pre></td>
+<td><pre>package org.geotools.referencing.crs;
+
+// J2SE dependencies
+<span class="add">import java.util.Collections;</span>
+<span class="add">import java.util.HashMap;</span>
+import java.util.Map;
+
+<span class="add">import org.geotools.referencing.IdentifiedObject;</span>
+<span class="add">import org.geotools.referencing.operation.transform.AbstractMathTransform;</span>
+<span class="add">import org.geotools.referencing.wkt.Formatter;</span>
+<span class="add">import org.geotools.resources.cts.ResourceKeys;</span>
+<span class="add">import org.geotools.resources.cts.Resources;</span>
+<span class="add">import org.opengis.parameter.ParameterDescriptorGroup;</span>
+import org.opengis.referencing.crs.CoordinateReferenceSystem;
+import org.opengis.referencing.crs.SingleCRS;
+<span class="add">import org.opengis.referencing.cs.CoordinateSystem;</span>
+<span class="add">import org.opengis.referencing.datum.Datum;</span>
+import org.opengis.referencing.operation.Conversion;
+import org.opengis.referencing.operation.MathTransform;
+<span class="add">import org.opengis.referencing.operation.NoninvertibleTransformException;</span>
+import org.opengis.referencing.operation.OperationMethod;
+<span class="add">import org.opengis.referencing.operation.Projection;</span>
+import org.opengis.spatialschema.geometry.MismatchedDimensionException;
+
+
+/**
+ * A coordinate reference system that is defined by its coordinate
+ * {@linkplain Conversion conversion} from another coordinate reference system</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/10796/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/10796/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/12215/AbstractDerivedCRS.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/12215/AbstractDerivedCRS.xhtml?rev=1675092&view=auto
==============================================================================
--- sis/ip-review/rev/12215/AbstractDerivedCRS.xhtml (added)
+++ sis/ip-review/rev/12215/AbstractDerivedCRS.xhtml Tue Apr 21 11:13:36 2015
@@ -0,0 +1,86 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDerivedCRS changes for revisions 12213:12215</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDerivedCRS changes for revisions 12213:12215</h1>
+<p>This commit is partially a revert of commit 10796 (which we reverted in the whole
code base anyway),
+and a change in a constant name. That constant has an other name and location in Apache SIS.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r12213:12215 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/crs/AbstractDerivedCRS.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 12213</th><th>Revision 12215</th></tr>
+<tr><td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="del"> * (C) 2003, Institut de Recherche pour le Développement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td>
+<td><pre>/*
+ * Geotools 2 - OpenSource mapping toolkit
+ * (C) 2003, Geotools Project Managment Committee (PMC)
+<span class="add"> * (C) 2003, Institut de Recherche pour le D�veloppement</span>
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public</pre></td></tr>
+<tr><td><pre> *       because {@link org.geotools.referencing.operation.CoordinateOperation}
lives in
+ *       a different package.
+ */
+<span class="del">public static IdentifiedObject \u00A4COMPARING;</span>
+
+/**
+ * The base coordinate reference system.</pre></td>
+<td><pre> *       because {@link org.geotools.referencing.operation.CoordinateOperation}
lives in
+ *       a different package.
+ */
+<span class="add">public static IdentifiedObject COMPARING;</span>
+
+/**
+ * The base coordinate reference system.</pre></td></tr>
+<tr><td><pre>     * from the CoordinateOperation super-class) that is set
to this GeneralDerivedCRS.
+     */
+    synchronized (GeneralDerivedCRS.class) {
+<span class="del">        if (\u00A4COMPARING != null) {</span>
+            // NOTE: the following assertion fails for deserialized objects.
+            // assert \u00A4COMPARING == conversionFromBase;
+            return true;
+        }
+        try {
+<span class="del">            \u00A4COMPARING = this;</span>
+            return equals(this.conversionFromBase,
+                          that.conversionFromBase,
+                          compareMetadata);
+        } finally {
+<span class="del">            \u00A4COMPARING = null;</span>
+        }
+    }
+}</pre></td>
+<td><pre>     * from the CoordinateOperation super-class) that is set to this
GeneralDerivedCRS.
+     */
+    synchronized (GeneralDerivedCRS.class) {
+<span class="add">        if (COMPARING != null) {</span>
+            // NOTE: the following assertion fails for deserialized objects.
+            // assert \u00A4COMPARING == conversionFromBase;
+            return true;
+        }
+        try {
+<span class="add">            COMPARING = this;</span>
+            return equals(this.conversionFromBase,
+                          that.conversionFromBase,
+                          compareMetadata);
+        } finally {
+<span class="add">            COMPARING = null;</span>
+        }
+    }
+}</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/12215/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/12215/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/12215/HEADER.html
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/12215/HEADER.html?rev=1675092&view=auto
==============================================================================
--- sis/ip-review/rev/12215/HEADER.html (added)
+++ sis/ip-review/rev/12215/HEADER.html Tue Apr 21 11:13:36 2015
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>Revision 12215</title>
+  </head>
+  <body>
+    <div>
+      <h1>Revision 12215</h1>
+<table>
+  <tr><td><b>Author:</b></td><td>dzwiers</td></tr>
+  <tr><td><b>Date:</b></td><td>2005-03-15</td></tr>
+  <tr><td><b>Message:</b></td><td>Martin + unicode</td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/12215/HEADER.html
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/12215/HEADER.html
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/20874/AbstractDerivedCRS.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/20874/AbstractDerivedCRS.xhtml?rev=1675092&view=auto
==============================================================================
--- sis/ip-review/rev/20874/AbstractDerivedCRS.xhtml (added)
+++ sis/ip-review/rev/20874/AbstractDerivedCRS.xhtml Tue Apr 21 11:13:36 2015
@@ -0,0 +1,64 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDerivedCRS changes for revisions 20873:20874</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDerivedCRS changes for revisions 20873:20874</h1>
+<p>Changes in GeoTools header only. The removal of the "<cite>or (at your option)
any later version</cite>" clause
+must be keep in Geotk for every classes having contribution from a developer other than those
who accepted re-licensing.
+This header does not apply to Apache SIS, since the above-cited contributions are omitted.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r20873:20874 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/crs/AbstractDerivedCRS.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 20873</th><th>Revision 20874</th></tr>
+<tr><td><pre>/*
+<span class="del"> * Geotools 2 - OpenSource mapping toolkit</span>
+<span class="del"> * (C) 2003, Geotools Project Managment Committee (PMC)</span>
+ * (C) 2003, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="del"> *    License as published by the Free Software Foundation; either</span>
+<span class="del"> *    version 2.1 of the License, or (at your option) any later version.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of</pre></td>
+<td><pre>/*
+<span class="add"> *    GeoTools - OpenSource mapping toolkit</span>
+<span class="add"> *    http://geotools.org</span>
+<span class="add"> *    (C) 2003-2006, GeoTools Project Managment Committee (PMC)</span>
+ * (C) 2003, Institut de Recherche pour le Développement
+ *
+ *    This library is free software; you can redistribute it and/or
+ *    modify it under the terms of the GNU Lesser General Public
+<span class="add"> *    License as published by the Free Software Foundation;</span>
+<span class="add"> *    version 2.1 of the License.</span>
+ *
+ *    This library is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of</pre></td></tr>
+<tr><td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 See the GNU
+*    Lesser General Public License for more details.
+*
+<span class="del">*    You should have received a copy of the GNU Lesser General Public</span>
+<span class="del">*    License along with this library; if not, write to the Free Software</span>
+<span class="del">*    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
 USA</span>
+<span class="del">*</span>
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td>
+<td><pre>*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*    Lesser General Public License for more details.
+*
+*    This package contains documentation from OpenGIS specifications.
+*    OpenGIS consortium's work is fully acknowledged here.
+*/</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/20874/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/20874/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html

Added: sis/ip-review/rev/24925/AbstractDerivedCRS.xhtml
URL: http://svn.apache.org/viewvc/sis/ip-review/rev/24925/AbstractDerivedCRS.xhtml?rev=1675092&view=auto
==============================================================================
--- sis/ip-review/rev/24925/AbstractDerivedCRS.xhtml (added)
+++ sis/ip-review/rev/24925/AbstractDerivedCRS.xhtml Tue Apr 21 11:13:36 2015
@@ -0,0 +1,37 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+  <head>
+    <meta charset="UTF-8"/>
+    <title>AbstractDerivedCRS changes for revisions 24924:24925</title>
+    <style type="text/css" media="all">
+      @import url("../../reports.css");
+    </style>
+  </head>
+  <body>
+    <div>
+      <h1>AbstractDerivedCRS changes for revisions 24924:24925</h1>
+<p>This commit propagates the package names change which was done in GeoAPI.
+There is no way such change could be done differently,
+since not renaming the packages cause a compilation error.</p>
+<p><b>Command line:</b></p>
+<blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r24924:24925 http://svn.osgeo.org/geotools/trunk/modules/library/referencing/src/main/java/org/geotools/referencing/crs/AbstractDerivedCRS.java</code></blockquote>
+<table class="changes">
+<tr><th>Revision 24924</th><th>Revision 24925</th></tr>
+<tr><td><pre>import org.opengis.referencing.operation.NoninvertibleTransformException;
+import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.Projection;
+<span class="del">import org.opengis.spatialschema.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.parameter.Parameters;</pre></td>
+<td><pre>import org.opengis.referencing.operation.NoninvertibleTransformException;
+import org.opengis.referencing.operation.OperationMethod;
+import org.opengis.referencing.operation.Projection;
+<span class="add">import org.opengis.geometry.MismatchedDimensionException;</span>
+
+// Geotools dependencies
+import org.geotools.parameter.Parameters;</pre></td></tr>
+</table>
+    </div>
+  </body>
+</html>

Propchange: sis/ip-review/rev/24925/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: sis/ip-review/rev/24925/AbstractDerivedCRS.xhtml
------------------------------------------------------------------------------
    svn:mime-type = text/html



Mime
View raw message